Commit Graph

188 Commits

Author SHA1 Message Date
Meg Viar
efda7b4253 Bug 1802194 - Update title and body text of Firefox View onboarding CFR message r=hanna_a,flod
Differential Revision: https://phabricator.services.mozilla.com/D162887
2022-11-28 14:20:18 +00:00
hanna alemu
ad8c25fedf Bug 1796900 - Don't nag users about Firefox View r=mviar,barret
Differential Revision: https://phabricator.services.mozilla.com/D160284
2022-11-09 20:06:58 +00:00
Ed Lee
c4e86dd0d0 Bug 1797366 - Return "Skip this step" button to the Get Started screen r=pdahiya
Revert D157019 "Bug 1790127 - Hide the secondary CTA on welcome screen if the primary action will have no effect. r=Mardak"
This reverts commit 605b709866e0ccc0e740071d627745c3958bbec4.

Differential Revision: https://phabricator.services.mozilla.com/D160305
2022-10-26 04:10:36 +00:00
Emily McMinn
7f463520d0 Bug 1790490 - Added alt tag div & strings for MR onboarding images r=mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D159770
2022-10-24 17:50:06 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Narcis Beleuzu
9f5ad99416 Backed out changeset 20fbab8f376a (bug 1791647) as req by Mardak 2022-10-11 21:09:45 +03:00
hanna alemu
9dfc61c5c6 Bug 1793800 - [Experiment] The Firefox View CFR message is shown in the Control branch of the MR Holdback studies r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D158682
2022-10-06 04:20:50 +00:00
Angel_V129
e3be76313a Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D157037
2022-10-04 19:02:24 +00:00
Emily McMinn
627580a470 Bug 1792695 - Update Fluent ID for default colorway tooltip on exisiting user onboarding r=negin
Differential Revision: https://phabricator.services.mozilla.com/D158284
2022-09-29 23:30:15 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
hanna alemu
d1d82341cd Bug 1791647 - Check home page checkbox by default for colorway upgrade screen r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D157989
2022-09-28 17:55:13 +00:00
hanna alemu
e78bca6f49 Bug 1792226 - Fx view CFR profile age of atleast two days r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D158040
2022-09-28 00:39:35 +00:00
hanna alemu
c326560584 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D156588
2022-09-20 19:39:02 +00:00
Emily McMinn
0763ca6c8b Bug 1790487 - Change Colorways tooltip and aria-label r=aminomancer,fluent-reviewers
I'll wait to land this until next week, so that we're not putting in new strings right at the end of Nightly.

I've tested this with MacOS VoiceOver & NVDA on windows and the behaviour is pretty good. VoiceOver will repeat the colorway group & name a few times which is annoying, but it's an existing problem we haven't found a tidy solution for yet.

Differential Revision: https://phabricator.services.mozilla.com/D157369
2022-09-20 15:12:18 +00:00
Cosmin Sabou
4d2a07b5af Backed out changeset 4eed140eab3f (bug 1783684) for causing several bc failures. CLOSED TREE 2022-09-18 20:04:16 +03:00
hanna alemu
bd65360b11 Bug 1783684 - Suggest Firefox View with a CFR panel for users who have closed tabs but haven't opened it r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D156588
2022-09-18 16:01:11 +00:00
Shane Hughes
75546a2dcb Bug 1790655 - Include screen list in AboutWelcome telemetry ping message IDs. r=Mardak
Add a list of screen initials to the message ID strings sent with
AboutWelcomeTelemetry impression pings. Each screen's message ID will
include a string representing the screen ID of each screen in the
message, in addition to information about the screen itself (for
example, `PLSICMG` represents AW_PIN_FIREFOX, AW_LANGUAGE_MISMATCH,
etc). This will support, for example, comparisons of user engagement
between messages with many screens versus messages with few screens.
Also change the screen ID for one screen that was adjacent to another
screen with the same initial, in order to disambiguate them (since both
screens can potentially be removed, currently).

Differential Revision: https://phabricator.services.mozilla.com/D157581
2022-09-17 18:08:52 +00:00
Ed Lee
655ad8b48c Bug 1782944 - The marketplace buttons from the “Get Firefox Klar” modal no longer redirect to the Firefox Klar on App Store/Google Play using de locale and region r=pdahiya
Remove image_overrides custom replacing the QR code for FOCUS message and instead use a separate message for de locale that also configures the links correctly like the KLAR message.

Differential Revision: https://phabricator.services.mozilla.com/D157518
2022-09-16 05:26:14 +00:00
Punam Dahiya
e22374b3fb Bug 1790072 - Existing user onboarding colorways screen should select user existing theme intensity r=Mardak
Configure upgrade spotlight with dark variation to persist variation as bold when starting with a dark theme.

Differential Revision: https://phabricator.services.mozilla.com/D157161
2022-09-15 02:42:02 +00:00
negin
6e90484073 Bug 1788521 - Add a pref to hide Pin Private Window option from Existing users MR onboarding r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D157144
2022-09-14 19:44:39 +00:00
Punam Dahiya
a10036f907 Bug 1787275 - Add majorRelease2022 nimbus holdback targeting to hide pin promo r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D157291
2022-09-14 17:49:26 +00:00
Shane Hughes
ae3150ef08 Bug 1790126 - Change Colorways onboarding primary label. r=Mardak,flod
Differential Revision: https://phabricator.services.mozilla.com/D157230
2022-09-14 14:38:20 +00:00
Punam Dahiya
f332fca018 Bug 1789192 - MR Onboarding Mobile Cross promo QRCode for MozillaOnline partner repack r=jprickett,hectorz
Differential Revision: https://phabricator.services.mozilla.com/D157000
2022-09-13 18:35:01 +00:00
Iulian Moraru
dcf1f3817e Backed out changeset b81337fc9ed1 (bug 1789192) for causing multiple bc failures. CLOSED TREE 2022-09-13 19:44:44 +03:00
Punam Dahiya
31a79a1338 Bug 1789192 - MR Onboarding Mobile Cross promo QRCode for MozillaOnline partner repack r=jprickett,hectorz
Patch updates QR code svg as confirmed in https://bugzilla.mozilla.org/show_bug.cgi?id=1789192#c3

Differential Revision: https://phabricator.services.mozilla.com/D157000
2022-09-13 15:52:27 +00:00
Shane Hughes
e641c823dc Bug 1790127 - Hide the secondary CTA on welcome screen if the primary action will have no effect. r=Mardak
If Firefox is the default app and pinned to the dock/taskbar, the
primary CTA on the welcome screen will have the same effect as the
secondary CTA. So we can hide one of them. The non-MR page already has
this feature and elects to hide the secondary CTA, so do the same here.

Differential Revision: https://phabricator.services.mozilla.com/D157019
2022-09-11 20:14:53 +00:00
Shane Hughes
367a4bf41c Bug 1789667 - Fix onboarding screen background images for HCM. r=mviar,emcminn
In HCM on Windows, background colors are overridden by the HCM theme's
default background value. And if a CSS background property has more
than 1 layer, only the last layer can include a background-color, so I
suspect that if it has one, background-images on the previous layers
will be obscured by the overridden default background on the last
layer. This patch circumvents this by putting the background-color on
the same layer as the background-image.

Differential Revision: https://phabricator.services.mozilla.com/D156719
2022-09-10 18:07:34 +00:00
Ben Hearsum
5f9ef20b27 Bug 1782295: Rename private window separation pref. r=pbz
I don't see any reason to keep this under the same namespace as the other former `privacySegmentation` prefs - but perhaps I'm missing something here.

Depends on D156733

Differential Revision: https://phabricator.services.mozilla.com/D156734
2022-09-08 13:09:11 +00:00
Shane Hughes
23af080683 Bug 1788966 - Stop showing privacy segmentation screen. r=Mardak
Remove the privacy segmentation screen unless a Nimbus variable or its fallback
pref is set. Bug 1788967 sets this pref to false, so this should remove the
screen by default but leave it available for us to continue work on it.

Differential Revision: https://phabricator.services.mozilla.com/D156330
2022-09-06 20:22:38 +00:00
Dan Mosedale
f069e9446a Bug 1789008 - make onboarding tab modal in new tab instead of window modal,r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D156359
2022-09-05 04:23:51 +00:00
Paul Zuehlcke
adc21c4e40 Bug 1788697 - Rename browser.privacySegmentation.enabled pref. r=pdahiya,timhuang,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D156194
2022-09-02 10:46:46 +00:00
Meg Viar
248755e275 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D155524
2022-08-31 16:09:26 +00:00
Emily McMinn
70ed34842d Bug 1776689 - Add assets for MR new user onboarding 50-50 template designs r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D155757
2022-08-31 01:20:27 +00:00
Butkovits Atila
a2ff884367 Backed out changeset 9256826198bb (bug 1776689) for causing failures at browser_parsable_css.js. CLOSED TREE 2022-08-31 03:25:08 +03:00
Emily McMinn
5cc8cd7862 Bug 1776689 - Add assets for MR new user onboarding 50-50 template designs r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D155757
2022-08-30 23:32:33 +00:00
hanna alemu
99a97a7301 Bug 1778796 - Add pin private browsing pinning option to existing user MR onboarding r=hanna_a
Depends on D154851

Differential Revision: https://phabricator.services.mozilla.com/D155305
2022-08-30 04:13:27 +00:00
Jason Prickett
fc6376143d Bug 1779514 - Add privacy segmentation screen for existing users in MR Onboarding r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D155287
2022-08-30 03:25:34 +00:00
Sandor Molnar
8aaea79f98 Backed out changeset 225b8bbe0912 (bug 1786647) for causing browser-chrome failures in toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser_asrouter_trigger_docs.js CLOSED TREE 2022-08-30 01:43:39 +03:00
Meg Viar
91ba440ce8 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D155524
2022-08-29 20:19:16 +00:00
Csoregi Natalia
591eeff1af Backed out changeset ba0784c1646a (bug 1786647) for fxms failures. CLOSED TREE 2022-08-29 19:51:17 +03:00
Meg Viar
4f744927cf Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D155524
2022-08-29 16:18:42 +00:00
criss
351bc28d66 Backed out changeset 56ba242e0732 (bug 1786647) for causing python fxms failures . CLOSED TREE 2022-08-29 17:14:11 +03:00
Meg Viar
605bbe0b26 Bug 1786647 - Split up Feature Callout messages and fetch from ASRouter on page load, focus, and screen advance r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D155524
2022-08-29 13:29:31 +00:00
Jason Prickett
92d400e12c Bug 1783750 - MR Onboarding Colorways save colorway on primary cta click r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D155516
2022-08-27 00:59:10 +00:00
Csoregi Natalia
449a36f56a Backed out changeset a9a1c540eac4 (bug 1783750) for causing newtab failures. CLOSED TREE 2022-08-27 02:28:29 +03:00
Jason Prickett
9d5ca66995 Bug 1783750 - MR Onboarding Colorways save colorway on primary cta click r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D155516
2022-08-26 22:29:27 +00:00
Dan Mosedale
e926022574 Bug 1781361 - impl set home page option for upgraders, r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D154851
2022-08-26 16:41:00 +00:00
negin
c74fa3c462 Bug 1781528 - Add Arrow to secondary button CTA r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D155594
2022-08-25 14:47:06 +00:00
Jason Prickett
e07f057866 Bug 1785987 - MR Onboarding mobile download link should open in background tab r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D155262
2022-08-24 16:08:30 +00:00
Jason Prickett
98a86335a7 Bug 1786246 - MR Onboarding Private Pin Skip Step button fix r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D155252
2022-08-22 18:16:35 +00:00