Iulian Moraru
e4cb785520
Backed out 3 changesets (bug 1801092) for causing newtab failures.
...
Backed out changeset 9153de956154
Backed out changeset 9df9c279c28d (bug 1801092)
Backed out changeset 7323c7444941 (bug 1801092)
2022-11-30 00:28:42 +02:00
Otto Länd
dbb211d8a1
No bug: apply code formatting via Lando
...
# ignore-this-changeset
2022-11-29 21:46:36 +00:00
hanna alemu
ad8c25fedf
Bug 1796900 - Don't nag users about Firefox View r=mviar,barret
...
Differential Revision: https://phabricator.services.mozilla.com/D160284
2022-11-09 20:06:58 +00:00
Kirk Steuber
8bbbac70d4
Bug 1727820 - Change nsIUpdateChecker consumers to use the new interface r=bhearsum
...
This patch misses one notable nsIUpdateChecker consumer: AppUpdater. This patch stack makes major changes to AppUpdater, so those changes will be made in their own patch later in this patch stack.
Differential Revision: https://phabricator.services.mozilla.com/D159295
2022-10-26 07:44:31 +00:00
Iulian Moraru
902802bebe
Backed out 18 changesets (bug 1727820) for causing mochitest failures. CLOSED TREE
...
Backed out changeset 04a0c1cbeeb3 (bug 1727820)
Backed out changeset a6633d97ba02 (bug 1727820)
Backed out changeset dd7cd58bdf72 (bug 1727820)
Backed out changeset 06b53d536ef1 (bug 1727820)
Backed out changeset 2cbec56223e5 (bug 1727820)
Backed out changeset 7ccc00d36f16 (bug 1727820)
Backed out changeset 023595d9cb76 (bug 1727820)
Backed out changeset 3dafccf3cf28 (bug 1727820)
Backed out changeset c60b9a6a79ce (bug 1727820)
Backed out changeset 9bbb0f0f1caf (bug 1727820)
Backed out changeset 6d8cf5f78de8 (bug 1727820)
Backed out changeset 8ed9a62d4c5a (bug 1727820)
Backed out changeset d429cf593dae (bug 1727820)
Backed out changeset 67ba1beb529a (bug 1727820)
Backed out changeset 15762d60d97e (bug 1727820)
Backed out changeset 04f5ad71363a (bug 1727820)
Backed out changeset 137f1da67f91 (bug 1727820)
Backed out changeset 5b91828ded9b (bug 1727820)
2022-10-26 01:25:06 +03:00
Kirk Steuber
c6ba4aa673
Bug 1727820 - Change nsIUpdateChecker consumers to use the new interface r=bhearsum
...
This patch misses one notable nsIUpdateChecker consumer: AppUpdater. This patch stack makes major changes to AppUpdater, so those changes will be made in their own patch later in this patch stack.
Differential Revision: https://phabricator.services.mozilla.com/D159295
2022-10-25 18:10:18 +00:00
Norisz Fay
11a2b4ece2
Backed out 18 changesets (bug 1727820) for causing mochitest failures on browser_updateAsk.js CLOSED TREE
...
Backed out changeset 577d5618fcd1 (bug 1727820)
Backed out changeset 9e6a904ec81d (bug 1727820)
Backed out changeset d95a38c6e8b4 (bug 1727820)
Backed out changeset dc9b7d7e97ae (bug 1727820)
Backed out changeset 464b501ae051 (bug 1727820)
Backed out changeset 9729c6dd1aac (bug 1727820)
Backed out changeset 3c67eac7d52e (bug 1727820)
Backed out changeset 7c2a0dfca2d2 (bug 1727820)
Backed out changeset 2021fb0cba9e (bug 1727820)
Backed out changeset 7a02de8e6ca6 (bug 1727820)
Backed out changeset 6e9017360297 (bug 1727820)
Backed out changeset 0bfff694ce96 (bug 1727820)
Backed out changeset 746d1c708507 (bug 1727820)
Backed out changeset 3b14d8d1fb94 (bug 1727820)
Backed out changeset c8a1417f3528 (bug 1727820)
Backed out changeset 69ef434ae92c (bug 1727820)
Backed out changeset ad646b770b07 (bug 1727820)
Backed out changeset 18b9dd91761f (bug 1727820)
2022-10-25 05:31:39 +03:00
Kirk Steuber
80f78afa02
Bug 1727820 - Change nsIUpdateChecker consumers to use the new interface r=bhearsum
...
This patch misses one notable nsIUpdateChecker consumer: AppUpdater. This patch stack makes major changes to AppUpdater, so those changes will be made in their own patch later in this patch stack.
Differential Revision: https://phabricator.services.mozilla.com/D159295
2022-10-24 20:53:21 +00:00
Mark Banner
5407bdffa8
Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
...
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.
Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Angel_V129
e3be76313a
Bug 1788756 - [Themes] Convert browser/theme JSM modules to ESMs. r=kpatenio
...
Differential Revision: https://phabricator.services.mozilla.com/D157037
2022-10-04 19:02:24 +00:00
Mark Banner
a49b8ef78f
Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D158094
2022-09-29 06:52:34 +00:00
Mark Banner
92309dcd01
Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D158088
2022-09-27 18:58:57 +00:00
Cristian Tuns
379cbd0e59
Backed out changeset cd3ab0559b8a (bug 1792344) for causing node failures CLOSED TREE
2022-09-27 14:44:13 -04:00
Mark Banner
87cee1d460
Bug 1792344 - Add targeting in ASRouter for distributions. r=Mardak,mkaply
...
Differential Revision: https://phabricator.services.mozilla.com/D158088
2022-09-27 18:06:46 +00:00
Jonathan Sudiaman
febfadf50b
Bug 1790758 - Convert Region.jsm and IgnoreLists.jsm JSM modules to ESMs r=Standard8,preferences-reviewers,credential-management-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D157337
2022-09-20 12:21:45 +00:00
Barret Rennie
6b4a7f9717
Bug 1784101 - Add targeting for detecting MR2022 holdback study r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D156215
2022-09-12 20:37:17 +00:00
Barret Rennie
baf65ff598
Bug 1787290 - Cache isDefaultBrowser in ASRouter targeting r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D155646
2022-08-30 05:07:45 +00:00
Sandor Molnar
e08f8f8370
Backed out changeset c0865c4d8f2f (bug 1787290) for causing xpc failures in backgroundtasks/tests/xpcshell/test_backgroundtask_targeting.js CLOSED TREE
2022-08-30 07:37:51 +03:00
Barret Rennie
6e6e62e509
Bug 1787290 - Cache isDefaultBrowser in ASRouter targeting r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D155646
2022-08-30 03:54:39 +00:00
Meg Viar
68f97c6096
Bug 1787783 - return boolean for userEnabledActiveColorway targeting param r=emcminn
...
For consistency, always return a boolean for `userEnabledActiveColorway` targeting param.
This change should have no effect on current functionality.
Differential Revision: https://phabricator.services.mozilla.com/D155847
2022-08-29 17:38:24 +00:00
Meg Viar
8ad31e8913
Bug 1786646 - Add targeting in ASRouter for "colorways active" and "user has not set up colorways" r=pdahiya,nalexander
...
Differential Revision: https://phabricator.services.mozilla.com/D155491
2022-08-26 21:54:52 +00:00
Iulian Moraru
2fb40f2509
Backed out changeset 6c93386d6258 (bug 1787290) for causing bc failures on browser_asrouter_targeting.js. CLOSED TREE
2022-08-26 22:20:30 +03:00
Barret Rennie
dcad2c681d
Bug 1787290 - Cache isDefaultBrowser in ASRouter targeting r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D155646
2022-08-26 17:44:31 +00:00
Cristian Tuns
60f732062a
Backed out changeset 500d9526b586 (bug 1786646) for causing xpcshell failures test_backgroundtask_targeting.js CLOSED TREE
2022-08-26 09:38:56 -04:00
Meg Viar
14b3ddf157
Bug 1786646 - Add targeting in ASRouter for "colorways active" and "user has not set up colorways" r=pdahiya
...
Differential Revision: https://phabricator.services.mozilla.com/D155491
2022-08-26 12:55:27 +00:00
Meg Viar
9eb6f24939
Bug 1780015 - Add targeting for users who prefer reduced motion in AboutWelcome message surfaces r=pdahiya
...
Differential Revision: https://phabricator.services.mozilla.com/D152174
2022-07-22 17:10:26 +00:00
Nick Alexander
232384a3e0
Bug 1780299 - Add isBackgroundTaskMode and backgroundTaskName to ASRouterTargeting. r=barret
...
These will allow targeting Nimbus experiments and Firefox Messaging
System messages only to background tasks.
Differential Revision: https://phabricator.services.mozilla.com/D152289
2022-07-20 19:15:18 +00:00
Iulian Moraru
df431be6b8
Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
...
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
f399fc3c21
Bug 1780074 - Migrate browser/components/newtab to ESM. r=daleharvey
...
Differential Revision: https://phabricator.services.mozilla.com/D152113
2022-07-20 10:36:52 +00:00
Tooru Fujisawa
328d63ce7f
Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983
Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
...
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b
Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af
Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
...
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Nick Alexander
6395b2359f
Bug 1775138 - Part 2: Ensure ASRouterTargeting.Environment can be used in background tasks. r=barret
...
We take a simple approach:
1. We add a test to verify that all getters succeed in background
task mode (save for an exclusion list of getters that access
non-local hosts).
2. We make certain getters background task-aware: for example,
because they require the `AddonsManager` or legacy Telemetry.
This will allow background tasks to access their own targeting as well
as a snapshot of the default profile's targeting.
Differential Revision: https://phabricator.services.mozilla.com/D151089
2022-07-08 20:36:09 +00:00
Nick Alexander
cc142c7dff
Bug 1775138 - Part 1: Snapshot Firefox Messaging System targeting configuration periodically. r=barret
...
This commit arranges to write `targeting.snapshot.json` to the local
profile directory every 30 minutes, and just before shutdown. For
simplicity, it uses the existing `JSONFile.jsm` implementation.
Differential Revision: https://phabricator.services.mozilla.com/D151057
2022-07-08 20:36:08 +00:00
Meg Viar
4c527f9886
Bug 1772025 - Add targeting for users who have private Firefox browser pinned r=pdahiya,barret
...
Differential Revision: https://phabricator.services.mozilla.com/D148446
2022-06-22 18:30:03 +00:00
Tooru Fujisawa
8cfc991c17
Bug 1773829 - Part 2: Stop using lazy getter unnecessarily in browser/components/newtab/. r=thecount
...
Depends on D149010
Differential Revision: https://phabricator.services.mozilla.com/D149011
2022-06-15 20:56:22 +00:00
Dan Mosedale
b2502351c9
Bug 1753915 - Add logging to ASRouter, r=barret
...
Differential Revision: https://phabricator.services.mozilla.com/D137968
2022-06-10 14:16:24 +00:00
Tooru Fujisawa
ff679ae78e
Bug 1772100 - Part 10: Use plain object for lazy getter in browser/components/newtab/. r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D148020
2022-06-06 22:46:23 +00:00
Tooru Fujisawa
f947410342
Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 04:42:09 +00:00
Molnar Sandor
4c2b06df41
Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
...
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
b580e51d8f
Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 02:49:13 +00:00
Norisz Fay
a2aaecaf19
Backed out changeset bbcec6afecd4 (bug 1753915) for causing newtab node failures CLOSED TREE
2022-06-03 00:11:50 +03:00
Dan Mosedale
3823854e76
Bug 1753915 - Add logging to ASRouter, r=barret
...
Differential Revision: https://phabricator.services.mozilla.com/D137968
2022-06-02 20:05:27 +00:00
Tooru Fujisawa
d1bd5e4401
Bug 1771463 - Do not export lazy getter "fxAccounts" from services/fxaccounts/FxAccounts.jsm. r=markh,preferences-reviewers,Mardak
...
Instead of exporting lazy getter, export a function that returns the FxAccount
singleton, lazily creating on the first call, and define the lazy getter on the
consumer side that calls the function.
Differential Revision: https://phabricator.services.mozilla.com/D147634
2022-05-31 14:09:10 +00:00
Cosmin Sabou
dd73bafd11
Backed out changeset 697ab99d1c61 (bug 1771463) for causing node newtab failures. CLOSED TREE
2022-05-31 07:16:41 +03:00
Tooru Fujisawa
7f15e8996c
Bug 1771463 - Do not export lazy getter "fxAccounts" from services/fxaccounts/FxAccounts.jsm. r=markh,preferences-reviewers
...
Instead of exporting lazy getter, export a function that returns the FxAccount
singleton, lazily creating on the first call, and define the lazy getter on the
consumer side that calls the function.
Differential Revision: https://phabricator.services.mozilla.com/D147634
2022-05-31 03:12:22 +00:00
Tooru Fujisawa
ec12e735ac
Bug 1610653 - Part 13: Do not store lexical variable also to global this property in browser/components/newtab. r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D144120
2022-05-30 15:19:40 +00:00
Tooru Fujisawa
8ea99a9dbb
Bug 1610653 - Part 2: Do not use global this property assignment to define global variable in browser/components/newtab. r=Mardak
...
Differential Revision: https://phabricator.services.mozilla.com/D144109
2022-05-30 15:19:36 +00:00
Andrei Oprea
28d88d09f4
Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
...
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 19:45:17 +00:00