Commit Graph

53 Commits

Author SHA1 Message Date
Iulian Moraru
e4cb785520 Backed out 3 changesets (bug 1801092) for causing newtab failures.
Backed out changeset 9153de956154
Backed out changeset 9df9c279c28d (bug 1801092)
Backed out changeset 7323c7444941 (bug 1801092)
2022-11-30 00:28:42 +02:00
Otto Länd
dbb211d8a1 No bug: apply code formatting via Lando
# ignore-this-changeset
2022-11-29 21:46:36 +00:00
Shane Hughes
8ceb90e910 Bug 1800087 - Fix ASRouter references to RS collections. r=barret
ASRouter's remote message providers were written to include a property
to specify the desired collection on the Remote Settings Kinto server.
But this property was mistakenly labeled `bucket` in many places. This
could be confusing because Kinto storage is organized by both buckets
and collections, with buckets being a higher level of organization and
collections belonging to buckets. Each individual message provider
specifies a collection like "cfr", while the bucket is set by the router
code ("main"). This carried over to everything that interacted with the
providers, so this patch effectively replaces every reference to a
"message provider bucket" with "message provider collection." But more
importantly, provider definitions are stored as JSON strings in
preference values, so these definitions erroneously contained key-value
pairs like `bucket: "cfr"` which should have been `collection: "cfr"`.
That means the pref values themselves must be migrated to ensure that
modified prefs continue to work. Existing tests are updated and a new
test is added for the migrator, to meet minimum coverage requirements.
Documentation is also updated to reflect the correct property name.

Differential Revision: https://phabricator.services.mozilla.com/D162067
2022-11-17 18:32:13 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
f399fc3c21 Bug 1780074 - Migrate browser/components/newtab to ESM. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D152113
2022-07-20 10:36:52 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Dan Mosedale
b2502351c9 Bug 1753915 - Add logging to ASRouter, r=barret
Differential Revision: https://phabricator.services.mozilla.com/D137968
2022-06-10 14:16:24 +00:00
Norisz Fay
a2aaecaf19 Backed out changeset bbcec6afecd4 (bug 1753915) for causing newtab node failures CLOSED TREE 2022-06-03 00:11:50 +03:00
Dan Mosedale
3823854e76 Bug 1753915 - Add logging to ASRouter, r=barret
Differential Revision: https://phabricator.services.mozilla.com/D137968
2022-06-02 20:05:27 +00:00
Tooru Fujisawa
ec12e735ac Bug 1610653 - Part 13: Do not store lexical variable also to global this property in browser/components/newtab. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D144120
2022-05-30 15:19:40 +00:00
Tooru Fujisawa
8ea99a9dbb Bug 1610653 - Part 2: Do not use global this property assignment to define global variable in browser/components/newtab. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D144109
2022-05-30 15:19:36 +00:00
Meg Viar
51b15e5d34 Bug 1747149 - Consolidate logic for when to show VPN promo and add BrowserUtils test r=dmose,preferences-reviewers,prathiksha,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D134874
2022-02-14 14:21:04 +00:00
smolnar
9f23ccb51e Backed out changeset 260a3d2ed070 (bug 1747149) for causing android xpc failures in test_BrowserUtils. 2022-02-11 05:04:29 +02:00
Meg Viar
e8992b0b02 Bug 1747149 - Consolidate logic for when to show VPN promo and add BrowserUtils tests r=dmose,preferences-reviewers,prathiksha,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D134874
2022-02-11 02:06:56 +00:00
Marian-Vasile Laza
955d57fe74 Backed out changeset 9c6f30f619d7 (bug 1747149) for causing xpcshell failures on test_BrowserUtils.js. CLOSED TREE 2022-02-09 02:08:44 +02:00
Meg Viar
91b66923e1 Bug 1747149 - Consolidate logic for when to show VPN promo and add BrowserUtils tests r=dmose,preferences-reviewers,prathiksha,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D134874
2022-02-08 21:39:38 +00:00
Dan Mosedale
48bceb9eaf Bug 1730621 - avoid showing captive portal VPN promo in some cases, r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D125832
2021-09-17 23:31:40 +00:00
Andrei Oprea
55a44da2ef Bug 1695764 - Remove code related to CFR ML Experiment r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D113963
2021-06-15 10:44:15 +00:00
Andrei Oprea
ea7c65fcad Bug 1675127 - Remove code from ASRouter that shows the triplets (3 cards) at the top of the newtab page r=k88hudson,pdahiya,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D97213
2020-12-03 13:47:39 +00:00
Punam Dahiya
d696b17955 Bug 1659150 - Remove about:welcome trailhead, full page and ReturnToAMO templates r=perftest-reviewers,Mardak,mkaply,nanj,sparky
Differential Revision: https://phabricator.services.mozilla.com/D89077
2020-09-11 16:35:04 +00:00
Cosmin Sabou
1090e15e9f Backed out changeset 08f94ba4c50c (bug 1659150) for bc failures on browser_all_files_referenced.js. CLOSED TREE 2020-09-11 08:32:46 +03:00
Punam Dahiya
29a57a59ff Bug 1659150 - Remove about:welcome trailhead, full page and ReturnToAMO templates r=perftest-reviewers,Mardak,mkaply,nanj,sparky
Differential Revision: https://phabricator.services.mozilla.com/D89077
2020-09-11 00:31:11 +00:00
Mark Banner
1cc76add79 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509
2020-03-08 21:45:16 +00:00
Andrei Oprea
01955d394e Bug 1613612 - Revert Bug 1603071 Enable release snippets in Nightly r=k88hudson
We now have support from the snippets backend to show content for the
Nightly channel

Differential Revision: https://phabricator.services.mozilla.com/D61811
2020-02-14 17:23:21 +00:00
Andrei Oprea
876dfc6bf9 Bug 1578754 - Implement groups configuration for Messaging System content r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D56545
2019-12-19 16:54:17 +00:00
Andrei Oprea
11da5786e8 Bug 1603071 - Enable release snippets in Nightly without telemetry r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D57460
2019-12-18 12:15:16 +00:00
Kate Hudson
7ffa0edeaa Bug 1599762 - Add filtering and sorting by score to ASRouterTargeting r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D55066
2019-11-28 23:28:23 +00:00
Punam Dahiya
6c72b56ec9 Bug 1592671 - Remove messaging router custom code to run firstrun experiments r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D54783
2019-11-28 04:16:10 +00:00
Arthur Iakab
634a8e805e Backed out changeset c4e2033deb99 (bug 1592671) for node-newtab test failures. 2019-11-28 01:09:47 +02:00
Punam Dahiya
5cd682f682 Bug 1592671 - Remove messaging router custom code to run firstrun experiments r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D54783
2019-11-27 21:15:38 +00:00
Andrei Oprea
1fcc644109 Bug 1595090 - Expose scores and values to targeting expression r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D52368
2019-11-12 15:39:20 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Ed Lee
fd0f5752a7 Bug 1554322 - Add accessible content, static clamping and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D32540
2019-05-25 00:38:53 +00:00
Ed Lee
01cf288d98 Bug 1551751 - Add return telemetry, faster stories and bug fixes to Activity Stream r=r1cky
Differential Revision: https://phabricator.services.mozilla.com/D31174
2019-05-15 02:21:12 +00:00
Ed Lee
135125c199 Bug 1548952 - Add offline fallback, request timeouts and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D29909
2019-05-04 05:36:06 +00:00
Andrei Oprea
a09dca3f13 Bug 1528953 - Add pref to opt out of recommended features r=k88hudson
To be reviewed together with https://github.com/mozilla/activity-stream/pull/4819

Differential Revision: https://phabricator.services.mozilla.com/D21408
2019-03-05 10:55:14 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Ricky Rosario
b7c4dae26f Bug 1505929 - Add FxA onboarding card, pref on CFR and ASR and bug fixes to Activity Stream r=k88hudson,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D11375
2018-11-10 19:13:10 +00:00
Cosmin Sabou
d477f94be3 Backed out changeset 9fce755a1262 (bug 1505929) for causing browser chrome nightly failures when tryin to connect to snippets.cdn.mozilla.net. a=backout 2018-11-10 16:45:39 +02:00
Ricky Rosario
65eab79e4b Bug 1505929 - Add FxA onboarding card, pref on CFR and ASR and bug fixes to Activity Stream r=k88hudson
MozReview-Commit-ID: 2NdTCG1NWe8

Differential Revision: https://phabricator.services.mozilla.com/D11375
2018-11-09 21:46:11 +00:00
Ed Lee
91bff3911a Bug 1502461 - Fix recommendation counts, recommendation alignment and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D9949
2018-10-27 01:31:08 +00:00
Ed Lee
1b48da1edc Bug 1500540 - Add end-of-year snippet, contextual-feature-recommender preference and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D9297
2018-10-19 22:59:47 +00:00
Ed Lee
1eb6522f1a Bug 1499886 - Add send-to-device snippet, right-to-left robustness and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D9045
2018-10-18 05:00:47 +00:00
Ed Lee
72de3d9cf6 Bug 1498462 - Add Personalization v2, RichText snippets and bug fixes to Activity Stream r=ursula
Differential Revision: https://phabricator.services.mozilla.com/D8588
2018-10-12 19:13:39 +00:00
k88hudson
3064862662 Bug 1496457 - Add Newsletter template, addon install telemetry, remove legacy onboarding code, and bug fixes to Activity Stream r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D7916
2018-10-05 19:16:25 +00:00
k88hudson
f7751bfaa1 Bug 1494427 - [Export] Add locale targeting, ASR onboarding/user pref fixes, test fixes to Activity Stream r=ursula
Differential Revision: https://phabricator.services.mozilla.com/D7196
2018-09-28 20:59:01 +00:00