Commit Graph

278 Commits

Author SHA1 Message Date
Iulian Moraru
e4cb785520 Backed out 3 changesets (bug 1801092) for causing newtab failures.
Backed out changeset 9153de956154
Backed out changeset 9df9c279c28d (bug 1801092)
Backed out changeset 7323c7444941 (bug 1801092)
2022-11-30 00:28:42 +02:00
Otto Länd
dbb211d8a1 No bug: apply code formatting via Lando
# ignore-this-changeset
2022-11-29 21:46:36 +00:00
Barret Rennie
d1a2566d45 Bug 1541508 - Use Services.env in browser/ r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D160136
2022-11-25 19:09:06 +00:00
Shane Hughes
8ceb90e910 Bug 1800087 - Fix ASRouter references to RS collections. r=barret
ASRouter's remote message providers were written to include a property
to specify the desired collection on the Remote Settings Kinto server.
But this property was mistakenly labeled `bucket` in many places. This
could be confusing because Kinto storage is organized by both buckets
and collections, with buckets being a higher level of organization and
collections belonging to buckets. Each individual message provider
specifies a collection like "cfr", while the bucket is set by the router
code ("main"). This carried over to everything that interacted with the
providers, so this patch effectively replaces every reference to a
"message provider bucket" with "message provider collection." But more
importantly, provider definitions are stored as JSON strings in
preference values, so these definitions erroneously contained key-value
pairs like `bucket: "cfr"` which should have been `collection: "cfr"`.
That means the pref values themselves must be migrated to ensure that
modified prefs continue to work. Existing tests are updated and a new
test is added for the migrator, to meet minimum coverage requirements.
Documentation is also updated to reflect the correct property name.

Differential Revision: https://phabricator.services.mozilla.com/D162067
2022-11-17 18:32:13 +00:00
Cristian Tuns
c3ffdd5df6 Backed out 19 changesets (bug 1541508) for causing xpcshell failures on test_notHeadlessByDefault.js CLOSED TREE
Backed out changeset 08476fa2bc27 (bug 1541508)
Backed out changeset 0bf7514845db (bug 1541508)
Backed out changeset aa612a5e9ef7 (bug 1541508)
Backed out changeset 6bb9360473f7 (bug 1541508)
Backed out changeset b3d8e92f50c2 (bug 1541508)
Backed out changeset fa40dded133e (bug 1541508)
Backed out changeset 2e7db4aa8d4f (bug 1541508)
Backed out changeset 6098e2eb62ea (bug 1541508)
Backed out changeset 2c599ee639c4 (bug 1541508)
Backed out changeset 7d44f6e2644c (bug 1541508)
Backed out changeset c1279c3d674c (bug 1541508)
Backed out changeset 8bd08a62a590 (bug 1541508)
Backed out changeset 740010cb005c (bug 1541508)
Backed out changeset 0bfc7dd85c62 (bug 1541508)
Backed out changeset c4374a351356 (bug 1541508)
Backed out changeset 44ccfeca7364 (bug 1541508)
Backed out changeset e944e706a523 (bug 1541508)
Backed out changeset 2c59d66f43e4 (bug 1541508)
Backed out changeset a1896eacb6f1 (bug 1541508)
2022-11-01 22:38:52 -04:00
Barret Rennie
813aae1553 Bug 1541508 - Use Services.env in browser/ r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D160136
2022-11-02 02:08:53 +00:00
Punam Dahiya
3187d5e5cb Bug 1753746 - PBM messaging devtool integration r=pdahiya,mconley
Differential Revision: https://phabricator.services.mozilla.com/D145808
2022-10-31 15:21:56 +00:00
Dan Mosedale
b307d5a622 Bug 1797553 - Add fxms-message-1 to default FxMS features, r=negin
Differential Revision: https://phabricator.services.mozilla.com/D160402
2022-10-26 21:22:58 +00:00
Barret Rennie
b1df109588 Bug 1797202 - Ingest messages from Nimbus rollouts in ASRouter r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D160263
2022-10-26 19:00:03 +00:00
Punam Dahiya
7137aedad9 Bug 1795037 - Fix filter of messages in ASRouter state after using PBM r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D160125
2022-10-26 03:15:40 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Barret Rennie
13c6e5729b Bug 1776326 - Prefetch Remote Images when enrolling in experiments r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D151353
2022-07-27 14:33:43 +00:00
Punam Dahiya
1b269b2963 Bug 1779858 - Update ShouldShowPromo to handle PIN promotype r=mviar,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D152135
2022-07-21 18:50:55 +00:00
Barret Rennie
f1d3a85827 Bug 1780445 - Fix Remote Settings server URL lookup in ASRouter and Remote Images r=pdahiya,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D152306
2022-07-21 02:28:59 +00:00
smolnar
6fa56c5349 Backed out changeset 81082e189b59 (bug 1780445) for causing node-new-tab failure. CLOSED TREE 2022-07-21 05:07:34 +03:00
Barret Rennie
3fac10850a Bug 1780445 - Fix Remote Settings server URL lookup in ASRouter and Remote Images r=pdahiya,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D152306
2022-07-21 01:19:15 +00:00
Iulian Moraru
df431be6b8 Backed out 3 changesets (bug 1780074, bug 1780347) for causing multiple failures. CLOSED TREE
Backed out changeset ee4c4d34816c (bug 1780347)
Backed out changeset a13d3939b98a (bug 1780074)
Backed out changeset 3bc739f7de43 (bug 1780074)
2022-07-20 14:57:48 +03:00
Mark Banner
f399fc3c21 Bug 1780074 - Migrate browser/components/newtab to ESM. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D152113
2022-07-20 10:36:52 +00:00
Nick Alexander
6e9303448d Bug 1775128 - Add toast_notification message template for displaying (native) toast notifications. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D150073
2022-07-20 02:58:42 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D151214
2022-07-11 15:09:13 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu
Differential Revision: https://phabricator.services.mozilla.com/D150893
2022-07-11 12:41:50 +00:00
Barret Rennie
b3e2605f2b Bug 1771073 - Correct FxMS features and keep them up to date with tests r=dmose,pdahiya
The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept *any* FxMS message.
The features have been updated with schemas that accept any FxMS message.

As part of this, all FxMS schemas have been updated with an `$id` so that they
can be bundled into feature schemas and have their internal `$ref`s work.
(Otherwise, a `$ref` would be relative to the top-level schema instead of the
sub-schema).

Schemas for individual message types are no longer exposed as resource:// URIs,
except in tests, as indivual schemas are no longer required at runtime.

Additionally, each FxMS schema has had its `template` field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").

A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:

```
cd ./browser/components/newtab/content-src/asrouter/schemas
../../../../../../mach make-schemas.py
```

Differential Revision: https://phabricator.services.mozilla.com/D147332
2022-06-29 23:01:37 +00:00
Tooru Fujisawa
62aa93946a Bug 1608282 - Part 4: Remove Cu.defineLazyGlobalGetters from JSM. r=webdriver-reviewers,extension-reviewers,jdescottes,kmag
Depends on D149196

Differential Revision: https://phabricator.services.mozilla.com/D149197
2022-06-16 00:19:54 +00:00
Butkovits Atila
0642580e74 Backed out 4 changesets (bug 1608282) for causing hazard failures. CLOSED TREE
Backed out changeset 32aebc8be201 (bug 1608282)
Backed out changeset 37c970364269 (bug 1608282)
Backed out changeset ced8d82cc2d2 (bug 1608282)
Backed out changeset e26e480c7dd6 (bug 1608282)
2022-06-16 03:10:02 +03:00
Tooru Fujisawa
b3d40a272f Bug 1608282 - Part 4: Remove Cu.defineLazyGlobalGetters from JSM. r=webdriver-reviewers,extension-reviewers,jdescottes,kmag
Depends on D149196

Differential Revision: https://phabricator.services.mozilla.com/D149197
2022-06-15 20:34:35 +00:00
Dan Mosedale
b2502351c9 Bug 1753915 - Add logging to ASRouter, r=barret
Differential Revision: https://phabricator.services.mozilla.com/D137968
2022-06-10 14:16:24 +00:00
Tooru Fujisawa
ff679ae78e Bug 1772100 - Part 10: Use plain object for lazy getter in browser/components/newtab/. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D148020
2022-06-06 22:46:23 +00:00
Tooru Fujisawa
f947410342 Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 04:42:09 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
2022-06-06 07:04:25 +03:00
Tooru Fujisawa
b580e51d8f Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D148166
2022-06-06 02:49:13 +00:00
Norisz Fay
a2aaecaf19 Backed out changeset bbcec6afecd4 (bug 1753915) for causing newtab node failures CLOSED TREE 2022-06-03 00:11:50 +03:00
Dan Mosedale
3823854e76 Bug 1753915 - Add logging to ASRouter, r=barret
Differential Revision: https://phabricator.services.mozilla.com/D137968
2022-06-02 20:05:27 +00:00
Tooru Fujisawa
e1a3290c6b Bug 1771460 - Part 3: Do not define CFRMessageProvider lazy getter. r=Gijs
CFRMessageProvider is eagerly imported and immediately used in the top-level.

Depends on D147593

Differential Revision: https://phabricator.services.mozilla.com/D147594
2022-05-30 20:50:22 +00:00
Tooru Fujisawa
ec12e735ac Bug 1610653 - Part 13: Do not store lexical variable also to global this property in browser/components/newtab. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D144120
2022-05-30 15:19:40 +00:00
Tooru Fujisawa
8ea99a9dbb Bug 1610653 - Part 2: Do not use global this property assignment to define global variable in browser/components/newtab. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D144109
2022-05-30 15:19:36 +00:00
Punam Dahiya
74fd8b3a3e Bug 1765907 - PBM experiment message should override default promo message r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D144871
2022-05-12 18:24:06 +00:00
Cristian Tuns
9a2ed99397 Backed out changeset eb12cdc5d1e8 (bug 1765907) for causing mochitest failures on browser_privatebrowsing_focus_promo.js CLOSED TREE 2022-05-10 14:38:02 -04:00
Punam Dahiya
daed30958c Bug 1765907 - PBM experiment message should override default promo message r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D144871
2022-05-10 17:12:05 +00:00
Barret Rennie
585dcbcd30 Bug 1761522 - Allow ja-JP-macos locale for RemoteL10n r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D142227
2022-04-28 17:10:15 +00:00
Mathieu Leplatre
bd032c460c Bug 1634127 - Download attachments in IndexedDB by default r=necko-reviewers,robwu,dragana
This patch changes the default behaviour of `download()`.

- Previous file-based behaviour was moved to `downloadToDisk()` and `deleteFromDisk()`. Existing consumers were migrated to avoid behaviour change.
- `download()` has now `{useCache: true}` by default, option was dropped, and `deleteCached()` is now `deleteDownloaded()`

Differential Revision: https://phabricator.services.mozilla.com/D141980
2022-04-20 13:07:50 +00:00
Barret Rennie
3384f9c880 Bug 1754220 - Update ASRouter messages when force-enrolling in an experiment r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D142240
2022-04-13 15:56:21 +00:00
Marian-Vasile Laza
7134707a38 Backed out changeset c43b947f03b0 (bug 1634127) for causing newtab failures. CLOSED TREE 2022-04-12 05:29:27 -07:00
Mathieu Leplatre
0da93ad8ff Bug 1634127 - Download attachments in IndexedDB by default r=necko-reviewers,robwu,dragana
This patch changes the default behaviour of `download()`.

- Previous file-based behaviour was moved to `downloadToDisk()` and `deleteFromDisk()`. Existing consumers were migrated to avoid behaviour change.
- `download()` has now `{useCache: true}` by default, option was dropped, and `deleteCached()` is now `deleteDownloaded()`

Differential Revision: https://phabricator.services.mozilla.com/D141980
2022-04-12 10:50:47 +00:00
Meg Viar
c02cdd5903 Bug 1762477 - Add test coverage for resetMessageState in ASRouter.jsm r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D142890
2022-04-07 18:26:13 +00:00
Cosmin Sabou
cc005b99cd Backed out changeset 253a415f7be7 (bug 1754220) for causing ASRouter related newtab failures. CLOSED TREE 2022-04-07 02:14:49 +03:00
Barret Rennie
080900b8aa Bug 1754220 - Update ASRouter messages when force-enrolling in an experiment r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D142240
2022-04-06 22:34:24 +00:00
Meg Viar
48fd34f067 Bug 1762242 - Conditionally show Private Browsing page Focus promo r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D142551
2022-04-01 12:36:30 +00:00
Dan Mosedale
5e02b224d2 Bug 1749775 - Add user telemetry for 98 VPN promo, r=andreio,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D135874
2022-02-11 16:31:06 +00:00