Commit Graph

60 Commits

Author SHA1 Message Date
Shane Hughes
16d1998b3f Bug 1783070 - Use safe navigators for About Welcome window functions. r=mviar
Update About Welcome's invocations of window functions to use optional
chaining to avoid errors when they are undefined. Then, the surfaces
that load the About Welcome bundle will no longer need to define those
references as empty functions.

Differential Revision: https://phabricator.services.mozilla.com/D155011
2022-08-26 21:43:54 +00:00
Jason Prickett
aab4b29d50 Bug 1781378 - Adding final MR onboarding strings r=pdahiya,fluent-reviewers,flod,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D154681
2022-08-19 20:42:45 +00:00
Dan Mosedale
ef1b2237aa Bug 1612986 - fix about:welcome/newtab/asrouter unit-test code-cov info, r=emcminn
This is a follow-on fix for the bug in question.  It changes the options used for building lcov.info so that the full m-c path gets included, so that https://coverage.moz.tools/ will start reflecting our unit test coverage.

Differential Revision: https://phabricator.services.mozilla.com/D144069
2022-04-20 17:36:35 +00:00
Meg Viar
1db2a0f1c1 Bug 1761250 - Enable showing Klar QR to users with de locale in Focus promos using Spotlight in PBM r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D141965
2022-03-29 17:24:11 +00:00
Andrei Oprea
dd9e0735eb Bug 1748215 - Upgrade newtab component to use webpack 5 r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D134956
2022-03-28 20:38:37 +00:00
Greg Tatum
80525762c6 Bug 1755519 - Add language switching to about:welcome; r=pdahiya,platform-i18n-reviewers,flod,dminor
This patch ended up adding some complexity to about:welcome, as the
language switching needs to eagerly perform fallible asynchronous
actions. Specifically it needs to get the list of addons and
pre-emptively install the langpack, which can take time, and can fail.

This necessitated building a custom React components and custom hooks to
be able to deal with these requirements.

The following command will allow for the testing of this feature.

./mach run \
  --temp-profile \
  --setpref "extensions.getAddons.langpacks.url=https://mock-amo-language-tools.glitch.me/?app=firefox&type=language&appversion=%VERSION%" \
  --setpref "intl.multilingual.aboutWelcome.languageMismatchEnabled=true" \
  --setpref "intl.multilingual.aboutWelcome.systemLocaleOverride=es-ES" `#(optional)` \
  -- --new-tab about:welcome

Differential Revision: https://phabricator.services.mozilla.com/D138831
2022-03-02 15:52:43 +00:00
Iulian Moraru
5d89a24073 Backed out 2 changesets (bug 1755519) for causing node test failures (About:welcome bundle out of date). CLOSED TREE
Backed out changeset 67e6561012ad (bug 1755519)
Backed out changeset 873d83eaa24e (bug 1755519)
2022-03-02 17:08:47 +02:00
Greg Tatum
efdc727635 Bug 1755519 - Add language switching to about:welcome; r=pdahiya,platform-i18n-reviewers,flod,dminor
This patch ended up adding some complexity to about:welcome, as the
language switching needs to eagerly perform fallible asynchronous
actions. Specifically it needs to get the list of addons and
pre-emptively install the langpack, which can take time, and can fail.

This necessitated building a custom React components and custom hooks to
be able to deal with these requirements.

The following command will allow for the testing of this feature.

./mach run \
  --temp-profile \
  --setpref "extensions.getAddons.langpacks.url=https://mock-amo-language-tools.glitch.me/?app=firefox&type=language&appversion=%VERSION%" \
  --setpref "intl.multilingual.aboutWelcome.languageMismatchEnabled=true" \
  --setpref "intl.multilingual.aboutWelcome.systemLocaleOverride=es-ES" `#(optional)` \
  -- --new-tab about:welcome

Differential Revision: https://phabricator.services.mozilla.com/D138831
2022-03-02 13:54:17 +00:00
Dan Mosedale
8789761b28 Bug 1612986 - add newtab mocha code coverage info, r=andreio,marco
Differential Revision: https://phabricator.services.mozilla.com/D135525
2022-01-31 23:57:21 +00:00
Punam Dahiya
d5c83d4cec Bug 1728852 - Add monochromatic themes to about:welcome r=Mardak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D126346
2021-09-30 22:32:58 +00:00
Dão Gottwald
318c79a3b7 Bug 1707700 - Implement getting sponsored top sites from Contile server rather than remote settings. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D115346
2021-05-20 11:17:57 +00:00
Punam Dahiya
f04071e2db Bug 1700729 - Implement multistage proton onboarding screens r=emcminn,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D110360
2021-04-02 20:36:05 +00:00
Butkovits Atila
bd0d2f96b0 Backed out changeset 746e470d41f1 (bug 1700729) for causing failures at browser_parsable_css.js. CLOSED TREE 2021-04-02 22:58:13 +03:00
Punam Dahiya
6512bd0571 Bug 1700729 - Implement multistage proton onboarding screens r=emcminn,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D110360
2021-04-02 18:51:31 +00:00
Punam Dahiya
60c350f877 Bug 1696547 - Refactor MultiStageAboutWelcome to support Proton onboarding r=Mardak,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D107954
2021-03-25 20:28:39 +00:00
Ed Lee
44267a5d28 Bug 1686343 - Ask user to pin Firefox during windows about:welcome onboarding r=pdahiya
Support pin special action and add a new action property to wait for default browser that changes styles and content.

Differential Revision: https://phabricator.services.mozilla.com/D105653
2021-02-19 10:25:54 +00:00
prathiksha
602b372b75 Bug 1671937 - Create a fly-out customization menu component for the newtab page. r=ewright,thecount
Differential Revision: https://phabricator.services.mozilla.com/D95044
2020-11-18 17:31:07 +00:00
Mike Conley
4e0d6462d2 Bug 1673109 - Get rid of unused dismissById function on ASRouterUtils. r=andreio
Differential Revision: https://phabricator.services.mozilla.com/D95792
2020-11-06 20:45:52 +00:00
Dão Gottwald
e2bd67295e Bug 1675050 - "Sponsored Top Sites" checkbox shouldn't need a restart to show up after enabling the remote settings backend. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D95753
2020-11-05 01:25:42 +00:00
Dão Gottwald
953520da5b Bug 1672144 - Sponsored top sites: Make "Our sponsors & your privacy" a direct link to SUMO. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D94098
2020-10-22 16:37:43 +00:00
Bernard Igiri
1252c9d1fa Bug 1614465 - Replacing ASRouter calls to MessageChannel with JSWindowActors to eliminate ASRouterFeed r=k88hudson
Patch by Bernard Igiri <bigiri@mozilla.com>

Replacing async events with async method calls that use JSWindowActors to communicate with the parent process.
This will simplify these calls, bring the relevant code into local scope, and eliminate the need for MessageChannel.
Eliminating the MessageChannel dependency allows us to move the ASRouter initialization out of ASRouterFeed and into
JSWindowActors.

Differential Revision: https://phabricator.services.mozilla.com/D71796
2020-10-21 20:04:13 +00:00
Csoregi Natalia
21d03e3442 Bug 1671196 - Fixing newtab failure. r=fix 2020-10-15 17:26:10 +03:00
Dão Gottwald
3cf29066d8 Bug 1668496 - Support sponsored_position attribute. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D93224
2020-10-13 13:35:40 +00:00
Narcis Beleuzu
dd07a038a5 Backed out 2 changesets (bug 1668496, bug 1670916) for causing bc failures on browser_topsites_section.js CLOSED TREE
Backed out changeset 4c2c0252027c (bug 1670916)
Backed out changeset a45a9a67003b (bug 1668496)
2020-10-13 16:12:02 +03:00
Dão Gottwald
58bfd1ec66 Bug 1668496 - Support sponsored_position attribute. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D93224
2020-10-13 12:26:18 +00:00
Dan Mosedale
77ab836af3 Bug 1654122 - Support displaying theme selection state, r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D90946
2020-09-24 19:09:34 +00:00
Dão Gottwald
61bc43068c Bug 1664402 - Support migrating browser.topsites.useRemoteSetting true to false and back to true. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D89891
2020-09-11 10:52:31 +00:00
Dão Gottwald
fe92009ed1 Bug 1661008 - Implement pinning of search shortcut tiles from remote settings. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D89146
2020-09-03 15:39:35 +00:00
Dão Gottwald
1e8ea9b637 Bug 1660966 - Implement basic region filtering for remote top site defaults. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D88120
2020-08-25 09:27:18 +00:00
Dão Gottwald
d3f817633d Bug 1653937 - Read top site defaults from remote settings. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D88041
2020-08-24 20:57:53 +00:00
Dão Gottwald
410b2ccc8b Bug 1657083 - Make sendTopSiteAttributionRequest optional. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D87599
2020-08-20 14:46:11 +00:00
Dão Gottwald
5215adbc11 Bug 1653932 - Add pref for top site defaults from remote settings. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D84532
2020-07-24 16:41:04 +00:00
Dão Gottwald
18b03e8f51 Bug 1642606 - Support date tag in search top site override URL. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D78277
2020-06-05 10:46:21 +00:00
Dão Gottwald
5f226f06f3 Bug 1637218 - Allow for registering overridden search top site usage with an extra request. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D76831
2020-06-03 10:42:47 +00:00
Ed Lee
4846b1048e Bug 1635098 - Allow nullish coalescing and optional chaining operators in newtab jsm code r=k88hudson
Include babel plugins to allow unit testing of files using the operators.
Reverts "Bug 1635054 - stop using ?. operator in newtab download manager code, r=aryx"

Differential Revision: https://phabricator.services.mozilla.com/D73739
2020-05-28 00:56:13 +00:00
Dão Gottwald
119ea0371b Bug 1630983 - Allow the Amazon search tile to point to a URL from a pref instead r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D75929
2020-05-23 20:48:34 +00:00
Dan Mosedale
6a25d13434 Bug 1567924 - add newtab/messaging unit testing to taskcluster r=Mardak,ahal
Adds unit tests for the Home page code and Messaging System code in browser/component/newtab into treeherder/try automation.  Currently at Tier 2, should move to Tier 1 before long.

Differential Revision: https://phabricator.services.mozilla.com/D43562
2019-08-29 14:06:38 +00:00
Sylvestre Ledru
f4d7743944 Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D37217
2019-07-10 12:03:37 +00:00
Andreea Pavel
1ec8be7299 Backed out changeset 3d59cb02b6ff (bug 1562642) for eslint failure on a CLOSED TREE 2019-07-10 14:44:29 +03:00
Sylvestre Ledru
48a94b058e Bug 1562642 - Part 3 - Add missing MPL2 headers in browser & toolkit r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D37217
2019-07-10 11:15:25 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Ed Lee
6d9b8df61b Bug 1563243 - Add optimistic images, string robustness and bug fixes to New Tab Page r=pdahiya,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D36764
2019-07-03 23:49:07 +00:00
Ed Lee
9044198bff Bug 1559536 - Add disabled checkboxes, reenabled stories and bug fixes to Activity Stream r=r1cky
Differential Revision: https://phabricator.services.mozilla.com/D35109
2019-06-18 18:33:22 +00:00
Ed Lee
8121f28a06 Bug 1546190 - Add sharper images, collapsible devtools and bug fixes to Activity Stream r=r1cky
Differential Revision: https://phabricator.services.mozilla.com/D28398
2019-04-22 20:43:46 +00:00
Ed Lee
de42813e79 Bug 1543756 - Add Discovery preferences, optimized images and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D27139
2019-04-11 21:20:17 +00:00
Ed Lee
c6b22007bf Bug 1541502 - Add Pocket menu, triggering improvements and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D25984
2019-04-04 14:32:55 +00:00
Ed Lee
bdcdeb3c15 Bug 1525452 - Add Message component, visibility capping and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D18841
2019-02-06 15:58:38 +00:00
Ed Lee
91bff3911a Bug 1502461 - Fix recommendation counts, recommendation alignment and bug fixes to Activity Stream r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D9949
2018-10-27 01:31:08 +00:00
k88hudson
3064862662 Bug 1496457 - Add Newsletter template, addon install telemetry, remove legacy onboarding code, and bug fixes to Activity Stream r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D7916
2018-10-05 19:16:25 +00:00
Ursula Sarracini
d8f0c8f7df Bug 1489962 - Add snippets targeting, Pocket tagging and bug fixes to Activity Stream r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D5914
2018-09-20 18:36:20 +00:00