Commit Graph

154 Commits

Author SHA1 Message Date
Shane Hughes
db26095c40 Bug 1795288 - Feature Callouts: add dismiss telemetry. r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D163531
2022-12-01 16:42:18 +00:00
Shane Hughes
8ceb90e910 Bug 1800087 - Fix ASRouter references to RS collections. r=barret
ASRouter's remote message providers were written to include a property
to specify the desired collection on the Remote Settings Kinto server.
But this property was mistakenly labeled `bucket` in many places. This
could be confusing because Kinto storage is organized by both buckets
and collections, with buckets being a higher level of organization and
collections belonging to buckets. Each individual message provider
specifies a collection like "cfr", while the bucket is set by the router
code ("main"). This carried over to everything that interacted with the
providers, so this patch effectively replaces every reference to a
"message provider bucket" with "message provider collection." But more
importantly, provider definitions are stored as JSON strings in
preference values, so these definitions erroneously contained key-value
pairs like `bucket: "cfr"` which should have been `collection: "cfr"`.
That means the pref values themselves must be migrated to ensure that
modified prefs continue to work. Existing tests are updated and a new
test is added for the migrator, to meet minimum coverage requirements.
Documentation is also updated to reflect the correct property name.

Differential Revision: https://phabricator.services.mozilla.com/D162067
2022-11-17 18:32:13 +00:00
Shane Hughes
7a6dea3750 Bug 1787532 - Let Feature Callouts perform actions on page events. r=mviar
Add a new module and feature callout functions to support messages
performing actions when a specified event is dispatched from the
content. This will allow Feature Callout messages to be dismissed when a
button is clicked within the page in which they are rendered. A screen
just needs to provide a `page_event_listeners` property, which is an
array of objects, each containing event listener parameters (event type,
target selector, and optional parameters) and an action specification
like those already used for buttons. The event listener will be added to
all elements matching the selector, so multiple different buttons could
dismiss or advance the message, if necessary. The new screen property
has this form:
```
page_event_listeners: [
  {
    params: {
      type: string,
      selectors: string,
      options?: {
        capture?: boolean,
        once?: boolean,
        preventDefault?: boolean,
      },
    },
    action: {
      type?: string,
      data?: object,
      dismiss?: boolean,
      etc...
    },
  },
]
```

Differential Revision: https://phabricator.services.mozilla.com/D158899
2022-10-18 14:29:27 +00:00
Mark Banner
43be0848c3 Bug 1792341 - Migrate most of the rest of toolkit/modules/ to be system ES modules. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D158451
2022-10-18 11:21:25 +00:00
Sylvestre Ledru
88a9e6ab35 Bug 1789204 - Import "avoiding intermittent oranges" from mdn r=marco DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D156408
2022-09-05 12:49:51 +00:00
Sylvestre Ledru
c1f90a79c6 Bug 1785928 - doc: fix some 404 in v2-system-addon/mochitests.html DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D156297
2022-09-03 16:42:22 +00:00
Sylvestre Ledru
c57add537c Bug 1785451 - Ride along: Fix some typos r=linter-reviewers,fluent-reviewers,geckoview-reviewers,extension-reviewers,keeler,rpl,calu,ahal,flod DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D154946
2022-08-18 07:29:08 +00:00
scott
87bfee2269 Bug 1779636 - Pocket newtab login state to events pings r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D152121
2022-07-29 20:46:40 +00:00
Nick Alexander
6e9303448d Bug 1775128 - Add toast_notification message template for displaying (native) toast notifications. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D150073
2022-07-20 02:58:42 +00:00
scott
acb6544ac6 Bug 1778351 - Removing some old Pocket newtab experiment code. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D151666
2022-07-19 17:32:56 +00:00
scott
75329af4b9 Bug 1777539 - Pocket newtab remove load more button and last card features r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D150789
2022-07-05 19:57:22 +00:00
Chris H-C
69a594ce29 Bug 1766887 - Introduce a minimal "newtab" ping for holistic data collection r=nanj,Dexter
It doesn't actually collect anything new, but by collecting it all in one place
we should make analysis easier.

Can be shut off by setting `browser.newtabpage.ping.enabled` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D146224
2022-06-17 20:21:49 +00:00
Cristian Tuns
b967cfd2bb Backed out 8 changesets (bug 1766887) for causing mochitest failures on browser_newtab_ping.js CLOSED TREE
Backed out changeset a6b01c1e8823 (bug 1766887)
Backed out changeset 1ef2dd2b779e (bug 1766887)
Backed out changeset f248baea014a (bug 1766887)
Backed out changeset 3f3066906403 (bug 1766887)
Backed out changeset 3ad63b0fa7b8 (bug 1766887)
Backed out changeset 06a0a6ef295a (bug 1766887)
Backed out changeset abe659b175cb (bug 1766887)
Backed out changeset f90e9e70f6d4 (bug 1766887)
2022-06-17 10:49:00 -04:00
Chris H-C
3e21f3e2ba Bug 1766887 - Introduce a minimal "newtab" ping for holistic data collection r=nanj,Dexter
It doesn't actually collect anything new, but by collecting it all in one place
we should make analysis easier.

Can be shut off by setting `browser.newtabpage.ping.enabled` to `false`.

Differential Revision: https://phabricator.services.mozilla.com/D146224
2022-06-17 13:47:04 +00:00
Scott
3e691f1733 Bug 1771546 - Pocket newtab colletion/topics card. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D147548
2022-06-10 23:44:31 +00:00
Dana Keeler
88d8e888f0 Bug 1769669 - require specifying the trusted root in content signature verifier r=jschanck,leplatrem,robwu,barret
Before this patch, the content signature verifier
(nsIContentSignatureVerifier/ContentSignatureVerifier) would identify the root
it trusted based on the value of a preference. This patch changes the
implementation to require a specified hard-coded root to trust as with add-on
signature verification.

Depends on D146644

Differential Revision: https://phabricator.services.mozilla.com/D146645
2022-06-03 23:26:28 +00:00
Mathieu Leplatre
57f5978d20 Bug 1702759 - Remove load_dump preference r=robwu
This is a breaking change. It is not possible to control the loading of dumps from a preference anymore.

Dumps are only loaded if server is pointed at PROD. The recommended way to prevent dumps loading in tests is to store a high timestamp in the local DB.

Differential Revision: https://phabricator.services.mozilla.com/D146049
2022-05-23 16:24:58 +00:00
Mathieu Leplatre
d4a89f2c4b Bug 1702759 - Remove bucket name preference r=robwu
This introduces a breaking change: the buckets cannot be changed via preferences anymore.

Before landing this patch, we should have a released a new version of the Remote Settings DevTools that is compatible with this new API.

Differential Revision: https://phabricator.services.mozilla.com/D145455
2022-05-23 16:24:57 +00:00
Scott
81040cee89 Bug 1767448 - Pocket newtab available screen height and width for card pings. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D145334
2022-05-10 21:03:36 +00:00
Mathieu Leplatre
aeb4fe2833 Bug 1738284 - Update CFR docs to use the Remote Settings DEV server r=nanj DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D130186
2021-11-02 16:54:52 +00:00
Andrei Oprea
28d88d09f4 Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 19:45:17 +00:00
Alexandru Michis
7b49cf4e2e Backed out changeset 5d92bd37605f (bug 1732724) for causing xpcshell failures in test_targeting.js
CLOSED TREE
2021-10-07 21:16:39 +03:00
Andrei Oprea
67bd2df2f9 Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 17:10:27 +00:00
Butkovits Atila
ca081ef18a Backed out changeset bbea0c20d7fe (bug 1732724) for causing Xpcshell failures at test_targeting.js. CLOSED TREE 2021-10-07 19:29:34 +03:00
Andrei Oprea
44e77f3182 Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 15:31:29 +00:00
Butkovits Atila
ab55bbe571 Backed out changeset 35d10fc51b62 (bug 1732724) for causing failures at test_targeting.js. CLOSED TREE 2021-10-07 17:17:15 +03:00
Andrei Oprea
3b9f764fb8 Bug 1732724 - Report targeting expression source in the case of undesired events r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D126776
2021-10-07 12:42:10 +00:00
Scott
d88d5f1009 Bug 1729946 - Adding Pocket newtab load more button. r=fluent-reviewers,gvn,flod
Differential Revision: https://phabricator.services.mozilla.com/D125631
2021-09-23 02:48:38 +00:00
Andrei Oprea
3cbae7f729 Bug 1728420 - New messaging surface Spotlight r=Mardak,dmose,nanj
Differential Revision: https://phabricator.services.mozilla.com/D121913
2021-09-03 13:41:21 +00:00
Scott
fc59d368e2 Bug 1691518 - Remove v1 personalization from newtab r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D120368
2021-07-28 22:42:32 +00:00
Nika Layzell
938c67f546 Bug 1706302 - Part 3: Remove AWTerminate.UNKNOWN, r=pdahiya
Previously the WebProgressListener in AboutWelcomeChild was detecting
OnLocationChange notifications for loading about:welcome rather than
notifications for navigating away from it, meaning that
AWTerminate.UNKNOWN was almost immediately replaced as soon as the
document was loaded, rather than only when navigating away. The
DOMDocElementInserted event fires slightly later than DOMWindowCreated
so the actor no longer sees the OnLocationChange notification for the
current document, causing tests to fail.

As this telemetry is no longer actively monitored, this patch removes
AWTerminate.UNKNOWN to preserve the existing behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D118620
2021-07-09 16:30:28 +00:00
surajeet310
04570a3770 Bug 1714788 - Fixed more Sphinx warnings in 'mach doc' ,r=sylvestre,webdriver-reviewers DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D116939
2021-06-07 19:28:40 +00:00
Scott
06420df2a4 Bug 1697597 - Adding a Pocket button home view r=gvn,flod
Differential Revision: https://phabricator.services.mozilla.com/D111185
2021-04-15 00:29:04 +00:00
Gavin Lazar Suntop
ecb0564329 Bug 1699202 - Add probes for Learn More and View List r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D108997
2021-03-26 17:06:52 +00:00
Nan Jiang
dc87844103 Bug 1688698 - Add telemetry for sponsored TopSites r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D104846
2021-02-22 20:03:18 +00:00
Nan Jiang
f9c899e733 Bug 1689496 - Add showSponsoredTopSites to user_prefs r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D103403
2021-01-29 18:47:01 +00:00
Andrei Oprea
70fb96e27c Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D101936
2021-02-01 22:01:52 +00:00
Butkovits Atila
dd685ab77d Backed out changeset 9464e66648e3 (bug 1685525) for node failures. CLOSED TREE 2021-02-01 23:24:42 +02:00
Andrei Oprea
ecf44dcdb5 Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D101936
2021-02-01 19:36:47 +00:00
Butkovits Atila
a14ac2049d Backed out changeset 57c61d78ae53 (bug 1685525) for causing failures on browser_asrouter_trigger_docs.js. 2021-02-01 20:24:40 +02:00
Andrei Oprea
d4bb44e5df Bug 1685525 - Update or add a trigger capable of targeting newtab/homepage for messages r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D101936
2021-02-01 16:14:45 +00:00
prathiksha
39e4edce67 Bug 1676627 - Add telemetry to track opening and closing of the fly out component on newtab page. r=thecount,nanj
Differential Revision: https://phabricator.services.mozilla.com/D102765
2021-01-25 16:26:03 +00:00
Erica Wright
187b9b3f7f Bug 1687048 - Add AS Telemetry for Top Sites and Snippets. r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D102230
2021-01-22 19:13:54 +00:00
Andrei Oprea
b97ab558bb Bug 1687297 - Failures to access IndexedDB are not being reported r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D102221
2021-01-20 17:59:35 +00:00
Butkovits Atila
c45d8d5f05 Backed out changeset 57bc299185c6 (bug 1687297) for causing node test failure. CLOSED TREE 2021-01-20 18:10:12 +02:00
Andrei Oprea
1eea9f5494 Bug 1687297 - Failures to access IndexedDB are not being reported r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D102221
2021-01-20 09:42:27 +00:00
Nan Jiang
f3bb123b10 Bug 1682372 - Remove unused fields in the impression stats ping r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D100712
2021-01-05 19:25:19 +00:00
Scott
65b2e9670f Bug 1681387 - Add Pocket and Spocs config telemetry to new config buttons r=nanj,ewright
Differential Revision: https://phabricator.services.mozilla.com/D99831
2020-12-22 04:14:42 +00:00
Nan Jiang
573d335ad4 Bug 1682379 - Remove SPOCS Fill event in Activity Stream r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D99805
2020-12-17 18:15:25 +00:00
Nan Jiang
ccf0b13265 Bug 1680805 - Remove all performance pings in Activity Stream r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D98808
2020-12-09 01:34:53 +00:00