Commit Graph

471 Commits

Author SHA1 Message Date
scott
81b2abcdfd Bug 1803410 - Pocket newtab topsites, fixing replaced pinned edge cases. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D163510
2022-12-01 17:38:57 +00:00
scott
34d6c900b7 Bug 1803206 - Pocket newtab sponsored topsite fixing image resize. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D163363
2022-11-30 03:57:12 +00:00
scott
e6e0377789 Bug 1803107 - Pocket newtab topsites fixing pinning issue with sponsored Pocket tile. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D163339
2022-11-29 19:10:47 +00:00
scott
e7f4d6f040 Bug 1802265 - Pocket newtab topsite spoc use title instead of sponsor. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D162947
2022-11-24 20:03:53 +00:00
Shane Hughes
8ceb90e910 Bug 1800087 - Fix ASRouter references to RS collections. r=barret
ASRouter's remote message providers were written to include a property
to specify the desired collection on the Remote Settings Kinto server.
But this property was mistakenly labeled `bucket` in many places. This
could be confusing because Kinto storage is organized by both buckets
and collections, with buckets being a higher level of organization and
collections belonging to buckets. Each individual message provider
specifies a collection like "cfr", while the bucket is set by the router
code ("main"). This carried over to everything that interacted with the
providers, so this patch effectively replaces every reference to a
"message provider bucket" with "message provider collection." But more
importantly, provider definitions are stored as JSON strings in
preference values, so these definitions erroneously contained key-value
pairs like `bucket: "cfr"` which should have been `collection: "cfr"`.
That means the pref values themselves must be migrated to ensure that
modified prefs continue to work. Existing tests are updated and a new
test is added for the migrator, to meet minimum coverage requirements.
Documentation is also updated to reflect the correct property name.

Differential Revision: https://phabricator.services.mozilla.com/D162067
2022-11-17 18:32:13 +00:00
Mark Banner
9ecec1531f Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D161942
2022-11-13 21:02:41 +00:00
scott
4f01a04373 Bug 1799649 - Pocket newtab sponsored topsite drag position change fix. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D161625
2022-11-08 21:24:47 +00:00
scott
b71ec3f1b5 Bug 1799481 - Pocket newtab sponsored topsites pin removed from context menu r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D161496
2022-11-07 18:57:51 +00:00
scott
6b25631050 Bug 1797612 - Newtab prevent sponsored topsites from being dragged r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D161000
2022-11-02 22:12:02 +00:00
Nan Jiang
aa7e4ae5e7 Bug 1794022 - Add telemetry for top sites SPOCS r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D160939
2022-11-01 21:02:26 +00:00
scott
258a894504 Bug 1794020 - topsite promo tiles
Differential Revision: https://phabricator.services.mozilla.com/D160851
2022-10-31 22:05:25 +00:00
Punam Dahiya
3187d5e5cb Bug 1753746 - PBM messaging devtool integration r=pdahiya,mconley
Differential Revision: https://phabricator.services.mozilla.com/D145808
2022-10-31 15:21:56 +00:00
Marian-Vasile Laza
fe65732048 Backed out changeset f394d8fa64f3 (bug 1794020) for causing marionette & telemetry failures. CLOSED TREE 2022-10-29 12:17:19 +03:00
scott
3adac7d415 Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-29 08:42:00 +00:00
Sandor Molnar
17a6bd06dc Backed out changeset 19fcc2a044a8 (bug 1794020) for causing mochitest failures in lib/DiscoveryStreamFeed.jsm CLOSED TREE 2022-10-28 21:37:39 +03:00
scott
dced0ed94d Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-28 16:03:49 +00:00
Noemi Erli
111f253947 Backed out changeset 12a565036b3c (bug 1794020) for causing DiscoveryStreamFeed.jsm related failures CLOSED TREE 2022-10-28 01:41:55 +03:00
scott
03cc186a29 Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-27 21:54:00 +00:00
Marian-Vasile Laza
bafe5f1f3b Backed out changeset ad5bb5f4a576 (bug 1794020) for causing bc failures on browser_policy_firefoxhome.js. CLOSED TREE 2022-10-26 22:37:25 +03:00
scott
e9cf819459 Bug 1794020 - topsite promo tiles r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D144438
2022-10-26 18:12:26 +00:00
Chris H-C
4f0806c847 Bug 1795136 - Correct sponsoredness detection for top story impressions, clicks r=nanj,thecount
I forgot to transmit the information from the content.

Differential Revision: https://phabricator.services.mozilla.com/D159406
2022-10-14 18:45:45 +00:00
Gavin Suntop
f8b59c716a Bug 1790667 - Design tweaks for STP button r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D157505
2022-10-07 17:04:27 +00:00
scott
26d7902675 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158531
2022-10-05 20:20:02 +00:00
Csoregi Natalia
ca10cb1d71 Backed out changeset 39dd7976006b (bug 1793487) for causing newtab failures. CLOSED TREE 2022-10-05 21:07:56 +03:00
scott
c0bd2e12f8 Bug 1793487 - Pocket newtab fixing placeholder images for recent saves r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D158531
2022-10-05 17:23:23 +00:00
Norisz Fay
ad1ab8d622 Backed out changeset b65e99ab62ad (bug 1790667) for causing node newtab failure CLOSED TREE 2022-10-04 21:34:07 +03:00
Gavin Suntop
d1027148f6 Bug 1790667 - Design tweaks for STP button r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D157505
2022-10-04 18:00:17 +00:00
scott
554aaaaf6b Bug 1791614 - Pocket newtab adding reader mode links to recent saves. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D157749
2022-09-20 20:08:51 +00:00
scott
ca1c4058a5 Bug 1790856 - Fixing Pocket recent saves id for telemetry. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D157353
2022-09-14 21:35:25 +00:00
Gavin Suntop
a456fc19a1 Bug 1787521 - Adjust button for newtab save to pocket action r=thecount,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D155995
2022-09-09 17:13:26 +00:00
Chris H-C
03ec4b9f67 Bug 1786612 - Instrument Pocket interactions with events r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D155756
2022-09-07 17:28:36 +00:00
scott
0bca9c36bf Bug 1787522 - Pocket newtab limit save to Pocket card hover button to specific regions. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D155771
2022-08-31 21:45:18 +00:00
scott
9064163ddd Bug 1782318 - Pocket newtab show placeholder thumbnail images for cards without images. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D155126
2022-08-24 15:40:12 +00:00
Daisuke Akatsuka
8eb71d3877 Bug 1785165: Make new window by context menu of tile be target to inheritance of sponsored session. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D154845
2022-08-19 21:14:49 +00:00
Iulian Moraru
90850c2e64 Backed out changeset 01420503a289 (bug 1785165) for causing node - newtab failures. CLOSED TREE 2022-08-19 12:06:58 +03:00
Daisuke Akatsuka
fce0456ffd Bug 1785165: Make new window by context menu of tile be target to inheritance of sponsored session. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D154845
2022-08-19 08:23:33 +00:00
Daisuke Akatsuka
3fcf717749 Bug 1784369: Make opening in new window target for inheritance of sponsored sessions. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D154483
2022-08-16 00:41:01 +00:00
Norisz Fay
e7039bb6db Backed out 3 changesets (bug 1784369, bug 1784242) for causing node newtab failures CLOSED TREE
Backed out changeset f19a8a76a85b (bug 1784242)
Backed out changeset 0722fc4bb4fa (bug 1784242)
Backed out changeset 2d4131b0ca28 (bug 1784369)
2022-08-16 03:19:32 +03:00
Daisuke Akatsuka
a42205a33c Bug 1784369: Make opening in new window target for inheritance of sponsored sessions. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D154483
2022-08-15 23:45:32 +00:00
scott
854c0a9536 Bug 1782319 - Pocket newtab fix issue if recent saves is paired with save to Pocket card r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D153292
2022-08-04 21:35:39 +00:00
Gavin Suntop
c0d548aa47 Bug 1780849 - refactoring pref drawer animation r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D152793
2022-08-03 17:18:12 +00:00
scott
87bfee2269 Bug 1779636 - Pocket newtab login state to events pings r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D152121
2022-07-29 20:46:40 +00:00
scott
9528bf357e Bug 1774471 - Pocket newtab refactor dscard props r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D152599
2022-07-26 22:51:57 +00:00
Butkovits Atila
8d5010e96e Backed out changeset a12870608bdf (bug 1780849) for causing failures at browser_contentSearchUI_default.js. CLOSED TREE 2022-07-26 23:10:06 +03:00
Gavin Suntop
1d5b1fa522 Bug 1780849 - refactoring pref drawer animation r=thecount
Differential Revision: https://phabricator.services.mozilla.com/D152793
2022-07-26 19:15:24 +00:00
Tooru Fujisawa
15758870e7 Bug 1780543 - Part 4: Add mozilla/remote-page environment. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D152429
2022-07-26 02:46:30 +00:00
scott
902f2f21c4 Bug 1780832 - Pocket newtab fixing collection and recent saves grid conflict. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D152540
2022-07-22 23:56:53 +00:00
scott
0bbeca25d3 Bug 1779643 - Pocket newtab remove old border and hero css and options r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D151872
2022-07-22 04:31:45 +00:00
Nick Alexander
6e9303448d Bug 1775128 - Add toast_notification message template for displaying (native) toast notifications. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D150073
2022-07-20 02:58:42 +00:00
scott
acb6544ac6 Bug 1778351 - Removing some old Pocket newtab experiment code. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D151666
2022-07-19 17:32:56 +00:00