Commit Graph

2663 Commits

Author SHA1 Message Date
Shane Hughes
83343af82b Bug 1794702 - Add a wipe transition for MR onboarding progress bar. r=yozhang
Differential Revision: https://phabricator.services.mozilla.com/D159821
2022-12-02 07:03:56 +00:00
Cristian Tuns
b34c0a9879 Backed out changeset 71a0bfc10512 (bug 1803367) for causing xpcshell failures in test_PanelTestProvider.js CLOSED TREE 2022-12-01 23:40:36 -05:00
scott
2aba9c12cd Bug 1799974 - Pocket newtab fixing loading of page to have less shifting. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D163621
2022-12-02 00:40:05 +00:00
hanna alemu
9cb780b2e9 Bug 1803367 - [Cleanup] Remove test messages and Strings used for the TCP rollout r=aminomancer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D163520
2022-12-02 00:25:16 +00:00
Shane Hughes
abf1e16f6c Bug 1801301 - Fix idle message trigger firing after wake. r=barret
Add a 1s grace period after waking from sleep in which notifications
from the idle service will be ignored. Break out the idle trigger tests
because we've reached the max statements per function limit.

Differential Revision: https://phabricator.services.mozilla.com/D163303
2022-12-01 23:29:55 +00:00
Greg Tatum
5f08f17bf3 Bug 1685180 - Ensure more programmatic fluent args have values; r=nordzilla
Depends on D162597

Differential Revision: https://phabricator.services.mozilla.com/D163626
2022-12-01 21:40:57 +00:00
Cristian Tuns
e4f818ecc2 Backed out changeset 732eca22ad6f (bug 1799974) for causing node failures CLOSED TREE 2022-12-01 14:59:56 -05:00
scott
f0ca205e0d Bug 1799974 - Pocket newtab fixing loading of page to have less shifting. r=gvn
Differential Revision: https://phabricator.services.mozilla.com/D163621
2022-12-01 19:28:48 +00:00
scott
81b2abcdfd Bug 1803410 - Pocket newtab topsites, fixing replaced pinned edge cases. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D163510
2022-12-01 17:38:57 +00:00
Shane Hughes
db26095c40 Bug 1795288 - Feature Callouts: add dismiss telemetry. r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D163531
2022-12-01 16:42:18 +00:00
Shane Hughes
7f3ae4ffc8 Bug 1799997 - Support media autoplay on about:welcome. r=pdahiya,pbz
Add the autoplay permission to about:welcome through the default
permissions file. If we add onboarding videos to other messaging
surfaces (like the multistage spotlight for existing user onboarding),
it won't be necessary to add permissions since autoplay is only blocked
in content. This also incidentally reduces the severity of bug 1799935.
The error still happens, breaking the video controls. But since the
video autoplays, the bug is only noticeable if you try to interact with
the video controls. Otherwise, the video will just play on its own and
advance to the next screen when it's finished.

Differential Revision: https://phabricator.services.mozilla.com/D162162
2022-11-30 04:18:24 +00:00
scott
34d6c900b7 Bug 1803206 - Pocket newtab sponsored topsite fixing image resize. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D163363
2022-11-30 03:57:12 +00:00
Meg Viar
18abc909b1 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D160503
2022-11-30 01:47:23 +00:00
Mark Banner
e4276619d3 Bug 1801092 - Add an ESLint rule to disllow use of Cu.reportError with a single argument. r=Gijs,cmkm
This enforces the bulk of the cases for Cu.reportError. A follow-up will extend this to the
two argument form.

Differential Revision: https://phabricator.services.mozilla.com/D162285
2022-11-29 23:07:42 +00:00
Iulian Moraru
e4cb785520 Backed out 3 changesets (bug 1801092) for causing newtab failures.
Backed out changeset 9153de956154
Backed out changeset 9df9c279c28d (bug 1801092)
Backed out changeset 7323c7444941 (bug 1801092)
2022-11-30 00:28:42 +02:00
Otto Länd
dbb211d8a1 No bug: apply code formatting via Lando
# ignore-this-changeset
2022-11-29 21:46:36 +00:00
Mark Banner
2f30acd85c Bug 1801092 - Add an ESLint rule to disllow use of Cu.reportError with a single argument. r=Gijs,cmkm
This enforces the bulk of the cases for Cu.reportError. A follow-up will extend this to the
two argument form.

Differential Revision: https://phabricator.services.mozilla.com/D162285
2022-11-29 21:21:28 +00:00
scott
e6e0377789 Bug 1803107 - Pocket newtab topsites fixing pinning issue with sponsored Pocket tile. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D163339
2022-11-29 19:10:47 +00:00
Meg Viar
5d6cd66915 Bug 1802918 - Update Firefox View Feature Callout tests to work after Colorways expire r=aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D163241
2022-11-29 15:43:49 +00:00
Meg Viar
efda7b4253 Bug 1802194 - Update title and body text of Firefox View onboarding CFR message r=hanna_a,flod
Differential Revision: https://phabricator.services.mozilla.com/D162887
2022-11-28 14:20:18 +00:00
Sandor Molnar
61f05197c3 Backed out changeset 28484915dc1b (bug 1795894) for causing mochitest failures. CLOSED TREE 2022-11-28 04:33:07 +02:00
Meg Viar
3633b07781 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D160503
2022-11-28 00:54:14 +00:00
Barret Rennie
d1a2566d45 Bug 1541508 - Use Services.env in browser/ r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D160136
2022-11-25 19:09:06 +00:00
Shane Hughes
f15f8a12bf Bug 1802333 - Idle trigger debug logging. r=barret
To debug the idle trigger's interaction with OS sleep state, it's
helpful to know whether sleep/wake notifications were sent. This allows
most of the idle trigger activity to be logged to the console, if the
pref `messaging-system.log` is set to `debug`. The new logging will also
be used to debug the behavior reported in bug 1801301.

Differential Revision: https://phabricator.services.mozilla.com/D163010
2022-11-25 10:42:25 +00:00
Csoregi Natalia
ad9adef7d6 Backed out changeset e1393a35e060 (bug 1802333) for newtab failure. CLOSED TREE 2022-11-25 06:45:19 +02:00
Shane Hughes
01dfa38321 Bug 1802333 - Idle trigger debug logging. r=barret
To debug the idle trigger's interaction with OS sleep state, it's
helpful to know whether sleep/wake notifications were sent. This allows
most of the idle trigger activity to be logged to the console, if the
pref `messaging-system.log` is set to `debug`. The new logging will also
be used to debug the behavior reported in bug 1801301.

Differential Revision: https://phabricator.services.mozilla.com/D163010
2022-11-25 03:52:03 +00:00
scott
e7f4d6f040 Bug 1802265 - Pocket newtab topsite spoc use title instead of sponsor. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D162947
2022-11-24 20:03:53 +00:00
Chris H-C
a741773afc Bug 1802207 - Wait to send component_init-reason "newtab" ping until newtab has been categorized r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D162906
2022-11-24 17:59:21 +00:00
Cristian Tuns
77cb29f0f8 Backed out changeset 4a504fa8d156 (bug 1802207) for causing bc failures CLOSED TREE 2022-11-24 10:46:53 -05:00
Chris H-C
7ff970f21b Bug 1802207 - Wait to send component_init-reason "newtab" ping until newtab has been categorized r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D162906
2022-11-24 15:22:49 +00:00
Cristian Tuns
d8e86b5e68 Backed out changeset 9c4f4de3d68c (bug 1802207) for causing lint failures on TelemetryFeed.test.js CLOSED TREE 2022-11-24 10:14:59 -05:00
Chris H-C
b88e45d4e4 Bug 1802207 - Wait to send component_init-reason "newtab" ping until newtab has been categorized r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D162906
2022-11-24 14:52:30 +00:00
negin
1779c1057f Bug 1800126 - [Cleanup] Refactor OnboardingVideo in its own component r=yozhang
[try](https://treeherder.mozilla.org/jobs?repo=try&revision=50e8d3a693d5a8cf6a6f3bf601c9cd241f5145e6)

Differential Revision: https://phabricator.services.mozilla.com/D162420
2022-11-23 17:50:13 +00:00
Punam Dahiya
ce3fbde864 Bug 1801762 - Add checkbox interaction telemetry for easy setup experiment r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D162677
2022-11-22 20:52:51 +00:00
Csoregi Natalia
dcbfe3fab0 Backed out changeset 6b0244ce90fb (bug 1800126) for causing newtab failures. CLOSED TREE 2022-11-22 18:09:09 +02:00
negin
9eab44a4b6 Bug 1800126 - [Cleanup] Refactor OnboardingVideo in its own component r=yozhang
Differential Revision: https://phabricator.services.mozilla.com/D162420
2022-11-22 15:25:41 +00:00
scott
35e4f02b0f Bug 1798956 - Pocket newtab ensure we clear spocs in cases where sponsored topsites applies to Pocket data. r=nanj
Differential Revision: https://phabricator.services.mozilla.com/D162028
2022-11-21 20:24:29 +00:00
Mark Banner
11b4005c4f Bug 1791974 - Use setAsDefault* parameters where appropriate for consumers of SearchTestUtils.installSearchExtension. r=mcheang
Differential Revision: https://phabricator.services.mozilla.com/D161045
2022-11-18 14:30:27 +00:00
Dão Gottwald
cfc7cc8b18 Bug 1801037 - Remove "New colorways are on the way" message from Firefox View. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D162264
2022-11-18 06:25:41 +00:00
Shane Hughes
8ceb90e910 Bug 1800087 - Fix ASRouter references to RS collections. r=barret
ASRouter's remote message providers were written to include a property
to specify the desired collection on the Remote Settings Kinto server.
But this property was mistakenly labeled `bucket` in many places. This
could be confusing because Kinto storage is organized by both buckets
and collections, with buckets being a higher level of organization and
collections belonging to buckets. Each individual message provider
specifies a collection like "cfr", while the bucket is set by the router
code ("main"). This carried over to everything that interacted with the
providers, so this patch effectively replaces every reference to a
"message provider bucket" with "message provider collection." But more
importantly, provider definitions are stored as JSON strings in
preference values, so these definitions erroneously contained key-value
pairs like `bucket: "cfr"` which should have been `collection: "cfr"`.
That means the pref values themselves must be migrated to ensure that
modified prefs continue to work. Existing tests are updated and a new
test is added for the migrator, to meet minimum coverage requirements.
Documentation is also updated to reflect the correct property name.

Differential Revision: https://phabricator.services.mozilla.com/D162067
2022-11-17 18:32:13 +00:00
Emily McMinn
e8b3e6267b Bug 1781091 - Update RTAMO to match MR1 designs r=mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D161482
2022-11-17 17:13:35 +00:00
Mark Banner
5d1820b074 Bug 1799314 - Convert consumers of testing modules to import ES modules direct (browser/). r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D161914
2022-11-17 12:00:30 +00:00
negin
f321eec644 Bug 1800655 - The “send yourself a download link” from the “Mobile” screen of the new and existing users’ Onboarding does not redirect to any page r=aminomancer
Because of the `::before` element which requires a z-index of 1 to render the box-shadow, it was causing links to be unclickable/behind the element. By adding `pointer-events: none` to the pseudo element, it is possible to click through the elements again/interact with the `<a>` tag

Differential Revision: https://phabricator.services.mozilla.com/D162226
2022-11-16 20:16:48 +00:00
negin
0d72b18f0c Bug 1797851 - Add telemetry to video section in onboarding r=pdahiya,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D161704
2022-11-16 17:10:34 +00:00
yoenzhang
e97af2d130 Bug 1797843 - Add support to play streaming video inside new user onboarding r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D161233
2022-11-15 04:46:36 +00:00
Mark Banner
9ecec1531f Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D161942
2022-11-13 21:02:41 +00:00
Cristian Tuns
3b81ff80a1 Backed out changeset 3b4e0751850a (bug 1797843) for causing mochitest failures nsContentSecurityUtils.cpp CLOSED TREE 2022-11-12 00:57:11 -05:00
yoenzhang
cd279e0fc6 Bug 1797843 - Add support to play streaming video inside new user onboarding r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D161233
2022-11-12 05:24:59 +00:00
Meg Viar
5cb39b67f2 Bug 1800156 - Prevent continuous onboarding messages from appearing after Spotlight is dismissed in Firefox view after 4+ views r=aminomancer
Add the highest possible frequency cap to the Firefox View Spotlight message so that it creates ASRouter impressions while still being able to sync across windows/tabs with Firefox View open.

Differential Revision: https://phabricator.services.mozilla.com/D161853
2022-11-11 00:00:00 +00:00
Punam Dahiya
eac66c92d8 Bug 1798336 - Add multiselect section to onboarding template r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D161230
2022-11-10 21:59:44 +00:00