Commit Graph

56 Commits

Author SHA1 Message Date
Dão Gottwald
cfc7cc8b18 Bug 1801037 - Remove "New colorways are on the way" message from Firefox View. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D162264
2022-11-18 06:25:41 +00:00
Tim Giles
e65dbcf363 Bug 1800689 - Remove colorways null state. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D162154
2022-11-17 17:05:27 +00:00
Norisz Fay
4966c7af4a Backed out changeset 3811dbb4b859 (bug 1800689) for causing bc failures on browser_colorways_card.js CLOSED TREE 2022-11-16 19:53:33 +02:00
Tim Giles
29d474c25c Bug 1800689 - Remove colorways null state. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D162154
2022-11-16 17:12:28 +00:00
Kelly Cochrane
3500b25829 Bug 1788152 - Update presentation of Recently Closed and Tab Pickup empty states r=flod,fluent-reviewers,desktop-theme-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D160545
2022-11-07 14:07:52 +00:00
Bernard Igiri
88c38f79b6 Bug 1796004 - Updated disclosure arrow direction and positioning in Fx View r=sclements
Updated disclosure arrow direction and positioning in Fx View, to match Figma, for both LTR an RTL presentations.

Differential Revision: https://phabricator.services.mozilla.com/D160134
2022-11-01 15:24:13 +00:00
Hanna Jones
bc09027cd8 Bug 1791474 - show more specific message for locked primary password error r=sfoster,fluent-reviewers
* Updated the error message to use the text [here](https://www.figma.com/file/SE4xHgOW84yLiv7vFugm9R/Firefox-View-Stepping-Stone)
* Updated the existing password test to verify the message contents

Differential Revision: https://phabricator.services.mozilla.com/D159787
2022-10-24 18:29:53 +00:00
Bernard Igiri
bec652a910 Bug 1780239 - Fix screen reader order of Colorway Landmark in FxView r=Gijs
Added dynamic DOM reordering to FX View so that the order of announcement in screen readers and tab sorting, matches the visual changes made by the responsive CSS layout.

Differential Revision: https://phabricator.services.mozilla.com/D157256
2022-10-07 20:21:49 +00:00
Dan Mosedale
d86e156394 Bug 1791873 - fix FxView sync-setup-container kbd access,r=Gijs
Backout tabIndex changes that caused the problem and add an integration test.

Differential Revision: https://phabricator.services.mozilla.com/D157988
2022-09-26 18:43:31 +00:00
Bernard Igiri
758c474634 Bug 1785274 - Changed container of Fx View logo and title to a non-navigational tag r=sclements
Replaced tag containing Fx View logo and title with a non-navigational tag, so that screen readers do not announce it as a navigational element.

Differential Revision: https://phabricator.services.mozilla.com/D157260
2022-09-21 12:37:16 +00:00
Dan Mosedale
39c12bfdc2 Bug 1790651 - place focus better on feature callout close, r=ayeddi,emcminn
When the user moves focus outside of a callout popup while it's open, this patch tracks and saves the most recently focused element until the focus moves back to the popup. Once the user exits the callout series, the focus is (visibly) placed back where the user last left it.

Differential Revision: https://phabricator.services.mozilla.com/D157398
2022-09-15 19:11:19 +00:00
Gijs Kruitbosch
d8a1297f7c Bug 1787559 - update recently closed tabs description in Firefox View, r=flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D157123
2022-09-12 15:58:17 +00:00
Mike Conley
8fb10b7edb Bug 1787441 - Use the browser brand icon as the favicon for about:firefoxview. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156585
2022-09-07 13:35:35 +00:00
Sam Foster
1bbdf0032f Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
2022-09-02 18:53:21 +00:00
Sarah Clements
636bc451f1 Bug 1764137 - Add correct aria-roles to named-deck in firefoxview r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D156085
2022-09-02 10:59:13 +00:00
Noemi Erli
ec9494988d Backed out changeset 59536058a947 (bug 1784902) for causing failures in browser_setup_state.js 2022-09-02 04:42:49 +03:00
Sam Foster
fe2b36be03 Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Ensure the summary focus outline doesnt get clipped by the zap-card border below it
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
2022-09-01 22:30:42 +00:00
Dão Gottwald
0df55530f9 Bug 1785265 - [Colorway Closet] Set role="presentation" on colorway illustrations. r=bigiri,extension-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D154902
2022-08-18 15:49:25 +00:00
Sarah Clements
626fb28e87 Bug 1780242 - Add aria labels to collapsible container elements r=fluent-reviewers,morgan,flod
* Add aria labels and role to button and div that contains the content

Differential Revision: https://phabricator.services.mozilla.com/D154106
2022-08-16 09:48:10 +00:00
Meg Viar
6358232229 Bug 1781084 - Add CSS transitions when moving Feature Callout from one element to the next r=Mardak
Depends on D154143

Differential Revision: https://phabricator.services.mozilla.com/D154275
2022-08-15 23:11:13 +00:00
Sam Foster
4b70d80706 Bug 1783278 - Allow primary buttons to wrap in card layout at narrow widths. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D154312
2022-08-12 00:46:55 +00:00
Niklas Baumgardner
fcd47c72bd Bug 1783273 - Remove hover state from Firefox View sync setup containers. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D154138
2022-08-10 13:35:51 +00:00
Meg Viar
1717fd75c8 Bug 1779024 - Create Feature Callout message surface using aboutwelcome r=pdahiya,Gijs,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D152449
2022-08-04 11:47:01 +00:00
Sarah Clements
f5b9a6d56a Bug 1768695 - Add error states handling to FirefoxView r=sfoster,fluent-reviewers,desktop-theme-reviewers
* Add new card and styling for network offline, sync error and sync disabled by admin errors
* Change loading spinner to rotating sync svg
* Add tests

Differential Revision: https://phabricator.services.mozilla.com/D153069
2022-08-03 12:14:32 +00:00
Francesco Lodolo (:flod)
2405be9e14 Bug 1775309 - Move firefoxView.ftl to locales/en-US for localization, r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D153462
2022-08-03 10:04:47 +00:00
Sandor Molnar
daecd1c9e2 Backed out changeset 8390be8eb18e (bug 1768695) for causing browser-chrome failures in browser/components/firefoxview/tests/browser/browser_tab_pickup_list.js CLOSED TREE 2022-08-02 18:58:22 +03:00
Sarah Clements
122e755a1c Bug 1768695 - Add error states handling to FirefoxView r=sfoster,fluent-reviewers,desktop-theme-reviewers
* Add new card and styling for network offline, sync error and sync disabled by admin errors
* Change loading spinner to rotating sync svg
* Add tests

Differential Revision: https://phabricator.services.mozilla.com/D153069
2022-08-02 11:56:23 +00:00
Sam Foster
469917ce66 Bug 1776779 - Add mobile promo and success confirmation banner. r=Gijs,markh
* Add mobile promo element to the Fxa/sync setup flow, and logic to show/hide it
* Add success confirmation for the mobile sync connection with logic to show/hide it
* Watch a new pref 'browser.tabs.firefox-view.mobilePromo.dismissed' for the promo
* Add a new notification in FxAccountsDevice when the devicelist cache is updated
* Use the devicelist updated notification drive the state changes in the setup flow manager
* Add test coverage for the mobile promo

Differential Revision: https://phabricator.services.mozilla.com/D151895
2022-07-30 01:30:15 +00:00
Sarah Clements
1e419131ff Bug 1761782 - Firefox View colors update in response to theme changes r=dao
* Use contentTheme.js to dynamically update text and background colors in response to
theme changes, including from colorways modal

Differential Revision: https://phabricator.services.mozilla.com/D151043
2022-07-28 12:19:02 +00:00
Bernard Igiri
fda7bc00a6 Bug 1780047 - Make Colorway CTA in Fx View responsive r=dao
Added dynamic layout adjustments to Colorway CTA in Firefox View according to both S and L sizing as described in Figma.

Differential Revision: https://phabricator.services.mozilla.com/D152215
2022-07-22 15:14:13 +00:00
Dão Gottwald
59386d48fc Bug 1778556 - [Colorway Closet] Move colorway l10n from preview/ to browser/. r=flod,fluent-reviewers,extension-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D152512
2022-07-22 15:05:44 +00:00
Sam Foster
617a3d5b9c Bug 1780168 - Rename TabsPickupContainer to TabPickupContainer for consistency. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D152220
2022-07-21 22:47:35 +00:00
Sam Foster
e0acecab85 Bug 1780168 - Extract tabsSetupFlowManager to be a system ESM. r=Gijs
* Move the tabsSetupFlowManager into its own system ESM. This allows multiple about:firefoxview instances to have a single manager and syncronize state without duplication
* The first call to tabSetupFlowManager.initialize() will do any necessary setup to wait for sync & fxa services to be ready
* tabSetupFlowManager handles its own uninit
* Move TabsPickupContainer to match file naming convention for our other custom element modules
* TabsPickupContainer instances observe tabSetupFlowManager's notifications for state changes, and can request the current uiStateIndex directly.
* The utility openFxaSignup and openSyncPreferences functions now need know which window to open the URL in

Differential Revision: https://phabricator.services.mozilla.com/D152151
2022-07-21 22:47:35 +00:00
Bernard Igiri
cbd7df1750 Bug 1776221 - Added auto update of Colorway CTA on theme change r=sfoster
With this fix changing the Colorway theme should automatically update the Colorway CTA in Firefox View. Additionally, the Colorways portion of firefoxview.mjs has been migrated to colorways-card.mjs and restructured to match the style of the rest of the Firefox View codebase.

Differential Revision: https://phabricator.services.mozilla.com/D150878
2022-07-15 21:36:56 +00:00
Norisz Fay
d9002d885b Backed out changeset 4ad72b0c451f (bug 1776221) for causing bc failures on browser_colorways_card.js CLOSED TREE 2022-07-13 20:17:42 +03:00
Bernard Igiri
cb1b4cc87f Bug 1776221 - Added auto update of Colorway CTA on theme change r=dao
With this fix changing the Colorway theme should automatically update the Colorway CTA in Firefox View. Additionally, the Colorways portion of firefoxview.mjs has been migrated to colorways-card.mjs and restructured to match the style of the rest of the Firefox View codebase.

Differential Revision: https://phabricator.services.mozilla.com/D150878
2022-07-13 14:12:04 +00:00
Sarah Clements
46ee65f0ff Bug 1774168 - Add empty list placeholder and collapsible container to Tab Pickup r=sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D150738
2022-07-07 16:08:07 +00:00
Dão Gottwald
39b4efcb2d Bug 1770030 - [Colorway Closet] Localize colorway names and descriptions. r=kpatenio,extension-reviewers,flod,rpl,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D150510
2022-06-30 19:44:31 +00:00
Mark Banner
92e99fe0ba Bug 1777445 - Move firefoxview to use mjs files, rather than defining sourceType for ESLint. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150734
2022-06-30 10:13:01 +00:00
Bernard Igiri
bb020f651c Bug 1777310 - Added Colorway CTA image to FX View r=dao
Added Colorway CTA image to FX View

Differential Revision: https://phabricator.services.mozilla.com/D150677
2022-06-30 04:00:40 +00:00
Bernard Igiri
79a2241a83 Bug 1773322 - Implement Colorways CTA for active Colorway r=dao,fluent-reviewers,Gijs
Implemented Colorway CTA in Firefox View for when a Colorway is active.

Differential Revision: https://phabricator.services.mozilla.com/D149175
2022-06-28 13:30:03 +00:00
Sam Foster
fff37f0fd0 Bug 1772278 - Add the sumo URLs for the 'learn more' links in the FxA/sync setup flow. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D150293
2022-06-27 18:55:10 +00:00
Sam Foster
a324dbf2a8 Bug 1774015 - Adjust layout for fxview. r=Gijs
* Set root element font-size to 15px to align with the size we set on body (in common-shared.css), allowing predictability when scaling and zoom-friendly (rem) widths
* Remove the <main> grid column-gap and manage padding/gutter around/between content areas with the --content-area-gutter variable
* Use a consistent 32px between content areas
* Simplify <main> grid to 2 columns with 2/3, 1/3 width respectively.
* Add a max-width to the page content to correspond to 1440px and horizontally center it in larger viewports
* Move the colorways content inside right-most column (grid slot) rather than *be* the column.

Differential Revision: https://phabricator.services.mozilla.com/D149457
2022-06-22 23:50:55 +00:00
Sarah Clements
44b2de639c Bug 1768037 - Create Tab Pickup synced tabs list component r=Gijs,fluent-reviewers,flod
* Create hero cards for Tabs Pickup section, query SyncedTabs API once a device has been synced

Differential Revision: https://phabricator.services.mozilla.com/D148788
2022-06-17 17:35:19 +00:00
Cristian Tuns
1267801ce8 Backed out changeset 3a8fbcc96d72 (bug 1768037) for causing bc failures on browser_parsable_script.js CLOSED TREE 2022-06-17 10:40:39 -04:00
Sarah Clements
ea37cd2f9f Bug 1768037 - Create Tab Pickup synced tabs list component r=Gijs,fluent-reviewers,flod
* Create hero cards for Tabs Pickup section, query SyncedTabs API once a device has been synced

Differential Revision: https://phabricator.services.mozilla.com/D148788
2022-06-17 13:30:40 +00:00
Sam Foster
7c510b3ded Bug 1768681 - Implement a loading state for tabs-pickup while we wait for remote tabs to sync. r=fluent-reviewers,desktop-theme-reviewers,dao,Gijs
* Add an animated svg loading spinner similar to pdf.js' loading.svg
* Add loading state strings and update string from previous steps
* Show a loading/syncing step when the last tab sync was greater than 30s ago
* Change the loading state to hide the setup steps and show the tabs list with a loading spinner
* Expose TABS_FRESH_ENOUGH_INTERVAL_SECONDS from SyncedTabs.jsm so we can define it in a single place

Differential Revision: https://phabricator.services.mozilla.com/D147565
2022-06-15 01:18:30 +00:00
Bernard Igiri
119a51c906 Bug 1771326 - Implement Colorways CTA for when no Colorway is selected r=dao,flod
Implemented Colorway CTA in Firefox View for when a Colorway Collection is active but no Colorway has been selected.

Differential Revision: https://phabricator.services.mozilla.com/D148144
2022-06-14 11:41:12 +00:00
Sam Foster
ade1bcc6a3 Bug 1761789 - Set up progressive layout grid for Firefox View. r=dao
* Add feature name and brand logo to populate the sidebar
* Refine area sizes, padding, margins etc
* Define rem-based break-points for progressive layout based on viewport and font-size.
* Use the header.page-section-header for the tabs-pickup section and sketch in the collapse button so we can better see how those headings are going to line up

Differential Revision: https://phabricator.services.mozilla.com/D148581
2022-06-10 18:53:33 +00:00
Bernard Igiri
e9b14cca8d Bug 1770046 - Added no active collection message to Colorway CTA r=dao,fluent-reviewers
The Colorway CTA in Firefox View now shows the message and images for when no Colorway Collection is active.

Differential Revision: https://phabricator.services.mozilla.com/D147229
2022-05-27 11:38:07 +00:00