Mike Conley
bbd86e3da7
Bug 1799947 - With Unified Extensions UI, make addons panel the fallback area for browser_actions. r=willdurand
...
Differential Revision: https://phabricator.services.mozilla.com/D161720
2022-11-15 18:37:31 +00:00
Mike Conley
d40309199d
Bug 1782203 - Add tests for the new Pin to Toolbar context menu item. r=willdurand,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D161338
2022-11-15 16:37:24 +00:00
Mike Conley
b5207e1356
Bug 1782203 - Unbreak existing context menu tests for Unified Extensions UI mode. r=willdurand,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D161337
2022-11-15 16:37:23 +00:00
Stanca Serban
7abed322ee
Backed out 3 changesets (bug 1782203) for causing lint failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
...
Backed out changeset 50e57afebed3 (bug 1782203)
Backed out changeset d17ea376ed45 (bug 1782203)
Backed out changeset e91d51f1ce90 (bug 1782203)
2022-11-15 17:42:22 +02:00
Mike Conley
cf35a57c36
Bug 1782203 - Add tests for the new Pin to Toolbar context menu item. r=willdurand,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D161338
2022-11-15 15:02:09 +00:00
Mike Conley
0a03210b6f
Bug 1782203 - Unbreak existing context menu tests for Unified Extensions UI mode. r=willdurand,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D161337
2022-11-15 15:02:09 +00:00
William Durand
307f9a8b0e
Bug 1777484 - Enhance extension widgets in the unified extensions panel. r=rpl,Itiel
...
Differential Revision: https://phabricator.services.mozilla.com/D161168
2022-11-15 12:59:34 +00:00
Csoregi Natalia
1ce4bb73a7
Backed out 4 changesets (bug 1782203, bug 1777484) for failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
...
Backed out changeset ae47d92443a7 (bug 1782203)
Backed out changeset 0c90b1d40e9f (bug 1782203)
Backed out changeset 4b4cae098ea0 (bug 1782203)
Backed out changeset 75eba3b7a626 (bug 1777484)
2022-11-15 03:06:21 +02:00
Mike Conley
e28ed5dfe8
Bug 1782203 - Add tests for the new Pin to Toolbar context menu item. r=willdurand,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D161338
2022-11-14 22:41:10 +00:00
Mike Conley
7045d9d8cd
Bug 1782203 - Unbreak existing context menu tests for Unified Extensions UI mode. r=willdurand,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D161337
2022-11-14 22:41:09 +00:00
William Durand
a5ca2f6904
Bug 1777484 - Enhance extension widgets in the unified extensions panel. r=rpl,Itiel
...
Differential Revision: https://phabricator.services.mozilla.com/D161168
2022-11-14 22:41:08 +00:00
William Durand
a9884dda35
Bug 1798324 - Update style of extension widgets in the panel. r=mconley,desktop-theme-reviewers,dao,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D161036
2022-11-10 11:29:16 +00:00
Tomislav Jovanovic
a63393aa92
Bug 1794427 - Origin Controls reflect implicit access through content scripts r=willdurand
...
Differential Revision: https://phabricator.services.mozilla.com/D160893
2022-11-09 13:21:09 +00:00
William Durand
093aba99c8
Bug 1799497 - Only register 'add-ons-button' widget when the unified extensions pref is disabled. r=Gijs,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D161569
2022-11-08 19:54:47 +00:00
Mike Conley
c759904dae
Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements
...
Long ago, the menu panel in was a customizable area that users could drag things into.
That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.
It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.
I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.
Differential Revision: https://phabricator.services.mozilla.com/D161078
2022-11-08 14:51:40 +00:00
William Durand
fc741397c8
Bug 1799143 - Fix attention dot for MV3 extension buttons in the toolbar and overflow panel. r=dao,extension-reviewers,zombie
...
Differential Revision: https://phabricator.services.mozilla.com/D161299
2022-11-08 14:28:10 +00:00
Mark Banner
19c189e131
Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato
...
Differential Revision: https://phabricator.services.mozilla.com/D161013
2022-11-07 17:56:10 +00:00
William Durand
332bb1164c
Bug 1799203 - Do not open panel when context-clicking the UEB. r=mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D161334
2022-11-05 09:07:14 +00:00
Mike Conley
767c9ae736
Bug 1799007 - Create Unified Extensions enabled and disabled variants of context menu tests. r=willdurand
...
Differential Revision: https://phabricator.services.mozilla.com/D161216
2022-11-05 01:27:10 +00:00
Csoregi Natalia
31cce8b96e
Backed out changeset 64187944ddd3 (bug 1799007) for causing extensions failures. CLOSED TREE
2022-11-05 00:06:26 +02:00
Mike Conley
326aeab233
Bug 1799007 - Create Unified Extensions enabled and disabled variants of context menu tests. r=willdurand
...
Differential Revision: https://phabricator.services.mozilla.com/D161216
2022-11-04 20:25:33 +00:00
William Durand
b31856e2ae
Bug 1797050 - Part 8 - Add test coverage for the deprecated manifest.json key "applications". r=rpl
...
Depends on D160248
Differential Revision: https://phabricator.services.mozilla.com/D160726
2022-11-04 19:09:02 +00:00
William Durand
12a393c465
Bug 1797050 - Part 6 - Use browser_specific_settings instead of applications in test manifests. r=rpl,perftest-reviewers,sparky
...
We want to encourage extension developers to use `browser_specific_settings` instead of `applications`, which will be unsupported in Manifest Version 3+. This patch makes sure test manifests in m-c won't cause any issues in the future.
Depends on D160541
Differential Revision: https://phabricator.services.mozilla.com/D160668
2022-11-03 16:23:03 +00:00
Marco Bonardo
6859ef34b1
Bug 1429108 - Switch FormHistory::update to promises. r=sgalich,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D160925
2022-11-03 09:35:39 +00:00
Marco Bonardo
dcb62ba55a
Bug 1429108 - Switch FormHistory::count to promises. r=sgalich,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D160923
2022-11-03 09:35:38 +00:00
Marco Bonardo
d799769a5f
Bug 1429108 - Switch FormHistory::search to promises. r=sgalich,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D160922
2022-11-03 09:35:38 +00:00
Shane Caraveo
e5c4d6af38
Bug 1784947 - Make browser action a custom widget to support unified extension button. r=desktop-theme-reviewers,zombie,Itiel
...
Co-Authored-By: William Durand <will+git@drnd.me >
Differential Revision: https://phabricator.services.mozilla.com/D154470
2022-11-03 09:30:22 +00:00
Mike Conley
ce84c284ed
Bug 1797838 - Add a webExtension property to CustomizableUI widgets for browserAction buttons. r=dao,willdurand
...
This property, along with the CustomizableUI.isWebExtensionWidget, will make it possible
to distinguish WebExtension-provided widgets without sniffing CSS classes, which is what
we currently do.
In the event that the widget has been destroyed or hasn't yet been created, this will
fallback to looking for the `-browser-action` suffix on the ID. This is mainly for use during
migrations which happen early during CustomizableUI startup, when it's unlikely that the
extensions have finished initializing themselves and creating their widgets yet.
Differential Revision: https://phabricator.services.mozilla.com/D160802
2022-11-02 16:52:59 +00:00
Mike Conley
92f1df1669
Bug 1797155 - Part 3: Add tests for Unified Extensions toolbar overflow behaviour. r=willdurand,extension-reviewers
...
Depends on D160293
Differential Revision: https://phabricator.services.mozilla.com/D160542
2022-11-01 21:50:56 +00:00
Mike Conley
bd0a2d6a38
Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand
...
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.
Depends on D160292
Differential Revision: https://phabricator.services.mozilla.com/D160293
2022-11-01 21:50:56 +00:00
William Durand
964e3b9095
Bug 1796559 - Only open about:addons on primary click. r=zombie
...
Differential Revision: https://phabricator.services.mozilla.com/D160329
2022-11-01 19:45:14 +00:00
Butkovits Atila
517ae6c72a
Backed out 3 changesets (bug 1797155) for causing failures at browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
...
Backed out changeset 67f5e4af25b6 (bug 1797155 )
Backed out changeset b8a8bd646606 (bug 1797155 )
Backed out changeset ec7cdd68c414 (bug 1797155 )
2022-11-01 19:33:25 +02:00
Mike Conley
2e4ddded0e
Bug 1797155 - Part 3: Add tests for Unified Extensions toolbar overflow behaviour. r=willdurand,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D160542
2022-11-01 16:44:33 +00:00
Mike Conley
7ba904bf88
Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand
...
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.
Differential Revision: https://phabricator.services.mozilla.com/D160293
2022-11-01 16:44:33 +00:00
Mark Banner
0008510845
Bug 1798018 - Convert consumers of toolkit/modules/tests to import ES modules direct. r=Gijs,webdriver-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich
...
Differential Revision: https://phabricator.services.mozilla.com/D160664
2022-11-01 13:26:38 +00:00
Joel Maher
67022e845c
Bug 1798331 - annotation more tests for win11. r=bxbrenden
...
Differential Revision: https://phabricator.services.mozilla.com/D160807
2022-10-31 21:15:09 +00:00
Marian-Vasile Laza
e32d202d39
Backed out 3 changesets (bug 1797155) for causing bc failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
...
Backed out changeset ee3f27f43bc5 (bug 1797155 )
Backed out changeset 863603ed770a (bug 1797155 )
Backed out changeset 3fbfc3d94e5a (bug 1797155 )
2022-10-31 21:29:22 +02:00
Mike Conley
ecdc0c7f3b
Bug 1797155 - Part 3: Add tests for Unified Extensions toolbar overflow behaviour. r=willdurand,extension-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D160542
2022-10-31 18:05:20 +00:00
Mike Conley
fc80458832
Bug 1797155 - Part 2: Make it possible to redirect browser action widgets to the Unified Extension panel on overflow. r=sclements,willdurand
...
When Unified Extensions is enabled, we want to make it so that any WebExtension browser_actions
overflow into the Unified Extensions panel instead of the default overflow panel.
Differential Revision: https://phabricator.services.mozilla.com/D160293
2022-10-31 18:05:20 +00:00
Oliver Dunk
9184ae7c67
Bug 1755763 - Update browserAction.openPopup API r=geckoview-reviewers,robwu,owlish
...
To align with other browsers, the user gesture requirement has
been removed and there is now an optional first argument which
can be used to provide a windowId.
Differential Revision: https://phabricator.services.mozilla.com/D139796
2022-10-31 15:22:41 +00:00
William Durand
78829ab8e2
Bug 1797050 - Part 3 - Use browser_specific_settings instead of applications in existing WebExt tests. r=rpl,geckoview-reviewers,extension-reviewers,owlish
...
We want to encourage extension developers to use `browser_specific_settings` instead of `applications`,
which will be unsupported in Manifest Version 3+. This patch prepares the introduction of a new warning
(that is usually converted into an error in the test environment).
Differential Revision: https://phabricator.services.mozilla.com/D160059
2022-10-28 09:53:09 +00:00
Joel Maher
7ba743bfbb
Bug 1797751 - carry over skip-if conditions from win10 to win11. r=bxbrenden,necko-reviewers,settings-reviewers,credential-management-reviewers,valentin,sgalich
...
Differential Revision: https://phabricator.services.mozilla.com/D160529
2022-10-28 00:00:40 +00:00
Mike Conley
8452e411e0
Bug 1797548 - Move Unified Extensions panelview into its own dedicated lazily created panel. r=cmkm,willdurand
...
Differential Revision: https://phabricator.services.mozilla.com/D160403
2022-10-27 17:13:43 +00:00
Stanca Serban
99f363367a
Backed out changeset adb4eb909fc2 (bug 1755763) for causing mochitests failures on browser_ext_browserAction_click_types.js. CLOSED TREE
2022-10-25 15:53:19 +03:00
Oliver Dunk
4782921100
Bug 1755763 - Update browserAction.openPopup API r=geckoview-reviewers,robwu,owlish
...
To align with other browsers, the user gesture requirement has
been removed and there is now an optional first argument which
can be used to provide a windowId.
Differential Revision: https://phabricator.services.mozilla.com/D139796
2022-10-25 11:49:42 +00:00
Tomislav Jovanovic
586bffe470
Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
...
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-22 17:21:58 +00:00
William Durand
7382b32c34
Bug 1795285 - Remove skip-if = condprof on test_ext_manifest.js. r=robwu
...
That was introduced in Bug 1793925 to workaround a pre-existing issue.
Differential Revision: https://phabricator.services.mozilla.com/D159663
2022-10-19 13:10:12 +00:00
Cosmin Sabou
ba255c1975
Backed out changeset 27a859f55fdd (bug 1793629) for causing bc failures on browser_preferences_usage.js.
2022-10-19 02:34:23 +03:00
Tomislav Jovanovic
fc9a32fdd5
Bug 1793629 - Implement attention indicator for the unified extensions button, r=willdurand
...
Differential Revision: https://phabricator.services.mozilla.com/D158938
2022-10-18 21:44:48 +00:00
Mark Banner
5407bdffa8
Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
...
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.
Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00