corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

749 Commits

Author SHA1 Message Date
William Durand
80f9f71d60 Bug 1799694 - Avoid flickering when messages have different lengths. r=rpl,mconley,desktop-theme-reviewers,Itiel 
This is a completely redesign based on mconley's idea to use `deck`.
That removes a lot of code and makes things a lot better.

Depends on D163077

Differential Revision: https://phabricator.services.mozilla.com/D162390
 2022-11-27 17:07:44 +00:00
William Durand
ef7a4e1a24 Bug 1799694 - Rename action/menu button class names in unified extensions. r=Itiel,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D163077
 2022-11-27 17:07:44 +00:00
William Durand
a4a9f55ee9 Bug 1802411 - Set disabled state on the action button for extension widgets. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D163100
 2022-11-25 14:53:59 +00:00
Tomislav Jovanovic
ce9d450436 Bug 1801136 - Update tooltips when extensions require attention for permissions, r=willdurand,flod 
Differential Revision: https://phabricator.services.mozilla.com/D162894
 2022-11-24 14:16:30 +00:00
William Durand
5ff99717fb Bug 1801515 - Hover messages shouldn't be hidden by extensions in the UEP. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D162555
 2022-11-22 17:49:18 +00:00
YUKI "Piro" Hiroshi
a53e90352a Bug 1271047 - Place "popup" type window to given coordinates r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D73419
 2022-11-22 09:05:29 +00:00
Cristian Tuns
d1e21d7b84 Backed out changeset 424c4d51a7cd (bug 1271047) for causing mochitest failures on /browser_ext_windows_size.js CLOSED TREE 2022-11-21 14:04:04 -05:00
YUKI "Piro" Hiroshi
91ce3fc92a Bug 1271047 - Place "popup" type window to given coordinates r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D73419
 2022-11-21 17:02:06 +00:00
trickypr
589688feed Bug 1510561 - Part 16: Apply plugin:mozilla/valid-jsdoc to toolkit/components/extensions. r=geckoview-reviewers,extension-reviewers,zombie,owlish 
Differential Revision: https://phabricator.services.mozilla.com/D161391
 2022-11-19 11:41:48 +00:00
William Durand
3b920d7b92 Bug 1801142 - Add hover messages on CUI widgets in the unified extensions panel. r=rpl,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D162331
 2022-11-18 12:08:19 +00:00
Mike Conley
1e8fc28499 Bug 1799947 - Update existing tests to put browser_action's into the navbar by default. r=willdurand,extension-reviewers 
We had a number of tests that assumed that when adding a browser_action without
specifying the default_area, that the button would enter the navbar. The previous
patch in this series changes that assumption when the Unified Extensions UI is
enabled.

Instead of updating all of these tests to add additional steps to move the
browser_action's out to the navbar after adding them, I've gone ahead and
updated them to default their browser_action's to the navbar instead.

Differential Revision: https://phabricator.services.mozilla.com/D161721
 2022-11-16 22:12:52 +00:00
Mike Conley
4d13193918 Bug 1799947 - With Unified Extensions UI, make addons panel the fallback area for browser_actions. r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D161720
 2022-11-16 22:12:52 +00:00
Marian-Vasile Laza
bfb43d0dc3 Backed out 2 changesets (bug 1799947) for causing browserAction bc, mochitest, devtools related failures. CLOSED TREE 
Backed out changeset ff58300200c4 (bug 1799947)
Backed out changeset 517df40ddcd4 (bug 1799947)
 2022-11-15 22:38:24 +02:00
Mike Conley
bbd86e3da7 Bug 1799947 - With Unified Extensions UI, make addons panel the fallback area for browser_actions. r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D161720
 2022-11-15 18:37:31 +00:00
Mike Conley
d4d3af9877 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D161200
 2022-11-15 16:37:23 +00:00
Stanca Serban
7abed322ee Backed out 3 changesets (bug 1782203) for causing lint failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 
Backed out changeset 50e57afebed3 (bug 1782203)
Backed out changeset d17ea376ed45 (bug 1782203)
Backed out changeset e91d51f1ce90 (bug 1782203)
 2022-11-15 17:42:22 +02:00
Mike Conley
55af77e9ed Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D161200
 2022-11-15 15:02:08 +00:00
William Durand
307f9a8b0e Bug 1777484 - Enhance extension widgets in the unified extensions panel. r=rpl,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D161168
 2022-11-15 12:59:34 +00:00
Csoregi Natalia
1ce4bb73a7 Backed out 4 changesets (bug 1782203, bug 1777484) for failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 
Backed out changeset ae47d92443a7 (bug 1782203)
Backed out changeset 0c90b1d40e9f (bug 1782203)
Backed out changeset 4b4cae098ea0 (bug 1782203)
Backed out changeset 75eba3b7a626 (bug 1777484)
 2022-11-15 03:06:21 +02:00
Mike Conley
70738f0144 Bug 1782203 - Add context menu items for pinning and unpinning addon buttons to the toolbar. r=willdurand,extension-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D161200
 2022-11-14 22:41:09 +00:00
William Durand
a5ca2f6904 Bug 1777484 - Enhance extension widgets in the unified extensions panel. r=rpl,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D161168
 2022-11-14 22:41:08 +00:00
William Durand
a9884dda35 Bug 1798324 - Update style of extension widgets in the panel. r=mconley,desktop-theme-reviewers,dao,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D161036
 2022-11-10 11:29:16 +00:00
Mike Conley
c759904dae Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements 
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
 2022-11-08 14:51:40 +00:00
William Durand
fc741397c8 Bug 1799143 - Fix attention dot for MV3 extension buttons in the toolbar and overflow panel. r=dao,extension-reviewers,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D161299
 2022-11-08 14:28:10 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D161013
 2022-11-07 17:56:10 +00:00
Shane Caraveo
e5c4d6af38 Bug 1784947 - Make browser action a custom widget to support unified extension button. r=desktop-theme-reviewers,zombie,Itiel 
Co-Authored-By: William Durand <will+git@drnd.me>

Differential Revision: https://phabricator.services.mozilla.com/D154470
 2022-11-03 09:30:22 +00:00
Mike Conley
ce84c284ed Bug 1797838 - Add a webExtension property to CustomizableUI widgets for browserAction buttons. r=dao,willdurand 
This property, along with the CustomizableUI.isWebExtensionWidget, will make it possible
to distinguish WebExtension-provided widgets without sniffing CSS classes, which is what
we currently do.

In the event that the widget has been destroyed or hasn't yet been created, this will
fallback to looking for the `-browser-action` suffix on the ID. This is mainly for use during
migrations which happen early during CustomizableUI startup, when it's unlikely that the
extensions have finished initializing themselves and creating their widgets yet.

Differential Revision: https://phabricator.services.mozilla.com/D160802
 2022-11-02 16:52:59 +00:00
Oliver Dunk
9184ae7c67 Bug 1755763 - Update browserAction.openPopup API r=geckoview-reviewers,robwu,owlish 
To align with other browsers, the user gesture requirement has
been removed and there is now an optional first argument which
can be used to provide a windowId.

Differential Revision: https://phabricator.services.mozilla.com/D139796
 2022-10-31 15:22:41 +00:00
Stanca Serban
99f363367a Backed out changeset adb4eb909fc2 (bug 1755763) for causing mochitests failures on browser_ext_browserAction_click_types.js. CLOSED TREE 2022-10-25 15:53:19 +03:00
Oliver Dunk
4782921100 Bug 1755763 - Update browserAction.openPopup API r=geckoview-reviewers,robwu,owlish 
To align with other browsers, the user gesture requirement has
been removed and there is now an optional first argument which
can be used to provide a windowId.

Differential Revision: https://phabricator.services.mozilla.com/D139796
 2022-10-25 11:49:42 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Tomislav Jovanovic
a16d5052dd Bug 1777343 - Implement simple origin controls attention indicator, r=willdurand,desktop-theme-reviewers,Itiel 
Differential Revision: https://phabricator.services.mozilla.com/D158476
 2022-10-13 22:04:52 +00:00
Alexandre Poirot
e0366a6c18 Bug 1700909 - [devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes 
Instead we should we querying Toolbox.commands.descriptorFront.

Differential Revision: https://phabricator.services.mozilla.com/D157942
 2022-10-11 20:33:51 +00:00
Cristian Tuns
c136da03a9 Backed out 5 changesets (bug 1700909) for causing mochitest failures CLOSED TREE 
Backed out changeset a49f15f66ed4 (bug 1700909)
Backed out changeset 5a6b15eb1e12 (bug 1700909)
Backed out changeset 67b12d0e350b (bug 1700909)
Backed out changeset 4e6312ea547a (bug 1700909)
Backed out changeset c49eab385e1c (bug 1700909)
 2022-10-10 10:38:03 -04:00
Alexandre Poirot
62214956c9 Bug 1700909 - [devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes 
Instead we should we querying Toolbox.commands.descriptorFront.

Differential Revision: https://phabricator.services.mozilla.com/D157942
 2022-10-10 11:28:05 +00:00
Andreea Pavel
734e00a91f Backed out 5 changesets (bug 1700909) for failing browser_ext_addon_debugging_netmonitor.js on a CLOSED TREE 
Backed out changeset 9bc3e4820f59 (bug 1700909)
Backed out changeset 998c0ec4f9d3 (bug 1700909)
Backed out changeset 6f6fe066fc38 (bug 1700909)
Backed out changeset e53aaf8ffe5b (bug 1700909)
Backed out changeset 3dbeffe25878 (bug 1700909)
 2022-09-29 19:40:43 +03:00
Alexandre Poirot
0d20bb1ccb Bug 1700909 - [devtools] Stop exposing Toolbox.descriptorFront. r=jdescottes 
Instead we should we querying Toolbox.commands.descriptorFront.

Differential Revision: https://phabricator.services.mozilla.com/D157942
 2022-09-29 14:43:24 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Mark Banner
c34ea601d2 Bug 1634555 - Send event telemetry for search default engine changes. r=daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D157471
 2022-09-28 09:40:36 +00:00
Alexandre Poirot
633eb069ef Bug 1791832 - [devtools] Convert devtools/startup JSM to ES Modules. r=jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D157911
 2022-09-26 10:48:05 +00:00
Brian
0b327f0974 Bug 1788925 - Convert AboutReader from JSM to ESM. r=Gijs. 
Differential Revision: https://phabricator.services.mozilla.com/D157034
 2022-09-23 21:19:12 +00:00
Emilio Cobos Álvarez
0676d5d593 Bug 1780876 - Try to deal with DOM/widget state mismatch on macOS. r=robwu 
The patch that that regressed this started using the widget state rather
than the DOM state to return full-screen. It seems on macOS they
sometimes can get out of sync, in the failure from comment 0 the window
is really full-screen.

We seemed to account for some of this in:

  https://searchfox.org/mozilla-central/rev/00e504083572d47f2199168f0f79c75c0ddaefb3/browser/components/extensions/test/browser/browser_ext_windows_create.js#31-36

Make sure we exit full-screen as appropriate if DOM thinks we're
fullscreen. This passes verify and at worst it should be harmless.

Differential Revision: https://phabricator.services.mozilla.com/D155353
 2022-08-23 22:13:19 +00:00
Shane Caraveo
c114951f8b Bug 1783972 make browser actions pop out of overflow r=zombie,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D154179
 2022-08-22 18:55:59 +00:00
Shane Caraveo
cd3dba3928 Bug 1711168 allow extension pages to be loaded as top level tabs by other extensions r=rpl,geckoview-reviewers,calu 
Ensure extensions can manage tabs and sessions that include tabs from other extensions.  The parent
patch to this introduces cross-extension access validation.  However that breaks this specific use case
that we need to continue supporting.  This patch modifies three extension apis, tab.create/update and
windows.create to allow the creation of extension tabs which cannot be otherwise accessed.

Differential Revision: https://phabricator.services.mozilla.com/D151766
 2022-08-02 17:08:58 +00:00
William Durand
68182a4ab7 Bug 1777483 - Part 4 - Add extension actions to the unified extensions context menu. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D153096
 2022-07-29 20:32:16 +00:00
Butkovits Atila
b01ed36979 Backed out 3 changesets (bug 1711168, bug 1773115) for causing failures at test_ext_web_accessible_resources.html. CLOSED TREE 
Backed out changeset 703c909eb009 (bug 1773115)
Backed out changeset 902385a7ce60 (bug 1711168)
Backed out changeset 3d061ce03de7 (bug 1711168)
 2022-07-27 00:13:26 +03:00
Shane Caraveo
26d3eac02e Bug 1711168 allow extension pages to be loaded as top level tabs by other extensions r=rpl 
Ensure extensions can manage tabs and sessions that include tabs from other extensions.  The parent
patch to this introduces cross-extension access validation.  However that breaks this specific use case
that we need to continue supporting.  This patch modifies three extension apis, tab.create/update and
windows.create to allow the creation of extension tabs which cannot be otherwise accessed.

Differential Revision: https://phabricator.services.mozilla.com/D151766
 2022-07-26 19:39:14 +00:00
Mark Banner
cd9bed2e7a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-26 15:11:30 +00:00
Emilio Cobos Álvarez
bc40301982 Bug 1780680 - More cleanly return "normal" state for closed windows. r=mixedpuppy 
It bit me in the dependent bug because bug, see the comment in:

  https://hg.mozilla.org/integration/autoland/rev/8bbec265ab8c

Differential Revision: https://phabricator.services.mozilla.com/D152480
 2022-07-26 12:02:46 +00:00
smolnar
4cb3dcaaa2 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE 
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
 2022-07-25 21:00:07 +03:00