Commit Graph

341 Commits

Author SHA1 Message Date
Gijs Kruitbosch
abd038ef9f Bug 1684006 - use the temp dir for downloads in uriloader tests, r=mak
This ensures that we don't leave downloads behind in race conditions, and that that
doesn't break future tests.

Differential Revision: https://phabricator.services.mozilla.com/D101041
2021-01-08 17:47:37 +00:00
Csoregi Natalia
33e32a990e Backed out changeset ac1a9dda65ed (bug 1684006) for xpcshell failures on downloads. CLOSED TREE 2021-01-08 18:31:07 +02:00
Gijs Kruitbosch
9d053ac4b1 Bug 1684006 - use the temp dir for downloads in uriloader tests, r=mak
This ensures that we don't leave downloads behind in race conditions, and that that
doesn't break future tests.

Differential Revision: https://phabricator.services.mozilla.com/D101041
2021-01-08 14:30:50 +00:00
Tom Schuster
0bb3affbe3 Bug 1683581 - Don't overwrite valid alternative image file-extensions. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D100235
2020-12-21 12:47:55 +00:00
Sebastian Streich
ef9e395b00 Bug 1676221 - Add UX nits to unblock UI r=ckerschb,Gijs
Show save dialogue
***
Automaticly show Panel On Block
***
Keep Open/Save Dialogue with open panel
***
Keep User choise in downloadsView
***
Add Unblock option to Unblock panel
***
lint
***
add test

Differential Revision: https://phabricator.services.mozilla.com/D96448
2020-12-18 15:30:33 +00:00
Butkovits Atila
8480457d60 Backed out changeset 234ae5cb0ff8 (bug 1676221) for causing leaks. CLOSED TREE 2020-12-17 10:54:31 +02:00
Sebastian Streich
0515cda67b Bug 1676221 - Add UX nits to unblock UI r=ckerschb,Gijs
Show save dialogue
***
Automaticly show Panel On Block
***
Keep Open/Save Dialogue with open panel
***
Keep User choise in downloadsView
***
Add Unblock option to Unblock panel
***
lint
***
add test

Differential Revision: https://phabricator.services.mozilla.com/D96448
2020-12-16 22:55:12 +00:00
Gijs Kruitbosch
5c4c731f32 Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
This changes two bits of Firefox that, together with the mime service, end up
very confused over webp + jpeg.

1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image
mimetype as the content type, it should ignore the URL. It doesn't have full channel
info so it can't really do better anyway. This fixes the context menu's "save image as..."
case.
2) it changes the external helper app service to do a few things slightly differently:
a. If we're told not to get an extension out of a URL, really don't. Don't just get the
   filename and then get it from there anyway...
b. If we've got a suggested filename, and a primary extension for the mimetype,
   and the extension on the file is not one of the known extensions for the mimetype,
   replace it with the primary extension.
This fixes the link case.

It also adds tests for both of these mechanisms as well as "save image as."

Differential Revision: https://phabricator.services.mozilla.com/D92306
2020-10-20 20:35:26 +00:00
Csoregi Natalia
e1f31bf2cf Backed out changeset ff2ad4b3e863 (bug 1667787) for failures on test_nullCharFile.xhtml. CLOSED TREE 2020-10-20 19:24:50 +03:00
Gijs Kruitbosch
993ebad789 Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
This changes two bits of Firefox that, together with the mime service, end up
very confused over webp + jpeg.

1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image
mimetype as the content type, it should ignore the URL. It doesn't have full channel
info so it can't really do better anyway. This fixes the context menu's "save image as..."
case.
2) it changes the external helper app service to do a few things slightly differently:
a. If we're told not to get an extension out of a URL, really don't. Don't just get the
   filename and then get it from there anyway...
b. If we've got a suggested filename, and a primary extension for the mimetype,
   and the extension on the file is not one of the known extensions for the mimetype,
   replace it with the primary extension.
This fixes the link case.

It also adds tests for both of these mechanisms as well as "save image as."

Differential Revision: https://phabricator.services.mozilla.com/D92306
2020-10-20 12:05:10 +00:00
Narcis Beleuzu
b0a4fed533 Backed out changeset 19f174844357 (bug 1667787) for bc failure on browser_bug676619.js . CLOSED TREE 2020-10-20 00:11:01 +03:00
Gijs Kruitbosch
304c70a46b Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
This changes two bits of Firefox that, together with the mime service, end up
very confused over webp + jpeg.

1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image
mimetype as the content type, it should ignore the URL. It doesn't have full channel
info so it can't really do better anyway. This fixes the context menu's "save image as..."
case.
2) it changes the external helper app service to do a few things slightly differently:
a. If we're told not to get an extension out of a URL, really don't. Don't just get the
   filename and then get it from there anyway...
b. If we've got a suggested filename, and a primary extension for the mimetype,
   and the extension on the file is not one of the known extensions for the mimetype,
   replace it with the primary extension.
This fixes the link case.

It also adds tests for both of these mechanisms as well as "save image as."

Differential Revision: https://phabricator.services.mozilla.com/D92306
2020-10-19 16:14:13 +00:00
Narcis Beleuzu
11b143f3d3 Backed out changeset fc8c5c66f081 (bug 1667787) for mochitest failure test_invalidCharFileExtension.xhtml . CLOSED TREE 2020-10-13 17:56:47 +03:00
Gijs Kruitbosch
7096e0a9bd Bug 1667787 - fix saving webp images served with jpeg extensions without content-disposition information, r=mak
This changes two bits of Firefox that, together with the mime service, end up
very confused over webp + jpeg.

1) it changes contentAreaUtils.js' getDefaultExtension that if it gets an image
mimetype as the content type, it should ignore the URL. It doesn't have full channel
info so it can't really do better anyway. This fixes the context menu's "save image as..."
case.
2) it changes the external helper app service to do a few things slightly differently:
a. If we're told not to get an extension out of a URL, really don't. Don't just get the
   filename and then get it from there anyway...
b. If we've got a suggested filename, and a primary extension for the mimetype,
   and the extension on the file is not one of the known extensions for the mimetype,
   replace it with the primary extension.
This fixes the link case.

It also adds tests for both of these mechanisms as well as "save image as."

Differential Revision: https://phabricator.services.mozilla.com/D92306
2020-10-13 14:00:41 +00:00
Denis Palmeiro
013feabc78 Bug 1652126: Re-enable browser_pdfjs_preview.js for asan builds. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D89804
2020-09-11 15:28:20 +00:00
Keefer Rourke
2dfa4ef9d6 Bug 1660015: Add IOUtils to privileged eslint environment configuration r=barret,zombie
This change makes eslint aware of the global IOUtils interface, such that it
may be used without having to access it from the window or otherwise declaring
the global in a special comment on a file-by-file basis.

Differential Revision: https://phabricator.services.mozilla.com/D87612
2020-08-26 15:31:24 +00:00
Razvan Maries
5ae4f53ef9 Backed out 12 changesets (bug 1660328, bug 1660015, bug 1649595, bug 1649596, bug 1649593, bug 1659176, bug 1659839, bug 1659838, bug 1657663, bug 1657647, bug 1655460) for xpcshell perma failures. CLOSED TREE
Backed out changeset ff95badf90e3 (bug 1660328)
Backed out changeset a92f8525ab6f (bug 1659176)
Backed out changeset 8ca05470a0d5 (bug 1659839)
Backed out changeset 5de389b735d3 (bug 1649596)
Backed out changeset 73bdddd96664 (bug 1649595)
Backed out changeset 59800d609b55 (bug 1659838)
Backed out changeset 8aca41723313 (bug 1649593)
Backed out changeset dc0d90b3e135 (bug 1657647)
Backed out changeset e3dd5b6b4fbd (bug 1657663)
Backed out changeset f9c823fa14ba (bug 1657663)
Backed out changeset a5aecc7a6469 (bug 1655460)
Backed out changeset 21b64ef30e12 (bug 1660015)
2020-08-26 06:35:20 +03:00
Keefer Rourke
a2885b953b Bug 1660015: Add IOUtils to privileged eslint environment configuration r=barret,zombie
This change makes eslint aware of the global IOUtils interface, such that it
may be used without having to access it from the window or otherwise declaring
the global in a special comment on a file-by-file basis.

Differential Revision: https://phabricator.services.mozilla.com/D87612
2020-08-24 16:13:01 +00:00
Sebastian Streich
ab0ade1b55 Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs
***

***
Added Better Testing

Differential Revision: https://phabricator.services.mozilla.com/D85439
2020-08-24 15:29:23 +00:00
Cosmin Sabou
91b9b823f3 Backed out changeset 388c153da388 (bug 1656296) for causing default process leaks. CLOSED TREE 2020-08-19 21:58:03 +03:00
Sebastian Streich
e4d6eb9fbd Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs
***

***
Added Better Testing

Differential Revision: https://phabricator.services.mozilla.com/D85439
2020-08-19 17:58:57 +00:00
Narcis Beleuzu
54eb459a55 Backed out changeset 1b7eb33c8ec9 (bug 1656296) for bc failure on browser_test_mixed_content_download.js . CLOSED TREE 2020-08-19 16:39:33 +03:00
Sebastian Streich
8fbbb0aa80 Bug 1656296 - Pass Blocked Downloads to the DownloadsUI r=ckerschb,Gijs
***

***
Added Better Testing

Differential Revision: https://phabricator.services.mozilla.com/D85439
2020-08-19 12:45:55 +00:00
Adam Gashlin
bed79f9a0a Bug 1639067 part 1 - Open more downloaded file types internally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D86650
2020-08-17 21:24:52 +00:00
Dorel Luca
431b3e2a3a Backed out 4 changesets (bug 1639067) for XPCshell failures in tests/unit/test_getMIMEInfo_pdf.js. CLOSED TREE
Backed out changeset 1e400fafd80b (bug 1639067)
Backed out changeset 7bb3c2ec5c7a (bug 1639067)
Backed out changeset 755fd5771648 (bug 1639067)
Backed out changeset 951e10b7354f (bug 1639067)
2020-08-18 00:18:32 +03:00
Adam Gashlin
4dcd79ed75 Bug 1639067 part 1 - Open more downloaded file types internally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D86650
2020-08-17 19:15:02 +00:00
Gijs Kruitbosch
3cf394511f Bug 1652296 - test that we do not delete files immediately when the user chooses to overwrite for a download, r=mkaply
Depends on D86985

Differential Revision: https://phabricator.services.mozilla.com/D86986
2020-08-14 15:57:47 +00:00
Noemi Erli
ca0e414de8 Bug 1634641 - Skip browser_pdfjs_preview.js in asan builds due to frequent failures. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D82263
2020-07-05 14:44:16 +00:00
Sam Foster
7a6bf11a8c Bug 1649421 - Handle null mimeInfo from a download when populating the context menu. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D81767
2020-07-01 22:27:51 +00:00
Sam Foster
19f6f1121e Bug 1639069 - Add download context menu items to 'Use' and 'Always use' the system viewer to open the download. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D79396
2020-06-25 22:19:37 +00:00
Sam Foster
20a6f91e8b Bug 1639069 - Provide helpers for getting a nsIMIMEInfo on DownloadsCommon, and confirming if a download is a given mime-type. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D79395
2020-06-26 02:34:03 +00:00
Sam Foster
89f45f13cf Bug 1642431 - Default to using a new tab when opening downloaded PDFs in the browser. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D79951
2020-06-18 15:39:37 +00:00
Sam Foster
dbcd872d8e Bug 1638156 - Allow key modifiers to determine how/'where' PDFs are opened when possible. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D75870
2020-05-29 07:16:54 +00:00
Razvan Maries
030be31f02 Backed out 2 changesets (bug 1638156) for perma failures on browser_pdfjs_preview.js. CLOSED TREE
Backed out changeset c5c3da72080f (bug 1638156)
Backed out changeset da0e27f7f17a (bug 1638156)
2020-05-28 05:01:13 +03:00
Sam Foster
0becf30a8f Bug 1638156 - Allow key modifiers to determine how/'where' PDFs are opened when possible. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D75870
2020-05-28 01:13:19 +00:00
Jared Wein
8c256df97e Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-23 16:21:16 +00:00
Mihai Alexandru Michis
4fd7fca091 Backed out changeset 2708f3e553cb (bug 1639606) for causing xpcshell failures in toolkit/components/downloads
CLOSED TREE
2020-05-23 00:26:32 +03:00
Jared Wein
56a9f83c26 Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-22 17:43:57 +00:00
Bogdan Tara
012e35fb3f Backed out changeset ee9c7714e513 (bug 1639606) for browser_download_open_with_internal_handler.js failures CLOSED TREE
DONTBUILD
2020-05-22 07:04:45 +03:00
Jared Wein
19d3c5edea Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-22 02:09:45 +00:00
Sam Foster
13b98b1471 Bug 1191591 - Open downloaded PDFs in pdf.js viewer. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73400
2020-05-18 17:30:26 +00:00
Noemi Erli
80613259fb Backed out 3 changesets (bug 1191591) for causing newtab failures
Backed out changeset bd59c10af492 (bug 1191591)
Backed out changeset 3ff8cc8dd4b7 (bug 1191591)
Backed out changeset c6b3783367f6 (bug 1191591)
2020-05-16 01:57:34 +03:00
Sam Foster
5c2d9e8887 Bug 1191591 - Open downloaded PDFs in pdf.js viewer. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D73400
2020-05-15 20:43:46 +00:00
Edgar Chen
d44563232f Bug 1615732 - Don't show download panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66414
2020-04-06 20:56:19 +00:00
Cosmin Sabou
2b8f829371 Backed out 7 changesets (bug 1615732) for bc failures on browser_ext_pageAction_click_types.js. CLOSED TREE
Backed out changeset 031b8abf43a8 (bug 1615732)
Backed out changeset 297d82b338dc (bug 1615732)
Backed out changeset bbcb173e6c44 (bug 1615732)
Backed out changeset d7c5824d4579 (bug 1615732)
Backed out changeset f648cf0653a7 (bug 1615732)
Backed out changeset fcd441a2a860 (bug 1615732)
Backed out changeset fa861e50f198 (bug 1615732)
2020-04-06 23:49:58 +03:00
Edgar Chen
2df04d111f Bug 1615732 - Don't show download panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66414
2020-03-17 01:03:00 +00:00
Gijs Kruitbosch
b481feca27 Bug 1616152 - avoid race conditions in about:downloads by waiting for downloads to load, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D63414
2020-02-21 15:02:34 +00:00
Gijs Kruitbosch
2d4d076e2c Bug 1609906 - add test for about:downloads so we can't completely break it without noticing, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D63106
2020-02-17 21:12:00 +00:00
Dão Gottwald
91122eb636 Bug 1610497 - Increase browser window min-width so the address bar can be focused by mouse. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D60960
2020-01-30 15:59:29 +00:00
Emma Malysz
ce4da4686b Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751
2019-12-11 00:27:19 +00:00