corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

1040 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
17e422836b Bug 1803010 - Use .value consistently for downloads ui. r=Gijs,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D163312
 2022-11-29 15:14:56 +00:00
Shane Hughes
86ca0e0d70 Bug 1802739 - Fix Downloads panel status label not resetting. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D163173
 2022-11-27 12:14:20 +00:00
lyavor
d8968bf47f Bug 1800453 - Improve Error Message when blocking mixed content downloads. r=freddyb,flod freddyb 
Differential Revision: https://phabricator.services.mozilla.com/D162101
 2022-11-24 08:42:19 +00:00
Mark Banner
e319b56680 Bug 1801809 - Automatically replace Cu.reportError with console.error (places, download). r=mak 
Depends on D162696

Differential Revision: https://phabricator.services.mozilla.com/D162697
 2022-11-22 16:23:38 +00:00
Emilio Cobos Álvarez
a4ea6e43d0 Bug 1801492 - Reset download status descriptions properly. r=dao 
Bug 1801492 changed the behavior here in a way that

  <description value="foo">bar</description>

Shows both "foo" and "bar". This code has multiple l10n ids that do a
mix of innerText vs. value attribute, see:

  https://searchfox.org/mozilla-central/rev/3d01e045479a6e5237958bd9aa8eb64306e1f48a/browser/locales/en-US/browser/downloads.ftl#162-168

That's all a bit sketchy over-all, but in order to support all of them
as is, reset them properly.

Differential Revision: https://phabricator.services.mozilla.com/D162464
 2022-11-21 16:17:25 +00:00
Norisz Fay
01ab1f4bb5 Backed out changeset f8ee92c050f2 (bug 1801492) for causing bc failures on browser_unknownContentType_blob.js CLOSED TREE 2022-11-21 15:15:25 +02:00
Emilio Cobos Álvarez
7b9c28f16b Bug 1801492 - Reset download status descriptions properly. r=dao 
Bug 1801492 changed the behavior here in a way that

  <description value="foo">bar</description>

Shows both "foo" and "bar". This code has multiple l10n ids that do a
mix of innerText vs. value attribute, see:

  https://searchfox.org/mozilla-central/rev/3d01e045479a6e5237958bd9aa8eb64306e1f48a/browser/locales/en-US/browser/downloads.ftl#162-168

That's all a bit sketchy over-all, but in order to support all of them
as is, reset them properly.

Differential Revision: https://phabricator.services.mozilla.com/D162464
 2022-11-21 10:37:21 +00:00
Mark Banner
5d1820b074 Bug 1799314 - Convert consumers of testing modules to import ES modules direct (browser/). r=Gijs,settings-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D161914
 2022-11-17 12:00:30 +00:00
Mike Conley
c759904dae Bug 1797836 - Part 2: Update CUI to have a general TYPE_PANEL instead of TYPE_MENU_PANEL. r=desktop-theme-reviewers,dao,sclements 
Long ago, the menu panel in was a customizable area that users could drag things into.

That changed back around 2017 in bug 1354117 when the Photon redesign was built. The
menu panel become a static menu, but we also made it possible to permanently move things
to the overflow panel of the nav-bar.

It looks like we never updated the area type constant from referring to the old menu panel
though, so it's "TYPE_MENU_PANEL", and registering a node for it happens with
registerMenuPanel. This patch changes to constant to TYPE_PANEL and updates the registration
method to registerPanelNode.

I a check around the codebase as well as GitHub looking to see if there were any
system add-ons or experimental WebExtensions that rely on TYPE_MENU_PANEL / registerMenuPanel,
but I couldn't find any.

Differential Revision: https://phabricator.services.mozilla.com/D161078
 2022-11-08 14:51:40 +00:00
Mark Banner
df52ac2d97 Bug 1798212 - Replace defineModuleGetter in Integration.sys.mjs with a ES version. r=settings-reviewers,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D161014
 2022-11-07 17:56:10 +00:00
Mark Banner
19c189e131 Bug 1798212 - Convert consumers of downloads code to ES modules. r=mak,geckoview-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,sgalich,mconley,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D161013
 2022-11-07 17:56:10 +00:00
Mark Banner
3e15e427bb Bug 1798212 - Convert downloads code to ES modules. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D161012
 2022-11-07 17:56:09 +00:00
Emilio Cobos Álvarez
8eb4bd796d Bug 1795944 - Remove descriptionheightworkaround. r=Gijs 
Stuff wraps properly now with flexbox emulation.

Differential Revision: https://phabricator.services.mozilla.com/D159621
 2022-10-19 11:55:29 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Shane Hughes
34b247cb72 Bug 1742999 - Make DownloadSpamProtection per-window. r=Gijs,mak 
This patch modifies DownloadSpamProtection and DownloadIntegration so
that each window will track blocked spam downloads separately. (Which
shouldn't affect permissions.) When a download is blocked, the helper
app service dispatches a notification, passing the relevant browsing
context and URL to DownloadIntegration. Then it passes the window and
URL to the singleton DownloadSpamProtection. That maps all the windows
to objects that carry the spam download objects. This allows us to only
show blocked spam downloads in the downloads panel of the window from
which they were triggered.

Differential Revision: https://phabricator.services.mozilla.com/D148092
 2022-10-04 22:38:18 +00:00
Andrew McCreight
670df172aa Bug 1792457 - Revert workarounds for weak references to XPCWJS crashes. r=Gijs 
I have fixed the underlying XPConnect issue, so these workarounds should
no longer be needed.

There are also two more in browser/base/content/browser-siteProtections.js
that I have not fixed.

Differential Revision: https://phabricator.services.mozilla.com/D158158
 2022-09-29 11:40:19 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Mark Banner
73631b4520 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 14:40:07 +00:00
Norisz Fay
6008f8d423 Backed out 3 changesets (bug 1789254) for causing bc failures on browser_xpcom_graph_wait.js CLOSED TREE 
Backed out changeset bea1e1ba4a14 (bug 1789254)
Backed out changeset 4086aaa5f3d0 (bug 1789254)
Backed out changeset 131cac1d1146 (bug 1789254)
 2022-09-08 17:14:00 +03:00
Mark Banner
e8c3c1e5b4 Bug 1789254 - Migrate enterprisepolicies consumers to use ESM imports directly. r=mkaply,necko-reviewers,application-update-reviewers,nalexander 
Differential Revision: https://phabricator.services.mozilla.com/D156464
 2022-09-08 12:43:32 +00:00
Emilio Cobos Álvarez
abab9b2db7 Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak 
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
 2022-09-02 20:26:29 +00:00
Butkovits Atila
e4a4a23311 Backed out changeset 368a7ce1b104 (bug 1788273) for causing failures at browser_recently_closed_tabs.js. CLOSED TREE 2022-09-02 16:35:55 +03:00
Emilio Cobos Álvarez
72c00adfaa Bug 1788273 - Tweak popup alignment so that it looks good on mirrored wayland popups. r=dao,mak 
When these panels had arrows, I guess the bottomcenter topleft alignment
made sense so that you could precisely align the arrow, but that's not
what we do now.

Don't use bottomcenter / leftcenter / rightcenter, since we really want
the sides to align.

This shouldn't change behavior on any platform except Linux + Wayland,
where the alignment looks good now in the case of bug 1784876.

Differential Revision: https://phabricator.services.mozilla.com/D156099
 2022-09-02 11:18:54 +00:00
Mathew Hodson
23d098346b Bug 1762444 - Replace setUp tasks with add_setup in browser mochitests. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D150330
 2022-08-29 08:54:54 +00:00
Eemeli Aro
a96b427af3 Bug 1786055 - Drop find keys from editMenuKeys.inc.xhtml. r=mconley 
It would appear that these <key> definitions in editMenuKeys.inc.xhtml
are not actaully used anywhere.

Differential Revision: https://phabricator.services.mozilla.com/D155448
 2022-08-26 16:31:40 +00:00
Mike Kaply
7502caaba1 Bug 1779018 - Use policy to determine if executable files can be launched. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D152195
 2022-08-16 22:32:52 +00:00
Calixte
379358db72 Bug 1778714 - Fix the pdf download link in the All Downloads view r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D151431
 2022-08-08 18:56:24 +00:00
Butkovits Atila
5b38a79427 Backed out changeset 724282da88eb (bug 1778714) for causing failures at browser_library_select_all.js. 2022-08-08 18:14:00 +03:00
Calixte
7428eacbc4 Bug 1778714 - Fix the pdf download link in the All Downloads view r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D151431
 2022-08-08 13:47:55 +00:00
Shane Hughes
a92838525b Bug 1783643 - Don't open downloads panel if window is inactive. r=Gijs 
Since bug 1741076, the downloads panel is already configured not to show
the downloads panel if the top chrome window is inactive. However, this
check doesn't matter if the downloads panel has never been opened before
in the profile (represented by pref browser.download.panel.shown). This
patch changes the check so that if the top window is not active, we
don't show the panel, no matter what.

Differential Revision: https://phabricator.services.mozilla.com/D153334
 2022-08-08 12:15:40 +00:00
Barret Rennie
8b95dddad0 Bug 1776304 - Port osfile.jsm usage to IOUtils in browser/components/downloads r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D150203
 2022-08-04 20:23:05 +00:00
Emilio Cobos Álvarez
2c1499dce8 Bug 1782185 - Fix a typo introduced in bug 1765083. r=Gijs 
I confirmed it's the only one, whoops.

Differential Revision: https://phabricator.services.mozilla.com/D153152
 2022-07-29 09:52:38 +00:00
Mark Banner
cd9bed2e7a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-26 15:11:30 +00:00
smolnar
4cb3dcaaa2 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE 
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
 2022-07-25 21:00:07 +03:00
Mark Banner
bf597b1f3a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-25 12:46:48 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
78524564fc Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-20 15:50:42 +00:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE 
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
 2022-07-20 15:44:53 +03:00
Mark Banner
9cb7e8c83c Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152057
 2022-07-20 10:36:51 +00:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 10:36:49 +00:00
Emilio Cobos Álvarez
0091892fb9 Bug 1779559 - Do this in toolkit instead. r=Gijs 
This simplifies a bit the tabbrowser/tab switcher code, and makes it
work in all windows.

The WPT failures are due to bug 1780212.

Differential Revision: https://phabricator.services.mozilla.com/D151822
 2022-07-19 19:25:48 +00:00
Cristian Tuns
b650749369 Backed out 5 changesets (bug 1779559) for causing wpt failures on unload-bubbles.html CLOSED TREE 
Backed out changeset fbb29df4aa9e (bug 1779559)
Backed out changeset eab896a61170 (bug 1779559)
Backed out changeset 645bdd59bb99 (bug 1779559)
Backed out changeset 23fe4f24d483 (bug 1779559)
Backed out changeset a68a015349ed (bug 1779559)
 2022-07-19 13:27:32 -04:00
Emilio Cobos Álvarez
8807f9dc40 Bug 1779559 - Disable occlusion in another mochitest. 
MANUAL PUSH: Orange fix CLOSED TREE
 2022-07-19 15:44:32 +02:00
Shane Hughes
f41f7c4796 Bug 1739348 - Don't open downloads panel after download dialogs. r=NeilDeakin 
This is a medium sized patch to legacy download construction. It takes
advantage of the new property added in Bug 1762033 to prevent the
downloads panel from being automatically shown when a download is added
after an interaction with the unknown content type dialog or the file
picker dialog. I chose to not do the same for failed transfers since I
thought it might serve some use, but that might be wrong. I don't know
if there's a way to test the dialog that appears when you download an
executable without going through the same path I adjusted with the
patch. It seems like it's covered but I could be wrong. Also add a test
to cover these changes from the bottom up. Thanks and apologies for my
sloppy C++, though I'm sure I'll learn a lot more from the review 😅

Differential Revision: https://phabricator.services.mozilla.com/D145312
 2022-07-18 20:45:41 +00:00
Marco Bonardo
b63a82b2f9 Bug 1743263 - Disable browser_download_spam_protection.js again on Linux 64. r=intermittent-reviewers,jmaher DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D152032
 2022-07-18 16:04:52 +00:00
ui.sayuree
af637533ab Bug 1777147 - remove DownloadsSubview module reference. r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D151862
 2022-07-15 14:28:08 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Barret Rennie
a70c93c344 Bug 1772941 - Port osfile.jsm usage to IOUtils in toolkit/content/ r=florian,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D149303
 2022-07-12 00:25:35 +00:00