corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
766,165 Commits 1 Branch 0 Tags
739b51aee122798f1d049575ff9f0747ca1fdea5
Commit Graph

767 Commits

Author SHA1 Message Date
Micah Tigley
a5ff856247 Bug 1674840 - Add Other Bookmarks folder to toolbar dynamically. r=Gijs,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D99701
 2020-12-17 16:52:35 +00:00
Micah Tigley
04928862eb Bug 1680732 - Call updateNodesVisibility() from 'Show Other Bookmarks' pref observer. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D98777
 2020-12-10 20:42:40 +00:00
Gijs Kruitbosch
144ce9b683 Bug 1678921 - make empty toolbar disclaimer take up no horizontal space, so the entire toolbar functions as a drag target for bookmarks, r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D98546
 2020-12-02 23:38:04 +00:00
Micah Tigley
4709190877 Bug 1678662 - Add a listener to respond to changes when the 'Show Other Bookmarks' pref is changed. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D98397
 2020-12-02 20:00:47 +00:00
Micah Tigley
41687e7f07 Bug 1678659 - Update Fluent strings for bookmarks toolbar submenu. r=jaws,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D98373
 2020-12-01 21:28:58 +00:00
Dão Gottwald
f1cf8c85f6 Bug 1679463 - Replace :not(foo):not(bar) with :not(foo,bar) in browser/. r=ntim 
Differential Revision: https://phabricator.services.mozilla.com/D98028
 2020-11-26 21:54:32 +00:00
Marco Bonardo
5fee7240ed Bug 1677408 - Part 4 - Replace onItemVisited with page-visited. r=Standard8 
Rather than fetching bookmarks from the disk for each page-visited notification,
we just let the result to recursively find and update children in the memory
structure.

Differential Revision: https://phabricator.services.mozilla.com/D97277
 2020-11-23 16:28:04 +00:00
Butkovits Atila
c08d529090 Backed out 7 changesets (bug 1677408) for bustages on nsNavHistory.cpp. CLOSED TREE 
Backed out changeset 1e0dc9aaa979 (bug 1677408)
Backed out changeset 4198bc35198c (bug 1677408)
Backed out changeset ff93f264138b (bug 1677408)
Backed out changeset 0f2d72d2ed5a (bug 1677408)
Backed out changeset 996cbd111957 (bug 1677408)
Backed out changeset b0c23854e117 (bug 1677408)
Backed out changeset f7d6cc5e4457 (bug 1677408)
 2020-11-23 16:49:31 +02:00
Marco Bonardo
ae29233b62 Bug 1677408 - Part 4 - Replace onItemVisited with page-visited. r=Standard8 
Rather than fetching bookmarks from the disk for each page-visited notification,
we just let the result to recursively find and update children in the memory
structure.

Differential Revision: https://phabricator.services.mozilla.com/D97277
 2020-11-23 12:56:40 +00:00
Gijs Kruitbosch
a69698a340 Bug 1667237 - bookmarks toolbar flickers on startup / new windows in some cases, r=florian,jaws 
Differential Revision: https://phabricator.services.mozilla.com/D97712
 2020-11-20 13:22:38 +00:00
Micah Tigley
2218b31ae9 Bug 1674539 - Add option to hide Other Bookmarks button from bookmarks toolbar. r=jaws,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D97211
 2020-11-19 21:49:26 +00:00
Narcis Beleuzu
016b07dbf6 Backed out 2 changesets (bug 1674539) for bc failures on browser_toolbar_other_bookmarks.js . CLOSED TREE 
Backed out changeset 63032f8390ea (bug 1674539)
Backed out changeset 36ab7b9324d9 (bug 1674539)
 2020-11-19 23:46:02 +02:00
Micah Tigley
afe05f330b Bug 1674539 - Add option to hide Other Bookmarks button from bookmarks toolbar. r=jaws,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D97211
 2020-11-19 20:40:04 +00:00
Jared Wein
1cacf7d2fc Bug 1665391 - Add telemetry to measure effectiveness of 2h2020 bookmarks changes. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D97251
 2020-11-19 16:01:25 +00:00
Jared Wein
1aeee18f35 Bug 1674091 - Show and hide the empty bookmarks message if there are visible children in the toolbar. r=Gijs,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D96763
 2020-11-14 01:07:35 +00:00
Jared Wein
c763bedef6 Bug 1674091 - Don't update the state of the Other Bookmarks shortcut folder if the personal-bookmarks item has been placed in the palette. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D96764
 2020-11-14 01:07:28 +00:00
Jared Wein
35a2f81166 Bug 1674091 - Add a getter for the Bookmarks Toolbar in BookmarkingUI. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D96762
 2020-11-14 01:07:28 +00:00
Cosmin Sabou
c02cd339df Backed out 3 changesets (bug 1674091) for bookmarks.jsm bc related failures. 
Backed out changeset b37a366b6bca (bug 1674091)
Backed out changeset 4d49ba20a908 (bug 1674091)
Backed out changeset c2ed373e6fc3 (bug 1674091)
 2020-11-13 02:37:56 +02:00
Jared Wein
63643ae16e Bug 1674091 - Don't update the state of the Other Bookmarks shortcut folder if the personal-bookmarks item has been placed in the palette. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D96764
 2020-11-12 21:23:54 +00:00
Jared Wein
09cc1da1b4 Bug 1674091 - Show and hide the empty bookmarks message if there are visible children in the toolbar. r=Gijs,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D96763
 2020-11-12 21:23:52 +00:00
Jared Wein
890c772341 Bug 1674091 - Add a getter for the Bookmarks Toolbar in BookmarkingUI. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D96762
 2020-11-12 21:23:50 +00:00
Gijs Kruitbosch
8159be9844 Bug 1675551 - ensure we can use the browser.toolbars.bookmarks.2h2020 pref for experiments and enable it on early beta, r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D96709
 2020-11-11 15:36:00 +00:00
Jared Wein
721fa81844 Bug 1674199 - Remove the special case of showing the bookmarks toolbar on about:blank if NTP is disabled. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D95196
 2020-11-10 04:18:47 +00:00
Gijs Kruitbosch
dffaa65a4a Bug 1674515 - show the bookmarks toolbar when creating a bookmark there, r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D96329
 2020-11-09 23:16:56 +00:00
Csoregi Natalia
6a0cdbf039 Backed out changeset ca520bfdc084 (bug 1674515) for failures on browser_autoshow_bookmarks_toolbar.js. CLOSED TREE 2020-11-09 19:32:08 +02:00
Gijs Kruitbosch
f6a60b989e Bug 1674515 - show the bookmarks toolbar when creating a bookmark there, r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D96329
 2020-11-09 16:00:29 +00:00
Gijs Kruitbosch
0a0c86d14c Bug 1432604 - use the last-used folder for new bookmarks, r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D94880
 2020-11-05 21:08:10 +00:00
Gijs Kruitbosch
452154d8d1 Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D94879
 2020-11-05 21:08:09 +00:00
Gijs Kruitbosch
13baffef64 Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws 
This adds a pref containing a parent GUID, a lazy pref getter that validates
that GUID (asynchronously), and starts using the pref from the
PlacesCommandHook.

It also sets the future default (toolbar) into firefox.js, and overrides
that on the default branch when the new 2020 bookmarks pref is not set.

Finally, it sets the pref to the unfiled default for existing profiles
with a migration. If we end up delaying shipping, we'll need to
update that migration - but I don't see a way around that.

Differential Revision: https://phabricator.services.mozilla.com/D94500
 2020-11-05 21:08:40 +00:00
Jared Wein
328aa2d63d Bug 1674160 - Don't show the bookmarks toolbar if there are no visible toolbarbuttons or toolbaritems. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D95539
 2020-11-05 23:00:55 +00:00
Jared Wein
84ba59a4bb Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs 
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
 2020-11-05 23:00:47 +00:00
Narcis Beleuzu
f5b44dd87b Backed out 4 changesets (bug 1425290, bug 1432604, bug 1665389) for bc failures on browser_bookmarkProperties_addKeywordForThisSearch.js . CLOSED TREE 
Backed out changeset 455ff5647429 (bug 1432604)
Backed out changeset cf70da964b70 (bug 1425290)
Backed out changeset e6b38d403cc3 (bug 1425290)
Backed out changeset 09f049232773 (bug 1665389)
 2020-11-05 23:01:31 +02:00
Narcis Beleuzu
479647874f Backed out 2 changesets (bug 1674160, bug 1003364) for bc failures on browser_bookmarks_toolbar_context_menu_view_options.js 
Backed out changeset b4ffebacc1b8 (bug 1674160)
Backed out changeset bfe8bc960f45 (bug 1003364)
 2020-11-05 22:55:59 +02:00
Gijs Kruitbosch
393befad12 Bug 1432604 - use the last-used folder for new bookmarks, r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D94880
 2020-11-04 23:43:05 +00:00
Gijs Kruitbosch
e0585a1ea6 Bug 1425290 - use the new default bookmark location pref for 'bookmark this link' and 'bookmark this frame', r=mak 
Differential Revision: https://phabricator.services.mozilla.com/D94879
 2020-11-04 23:24:35 +00:00
Gijs Kruitbosch
9bcce69d4a Bug 1665389 - create bookmarks on the toolbar by default, r=mak,jaws 
This adds a pref containing a parent GUID, a lazy pref getter that validates
that GUID (asynchronously), and starts using the pref from the
PlacesCommandHook.

It also sets the future default (toolbar) into firefox.js, and overrides
that on the default branch when the new 2020 bookmarks pref is not set.

Finally, it sets the pref to the unfiled default for existing profiles
with a migration. If we end up delaying shipping, we'll need to
update that migration - but I don't see a way around that.

Differential Revision: https://phabricator.services.mozilla.com/D94500
 2020-11-04 23:24:27 +00:00
Jared Wein
29eb64dd87 Bug 1674160 - Don't show the bookmarks toolbar if there are no visible toolbarbuttons or toolbaritems. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D95539
 2020-11-05 19:10:29 +00:00
Jared Wein
76c6dfa789 Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs 
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
 2020-11-05 19:09:18 +00:00
Jared Wein
7d0327cac7 Bug 1673403 - Show the Bookmarks Toolbar in customize mode as long as it's not set to Never show. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D95777
 2020-11-04 17:11:26 +00:00
Jared Wein
e21dfc685f Bug 1672792 - Indicate shortcuts key to Alt > View > Toolbars > Bookmarks Toolbar menu. r=mtigley 
Differential Revision: https://phabricator.services.mozilla.com/D95805
 2020-11-04 16:23:55 +00:00
Razvan Maries
038da7739d Backed out changeset e52abe08f115 (bug 1673403) for multiple bc perma failures. CLOSED TREE 2020-11-04 01:36:06 +02:00
Jared Wein
0efb8a4c3d Bug 1673403 - Show the Bookmarks Toolbar in customize mode as long as it's not set to Never show. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D95777
 2020-11-03 22:26:41 +00:00
Jared Wein
96d7520ba9 Bug 1675040 - Don't show the Other Bookmarks folder if the user has moved the Personal Bookmarks item out of the Bookmarks Toolbar. r=mtigley 
Differential Revision: https://phabricator.services.mozilla.com/D95761
 2020-11-03 21:53:09 +00:00
Gijs Kruitbosch
0e50958317 Bug 1673566 - use radio items for the bookmarks toolbar toggle UI, r=mtigley 
Differential Revision: https://phabricator.services.mozilla.com/D95319
 2020-10-30 17:41:23 +00:00
Micah Tigley
a9a0aa5aea Bug 1664053 - Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D93698
 2020-10-28 22:37:51 +00:00
Jared Wein
f2c443a65c Bug 1673402 - Don't show the bookmarks toolbar on the new tab page if there are no contents. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D94775
 2020-10-27 18:23:31 +00:00
Dorel Luca
b959dcf2b1 Backed out 2 changesets (bug 1664053) for Browser-chrome failures. CLOSED TREE 
Backed out changeset 7ead316c420d (bug 1664053)
Backed out changeset 7ae93e1c8b86 (bug 1664053)
 2020-10-26 20:08:38 +02:00
Micah Tigley
2171053b5c Bug 1664053 - Show 'Other Bookmarks' folder in bookmarks toolbar. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D93698
 2020-10-22 02:04:24 +00:00
Jared Wein
64176c986d Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers,marionette-reviewers,whimboo 
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
 2020-10-26 02:32:07 +00:00
Mihai Alexandru Michis
dc6c624799 Backed out changeset ba261cf25651 (bug 727668) for causing marionette failures in test_screenshot.py 
CLOSED TREE
 2020-10-22 06:13:54 +03:00