Commit Graph

43 Commits

Author SHA1 Message Date
Jonas Allmann
245381a9bb Bug 1529231, Remove all occurences of ondialogaccept and ondialogcancel, r=Gijs
Removed all occurences of ondialogaccept.
Removed all occurences of ondialogcancel.
Replaced all removed attributes with event handlers.

Differential Revision: https://phabricator.services.mozilla.com/D21227
2019-03-26 18:34:02 +00:00
Jonas Allmann
ef12b8cb90 Bug 1525636, Replace ondialogextra1 and ondialogextra2 attributes with event handlers, r=Gijs
Remove all occurences of the above mentioned attributes and replace them by event handlers.
Minor changes to consuming functions to preserve functionality.

Differential Revision: https://phabricator.services.mozilla.com/D20368
2019-02-20 11:11:31 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Jared Wein
0c36c76bb7 Bug 1523126 - Dialogs that use Fluent for localizing the dialog buttons need to wait for the buttons to be translated before sizing to content. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D17758
2019-01-26 23:23:15 +00:00
cowlesni
2907f7fcc3 Bug 1517529 - Migrate safeMode dialog to Fluent for localization, r=Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D16987
2019-01-21 21:51:10 +00:00
Marco Castelluccio
4beb0fd8c7 Bug 1436425 - Stop importing resetProfile.js when it is unneeded. r=MattN 2018-02-07 13:08:55 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Mark Banner
1b6f3efb6e Bug 1352969 - Fix various ESLint no-undef issues in browser/base (no-undef is not enabled yet). r=mossop
MozReview-Commit-ID: BuTyJAfUoWR
2017-02-22 17:02:59 +00:00
Mark Banner
6b3a6a4cda Bug 1313998 - Turn on no-unused-vars for local variable scopes in browser/base/content. r=mossop
MozReview-Commit-ID: IyFGBotfd11
2016-10-31 10:33:38 +00:00
Jared Wein
99638e1465 Bug 1294621 - Enable the no-lonely-if rule for eslint. r=gijs
MozReview-Commit-ID: 8izEqc8IyCu
2016-08-12 11:50:35 -04:00
Jared Wein
ebf1ccbe46 Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh
2016-08-03 18:54:59 -04:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Mark Hammond
4f82da56ce Bug 1063702 - Update all Reset Firefox strings and relevant UI to new UX requirements. r=MattN 2014-10-11 12:37:16 +11:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Matthew Noorenberghe
1a6fa27edf Bug 894188 - "resetSupported is not defined" in safe mode dialog. r=jaws 2013-07-15 21:09:00 -07:00
Andres Hernandez
e80b022632 Bug 325901 - fix unnecessarily preprocessed files in browser/, r=gavin 2012-08-10 14:20:25 -06:00
Matthew Noorenberghe
872c582755 Bug 732303 - Redesign safe mode dialog with the profile reset option. r=dolske, ui-r=limi 2012-03-09 15:21:03 -08:00
Gervase Markham
cb6a072c2a Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Matthew Noorenberghe
f9b32440f4 Bug 294260 - Safe Mode: Auto detect previous start-up failure and offer to start in safe mode r=bsmedberg,Mossop 2011-11-07 21:20:42 -08:00
Marco Castelluccio
cfafc81143 Bug 521264 - Don't use file.exists() when not necessary - browser/base part; r=dietrich 2011-08-30 22:45:31 +01:00
Dave Townsend
1b0945bd12 Bug 600068: Safe mode dialog doesn't always disable all add-ons. r=gavin, a=blocks-betaN 2010-10-11 09:34:28 -07:00
Asaf Romano
d7fc06d9d1 Bug 575157 - Safe Mode's "Disable All Add-Ons" Has No Effect. r=mossop 2010-07-01 00:36:29 +02:00
Dão Gottwald
01ab32f2dd Bug 527417 - nsIPluginHost::getPluginTags aPluginCount out param should be optional. r=josh 2009-11-09 22:11:58 +01:00
Dão Gottwald
37102a6574 Bug 526987 - getItemList, getIncompatibleItemList, getDependentItemListForID and updateAndGetNewBlocklistedItems itemCount out params should be optional. r=dtownsend 2009-11-07 09:21:07 +01:00
Gijs Kruitbosch
481a49d458 Back out bug 487059, fix tests and EM to cope, r=gavin,beltzner, bug 524995 2009-10-29 14:44:10 +01:00
Tyler Downer
3a88e56ef7 Bug 503457 - Change "Reset bookmarks to Firefox defaults" to "Delete all bookmarks except for backups". r=rstrong, ui-r=boriss 2009-07-31 14:49:58 +02:00
Dão Gottwald
2d53b25d70 Bug 487059 - clearUserPref shouldn't throw if a pref doesn't have a default or user value. r+sr=bsedberg 2009-04-10 10:24:24 +02:00
Dave Townsend
736a1c7b86 Bug 409959: Safe mode option to disable all add-ons doesn't disable plugins. r=gavin 2008-07-11 21:11:59 +01:00
f9516b7176 Bug 392140 - Remove TYPE_PLUGIN from the extension manager. r=bsmedberg 2007-08-16 14:14:51 -07:00
58a0dfca5d Bug 364297: add a new per-profile default-pref directory and associated directory service keys, and a way to trigger pref service default pref reloading to facilitate the change of default prefs without affecting exisiting users, r=mconnor, sr=bsmedberg 2007-05-02 13:13:33 -07:00
gavin@gavinsharp.com
c694502934 Bug 334486: Ability to restore shipped search engines after they've been removed, patch by Michael Wu <michael.wu@mozilla.com>, r=mconnor 2006-07-05 19:09:38 +00:00
mozilla.mano@sent.com
cadc283b41 Bug 311496 - Safe Mode UI: 'Make Changes and Restart' button should be disabled if no action is checked, r=mconnor. 2006-06-10 14:10:27 +00:00
gavin@gavinsharp.com
780019a43c Bug 311015: add option to permanently disable all addons and revert to the default theme when launched in safe mode, r=mconnor, r=rob_strong 2006-05-29 15:29:37 +00:00
gavin@gavinsharp.com
10dc437287 fix whitespace to sync branch/trunk 2006-02-24 01:29:51 +00:00
bsmedberg@covad.net
58be2befdc Bug 311503 - Safe mode should offer "cancel" option (now named "Exit") r=mconnor/beltzner 2005-10-12 00:29:11 +00:00
mconnor@steelgryphon.com
115867ba7d bug 304403 - better safe mode UE, part 2, r=bsmedberg 2005-10-04 05:02:47 +00:00
gerv@gerv.net
5ce3368933 Bug 236613: change to MPL/LGPL/GPL tri-license. 2005-09-13 18:40:56 +00:00
mconnor@steelgryphon.com
1b18cf5f47 bug 304403 - better safe mode UE, part 1, a=chase 2005-08-12 07:01:09 +00:00