Commit Graph

176 Commits

Author SHA1 Message Date
Nipun Shukla
9044371423 Bug 1794159 - Part 3: Enable MSIX pinning in nsWindowsShellService r=nrishel,nalexander,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217763
2024-08-12 17:05:48 +00:00
pstanciu
4aef4243c2 Backed out 3 changesets (bug 1794159) for causing bc failures on browser_browserGlue_telemetry.js CLOSED TREE
Backed out changeset 764e14e5df4a (bug 1794159)
Backed out changeset 76b8d6cebe8b (bug 1794159)
Backed out changeset f28a29199ba8 (bug 1794159)
2024-08-08 11:16:27 +03:00
Nipun Shukla
9f77b85299 Bug 1794159 - Part 3: Enable MSIX pinning in nsWindowsShellService r=nrishel,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D217763
2024-08-08 02:48:50 +00:00
Nipun Shukla
5d442069c0 Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-08-07 13:12:20 +00:00
Stanca Serban
973a3fec8c Backed out changeset 0218b28ab8ed (bug 1904436) for crashes related to taskbar pinning. a=backout 2024-07-25 17:28:14 +03:00
Nipun Shukla
627adad1af Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-07-24 18:40:33 +00:00
Norisz Fay
d75ebb2a50 Backed out changeset d06c14636494 (bug 1904436) as requested for crashes related to Windows pinning to taskbar CLOSED TREE 2024-07-10 22:27:46 +03:00
Nipun Shukla
34c75b3d57 Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-07-09 19:23:19 +00:00
Nipun Shukla
289ec4a1dd Bug 1898094 - Implemented Windows Start Menu pinning APIs in nsIWindowsShellService r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D211114
2024-07-09 19:13:47 +00:00
Nicholas Rishel
c38ebcec1e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D210247
2024-05-21 02:37:10 +00:00
Sandor Molnar
0f4b2c2a80 Backed out changeset 6c952a8ea651 (bug 1894865) for causing build bustages @ browser/components/shell/nsWindowsShellServiceInternal.h CLOSED TREE 2024-05-20 22:06:06 +03:00
Nicholas Rishel
2e90f2e33e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D210247
2024-05-20 18:49:11 +00:00
Nipun Shukla
8fa18f7f5e Bug 1895744 - Implemented WRL StartupTask for MSIX launch on login r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D209718
2024-05-15 15:34:42 +00:00
Tamas Szentpeteri
833395877b Backed out 2 changesets (bug 1893341, bug 1895744) for causing bc failures in browser_windows_launch_on_login_msix.js. CLOSED TREE
Backed out changeset ce5384469c24 (bug 1893341)
Backed out changeset 658645fa9303 (bug 1895744)
2024-05-15 11:24:17 +03:00
Nipun Shukla
51e5f06d08 Bug 1895744 - Implemented WRL StartupTask for MSIX launch on login r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D209718
2024-05-15 02:54:55 +00:00
Butkovits Atila
99d0c239a5 Backed out 2 changesets (bug 1893458, bug 1890634) for causing bustages at TaskbarPinningMetricsTests.cpp. CLOSED TREE
Backed out changeset 29ad5906bfb0 (bug 1890634)
Backed out changeset bfcfe75b775a (bug 1893458)
2024-05-02 00:22:14 +03:00
Michael Hughes
92c041d105 Bug 1890634 - add telemetry for tab pinning r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D207789
2024-05-01 17:11:53 +00:00
Michael Hughes
e8f6c31e3d Bug 1893458 - attempt to fix tab pinning not working sometimes on the first time r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D208669
2024-05-01 17:11:53 +00:00
Cristian Tuns
c784fd60cd Backed out 2 changesets (bug 1893458, bug 1890634) build bustages in Windows11TaskbarPinning.cpp CLOSED TREE
Backed out changeset fb9d21d9a3f9 (bug 1890634)
Backed out changeset 2a32d2f7aa06 (bug 1893458)
2024-04-29 14:01:41 -04:00
Michael Hughes
2ebe6702e6 Bug 1890634 - add telemetry for tab pinning r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D207789
2024-04-29 17:06:08 +00:00
Michael Hughes
1cfd97def2 Bug 1893458 - attempt to fix tab pinning not working sometimes on the first time r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D208669
2024-04-29 17:06:07 +00:00
Michael Hughes
3cdd7caa11 Bug 1879975 - Newer versions of Windows disable pinning to the taskbar using older methods r=mpohle,bhearsum,nrishel,glandium,nalexander
This is adding in the new Windows 11 only version of taskbar pinning. For the new pinning to work, we need to use limited access feature tokens. Those are going to be made private and aren't included with this change.
This change will compile, and will work if built against the correct limited access feature tokens, as specified in developer local machine config files, but for every other build, the new taskbar pinning won't work and will fall back to the old methods.
I will implement the try / release building machines using the secret limited access feature tokens in a follow-up diff.

Differential Revision: https://phabricator.services.mozilla.com/D205004
2024-04-22 23:07:37 +00:00
Aron Cseh
f54720ca9c Backed out 4 changesets (bug 1879975) for causing l10n bustages CLOSED TREE
Backed out changeset 280d7a1f6adc (bug 1879975)
Backed out changeset 5f362eae55c5 (bug 1879975)
Backed out changeset cfc40111608f (bug 1879975)
Backed out changeset af2eee38668d (bug 1879975)
2024-04-18 16:41:31 +03:00
Michael Hughes
9acb5439c1 Bug 1879975 - Newer versions of Windows disable pinning to the taskbar using older methods r=mpohle,bhearsum,nrishel,glandium
This is adding in the new Windows 11 only version of taskbar pinning. For the new pinning to work, we need to use limited access feature tokens. Those are going to be made private and aren't included with this change.
This change will compile, and will work if built against the correct limited access feature tokens, as specified in developer local machine config files, but for every other build, the new taskbar pinning won't work and will fall back to the old methods.
I will implement the try / release building machines using the secret limited access feature tokens in a follow-up diff.

Differential Revision: https://phabricator.services.mozilla.com/D205004
2024-04-17 17:51:58 +00:00
Cristina Horotan
97caeefa9b Backed out 3 changesets (bug 1879975) for causing Valgrind failure. CLOSED TREE
Backed out changeset 5eee9358d22a (bug 1879975)
Backed out changeset d9a53dc2478c (bug 1879975)
Backed out changeset e04956da20c6 (bug 1879975)
2024-04-17 04:03:42 +03:00
Michael Hughes
b3d5513f8f Bug 1879975 - Newer versions of Windows disable pinning to the taskbar using older methods r=mpohle,bhearsum,nrishel,glandium
This is adding in the new Windows 11 only version of taskbar pinning. For the new pinning to work, we need to use limited access feature tokens. Those are going to be made private and aren't included with this change.
This change will compile, and will work if built against the correct limited access feature tokens, as specified in developer local machine config files, but for every other build, the new taskbar pinning won't work and will fall back to the old methods.
I will implement the try / release building machines using the secret limited access feature tokens in a follow-up diff.

Differential Revision: https://phabricator.services.mozilla.com/D205004
2024-04-16 23:21:24 +00:00
Natalia Csoregi
c300e2cb7e Backed out 3 changesets (bug 1879975) for causing bustage while fetching windows-laf-tokens.data CLOSED TREE
Backed out changeset 5e5bc998487f (bug 1879975)
Backed out changeset be268309f0f7 (bug 1879975)
Backed out changeset b2f6d0289dc6 (bug 1879975)
2024-04-12 23:55:45 +03:00
Michael Hughes
9694eff990 Bug 1879975 - Newer versions of Windows disable pinning to the taskbar using older methods r=mpohle,bhearsum,nrishel,glandium
This is adding in the new Windows 11 only version of taskbar pinning. For the new pinning to work, we need to use limited access feature tokens. Those are going to be made private and aren't included with this change.
This change will compile, and will work if built against the correct limited access feature tokens, as specified in developer local machine config files, but for every other build, the new taskbar pinning won't work and will fall back to the old methods.
I will implement the try / release building machines using the secret limited access feature tokens in a follow-up diff.

Differential Revision: https://phabricator.services.mozilla.com/D205004
2024-04-12 20:19:10 +00:00
Sandor Molnar
910a3e9301 Backed out 3 changesets (bug 1879975) for causing build bustages @ browser/components/shell/Windows11LimitedAccessFeatures.h CLOSED TREE
Backed out changeset 59dafb79d2be (bug 1879975)
Backed out changeset e51e76ec89c5 (bug 1879975)
Backed out changeset 9bcec32fe1ac (bug 1879975)
2024-04-11 00:41:59 +03:00
Michael Hughes
4a6f7586b4 Bug 1879975 - Newer versions of Windows disable pinning to the taskbar using older methods r=mpohle,bhearsum,nrishel
This is adding in the new Windows 11 only version of taskbar pinning. For the new pinning to work, we need to use limited access feature tokens. Those are going to be made private and aren't included with this change.
This change will compile, and will work if built against the correct limited access feature tokens, as specified in developer local machine config files, but for every other build, the new taskbar pinning won't work and will fall back to the old methods.
I will implement the try / release building machines using the secret limited access feature tokens in a follow-up diff.

Differential Revision: https://phabricator.services.mozilla.com/D205004
2024-04-10 21:17:20 +00:00
Natalia Csoregi
5a1ef8dfcb Backed out 3 changesets (bug 1879975) for causing valgrind bustages. CLOSED TREE
Backed out changeset e66749b7e244 (bug 1879975)
Backed out changeset c3ab151d75bd (bug 1879975)
Backed out changeset f9aa23ba9fde (bug 1879975)
2024-04-10 10:13:21 +03:00
Michael Hughes
406e488c90 Bug 1879975 - Newer versions of Windows disable pinning to the taskbar using older methods r=mpohle,bhearsum,nrishel
This is adding in the new Windows 11 only version of taskbar pinning. For the new pinning to work, we need to use limited access feature tokens. Those are going to be made private and aren't included with this change.
This change will compile, and will work if built against the correct limited access feature tokens, as specified in developer local machine config files, but for every other build, the new taskbar pinning won't work and will fall back to the old methods.
I will implement the try / release building machines using the secret limited access feature tokens in a follow-up diff.

Differential Revision: https://phabricator.services.mozilla.com/D205004
2024-04-10 05:19:20 +00:00
Michael Hughes
0708cf0525 Bug 1863636 - mochi tests for filename validation to prevent callers of new functions from creating bad file paths r=nshukla,gstoll
Added in mochi tests to validate that the C++ filename validation for taskbar tab shortcut paths works.

Differential Revision: https://phabricator.services.mozilla.com/D199689
2024-01-29 22:26:21 +00:00
Michael Hughes
93d767ccf4 Bug 1863636 - adding filename validation to prevent callers of new functions from creating bad file paths r=nshukla,gstoll
As per comments on this diff about getTaskbarTabShortcutPath () I added validation on the C++ side to ensure that the shortcut name passed in can be used as a filename. Tested the changes in the browser console window and confirmed that regular names "abcd" work and confirmed that bad names ("..\\something", ".\\s", ".s", "some?") failed and generated an exception in Javascript.

Differential Revision: https://phabricator.services.mozilla.com/D199590
2024-01-26 00:10:40 +00:00
Nipun Shukla
21b3aee479 Bug 1863636 - Part 2: Added native code changes for taskbar tabs r=win-reviewers,mhughes,gstoll
Differential Revision: https://phabricator.services.mozilla.com/D197342
2024-01-22 22:00:13 +00:00
Narcis Beleuzu
f9b3d057ab Backed out changeset f83bd0235854 (bug 1863636) for causing Bug 1875554 2024-01-22 12:52:17 +02:00
Nipun Shukla
42f11d9ee3 Bug 1863636 - Part 2: Added native code changes for taskbar tabs r=win-reviewers,mhughes,gstoll
Differential Revision: https://phabricator.services.mozilla.com/D197342
2024-01-19 20:58:16 +00:00
Nipun Shukla
1c8adb5195 Bug 1872543 - Fixed tab freeze due to getLaunchOnLoginShortcuts r=nalexander,mhughes
Differential Revision: https://phabricator.services.mozilla.com/D197590
2024-01-03 22:59:55 +00:00
Nipun Shukla
b211acfaed Bug 1870852 - Fixed about:welcome pinning regression r=mhughes
Differential Revision: https://phabricator.services.mozilla.com/D196897
2023-12-20 18:13:30 +00:00
Nipun Shukla
dd8b73c28c Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191763
2023-12-12 00:22:08 +00:00
Sandor Molnar
2313150db4 Backed out changeset 677c3005fd69 (bug 1860271) for causing node newtab failures at browser/components/newtab CLOSED TREE 2023-12-11 23:31:08 +02:00
Nipun Shukla
c334dcfcd7 Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191763
2023-12-11 20:59:45 +00:00
Nipun Shukla
12d6b22518 Bug 1863636 - Folded shortcut creation required for taskbar tabs into nsWindowsShellService r=mhughes
Differential Revision: https://phabricator.services.mozilla.com/D192998
2023-11-20 16:26:03 +00:00
Nick Alexander
5a2079d68e Bug 1818418 - Use reg.exe to implement MSIX 1-click set-to-default. r=mhughes
This approach uses `reg.exe` to delete and recreate the relevant HKCU
registry key-value pairs.

Differential Revision: https://phabricator.services.mozilla.com/D170717
2023-11-04 22:58:30 +00:00
Noemi Erli
41830fefad Backed out changeset 45ab2db62a65 (bug 1818418) for causing bustages in WindowsUserChoice.h 2023-11-04 11:07:26 +02:00
Nick Alexander
028ad01c21 Bug 1818418 - Use reg.exe to implement MSIX 1-click set-to-default. r=mhughes
This approach uses `reg.exe` to delete and recreate the relevant HKCU
registry key-value pairs.

Differential Revision: https://phabricator.services.mozilla.com/D170717
2023-11-04 02:49:46 +00:00
Butkovits Atila
5ebcfd01ff Backed out changeset e0f1fa408c70 (bug 1818418) for causing bustages at WindowsUserChoice.cpp. CLOSED TREE 2023-11-04 02:00:16 +02:00
Nick Alexander
644f3b8048 Bug 1818418 - Use reg.exe to implement MSIX 1-click set-to-default. r=mhughes
This approach uses `reg.exe` to delete and recreate the relevant HKCU
registry key-value pairs.

Differential Revision: https://phabricator.services.mozilla.com/D170717
2023-11-03 22:48:57 +00:00
Masatoshi Kimura
c2dc436126 Bug 1845057 - Remove aClaimAllTypes from setDefaultBrowser. r=nrishel,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189678
2023-10-02 16:56:42 +00:00
Masatoshi Kimura
f90f9c3b98 Bug 1844908 - Remove pre-Win10-specific codepath from browser/components/shell/. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D184288
2023-07-26 08:52:50 +00:00