Commit Graph

329 Commits

Author SHA1 Message Date
Jonathan Sudiaman
70919ebe73 Bug 1944016 - Add new strings to tab context menu for switching to/from vertical tabs r=sidebar-reviewers,fluent-reviewers,tabbrowser-reviewers,dao,bolsson,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D236035
2025-01-29 23:29:40 +00:00
Dão Gottwald
b377e92246 Bug 1944643 - Dispatch event when saving and closing a group. r=dwalker,tabbrowser-reviewers,omc-reviewers,emcminn
Note that in order to support the callout, we want to dispatch this only when picking "save and close" from the menu.

Differential Revision: https://phabricator.services.mozilla.com/D236020
2025-01-29 19:09:19 +00:00
Dão Gottwald
a49bb76e1e Bug 1932489: Drag/drop based on "element index" instead of tab index. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D234804
2025-01-29 18:37:29 +00:00
DJ
8d61f15c5c Bug 1943032 - Localize tabgroup aria-label and description. r=dao,fluent-reviewers,tabbrowser-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D235640
2025-01-28 14:51:28 +00:00
Dão Gottwald
5e253e3ce8 Bug 1944083 - Clicking outside the tab group create panel should keep the new group. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D235667
2025-01-28 11:39:14 +00:00
Butkovits Atila
b76f85c5bf Backed out changeset 8fc3326bce7f (bug 1943032) for causing failures at browser_tab_groups_a11y.js. CLOSED TREE 2025-01-28 07:57:01 +02:00
DJ
c120fd16a2 Bug 1943032 - Localize tabgroup aria-label and description. r=dao,fluent-reviewers,tabbrowser-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D235640
2025-01-28 04:44:31 +00:00
Dão Gottwald
6f30f874cf Bug 1940269 - Place a "Show more" button in tab overflow menu in tab groups section if there's more than 6 tab groups. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D235422
2025-01-25 00:49:15 +00:00
Dão Gottwald
f32e1c5b18 Bug 1943635 - Set tooltips on color options in the tab group panel. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D235464
2025-01-24 23:27:41 +00:00
Emilio Cobos Álvarez
77261b9adc Bug 1943301 - Simplify tab throbber animation syncing. r=dao,tabbrowser-reviewers
We just need to make sure all the throbber animations share a start
time, and we can use an arbitrary time (i.e., zero) rather than going
through all the tabs.

Differential Revision: https://phabricator.services.mozilla.com/D235300
2025-01-23 15:02:01 +00:00
Dão Gottwald
ff3720f743 Bug 1942170 - Properly label tab group color radio buttons. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D234965
2025-01-22 12:45:40 +00:00
Jeremy Swinarton
4c0ff4a071 Bug 1940752: 'Reopen Closed Tab' tab context menu, and other paths calling undoCloseTab, support tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234680
2025-01-21 23:07:02 +00:00
Dão Gottwald
f88b753dc2 Bug 1942156 - Fix tab group dialog's role and name. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234954
2025-01-21 15:23:55 +00:00
Dão Gottwald
44026bd308 Bug 1921034 - Remove bug reference. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D234949
2025-01-21 12:45:36 +00:00
Dão Gottwald
c4a94bbaa7 Bug 1942176 - Handle context menu key for tab group labels, r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D234668
2025-01-20 15:25:23 +00:00
DJ
857429c48c Bug 1937856 - prevent saving tab groups with only discarded tabs. r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234505
2025-01-17 14:46:24 +00:00
Shane Hughes
65116b6a5c Bug 1941391 - Check for popups before opening tab preview panel. r=dao,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234085
2025-01-17 14:32:44 +00:00
Dão Gottwald
602f317a6a Bug 1941645 - Stop scrolling to the selected tab when collapsing/expanding a group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234326
2025-01-17 11:48:38 +00:00
Greg Stoll
96e0daa1a5 Bug 1926396 - when unloading current tab, don't switch to an unloaded tab r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D234569
2025-01-16 19:53:09 +00:00
Dão Gottwald
6892d26869 Bug 1941830 - In the all tabs menu, sort open groups by last accessed time. r=tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D234353
2025-01-16 04:24:52 +00:00
Kelly Cochrane
f9046ef713 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-16 01:40:47 +00:00
Alexandru Marc
402a01520a Backed out changeset 2821188eb89d (bug 1921060) for causing multiple failures 2025-01-16 02:25:14 +02:00
Kelly Cochrane
a876cd0373 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-15 23:07:45 +00:00
Nikki Sharpley
4132fa94c6 Bug 1932347 - Adjust positioning of tab preview for vertical tabs r=tabbrowser-reviewers,dwalker
Previous patch was slightly off in Nightly. Opt for 3px offset instead.

Differential Revision: https://phabricator.services.mozilla.com/D234205
2025-01-14 18:07:52 +00:00
Dão Gottwald
027c8b5a85 Bug 1927927 - Make moving a tab to a group via the tab context menu activate the group's window. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D234173
2025-01-14 15:55:47 +00:00
Nikki Sharpley
ec1812e2e7 Bug 1932347 - Adjust vertical tab preview positioning r=tabbrowser-reviewers,dwalker
Differential Revision: https://phabricator.services.mozilla.com/D233266
2025-01-13 19:36:27 +00:00
Stanca Serban
9e9507fcbb Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js. 2025-01-13 21:35:03 +02:00
Kelly Cochrane
50f355f8ec Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D231182
2025-01-13 17:55:32 +00:00
Dão Gottwald
9dc9702c7e Bug 1940545 - Prevent empty tooltip on unnamed tab groups. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233666
2025-01-10 14:23:19 +00:00
Stephen Thompson
86ccb78df7 Bug 1939503 - create context menus for tab groups in tab overflow menu r=dao,fluent-reviewers,tabbrowser-reviewers
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group

Differential Revision: https://phabricator.services.mozilla.com/D233129
2025-01-09 20:07:00 +00:00
Dão Gottwald
83741f2f76 Bug 1940740 - Dispatch event when accepting the tab group creation panel. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233663
2025-01-09 14:58:03 +00:00
Dão Gottwald
a5e0177580 Bug 1940444 - Uncaught TypeError: can't access property "pinned", middleTab is undefined when attemtping to drag multiple discontinuous tabs while there's a collapsed tab group. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233495
2025-01-08 16:22:11 +00:00
Butkovits Atila
d7afe8c2aa Backed out changeset 0edde29b2e70 (bug 1939503) for causing failures at browser_tab_manager_groups.js. CLOSED TREE 2025-01-08 05:43:29 +02:00
Stephen Thompson
607c9a5cec Bug 1939503 - create context menus for tab groups in tab overflow menu r=dao,fluent-reviewers,tabbrowser-reviewers
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group

Differential Revision: https://phabricator.services.mozilla.com/D233129
2025-01-08 02:47:03 +00:00
Dão Gottwald
206b27689c Bug 1939593 - Unbreak ::first-letter for tab group labels. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D233347
2025-01-07 14:18:48 +00:00
Dão Gottwald
048a7a56f8 Bug 1940041 - Fix typo. r=tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D233271
2025-01-06 19:27:45 +00:00
Stephen Thompson
b41097f455 Bug 1933309 - arrow keys should select tabs and tab group labels in the tab strip r=dao,tabbrowser-reviewers
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D233016
2025-01-06 17:08:03 +00:00
Mauro B
35bae9ed07 Bug 1921951 - Fixed linter errors. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233208
2025-01-04 12:48:45 +00:00
Mauro B
dea2dbc861 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233205
2025-01-04 12:48:45 +00:00
Narcis Beleuzu
884122ae28 Backed out changeset 5ddfa4c882b5 (bug 1921951) for lint failures on tabs.js . CLOSED TREE 2025-01-04 02:05:03 +02:00
Mauro B
1cae811100 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233205
2025-01-03 23:24:54 +00:00
Dão Gottwald
1a4c207141 Bug 1939677 - Correctly add toolbarbuttons to TAB key order. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233089
2025-01-03 17:34:14 +00:00
Dão Gottwald
e9e9d3a05a Bug 1926254 - Esc key should cancel rather than accept the tab group create panel. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233185
2025-01-03 17:15:50 +00:00
Jeremy Swinarton
82d7acff7a Bug 1936015: Groups can be deleted after switching between horizontal and vertical tabs r=dao,sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232925
2025-01-03 13:37:41 +00:00
Stephen Thompson
4076f2c38a Bug 1936752 - unlock tab sizes in collapsed tab groups r=jswinarton,tabbrowser-reviewers
In certain cases when closing a tab(s), we temporarily lock the width of the tabs instead of letting them grow/shrink. If you close a tab and then quickly collapse a tab group right afterwards, you can end up with the tab group label going into the collapsed state correctly but the tabs in the tab group are still visible.

The issue is that we lock tab sizes on visible tabs using `max-width: ... !important` and we are hiding tabs in collapsed tab groups by using a CSS rule of `max-width: 0`. When we unlock the tab sizes, we only unlock visible tabs, but the tabs inside of the collapsed tab group are no longer considered visible.

This fix removes the tab lock size `max-width: ... !important` rule on all tabs regardless of tab visibility.

Differential Revision: https://phabricator.services.mozilla.com/D233022
2024-12-31 20:03:05 +00:00
Niklas Baumgardner
0f7ec7d1ef Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 20:46:00 +00:00
Dão Gottwald
3336bd457a Bug 1937203 - Tab group panel should close when expanding/collapsing a group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232657
2024-12-19 20:30:41 +00:00
Goloman Adrian
8893c682ad Backed out changeset b732fa6b4026 (bug 1919600) for causing bc failures @browser_preferences_usage.js. CLOSED TREE 2024-12-19 19:47:31 +02:00
Niklas Baumgardner
99881abf10 Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 16:07:05 +00:00
Dão Gottwald
8b91d8e6b9 Bug 1935956 - Include group labels in scrollable elements. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232517
2024-12-19 15:32:48 +00:00