Commit Graph

199 Commits

Author SHA1 Message Date
Alex Kontos
e7824895ad refactor: rename Firefox related references to their relevant counterparts 2025-11-03 16:04:55 +00:00
Francesco Lodolo
3bd4b9b693 Bug 1969793 - Correct path to setDesktopBackground.ftl in nsWindowsShellService, a=RyanVM
Original Revision: https://phabricator.services.mozilla.com/D252151

Differential Revision: https://phabricator.services.mozilla.com/D252279
2025-06-03 11:46:04 +00:00
jilvin
0e104cbe54 Bug 1902439 - Checks return of nsIOutputStream::Write() to NS_OK in WriteBitmap() to handle failures better. r=mpohle,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D234318
2025-05-20 17:37:48 +00:00
Francesco Lodolo (:flod)
88fdda4cc7 Bug 1955747 - Migrate strings in shellservice.properties to Fluent, r=nrishel,eemeli
Differential Revision: https://phabricator.services.mozilla.com/D242977
2025-04-02 05:42:44 +00:00
Eric Chen
67bb7296ec Bug 1955385 - revise MSIX code path for CheckCurrentProcessAUMIDForTesting r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D242588
2025-03-23 19:07:20 +00:00
Eric Chen
192c0c6787 Bug 1950734 - Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D239827
2025-03-19 20:41:18 +00:00
Cristina Horotan
bb136e0d12 Backed out changeset c7a895ce1e23 (bug 1950734) for causing bc failures at browser_processAUMID.js. CLOSED TREE 2025-03-13 07:31:36 +02:00
Eric Chen
3fa85c5c7a Bug 1950734 - Make MSIX builds skip the AUMID altering steps in taskbar pinning as it's unnecessary r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D239827
2025-03-12 23:45:49 +00:00
Eric Chen
d4bc2bcaee Bug 1949263 - prevent MSIX Firefox from calling PollAppsFolderForShortcut r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D239824
2025-03-03 15:34:20 +00:00
Nicholas Rishel
7034f58767 Bug 1932795 - Fix debug build assert by moving SourceSurface::GetFrame call to main thread during nsWindowsShellService::CreateWindowsIcon. r=nalexander,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D229849
2024-11-27 21:56:01 +00:00
Nicholas Rishel
57ab7f1ebd Bug 1930048 - Fix MinGW compile errors. r=mpohle,win-reviewers,gstoll
Tagalong: Clean up include order and remove unnecessary includes.

Differential Revision: https://phabricator.services.mozilla.com/D229033
2024-11-14 20:45:22 +00:00
Max Christian Pohle
846bcd126a Bug 1923448 - Generalized Windows Pinning, r=nrishel,gfx-reviewers,nical
Differential Revision: https://phabricator.services.mozilla.com/D224975
2024-11-12 22:48:55 +00:00
Nicholas Rishel
2a8da6a369 Bug 1893458 - Verify Start Menu shortcuts created at runtime have propagated to shell:appsfolder before attempting to pin them. r=win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D227131
2024-11-07 21:51:23 +00:00
Stanca Serban
1cefb44ccb Backed out changeset 2fe294eb4a06 (bug 1923448) for causing nsWindowsShellService.cpp. CLOSED TREE 2024-11-07 12:37:21 +02:00
Max Christian Pohle
423ab686ff Bug 1923448 - Generalized Windows Pinning, r=nrishel,gfx-reviewers,nical
Differential Revision: https://phabricator.services.mozilla.com/D224975
2024-11-07 09:54:52 +00:00
Nicholas Rishel
085457c06f Bug 1926151 - Remove Desktop and Public Desktop from folders a pinnable shortcut can exist in. r=bhearsum
We prioritize using `ITaskbarManager` now, which requires a shortcut exist in a location visible from `shell:appsfolder`. `IPinnedList3` can use shortcuts from Desktop and Public Desktop (and potentially other locations) but there's no reason to check for these cases since we have already created the shortcut for `ITaskbarManager`. The rare case of failing to create as shortcut for `ITaskbarManager` is not worth accounting for given `IPinnedList3` is not supported in newer versions of Windows.

Differential Revision: https://phabricator.services.mozilla.com/D227134
2024-10-31 19:53:56 +00:00
Nicholas Rishel
51fef936bb Bug 1926151 - Pre: Rename Matching to Pinnable to better convey usage of hasPinnableShortcut. r=bhearsum,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D227133
2024-10-31 19:53:55 +00:00
serge-sans-paille
262f78c07f Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-28 08:21:19 +00:00
Alexandru Marc
a5eb905bf4 Backed out changeset d92f391b3b0c (bug 1922838) for backing out bug 1915351 2024-10-25 16:42:33 +03:00
serge-sans-paille
07101ac24d Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 09:06:01 +00:00
Alexandru Marc
004e704b22 Backed out changeset 448597bce69d (bug 1922838) for causing build bustages. CLOSED TREE 2024-10-24 11:37:49 +03:00
serge-sans-paille
2c916d4973 Bug 1922838 - Replace ArrayLength, ArrayEnd and MOZ_ARRAY_LENGTH by standard alternative r=glandium,necko-reviewers,jgilbert,application-update-reviewers,media-playback-reviewers,credential-management-reviewers,anti-tracking-reviewers,places-reviewers,profiler-reviewers,win-reviewers,dom-storage-reviewers,bytesized,janv,dimi,daisuke,karlt,gstoll,canaltinova,timhuang
Namely std::size, std::end and std::size. This drops C support for
MOZ_ARRAY_LENGTH but it wasn't used anyway.

Differential Revision: https://phabricator.services.mozilla.com/D224611
2024-10-24 07:38:30 +00:00
Emilio Cobos Álvarez
4c840d573b Bug 1925866 - NS_NewLocalFile's aFollowSymlinks arg is unused. r=xpcom-reviewers,necko-reviewers,valentin,media-playback-reviewers,win-reviewers,karlt,nika,rkraesig
Remove it and related functions, and update the callers.

Differential Revision: https://phabricator.services.mozilla.com/D226261
2024-10-22 09:38:16 +00:00
Nipun Shukla
9044371423 Bug 1794159 - Part 3: Enable MSIX pinning in nsWindowsShellService r=nrishel,nalexander,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217763
2024-08-12 17:05:48 +00:00
pstanciu
4aef4243c2 Backed out 3 changesets (bug 1794159) for causing bc failures on browser_browserGlue_telemetry.js CLOSED TREE
Backed out changeset 764e14e5df4a (bug 1794159)
Backed out changeset 76b8d6cebe8b (bug 1794159)
Backed out changeset f28a29199ba8 (bug 1794159)
2024-08-08 11:16:27 +03:00
Nipun Shukla
9f77b85299 Bug 1794159 - Part 3: Enable MSIX pinning in nsWindowsShellService r=nrishel,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D217763
2024-08-08 02:48:50 +00:00
Nipun Shukla
5d442069c0 Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-08-07 13:12:20 +00:00
Stanca Serban
973a3fec8c Backed out changeset 0218b28ab8ed (bug 1904436) for crashes related to taskbar pinning. a=backout 2024-07-25 17:28:14 +03:00
Nipun Shukla
627adad1af Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-07-24 18:40:33 +00:00
Norisz Fay
d75ebb2a50 Backed out changeset d06c14636494 (bug 1904436) as requested for crashes related to Windows pinning to taskbar CLOSED TREE 2024-07-10 22:27:46 +03:00
Nipun Shukla
34c75b3d57 Bug 1904436 - Implement private browser pinning using new Windows taskbar APIs r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D214757
2024-07-09 19:23:19 +00:00
Nipun Shukla
289ec4a1dd Bug 1898094 - Implemented Windows Start Menu pinning APIs in nsIWindowsShellService r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D211114
2024-07-09 19:13:47 +00:00
Nicholas Rishel
c38ebcec1e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D210247
2024-05-21 02:37:10 +00:00
Sandor Molnar
0f4b2c2a80 Backed out changeset 6c952a8ea651 (bug 1894865) for causing build bustages @ browser/components/shell/nsWindowsShellServiceInternal.h CLOSED TREE 2024-05-20 22:06:06 +03:00
Nicholas Rishel
2e90f2e33e Bug 1894865 - Concat nsStrings to avoid issues converting wide characters to char and back again. r=bytesized
Differential Revision: https://phabricator.services.mozilla.com/D210247
2024-05-20 18:49:11 +00:00
Nipun Shukla
8fa18f7f5e Bug 1895744 - Implemented WRL StartupTask for MSIX launch on login r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D209718
2024-05-15 15:34:42 +00:00
Tamas Szentpeteri
833395877b Backed out 2 changesets (bug 1893341, bug 1895744) for causing bc failures in browser_windows_launch_on_login_msix.js. CLOSED TREE
Backed out changeset ce5384469c24 (bug 1893341)
Backed out changeset 658645fa9303 (bug 1895744)
2024-05-15 11:24:17 +03:00
Nipun Shukla
51e5f06d08 Bug 1895744 - Implemented WRL StartupTask for MSIX launch on login r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D209718
2024-05-15 02:54:55 +00:00
Butkovits Atila
99d0c239a5 Backed out 2 changesets (bug 1893458, bug 1890634) for causing bustages at TaskbarPinningMetricsTests.cpp. CLOSED TREE
Backed out changeset 29ad5906bfb0 (bug 1890634)
Backed out changeset bfcfe75b775a (bug 1893458)
2024-05-02 00:22:14 +03:00
Michael Hughes
92c041d105 Bug 1890634 - add telemetry for tab pinning r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D207789
2024-05-01 17:11:53 +00:00
Michael Hughes
e8f6c31e3d Bug 1893458 - attempt to fix tab pinning not working sometimes on the first time r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D208669
2024-05-01 17:11:53 +00:00
Cristian Tuns
c784fd60cd Backed out 2 changesets (bug 1893458, bug 1890634) build bustages in Windows11TaskbarPinning.cpp CLOSED TREE
Backed out changeset fb9d21d9a3f9 (bug 1890634)
Backed out changeset 2a32d2f7aa06 (bug 1893458)
2024-04-29 14:01:41 -04:00
Michael Hughes
2ebe6702e6 Bug 1890634 - add telemetry for tab pinning r=nrishel
Differential Revision: https://phabricator.services.mozilla.com/D207789
2024-04-29 17:06:08 +00:00
Michael Hughes
1cfd97def2 Bug 1893458 - attempt to fix tab pinning not working sometimes on the first time r=nalexander,nrishel
Differential Revision: https://phabricator.services.mozilla.com/D208669
2024-04-29 17:06:07 +00:00
Michael Hughes
3cdd7caa11 Bug 1879975 - Newer versions of Windows disable pinning to the taskbar using older methods r=mpohle,bhearsum,nrishel,glandium,nalexander
This is adding in the new Windows 11 only version of taskbar pinning. For the new pinning to work, we need to use limited access feature tokens. Those are going to be made private and aren't included with this change.
This change will compile, and will work if built against the correct limited access feature tokens, as specified in developer local machine config files, but for every other build, the new taskbar pinning won't work and will fall back to the old methods.
I will implement the try / release building machines using the secret limited access feature tokens in a follow-up diff.

Differential Revision: https://phabricator.services.mozilla.com/D205004
2024-04-22 23:07:37 +00:00
Aron Cseh
f54720ca9c Backed out 4 changesets (bug 1879975) for causing l10n bustages CLOSED TREE
Backed out changeset 280d7a1f6adc (bug 1879975)
Backed out changeset 5f362eae55c5 (bug 1879975)
Backed out changeset cfc40111608f (bug 1879975)
Backed out changeset af2eee38668d (bug 1879975)
2024-04-18 16:41:31 +03:00
Michael Hughes
9acb5439c1 Bug 1879975 - Newer versions of Windows disable pinning to the taskbar using older methods r=mpohle,bhearsum,nrishel,glandium
This is adding in the new Windows 11 only version of taskbar pinning. For the new pinning to work, we need to use limited access feature tokens. Those are going to be made private and aren't included with this change.
This change will compile, and will work if built against the correct limited access feature tokens, as specified in developer local machine config files, but for every other build, the new taskbar pinning won't work and will fall back to the old methods.
I will implement the try / release building machines using the secret limited access feature tokens in a follow-up diff.

Differential Revision: https://phabricator.services.mozilla.com/D205004
2024-04-17 17:51:58 +00:00
Cristina Horotan
97caeefa9b Backed out 3 changesets (bug 1879975) for causing Valgrind failure. CLOSED TREE
Backed out changeset 5eee9358d22a (bug 1879975)
Backed out changeset d9a53dc2478c (bug 1879975)
Backed out changeset e04956da20c6 (bug 1879975)
2024-04-17 04:03:42 +03:00
Michael Hughes
b3d5513f8f Bug 1879975 - Newer versions of Windows disable pinning to the taskbar using older methods r=mpohle,bhearsum,nrishel,glandium
This is adding in the new Windows 11 only version of taskbar pinning. For the new pinning to work, we need to use limited access feature tokens. Those are going to be made private and aren't included with this change.
This change will compile, and will work if built against the correct limited access feature tokens, as specified in developer local machine config files, but for every other build, the new taskbar pinning won't work and will fall back to the old methods.
I will implement the try / release building machines using the secret limited access feature tokens in a follow-up diff.

Differential Revision: https://phabricator.services.mozilla.com/D205004
2024-04-16 23:21:24 +00:00
Natalia Csoregi
c300e2cb7e Backed out 3 changesets (bug 1879975) for causing bustage while fetching windows-laf-tokens.data CLOSED TREE
Backed out changeset 5e5bc998487f (bug 1879975)
Backed out changeset be268309f0f7 (bug 1879975)
Backed out changeset b2f6d0289dc6 (bug 1879975)
2024-04-12 23:55:45 +03:00