corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
896,032 Commits 1 Branch 0 Tags
6cf0bc44df72c55ff661cd36c9d4b07f17f2ceb5
Commit Graph

373 Commits

Author SHA1 Message Date
Nick Grato
6cf0bc44df Bug 1946523 - STG - Step 1 UI migration r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,bolsson 
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.

Differential Revision: https://phabricator.services.mozilla.com/D237277
 2025-02-14 23:37:56 +00:00
Rolf Rando
1ff1ef6aba Bug 1946322 Land SmartTabGrouping utility class and tabbrowser code for Smart Tab Grouping r=tabbrowser-reviewers,dao,tarek 
Landing in moz-central the utility SmartTabGrouping class that enables smart tab grouping of browser tabs.

This includes some cleanup in the toolkit/../ml /code, including adding more tests.

We are slimming test data tsv files by using 5 dimensional embeddings instead of 500 dim.

There is still some algorithm code in  /tabbrowser/SmartTabGrouping  because it is tied up with tabs. We could maybe move some to toolkit/../ml if required but it is a little tricky.

With this patch landed, some clustering access would be available in the console by typing: gBrowser.smartTabGrouping()

@ngrato will have a separate patch to enable the UI.

Differential Revision: https://phabricator.services.mozilla.com/D237112
 2025-02-14 17:33:50 +00:00
Kelly Cochrane
dcab8d8bd8 Bug 1945993 - Make sure browser.tabs.tabMinWidth pref is applied as expected to horizontal tabs r=desktop-theme-reviewers,tabbrowser-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D236934
 2025-02-14 14:58:03 +00:00
DJ
f43ce0afa5 Bug 1947758 - improve group handling in gBrowser.moveTabForward/Backward. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D238124
 2025-02-14 11:24:14 +00:00
Jonathan Sudiaman
ff8389ea29 Bug 1946868 - Remove "Turn on/off Vertical Tabs" in the tab context menu r=sidebar-reviewers,tabbrowser-reviewers,nsharpley,dao 
Backout of Bug 1944016 - Add new strings to tab context menu for switching to/from vertical tabs.

Differential Revision: https://phabricator.services.mozilla.com/D238106
 2025-02-14 00:55:12 +00:00
DJ
a0b1928d27 Bug 1945169 - prevent a closing window from saving a group that is being adopted. r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237988
 2025-02-13 19:39:28 +00:00
Jeremy Swinarton
eea0d1bd7f Bug 1933112: Tab groups only appear in TOM menus for windows with same privateness r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237604
 2025-02-13 14:25:36 +00:00
Dão Gottwald
dd7219da44 Bug 1943814 - Reset related tabs map in _handleTabMove. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237729
 2025-02-12 17:56:15 +00:00
Dão Gottwald
eb3174b1b2 Bug 1947598 - When moving a group to current window, select that group. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237874
 2025-02-12 17:43:48 +00:00
Dão Gottwald
aeb3a50787 Bug 1947782 - The Tab Groups sub-menu in the "List all tabs" menu should be scrollable. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237905
 2025-02-12 17:43:13 +00:00
Jeremy Swinarton
566b514ef6 Bug 1946761: Prevent saving tab groups in private windows r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237588
 2025-02-11 13:43:27 +00:00
Dão Gottwald
c5553f5d8d Bug 1947269 - Fix double menuseparator in list all tabs menu when there are no tab groups. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237614
 2025-02-10 23:12:25 +00:00
Dão Gottwald
0edf7605e6 Bug 1947275 - Fix tab groups subview command handling. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237621
 2025-02-10 23:11:00 +00:00
kernp25
cb1f1d5155 Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth 
Differential Revision: https://phabricator.services.mozilla.com/D233071
 2025-02-10 15:24:32 +00:00
Dão Gottwald
5c9f9cced1 Bug 1945463 - [tab groups d&d] Fix greatestOverlap to account for elements completely overlapping one another. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237287
 2025-02-10 14:45:16 +00:00
Dão Gottwald
5b86e468e0 Bug 1946318 - Show groups from all windows in groups list, implement sub view for showing all groups, and add header to tabs list. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D237209
 2025-02-08 10:46:37 +00:00
Butkovits Atila
6282e4ff0b Backed out changeset 9fe6747802c0 (bug 1946318) forcausing failures at browser_tab_manager_groups.js. CLOSED TREE 2025-02-08 05:43:43 +02:00
Dão Gottwald
b1c04cf7d5 Bug 1946318 - Show groups from all windows in groups list, implement sub view for showing all groups, and add header to tabs list. r=dwalker,fluent-reviewers,tabbrowser-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D237209
 2025-02-08 00:08:45 +00:00
DJ
6fadf58d15 Bug 1942375 - Keep tab group manager UI in sync with browser state. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236944
 2025-02-07 17:51:24 +00:00
Sandor Molnar
91a3d57c8b Backed out changeset eef63d507b52 (bug 1942375) for causing mochitest with vertical tabs enabled perma failures. CLOSED TREE 2025-02-07 12:07:00 +02:00
DJ
32a6b12a0a Bug 1942375 - Keep tab group manager UI in sync with browser state. r=dao,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236944
 2025-02-07 09:01:40 +00:00
Emilio Cobos Álvarez
81c4d6a66f Bug 1946016 - Remove macOS special case too. r=dao,tabbrowser-reviewers 
Just tested, doesn't change behavior.

Differential Revision: https://phabricator.services.mozilla.com/D236871
 2025-02-05 20:42:47 +00:00
Greg Stoll
236598ef4b Bug 1926973 - make unloaded tabs favicon semi-transparent behind a pref r=desktop-theme-reviewers,tabbrowser-reviewers,dao 
Note that this is behind a pref that is turned off right now - I'm
landing this so UX and a11y folks can more easily take a look at it.

Differential Revision: https://phabricator.services.mozilla.com/D235864
 2025-02-05 19:05:06 +00:00
Nick Grato
7f9c942b8d Bug 1945223 - Browser Pref for Smart Tab Grouping r=tabbrowser-reviewers,dao 
Add a feature flag for turning on/off the UI for smart tab grouping. Updating formatting for the HTML. Due to the use of XUL the html has no syntax highlighting and is extremely difficult to read when not formatted vertically. More UI is comming and this helps pave the way for a more readable file.

Differential Revision: https://phabricator.services.mozilla.com/D236383
 2025-02-05 18:25:34 +00:00
Dão Gottwald
0bbc0c683c Bug 1946050 - Consolidate tab context menu code dealing with multiple context tabs. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236843
 2025-02-05 18:16:04 +00:00
Kelly Cochrane
cae199c0f2 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233098
 2025-02-05 18:04:20 +00:00
Emilio Cobos Álvarez
f592072c68 Bug 1946016 - Don't be explicit about window size when detaching tabs on Linux. r=dao,tabbrowser-reviewers 
Let Gecko choose a suitable size. This seems to result in the desired
behavior (same as Ctrl+N). Tested GNOME and Kwin, X11 and Wayland.

The reason for the behavior change here is because `outerWidth` before
the regressing patch returned the inner, not the outer width. Combined
with the pre-existing behavior that decorations are added asynchronously
by the window manager, it just happened to conveniently cancel out that
bug, which is now fixed.

It's unclear we need this at all on macOS fwiw. IIRC Cmd+N does also the
same thing as Windows, so maybe we can remove this block altogether.

Separate patch tho, as I don't have a macOS build ready to test it this
very moment, but I think it should just work.

Differential Revision: https://phabricator.services.mozilla.com/D236867
 2025-02-05 17:02:24 +00:00
Stanca Serban
0efa589b90 Backed out changeset 1be8354cedcd (bug 1930201) for causing mochitests failures. CLOSED TREE 2025-02-05 19:11:28 +02:00
Dão Gottwald
84d41371c1 Bug 1935022 - Wait for two animation frames before tracking mouse movement in the ctrl-tab panel. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D236854
 2025-02-05 14:10:40 +00:00
Kelly Cochrane
03c6b75a99 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao 
Differential Revision: https://phabricator.services.mozilla.com/D233098
 2025-02-05 14:05:08 +00:00
Dão Gottwald
fda9eb5278 Bug 1945264 - Let related new tabs inherit the current tab group. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236731
 2025-02-04 23:32:36 +00:00
Dão Gottwald
de0ae0ca64 Bug 1943589 - Allow adoptTab to adopt tabs into a tab group. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236722
 2025-02-04 19:32:43 +00:00
Emma Zuehlcke
c4bd8080a9 Bug 1866661, r=hjones,reusable-components-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D235457
 2025-02-04 14:26:29 +00:00
Butkovits Atila
b061588f31 Backed out changeset 2c11770a86dc (bug 1939658) for causing failures at test_JsonSchemaValidator.js. CLOSED TREE 2025-02-04 13:07:29 +02:00
kernp25
cd2f76670a Bug 1939658 - Replace new URL usage with URL.parse/URL.canParse where possible. r=robwu,Standard8,Gijs,mtigley,pdahiya,settings-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,places-reviewers,omc-reviewers,migration-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,webcompat-reviewers,urlbar-reviewers,twisniewski,mossop,dao,nchevobbe,webdriver-reviewers,whimboo,issammani,mconley,nbarrett,beth 
Differential Revision: https://phabricator.services.mozilla.com/D233071
 2025-02-04 08:25:28 +00:00
Nick Grato
00132688f5 Bug 1944154 - State Machine for tab states r=tabbrowser-reviewers,dao 
To prep for the transition of code migrating from Larch to Central, for STG (Smart Tab Grouping), the best technique would be to implement peace by peace not to overwhelm a single patch.

This bug is the beginning of said work by setting the ground work for the state machine that manages the many additional states used by the STG feature.

Differential Revision: https://phabricator.services.mozilla.com/D235712
 2025-02-03 18:11:17 +00:00
Dão Gottwald
ae8e1343e4 Bug 1945440 - Fix tab drag and drop in RTL mode. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236512
 2025-02-03 14:21:52 +00:00
Dão Gottwald
bc676fe35e Bug 1943971 - Let moving tabs to start/end not keep or put them in groups. r=jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236318
 2025-02-03 10:15:25 +00:00
Dão Gottwald
0093579918 Bug 1945118 - Revert change from bug 1944844 and fix differently, by having #triggerDragOverCreateGroup update dragData. r=dwalker,jswinarton,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236343
 2025-01-31 14:22:14 +00:00
Dão Gottwald
69404071c4 Bug 1936282 - When using the tab context menu to create a group from the all tabs panel, make sure we close that panel so that it doesn't obscure the tab group creation panel. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236160
 2025-01-31 06:49:38 +00:00
Goloman Adrian
1527be7ffd Backed out changeset bb54bd88c1ec (bug 1936282) for causing bc failures @browser_tab_groups.js. CLOSED TREE 2025-01-30 23:30:56 +02:00
Dão Gottwald
4d47d13ad1 Bug 1943885 - Pinning first tab should ungroup it. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236212
 2025-01-30 17:01:11 +00:00
Dão Gottwald
106b2aad45 Bug 1936282 - When using the tab context menu to create a group from the all tabs panel, make sure we close that panel so that it doesn't obscure the tab group creation panel. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236160
 2025-01-30 14:49:12 +00:00
Dão Gottwald
89a390256e Bug 1944844 - Set dropElement before returning early. r=tabbrowser-reviewers,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D236159
 2025-01-30 14:44:07 +00:00
Jonathan Sudiaman
70919ebe73 Bug 1944016 - Add new strings to tab context menu for switching to/from vertical tabs r=sidebar-reviewers,fluent-reviewers,tabbrowser-reviewers,dao,bolsson,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D236035
 2025-01-29 23:29:40 +00:00
Dão Gottwald
b377e92246 Bug 1944643 - Dispatch event when saving and closing a group. r=dwalker,tabbrowser-reviewers,omc-reviewers,emcminn 
Note that in order to support the callout, we want to dispatch this only when picking "save and close" from the menu.

Differential Revision: https://phabricator.services.mozilla.com/D236020
 2025-01-29 19:09:19 +00:00
Dão Gottwald
a49bb76e1e Bug 1932489: Drag/drop based on "element index" instead of tab index. r=tabbrowser-reviewers,jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D234804
 2025-01-29 18:37:29 +00:00
DJ
8d61f15c5c Bug 1943032 - Localize tabgroup aria-label and description. r=dao,fluent-reviewers,tabbrowser-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D235640
 2025-01-28 14:51:28 +00:00
Dão Gottwald
5e253e3ce8 Bug 1944083 - Clicking outside the tab group create panel should keep the new group. r=dwalker,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D235667
 2025-01-28 11:39:14 +00:00
Butkovits Atila
b76f85c5bf Backed out changeset 8fc3326bce7f (bug 1943032) for causing failures at browser_tab_groups_a11y.js. CLOSED TREE 2025-01-28 07:57:01 +02:00