corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
896,032 Commits 1 Branch 0 Tags
6cf0bc44df72c55ff661cd36c9d4b07f17f2ceb5
Commit Graph

3588 Commits

Author SHA1 Message Date
Dão Gottwald
9092f40692 Bug 1948257 - Deleted tab groups in the app menu's history view should use the filled-in group icon. r=dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D238195
 2025-02-14 16:41:11 +00:00
DJ
a0b1928d27 Bug 1945169 - prevent a closing window from saving a group that is being adopted. r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237988
 2025-02-13 19:39:28 +00:00
Jeremy Swinarton
97dd33ecbd Bug 1947503: Closed tab groups code supports session store files created before Firefox 135 r=dao,dwalker,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237904
 2025-02-13 15:10:03 +00:00
Jeremy Swinarton
566b514ef6 Bug 1946761: Prevent saving tab groups in private windows r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237588
 2025-02-11 13:43:27 +00:00
Jeremy Swinarton
016c599fa5 Bug 1944416: Restore individual tabs from closed groups in closed windows r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237110
 2025-02-07 21:35:32 +00:00
Dão Gottwald
e68210bd1a Bug 1946539 - Use default group icon in recently closed tabs menu. r=jswinarton,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D237181
 2025-02-07 15:23:51 +00:00
Jeremy Swinarton
2290ebcc4a Bug 1944328: "Reopen All Tabs" supports closed tab groups from closed windows r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236872
 2025-02-05 21:06:43 +00:00
Sam Foster
c32900b41c Bug 1942314 - Avoid showing sidebars and responding to sidebar events in popup windows. r=sidebar-reviewers,sessionstore-reviewers,jsudiaman,sclements 
- Guard the main entry-points in SidebarController to handle the window being a popup
- Amend the test to also try the shortcut to show a sidebar in a popup window

Differential Revision: https://phabricator.services.mozilla.com/D236292
 2025-02-04 07:43:21 +00:00
Jeremy Swinarton
140b7bce30 Bug 1945111: Only include tabs inside groups at deletion time in closed tab groups in history menus r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236432
 2025-02-03 14:45:41 +00:00
Jeremy Swinarton
3414d7d519 Bug 1915174: Restore closed tabs to their original tab group r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D236347
 2025-02-03 14:22:39 +00:00
Jeremy Swinarton
a86608a71b Bug 1943850: Recently closed tabs use correct indexing r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D235813
 2025-01-28 15:14:45 +00:00
Nikki Sharpley
551f8d2aaa Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane,sessionstore-reviewers 
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
 2025-01-28 00:51:28 +00:00
Sandor Molnar
4cfec08470 Bug 1775616 - Disable test 'browser_async_window_flushing.js' on win/linux/mac- opt & asan for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D235521
 2025-01-25 00:46:16 +00:00
Florian Quèze
466d8c2170 Bug 1935420 - rewrite more JS code storing histograms in local variables (includes changes done by hand), r=chutten,search-reviewers,anti-tracking-reviewers,sessionstore-reviewers,dao. 
Differential Revision: https://phabricator.services.mozilla.com/D234009
 2025-01-24 16:18:32 +00:00
Jeremy Swinarton
f000526cd1 Bug 1940752: Remove test debug logs forgotten in previous patch r=dao,sessionstore-reviewers 
The last patch for this bug was backed out the first time I attempted to
land it. After I fixed the issue and re-landed, I accidentally left some
debug cruft that wasn't caught by the linter.

Differential Revision: https://phabricator.services.mozilla.com/D235354
 2025-01-24 14:22:32 +00:00
Jeremy Swinarton
7db0891300 Bug 1941799: 'Reopen All Tabs' supports tab groups r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D235317
 2025-01-23 19:55:42 +00:00
Jeremy Swinarton
4c0ff4a071 Bug 1940752: 'Reopen Closed Tab' tab context menu, and other paths calling undoCloseTab, support tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234680
 2025-01-21 23:07:02 +00:00
Dão Gottwald
78725d1a6b Bug 1942809 - Consolidate tabs.length check by moving it into _recordSavedTabGroupState. r=dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D234956
 2025-01-21 15:23:48 +00:00
Jeremy Swinarton
f9b9eb75c1 Bug 1932941: Add session support for closed tab groups in closed windows r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234176
 2025-01-21 14:58:01 +00:00
DJ
857429c48c Bug 1937856 - prevent saving tab groups with only discarded tabs. r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234505
 2025-01-17 14:46:24 +00:00
Joel Maher
bcc50efbeb Bug 1940980 - Green up win11-64 opt/debug/asan/ccov. r=aryx,media-playback-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,urlbar-reviewers,aosmond,mconley,ochameau,dimi,jteow,mtigley 
Differential Revision: https://phabricator.services.mozilla.com/D233862
 2025-01-16 23:02:48 +00:00
Stanca Serban
54f9cf7d9a Backed out changeset 49fc474d91a0 (bug 1932941) for causing mochitests failures in browser_tab_groups_closed_groups_in_closed_windows.js. 2025-01-16 19:44:56 +02:00
Jeremy Swinarton
feb3d5e3db Bug 1932941: Add session support for closed tab groups in closed windows r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234176
 2025-01-16 15:43:57 +00:00
Kelly Cochrane
f9046ef713 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-16 01:40:47 +00:00
Alexandru Marc
402a01520a Backed out changeset 2821188eb89d (bug 1921060) for causing multiple failures 2025-01-16 02:25:14 +02:00
Kelly Cochrane
a876cd0373 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-15 23:07:45 +00:00
Jeremy Swinarton
e409401215 Bug 1939719: Resolve talos sessionstore perf issue r=dao,sessionstore-reviewers 
The root cause of this turned out to be that the talos
sessionstore.js file did not have groups, but the call to load groups
during the deferred restore routine was expecting them to exist,
throwing an error. This change fixes the issue.

PerfCompare run: https://perf.compare/compare-results?baseRev=6ccc0ebc69e907e55033ea729a5ca40d0fcb22fe&newRev=5d112ab0e86f98dbb7a9c6f8d40de01564ebec7b&baseRepo=try&newRepo=try&framework=1

Differential Revision: https://phabricator.services.mozilla.com/D234347
 2025-01-15 16:52:30 +00:00
Jeremy Swinarton
a80eb49e6c Bug 1939904: Closed tab groups in history menus can be restored regardless of window they were closed in. r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D234042
 2025-01-14 17:49:24 +00:00
Yazan Al Macki
4507fb96aa Bug 1925235 - Avoid updating unified search button icon if searchMode has changed. r=daleharvey,sessionstore-reviewers,dao 
Currently, multiple calls to #updateSearchIcon can run concurrently. When restarting the browser with a tab , and another tab in which a local search mode is active, the local search mode is incorrectly displayed as the default engine search mode. I believe this is due to the first #updateSearchIcon call (default engine, triggered when new tab is reopened) taking longer than the subsequent #updateSearchIcon call (triggered when the search mode is restored).

This is probably due to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#329-334 | this ]] code taking a while to execute in comparison to [[ https://searchfox.org/mozilla-central/rev/b6718bf263ae780289da471f0ea35797a09e2f05/browser/components/urlbar/SearchModeSwitcher.sys.mjs#338-342 | this ]] code that runs for local search modes.

Ensuring that an #updateSearchIcon call terminates if search mode switches during its async processing prevents it from interfering with the next call triggered and incorrectly overriding the icon.

Differential Revision: https://phabricator.services.mozilla.com/D233036
 2025-01-14 14:34:05 +00:00
Stanca Serban
9e9507fcbb Backed out changeset d448ac7b0d9e (bug 1921060) for causing mochitests failures in browser_audioTabIcon.js. 2025-01-13 21:35:03 +02:00
Kelly Cochrane
50f355f8ec Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements,sidebar-reviewers,fluent-reviewers,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D231182
 2025-01-13 17:55:32 +00:00
Dão Gottwald
2dcb43e95d Bug 1940231 - When restoring a session, prevent original startup tabs from moving into a restored tab group. r=tabbrowser-reviewers,jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D234022
 2025-01-13 15:59:48 +00:00
Cosmin Sabou
b1cd82afbc Bug 1787024 - Disable browser_async_remove_tab.js also on linux ASan for frequent failures. a=test-only 2025-01-11 02:48:42 +02:00
Dão Gottwald
f60b181b60 Bug 1940791 - When restoring a group, select it. r=jswinarton 
Differential Revision: https://phabricator.services.mozilla.com/D233863
 2025-01-10 16:14:38 +00:00
Sebastian Hengst
7e0528301b Bug 1775605 - disable browser_label_and_icon.js on Linux ASan for frequent failures 
Differential Revision: https://phabricator.services.mozilla.com/D233770
 2025-01-09 22:02:28 +00:00
Jonathan Sudiaman
9372222c8c Bug 1935482 - Replace legacy properties with SidebarState properties r=sidebar-reviewers,sessionstore-reviewers,nsharpley,sfoster 
- Move resize observer (setting max width) logic over to SidebarState.
- Add `command` property to SidebarState.
- Handle receiving legacy session restore data.
- Add unit tests along with mocking structures to get a better idea of state/controller coupling (which we should ultimately reduce).

Differential Revision: https://phabricator.services.mozilla.com/D232730
 2025-01-08 23:06:42 +00:00
Jeremy Swinarton
cf0ea617df Bug 1939599: Tab groups can be restored by Ctrl+Shift+T r=dao,sthompson,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D233102
 2025-01-08 22:33:13 +00:00
Joel Maher
248157ee22 Bug 1938960 - additional greening up of win11 24h2, carry forward existing annotations. r=aryx,webdriver-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,nchevobbe,dimi,whimboo,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D233026
 2025-01-07 19:51:49 +00:00
Dão Gottwald
899b3c4127 Bug 1939413 - Ensure _savedGroups isn't undefined. r=jswinarton,dwalker 
Differential Revision: https://phabricator.services.mozilla.com/D233163
 2025-01-03 16:51:08 +00:00
Goloman Adrian
359af847a8 Bug 1787024 - fix typo in manifest file. a=typo-fix 2025-01-03 18:23:54 +02:00
Goloman Adrian
6f97f31f70 Bug 1787024 - disable test browser_async_remove_tab.js for frequent failures. r=sessionstore-reviewers,dao DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D232911
 2024-12-31 17:50:55 +00:00
Jeremy Swinarton
4ded93c800 Bug 1927767: Closed tab groups from the last session appear correctly in history menus r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232879
 2024-12-30 14:56:50 +00:00
Luca Greco
775328ed67 Bug 1786601 - Tweak browser_ext_tabs_events.js to expect SessionStore onMoveToNewWindow uncaught rejection. r=dao,sessionstore-reviewers,robwu 
This patch modifies SessionStoreInternal.onMoveToNewWindow to raise a more specific error message when
no TabState is found for the tab being moved, and then allows that more specific error message
as an uncaught rejection in browser_ext_tabs_events.js through PromiseTestUtils.allowMatchingRejectionsGlobally.

These changes don't address the underlying issue hit by SessionStoreInternal, but in the short term
it will allow to prevent the high frequency intermittent failure currently hit by the
browser_ext_tabs_events.js (and to keep the existing test coverage which would be lost if we
would instead skip the entire test file to workaround the intermittency).

An inline comment added right above the call to PromiseTestUtils.allowMatchingRejectionsGlobally
includes a mention to Bug 1938594 (a new bug filed under the "Firefox :: Session Restore" bugzilla
component to track additional investigations on the SessionStore/TabStateFlusher side) as a reminder
of the underlying issue (and to remove the workaround when it may not be necessary anymore).

Differential Revision: https://phabricator.services.mozilla.com/D230528
 2024-12-22 18:06:56 +00:00
DJ
c5ab0e12ee Bug 1938589 - init savedGroups from session file. r=sthompson,dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232747
 2024-12-21 03:30:15 +00:00
Jeremy Swinarton
9561dbc00e Bug 1927768: Purging domain data handles tabs in closed groups r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232228
 2024-12-19 17:01:04 +00:00
Tom Schuster
60946c123d Bug 1937545 - Remove inline event handlers from RecentlyClosedTabsAndWindowsMenuUtils r=sessionstore-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D232618
 2024-12-19 14:01:10 +00:00
Stephen Thompson
808fb505dc Bug 1921857 - "close tabs to the left/right" changes for tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers 
1. should be available in the context menu even if there are collapsed tab groups to the left/right
2. should close collapsed tab groups when they are to the left/right
3. tab groups should be saved when they are going to be closed when using "close tabs to the left/right"

Differential Revision: https://phabricator.services.mozilla.com/D232432
 2024-12-19 10:22:24 +00:00
Stephen Thompson
f8fd5db3b5 Bug 1933813 - "close other tabs" changes for tab groups r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D232430
 2024-12-19 08:54:25 +00:00
Stanca Serban
30c8718405 Backed out changeset a2a3d6bf518f (bug 1921060) as requested for causing multiple regressions. 2024-12-18 20:51:04 +02:00
Stephen Thompson
d217c2630b Bug 1921802 - save open tab groups on window close r=dao,sessionstore-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D231892
 2024-12-18 15:54:21 +00:00