Commit Graph

3346 Commits

Author SHA1 Message Date
Valentin Gosu
66643c5bf0 Bug 1574475 - Remove FTP proxy code r=necko-reviewers,preferences-reviewers,mixedpuppy,mkaply,dragana
Differential Revision: https://phabricator.services.mozilla.com/D111248
2021-04-28 09:33:46 +00:00
Joel Maher
5a5bc0c176 Bug 1706716 green up mda, xpcshell, browser-chrome, reftest for apple silicon. r=necko-reviewers,extension-reviewers,preferences-reviewers,application-update-reviewers,zombie,ahal,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D113001
2021-04-22 18:39:40 +00:00
Narcis Beleuzu
359bfccedf Backed out 8 changesets (bug 1574475, bug 1699222) for build bustages on moz.build . CLOSED TREE
Backed out changeset 6c2c039872b3 (bug 1574475)
Backed out changeset 8a2a04743c5f (bug 1699222)
Backed out changeset 9437c60798d6 (bug 1574475)
Backed out changeset 7ef1884ac11b (bug 1574475)
Backed out changeset ec8c237d5298 (bug 1574475)
Backed out changeset 4a760b3f5d53 (bug 1574475)
Backed out changeset b229b0eea1e7 (bug 1574475)
Backed out changeset 03d34a2f10a6 (bug 1574475)
2021-04-22 18:10:59 +03:00
Valentin Gosu
52e46d11c4 Bug 1574475 - Remove FTP proxy code r=necko-reviewers,preferences-reviewers,mixedpuppy,mkaply,dragana
Differential Revision: https://phabricator.services.mozilla.com/D111248
2021-04-22 13:41:34 +00:00
Markus Stange
4b2c5e6c55 Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111955
2021-04-20 17:44:16 +00:00
Tim Huang
c3eee6e1a7 Bug 1698845 - Part 4: Update the string for the cookie blocking label of dFPI. r=johannh,fluent-reviewers,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D112098
2021-04-15 07:17:35 +00:00
Tim Huang
6f32f3b2f9 Bug 1698845 - Part 3: Remove the icons in the content blocking section of about:preference#privacy and use the bullet points for standard and strict mode. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D112089
2021-04-15 07:17:35 +00:00
Tim Huang
5a5fb2aa74 Bug 1698845 - Part 2: Add a test to check the visibility of the cookie blocking info for state partitioning in PBM. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D111934
2021-04-15 07:17:35 +00:00
Tim Huang
c96270666c Bug 1698845 - Part 1: Add a new cookie info for the state partitioning in PBM in 'about:preference#privacy'. r=johannh,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111933
2021-04-15 07:17:34 +00:00
Narcis Beleuzu
2fd43d5a0b Backed out 7 changesets (bug 1704948, bug 1704879) for bc failures on browser_ext_menus_capture_secondary_click.js
Backed out changeset 02705918c4bf (bug 1704879)
Backed out changeset 79945b876a1d (bug 1704879)
Backed out changeset eb725de20b11 (bug 1704948)
Backed out changeset 454597ac2ba3 (bug 1704948)
Backed out changeset a43a8ef206ea (bug 1704948)
Backed out changeset 2369e321069e (bug 1704948)
Backed out changeset bdf396edd692 (bug 1704948)
2021-04-15 03:30:52 +03:00
Markus Stange
7f0c1757af Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111955
2021-04-14 21:23:27 +00:00
Kirk Steuber
932e0a6f30 Bug 1703302 - Remove app.background.experimental to show background update UI unconditionally r=nalexander,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111199
2021-04-14 17:50:07 +00:00
alwu
2143d1c4ea Bug 1700829 - remove probe expiring in Fx90 : MEDIA_CONTROL_SETTING_CHANGE. r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111657
2021-04-14 16:56:57 +00:00
Michelle
a3ed4588e3 Bug 1704006 - Removed expired telemetry probe preferences.use_bookmark from Scalar.yaml and home.js r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111738
2021-04-13 21:27:59 +00:00
Tim Huang
687a76a8fc Bug 1698843 - Part 5: Modify the tests to check the behavior of setting cookieBehavior in custom mode. r=pbz
This patch modifies two tests browser_contentblocking.js and
browser_contentblocking_categories.js to test the private cookieBehavior
setting in custom mode.

Differential Revision: https://phabricator.services.mozilla.com/D111006
2021-04-13 18:07:12 +00:00
Vijay Budhram
15218741b0 Bug 1701529 - Remove unused FxA toolbar menu items r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111303
2021-04-09 19:08:03 +00:00
Andrei Oprea
5fd4c4ba70 Bug 1699701 - Convert all usages of ExperimentFeature to singleton API r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D110284
2021-04-09 14:13:13 +00:00
Sebastian Hengst
cba2b35987 Backed out changeset d402c8657d3f (bug 1699701) for failing newtab's activity-stream:AboutPreferences Feed and more. CLOSED TREE 2021-04-09 15:35:48 +02:00
Andrei Oprea
ebb65f340a Bug 1699701 - Convert all usages of ExperimentFeature to singleton API r=k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D110284
2021-04-09 12:49:00 +00:00
Umar Ahmed
25e378a62f Bug 1703155 - Remove expired Telemetry probe preferences.use_current_page r=chutten,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111123
2021-04-08 13:05:44 +00:00
Liz Krane
cdc2140a50 Bug 1702370 - Replace BrowserTestUtils.waitForCondition with TestUtils.waitForCondition in browser/components/preferences/tests/siteData/head.js r=prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D110642
2021-04-05 22:39:47 +00:00
Kirk Steuber
7425278256 Bug 1674277 - Make AUS.stopDownload asynchronous r=nalexander,preferences-reviewers
The Downloader's cleanup function really ought to be asynchronous. The observer for "quit-application" is already asynchronous, so there's no problem there. But really, we ought to be cleaning up each downloader that we use, not just the last one. Which means that the cleanup ought to happen in AUS.stopDownload. So this patch will convert AUS.stopDownload to be asynchronous so that we can properly clean up the downloader from there.

Differential Revision: https://phabricator.services.mozilla.com/D110646
2021-04-05 19:52:12 +00:00
Tim Nguyen
639865603e Bug 1701448 - Tweak in-content page styling further for Proton. r=desktop-theme-reviewers,dao
* Update green color used for success
* Fix actions menulist alignment
* Make various elements use new accent colors
* Fix lack of border on HTML checkboxes
* Update various colors to proton colors
* Update input border-radius to 4px
* Update border colors

Differential Revision: https://phabricator.services.mozilla.com/D110033
2021-04-05 19:42:47 +00:00
Csoregi Natalia
2c7d00573d Backed out 2 changesets (bug 1701448, bug 1699917) for failures on browser_parsable_css.js. CLOSED TREE
Backed out changeset 3693f90f395d (bug 1701448)
Backed out changeset 99ce41916bb2 (bug 1699917)
2021-04-05 22:08:42 +03:00
Tim Nguyen
fbd6289896 Bug 1701448 - Tweak in-content page styling further for Proton. r=desktop-theme-reviewers,dao
* Update green color used for success
* Fix actions menulist alignment
* Make various elements use new accent colors
* Fix lack of border on HTML checkboxes
* Update various colors to proton colors
* Update input border-radius to 2px
* Update border colors

Differential Revision: https://phabricator.services.mozilla.com/D110033
2021-04-05 16:29:18 +00:00
Drew Willcoxon
f4fe098e2a Bug 1701756 - Fix stretched navbar images in the search bar preferences UI. r=Gijs,preferences-reviewers
We just need to set `align=start` on `#searchBarVisibleGroup`. There are a
couple of things to note about this:

* The images are stretched only when the Quick Suggest checkbox is visible,
  which it isn't unless the Quick Suggest pref is enabled
* This is broken even without the Quick Suggest checkbox because the two images
  shrink when the window is narrow

Differential Revision: https://phabricator.services.mozilla.com/D110487
2021-04-01 12:00:49 +00:00
Francesco Lodolo (:flod)
2554bafe65 Bug 1700638 - Remove Sync brand from Menu bar and Settings, r=fluent-reviewers,preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D110012
2021-03-30 14:30:55 +00:00
Tim Huang
0470c65b89 Bug 1695050 - Part 2: Modify CookieJarSettings::Create() to be able to creat cookieJarSettings according to the browsing mode. r=dimi,preferences-reviewers
This patch modifies the current CookieJarSettings::Create() function.
It removes the current function and adds two variants. One takes the
nsIPrincipal as input and another takes the enum value. The new
functions will test if the input is for the private browsing window to
create the corresponding cookieJarSettings.

Differential Revision: https://phabricator.services.mozilla.com/D109045
2021-03-29 11:01:51 +00:00
Bernard Igiri
186b5a93bd Bug 1692303 - Flip default value to browser.ctrlTab.recentlyUsedOrder to false r=mstriemer,mconley,preferences-reviewers
Changed default Ctrl+Tab preference to false and added UI migration to reset it for users who haven't not used the feature before.

Differential Revision: https://phabricator.services.mozilla.com/D109653
2021-03-26 21:56:41 +00:00
Gijs Kruitbosch
1187de795d Bug 1694511 - update references inside the prefs/about:addons to Preferences/Options to use 'Settings' instead, r=preferences-reviewers,fluent-reviewers,jaws,robwu
Differential Revision: https://phabricator.services.mozilla.com/D106199
2021-03-25 19:11:47 +00:00
Csoregi Natalia
a46838a0ab Backed out changeset 816285ac4de4 (bug 1694511) for failures on browser_experimental_features.js. CLOSED TREE 2021-03-24 15:15:27 +02:00
Gijs Kruitbosch
ccc4df07c0 Bug 1694511 - update references inside the prefs/about:addons to Preferences/Options to use 'Settings' instead, r=preferences-reviewers,fluent-reviewers,jaws,robwu
Differential Revision: https://phabricator.services.mozilla.com/D106199
2021-03-24 11:27:27 +00:00
Andrei Oprea
dd3cc61a4e Bug 1694472 - Update UrlbarPrefs to use ExperimentFeature r=k88hudson,mak
Differential Revision: https://phabricator.services.mozilla.com/D106269
2021-03-23 10:26:26 +00:00
Kirk Steuber
64050ee4b5 Bug 1483399 - Add a UI to about:preferences to control app.update.background.enabled r=nalexander,preferences-reviewers,Gijs
The UI is currently hidden unless app.update.background.experimental is set to true. The preferences page must be reloaded after setting this pref.

Differential Revision: https://phabricator.services.mozilla.com/D108705
2021-03-22 20:40:27 +00:00
Valentin Gosu
086f34b47e Bug 1658278 - Split TRR's CONFIRM_TRYING into CONFIRM_TRYING_OK and CONFIRM_TRYING_FAILED r=necko-reviewers,nhnt11,dragana,preferences-reviewers
- Adds CONFIRM_TRYING_FAILED confirmation state. We use this state when we retry confirmation after confirmation fails.
- Rename CONFIRM_TRYING to CONFIRM_TRYING_OK. We use this state when we try confirmation but no confirmation failure has happened.
- Rename CONFIRM_INIT to CONFIRM_OFF. We use this state whenever there is an event that would disable TRR - such as a TRR mode change.
- Add CONFIRM_DISABLED confirmation state. We use this state in mode3 or when confirmationNS=="skip"
- To potentially allow us to have the same behaviour as after Bug 1689113, specifically the we might be able to report TRRService::Enabled = true when retrying and the state is CONFIRM_TRYING_FAILED we added `network.trr.attempt-when-retrying-confirmation`
- After a large number of TRR failures occurs, we immediately trigger another confirmation and go into CONFIRM_TRYING_OK. This allows us to cope with a temporary increase in network latency that is smaller than 6s.
- We no longer trigger confirmation for nsIRequest::TRR_FIRST_MODE when the resolver mode is not TRR_FIRST. This allows us to simplify the code.
- test_trr_proxy.js now calls trr_test_setup() after it sets up the pac script to avoid confirmation causing non-local connections in tests.
- Moves all the confirmation state handing into HandleConfirmationEvent

Differential Revision: https://phabricator.services.mozilla.com/D107666
2021-03-19 17:51:26 +00:00
Mark Banner
fe42d2ce60 Bug 1696027 - Remove use of nsISearchEngine.addEngineWithDetails from mochitests. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107624
2021-03-10 14:21:12 +00:00
Bogdan Tara
2a95503dbc Backed out 2 changesets (bug 369739, bug 1696027) for browser_searchChangedEngine.js and test_webextensions_upgrade.js failures CLOSED TREE
Backed out changeset 2705f924b635 (bug 369739)
Backed out changeset 6e5ccf3eeaa6 (bug 1696027)
2021-03-10 15:36:28 +02:00
Mark Banner
be48c80b3e Bug 1696027 - Remove use of nsISearchEngine.addEngineWithDetails from mochitests. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107624
2021-03-10 12:34:43 +00:00
Mark Banner
3ab4dbb9f2 Bug 1690114 - When a search engine changes properly update the default and the tree in preferences. r=preferences-reviewers,Gijs
Prior to this patch we would only update the icons.

Depends on D107668

Differential Revision: https://phabricator.services.mozilla.com/D107669
2021-03-10 08:48:05 +00:00
Bogdan Tara
6218f17ee1 Backed out 2 changesets (bug 369739, bug 1696027) for test_TelemetryEnvironment.js xpcshell failures CLOSED TREE
Backed out changeset 9ea26aff5a9b (bug 369739)
Backed out changeset 395e7278e415 (bug 1696027)
2021-03-10 10:27:02 +02:00
Mark Banner
a0d1d0b31a Bug 1696027 - Remove use of nsISearchEngine.addEngineWithDetails from mochitests. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D107624
2021-03-10 07:40:22 +00:00
Dale Harvey
483fa9b0fe Bug 1697003 - Update strings for Firefox Suggest experiment r=adw
Differential Revision: https://phabricator.services.mozilla.com/D107525
2021-03-09 12:59:03 +00:00
Gijs Kruitbosch
021ab9e657 Bug 1696645 - fix height of buttons in container settings rows r=preferences-reviewers,desktop-theme-reviewers,ntim
Wrapping text can mean the container name takes up more vertical space.
The buttons should keep their ideal spacing instead of stretching vertically.

Differential Revision: https://phabricator.services.mozilla.com/D107486
2021-03-08 17:19:47 +00:00
Drew Willcoxon
bdd02d3cca Bug 1693671 - Update the Quick Suggest help URL. r=daleharvey,Gijs
We're going with a SUMO page after all and not a blog URL.

Depends on D106940

Differential Revision: https://phabricator.services.mozilla.com/D107012
2021-03-03 00:48:01 +00:00
Bernard Igiri
6a4e30b806 Bug 1685961 - Hide Content Process Limit UI r=Gijs
Hides the "Content Process Limit" UI when Fission is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D105055
2021-03-01 18:23:31 +00:00
Tim Nguyen
40c58f1bbc Bug 1693374 - Make common.css sidebar footer styles re-usable. r=desktop-theme-reviewers,harry,robwu
Differential Revision: https://phabricator.services.mozilla.com/D106300
2021-02-26 22:18:44 +00:00
Butkovits Atila
ef7f377d7a Backed out changeset d146eb93b6d0 (bug 1693374) for causing failures at browser_interaction_telemetry.js. CLOSED TREE 2021-02-26 21:32:25 +02:00
Tim Nguyen
5ee43ca18e Bug 1693374 - Make common.css sidebar footer styles re-usable. r=desktop-theme-reviewers,harry,robwu
Differential Revision: https://phabricator.services.mozilla.com/D106300
2021-02-26 17:44:32 +00:00
Drew Willcoxon
1a2e2be9d8 Bug 1693927 - Record keyed scalar telemetry for impressions and clicks on Quick Suggest results. r=harry,nanj
This adds three new keyed scalars:

* `contextual.services.quicksuggest.impression`: Incremented when a Quick
  Suggest result is shown in an address bar engagement where the user picks any
  result.
* `contextual.services.quicksuggest.click`: Incremented when the user picks a
  Quick Suggest result (not including the help button).
* `contextual.services.quicksuggest.help``: Incremented when the user picks the
  onboarding help button in a Quick Suggest result.

The changes to telemetry.rst and Scalars.yaml have more details.

I modified `TelemetryEvent.typeFromElement()` to return `"help"` for clicks on
the help button so that the quick suggest provider can tell whether the main
part of the result was picked or the help button. I left `"tiphelp"` for tip
help buttons in case anything depends on that.

Depends on D106060

Differential Revision: https://phabricator.services.mozilla.com/D106173
2021-02-25 06:21:30 +00:00
Csoregi Natalia
d96bc26433 Backed out 2 changesets (bug 1693927, bug 1693126) as requested. CLOSED TREE
Backed out changeset f49147a4544b (bug 1693126)
Backed out changeset 8bb5bc9c97b2 (bug 1693927)
2021-02-25 05:08:26 +02:00