Commit Graph

303 Commits

Author SHA1 Message Date
Daniel Varga
0326272045 Backed out changeset 5e048feda16f (bug 1613337) mac and linux opt all_files_referenced failures 2020-02-29 21:12:33 +02:00
Ed Lee
13e79d15aa Bug 1613337 - Support importing Windows Chrome/Edge logins with v10 AEAD format r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D64713
2020-02-29 16:19:18 +00:00
Matthew Noorenberghe
8052744b84 Bug 1582738 - ChromeProfileMigrator: Don't initialize crypto if there are no rows. r=Gijs
Initializing OSCrypto can lead to a useless macOS Keychain prompt when there are no logins to import.

Differential Revision: https://phabricator.services.mozilla.com/D46616
2020-01-28 10:50:10 +00:00
Matthew Noorenberghe
4c950765ff Bug 1216186 - Use the actual browser name for imported bookmark folders from Chromium. r=Gijs
Using _getLocalePropertyForBrowser isn't ideal but ideally this patch would get uplifted so I didn't want to do a larger refactoring to fix this.

Differential Revision: https://phabricator.services.mozilla.com/D61104
2020-01-28 12:27:25 +00:00
Andreea Pavel
004229e0c9 Bug 1558330 - disable test_MigrationUtils_timedRetry.js on mac shippable r=egao
Differential Revision: https://phabricator.services.mozilla.com/D54888
2019-11-27 07:11:51 +00:00
Ehsan Akhgari
e195d030f5 Bug 1591813 - Make nsICookieManager.getCookiesFromHost() return an Array<nsICookie>; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D50750
2019-10-28 12:08:09 +00:00
Mark Hammond
0f63f855d4 Bug 1577662 (part 2) - Profile reset now correctly handles that signed in to FxA doesn't always mean sync. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D47572
2019-10-01 01:12:42 +00:00
Mark Hammond
30236b5212 Bug 1577662 (part 1) - Allow profile refresh test to test multiple refresh scenarios. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D47571
2019-10-01 01:12:23 +00:00
Matthew Noorenberghe
4ae7f7853a Bug 1423714 - Import logins from Chrome/Chromium on macOS. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D45155
2019-09-18 04:47:34 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Ciure Andrei
c0802578d1 Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE 2019-08-19 13:00:44 +03:00
Moritz Birghan
ecdc572dbd Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614
2019-08-19 07:17:12 +00:00
Matthew Noorenberghe
16e6094f43 Bug 1569414 - Don't hardcode a too old history visit date in test_Chrome_history.js.
Differential Revision: https://phabricator.services.mozilla.com/D39606
2019-07-27 15:57:53 +00:00
Gijs Kruitbosch
20abdebabd Bug 1557960 - cope with 0 values in Chrome's date/time columns when importing, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D37810
2019-07-15 21:52:56 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Maliha Islam
29ba83b477 Bug 1559975 - Make directories python3 compatible r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D35257
2019-07-02 15:47:34 +00:00
Boris Zbarsky
95de682140 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196
2019-06-11 15:51:51 +00:00
Matthew Noorenberghe
b45e2f12a4 Bug 1148205 - Replace misnamed formSubmitURL and hostname properties on nsILoginInfo in browser/. r=jaws,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D33346
2019-06-05 05:33:24 +00:00
Andrea Marchesini
5cde15b155 Bug 1554464 - Merge nsICookie2 and nsICookie in 1 single interface, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33031
2019-05-31 09:36:44 +00:00
Andrea Marchesini
da871a46a1 Bug 1551798 - Rename nsICookie2.SAMESITE_UNSET to nsICookie2.SAMESITE_NONE, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31214
2019-05-29 15:55:03 +00:00
arthur.iakab
f6d085aa58 Backed out 5 changesets (bug 1551798) for multiple build bustages on StaticPrefList.h CLOSED TREE
Backed out changeset c89daff34d97 (bug 1551798)
Backed out changeset bbc3f88b8c03 (bug 1551798)
Backed out changeset b87996b8a411 (bug 1551798)
Backed out changeset d88b0002d736 (bug 1551798)
Backed out changeset 0fe740c90e2b (bug 1551798)
2019-05-29 18:07:26 +03:00
Andrea Marchesini
f2a2bcb708 Bug 1551798 - Rename nsICookie2.SAMESITE_UNSET to nsICookie2.SAMESITE_NONE, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31214
2019-05-24 15:18:49 +00:00
Boris Zbarsky
6babe3ddd4 Bug 1551657 part 3. Stop using [array] in findLogins. r=MattN
I audited the results from
https://searchfox.org/mozilla-central/search?q=%5B%5EA-Za-z_%5D%5BFf%5DindLogins%5B%5EA-Za-z_%5D&case=true&regexp=true&path=

Differential Revision: https://phabricator.services.mozilla.com/D31119
2019-05-14 19:28:52 +00:00
Boris Zbarsky
bc9de78e60 Bug 1551657 part 1. Stop using [array] in getAllLogins. r=MattN
I audited all the callsites
https://searchfox.org/mozilla-central/search?q=%5B%5EA-Za-z_%5D%5BGg%5DetAllLogins%5B%5EA-Za-z_%5D&case=true&regexp=true&path=
brings up.

Differential Revision: https://phabricator.services.mozilla.com/D31117
2019-05-14 19:28:51 +00:00
Matthew Noorenberghe
b0aa646e82 Bug 1543258 - Handle NULL 'action_url' for Chrome login import. r=sfoster
Save it with the wildcard "" value so it works with any form action.

Differential Revision: https://phabricator.services.mozilla.com/D30332
2019-05-09 22:59:18 +00:00
Sylvestre Ledru
d42e742a3e Bug 1519636 - Reformat recent changes to the Google coding style r=Ehsan
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D24168
2019-03-31 15:12:55 +00:00
Mark Banner
d5029e0dae Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850
2019-03-28 09:38:14 +00:00
Matthew Noorenberghe
5e9e9d9890 Bug 1533288 - Test import of Internet Explorer history. r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D22845
2019-03-13 03:12:15 +00:00
Matthew Noorenberghe
bfd2a05dbb Bug 1533288 - Add an executable to insert IE history on test machines. r=jaws,firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D22844
2019-03-13 03:12:08 +00:00
Jared Wein
37fef0239b Bug 1529495 - Remove unused third argument to OSCrypto.decryptData and OSCrypto.encryptData. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D20628
2019-02-21 15:35:27 +00:00
Jared Wein
623d84cec0 Bug 1520949 - Use TextEncoder/TextDecoder to handle multibyte characters in passwords. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D20625
2019-02-21 15:34:57 +00:00
Joel Maher
91c8d51ae3 Bug 1522900 - adjust manifests to allow tests to pass on windows10 1803 release. r=gbrown CLOSED TREE 2019-02-11 10:02:51 +01:00
Marco Bonardo
b68bb48ee4 Bug 1522818 - Skip test_IE_cookies.js when cookies are not stored as files. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D17953
2019-01-30 00:08:39 +00:00
Mark Banner
98c7d8dead Bug 1520808 - Allow importing of history from Chrome even if it was created in the future. r=mak
Rather than aborting adding data, we set the history items to have the current date/time. This seems mildly better than throwing away the history data.

Differential Revision: https://phabricator.services.mozilla.com/D17830
2019-01-29 12:06:05 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Dave Townsend
6e8218eb19 Bug 1518587: Move startup profile selection to nsToolkitProfileService. r=froydnj
Currently nsAppRunner is responsible for choosing or creating a profile to use
at startup. It then has to create a reset profile if necessary and lock the
selected profile directories. But these latter things are done in different
places of the selection code and done in different ways, sometimes we delay
while trying to get the lock, sometimes we don't.

This patch moves the profile selection part of the code to its own function so
that then we only have to have one place that does the profile reset and
locking logic.

It makes a lot of sense to have the selection code live in the profile service.
It can use information from the database load to help make the choices and it
also means that we can expose the profile selection code through xpcom allowing
it to be easily automatically tested. It will also be more important for future
patches for the dedicated profiles feature.

Differential Revision: https://phabricator.services.mozilla.com/D16116
2019-01-14 17:27:34 +00:00
Henrik Skupin
7b158d8d5b Bug 1499367 - Improve assertion for profileNameToRemove in test_refresh_firefox.py. r=Gijs
assertIn(el, list) should be favored over assertTrue(el in list),
which gives clear details about what is different.

Differential Revision: https://phabricator.services.mozilla.com/D8857
2018-10-16 14:40:46 +00:00
Gijs Kruitbosch
e76c445ba7 Bug 1488926 - remove automigration code (already preffed off), r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D8425
2018-10-11 17:04:59 +00:00
Doug Thayer
6c2f2815de Bug 1426245 - Test changes r=mak
MozReview-Commit-ID: 4fhhzspxLJZ

Depends on D4606

Differential Revision: https://phabricator.services.mozilla.com/D5162
2018-10-09 14:47:31 +00:00
Andrea Marchesini
3c6400c151 Bug 1260399 - Remove deprecated messages in nsICookieManager methods - part 2 - nsICookieManager.getCookiesFromHost(), r=ehsan 2018-09-24 11:37:57 +02:00
Andrea Marchesini
624a129768 Bug 1260399 - Remove deprecated messages in nsICookieManager methods - part 1 - nsICookieManager.add(), r=ehsan 2018-09-24 11:37:56 +02:00
Kris Maglione
f6a4413b4c Bug 1484496: Part 5a - Convert browser/ nsISimpleEnumerator users to use JS iteration. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3729
2018-08-18 19:27:33 -07:00
Jonathan Kingston
d50c555bf6 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb r?=gijs
Summary: Depends on D2046

Reviewers: ckerschb!, Gijs!

Tags: #secure-revision

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047
2018-07-06 21:16:29 +01:00
dvarga
86b7ee6d9f Backed out 2 changesets (bug 1362034) for failure at browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE
Backed out changeset 1c3329958b8a (bug 1362034)
Backed out changeset f68b1b76af36 (bug 1362034)
2018-08-08 22:11:56 +03:00
Jonathan Kingston
92858e3e21 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047
2018-08-08 20:05:30 +03:00
Andreea Pavel
31fb9c007c Backed out 2 changesets (bug 1362034) for failing damp | inspector/cold-open.js on a CLOSED TREE
Backed out changeset 8c8925b75aa2 (bug 1362034)
Backed out changeset ff6b05c96094 (bug 1362034)
2018-08-06 20:42:44 +03:00
Jonathan Kingston
c7bb2480d8 Bug 1362034 - Tests for addTab() to provide the correct triggering principal. r=ckerschb,Gijs
Summary: Depends on D2046

Reviewers: ckerschb, Gijs

Reviewed By: ckerschb, Gijs

Bug #: 1362034

Differential Revision: https://phabricator.services.mozilla.com/D2047
2018-08-06 19:56:37 +03:00
Gijs Kruitbosch
c9e0866650 Bug 1434281 - also delete local/cache profile directory from refresh test, r=whimboo
Ensure local profile directory is also deleted in test teardown.

Differential Revision: https://phabricator.services.mozilla.com/D2671
2018-08-02 18:54:28 +00:00
Mark Banner
76e8f30587 Bug 1478305 - Remove unnecessary imports and fix ESLint warnings about unused variables for browser/. r=jaws
MozReview-Commit-ID: 1vHR6ixePkN
2018-07-30 10:27:36 +01:00
Mark Banner
9723b146c2 Bug 1478308 - Remove unnecessary ChromeUtils.imports in browser/ r=mikedeboer
MozReview-Commit-ID: BYTDdLU2HoM
2018-07-25 09:10:07 +01:00