Commit Graph

140 Commits

Author SHA1 Message Date
Jens Stutte
9a46720c62 Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 22:11:58 +00:00
Cosmin Sabou
8ec6cda9d8 Backed out changeset 03cae7800b41 (bug 1678330) for mochitest plain failures on test_window_open_discarded_bc.html. CLOSED TREE 2021-03-02 20:18:21 +02:00
Jens Stutte
7ef53cdaed Bug 1678330: Ensure nested SpinEventLoopUntil(OrShutdown) calls are traceable to the originating source in case of crash. r=nika,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106839
2021-03-02 15:15:20 +00:00
Gijs Kruitbosch
7e34ee9722 Bug 1665442 - remove the import button once the user successfully imports bookmarks, r=jaws
Any import of bookmarks that attempts to insert at least 1 bookmark successfully
will be treated as a success. This avoids discounting imports where one or more
bookmarks could not be imported due to issues with the URL, especially because
the user has no obvious remedial options - retrying is unlikely to fix things.

Differential Revision: https://phabricator.services.mozilla.com/D93768
2020-10-20 15:28:28 +00:00
Gijs Kruitbosch
005c43d234 Bug 1665442 - show an import button on the bookmarks toolbar for new profiles without bookmarks, r=jaws,fluent-reviewers,flod,dao
Differential Revision: https://phabricator.services.mozilla.com/D93618
2020-10-20 15:29:30 +00:00
Gijs Kruitbosch
7f44ca97cb Bug 1665442 - cleanup in browser migration code while passing by, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D93617
2020-10-20 13:04:40 +00:00
Ed Lee
a8bebc9422 Bug 1665802 - Directly migrate importable passwords without wizard for single profile r=sfoster
Share importable handling from LoginManagerParent and support directly migrating.

Differential Revision: https://phabricator.services.mozilla.com/D90635
2020-09-24 20:00:08 +00:00
Mihai Alexandru Michis
027da3f15f Backed out 2 changesets (bug 1666373, bug 1665802) for causing gv-junit and xpcshell failures.
Backed out changeset 296c8ba967c9 (bug 1666373)
Backed out changeset c1fe3374ab97 (bug 1665802)
2020-09-24 10:52:40 +03:00
Ed Lee
379dc903a1 Bug 1665802 - Directly migrate importable passwords without wizard for single profile r=sfoster
Share importable handling from LoginManagerParent and support directly migrating.

Differential Revision: https://phabricator.services.mozilla.com/D90635
2020-09-23 22:32:47 +00:00
Jared Wein
d4a3809d85 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 15:56:36 +00:00
Mihai Alexandru Michis
4b61ccb021 Backed out changeset 8b917683232d (bug 1656277) for causing xpcshell failures in test_IE_bookmarks.js
CLOSED TREE
2020-08-14 08:36:35 +03:00
Jared Wein
41d021123f Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is behind a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-14 03:27:22 +00:00
Csoregi Natalia
aa0319a6dd Backed out changeset 4fc26e678c18 (bug 1656277) for failures on test_Edge_db_migration.js. CLOSED TREE 2020-08-14 04:21:35 +03:00
Jared Wein
1f16b4feae Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Noemi Erli
4de7581677 Backed out changeset c2c4b8d6b915 (bug 1656277) for causing build bustages in nsDocShell.cpp CLOSED TREE 2020-08-14 01:13:41 +03:00
Jared Wein
cccc0ccf92 Bug 1656277 - Show the bookmarks toolbar after migration if bookmarks were in the other browsers toolbar. r=MattN,Standard8
This is controlled by a pref so we can run a study on it.

Differential Revision: https://phabricator.services.mozilla.com/D85956
2020-08-13 21:56:40 +00:00
Kris Maglione
9bddbcfdd1 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Gijs Kruitbosch
df86f6d8ed Bug 1643321 - fix missing/differently-identified fluent localization of browser profile migration data types, r=MattN,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D78412
2020-06-08 12:00:38 +00:00
Riley Byrd
1ebb0c9974 Bug 1518234 - Migrate migration wizard to Fluent r=flod,Gijs,fluent-reviewers
Based on a patch originally written by Ian Kirkpatrick <kirkpa47@msu.edu>

Differential Revision: https://phabricator.services.mozilla.com/D17393
2020-06-02 06:46:09 +00:00
Ed Lee
361cbdb4a5 Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128
2020-03-13 23:38:52 +00:00
Dão Gottwald
226dceee35 Bug 1620536 - Move "Import from Another Browser" to the Help menu. r=Mardak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D66551
2020-03-13 17:29:15 +00:00
Matthew Noorenberghe
1c4e674073 Bug 1608513 - Chromium Edge migrator support on Windows and macOS. r=Gijs
Microsoft supports using both old and new Edge in side-by-side (SxS) mode so both migrators should be supported if they have data.

Also rename the existing EdgeHTML Edge migrator to "Microsoft Edge Legacy" to allow disambiguation. This is the name Microsoft uses in side-by-side (SxS) mode.

Differential Revision: https://phabricator.services.mozilla.com/D60621
2020-01-22 18:35:11 +00:00
Matthew Noorenberghe
5d4b5120a2 Bug 1605491 - Add Chromium Edge Beta migrator support on Windows. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D59542
2020-01-11 00:05:09 +00:00
Matthew Noorenberghe
b94148f2ca Bug 1605491 - Add Chromium Edge Beta migrator support on macOS. r=Gijs
Re-using all of the import logic from our Chrome/Chromium migrator.

Differential Revision: https://phabricator.services.mozilla.com/D58203
2020-01-10 21:40:30 +00:00
premk
ad0520c6ab Bug 1523179 - Support Chrome Beta import on Windows. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D59541
2020-01-10 20:00:10 +00:00
Matthew Noorenberghe
452fd0c08f Bug 1523179 - Fix Linux Chrome Beta and Chrome Dev migrator support and telemetry. r=Gijs
Symbols exported from a JSM cannot be nested inside an `if` otherwise `undefined` will be exported. I don't think it's worth filing a bug for that considering bug 1608269 is coming.

Differential Revision: https://phabricator.services.mozilla.com/D58202
2020-01-10 21:13:50 +00:00
Emma Malysz
ce4da4686b Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751
2019-12-11 00:27:19 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Boris Zbarsky
95de682140 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196
2019-06-11 15:51:51 +00:00
Soeren Hentzschel
e2b69c9c3e Bug 1522856 - Add an "import" option to the file menu to make browser migration discoverable. r=MattN,felipe
Differential Revision: https://phabricator.services.mozilla.com/D19274
2019-03-04 15:29:03 -08:00
Mark Banner
98c7d8dead Bug 1520808 - Allow importing of history from Chrome even if it was created in the future. r=mak
Rather than aborting adding data, we set the history items to have the current date/time. This seems mildly better than throwing away the history data.

Differential Revision: https://phabricator.services.mozilla.com/D17830
2019-01-29 12:06:05 +00:00
Kris Maglione
856fa07b17 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750
2019-01-17 10:18:31 -08:00
Kris Maglione
2fe938bed2 Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888
2018-10-25 19:04:01 -07:00
arthur.iakab
60aefe8252 Backed out 2 changesets (bug 1482091) for bc failures on browser_domFullscreen_fullscreenMode.js
Backed out changeset bc03f101937e (bug 1482091)
Backed out changeset 28a19b7290ab (bug 1482091)
2018-11-03 01:08:36 +02:00
Kris Maglione
937d3bc224 Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888
2018-10-25 19:04:01 -07:00
arthur.iakab
0b02a4f71d Backed out 2 changesets (bug 1482091)for failing browser chrome failures on browser_panelUINotifications_fullscreen_noAutoHideToolbar.js
Backed out changeset afd0a13bcfff (bug 1482091)
Backed out changeset a19c6b3e0402 (bug 1482091)
2018-11-02 23:01:15 +02:00
Kris Maglione
31d1c1a1da Bug 1482091: Part 2 - Remove TelemetryStopwatch.jsm in favor of native implementation. r=chutten
Differential Revision: https://phabricator.services.mozilla.com/D9888
2018-10-25 19:04:01 -07:00
Gijs Kruitbosch
e76c445ba7 Bug 1488926 - remove automigration code (already preffed off), r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D8425
2018-10-11 17:04:59 +00:00
Kris Maglione
0847e8227e Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB
2018-05-25 17:02:29 -07:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Ganesh Chaitanya Kale
67bb868656 Bug 1282770 - Convert uses of PU.asyncHistory.updatePlaces in browser/components/migration to PU.history.insertMany. r=mak
Patch originally by Ganesh, updated by Standard8

MozReview-Commit-ID: AihTLo5OyK1
2018-03-20 12:36:31 +00:00
Felipe Gomes
4351746c37 Bug 1439443 - Policies: Don't create the default and smart bookmarks on the profile. r=mak 2018-03-16 21:02:05 -03:00
Kit Cambridge
1e89ded632 Bug 1199077 - Split change sources for automatic and manual bookmark restores. r=mak
MozReview-Commit-ID: 1glcCPj2X90
2018-03-01 13:37:13 -08:00
Gijs Kruitbosch
ac044211af Bug 1437940 - include Chrome Beta and Chrome Dev in migration list on Linux, r=dthayer
MozReview-Commit-ID: HDTkdXdYos3
2018-03-01 14:03:06 +00:00
Sebastian Hengst
4e51639fe3 merge mozilla-central to autoland on a CLOSED TREE 2018-02-24 03:07:44 +02:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Doug Thayer
396519498c Bug 1432529 - Exit spinEventLoopUntil when canceling migrator r=Gijs
Fairly trivial - discussed in bug 862127. Opt to cancel the spin wait
rather than disable canceling in the UI.

MozReview-Commit-ID: B55Fsw34uX7
2018-02-15 11:55:10 -08:00
Margareta Eliza Balazs
7ec62aee45 Backed out changeset ebbcdc3e642d (bug 1433593) for X failing in toolkit/components/passwordmgr/test/unit/test_maybeImportLogin.js on a CLOSED TREE 2018-02-16 04:50:42 +02:00
Doug Thayer
2a70781cd0 Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00