Drew Willcoxon
cde79dcab3
Bug 1692526 - Allow results to include a help/info button. r=dao
...
This supports a new `helpUrl` payload property on all results. It causes results
in the view to have a help button that can be selected and picked independently
of the main part of the result. When picked, the help button loads the
`helpUrl`. It looks and acts the same as the help buttons we already have for
tip results.
The help button should be flush with the trailing edge of the result row, and it
should be selectable independently from the main part of the result. To achieve
that without disrupting things too much, I create the button inside of
`.urlbarView-row` but outside of `.urlbarView-row-inner`. The "main" part of the
row is `.urlbarView-row-inner`. I made `.urlbarView-row` have `display: flex` so
the the inner part can have `flex: 1` so it can fill up the entire row except
for the help button.
This also reworks view selection a little so that for each row, we look for
selectable elements in the row instead of assuming that the row itself is
selectable. That also lets us remove a couple of special cases for tip and
dynamic results.
Differential Revision: https://phabricator.services.mozilla.com/D105095
2021-02-18 18:00:22 +00:00
Daisuke Akatsuka
46c5bd7203
Bug 1678618: Apply page-removed event. r=mak
...
Depends on D101114
Differential Revision: https://phabricator.services.mozilla.com/D101115
2021-02-15 08:04:15 +00:00
Csoregi Natalia
9ef5ee3b2c
Backed out 4 changesets (bug 1678618) for node failures. CLOSED TREE
...
Backed out changeset e714440f6c0d (bug 1678618)
Backed out changeset ae83fda183dd (bug 1678618)
Backed out changeset bef0ea72ded8 (bug 1678618)
Backed out changeset ec96259a3f81 (bug 1678618)
2021-02-15 05:49:54 +02:00
Daisuke Akatsuka
62240408ac
Bug 1678618: Apply page-removed event. r=mak
...
Depends on D101114
Differential Revision: https://phabricator.services.mozilla.com/D101115
2021-02-15 02:47:38 +00:00
digitalsimboja
6d5d3bf4b4
Bug 1692349 - Remove unreliable assertion in test_ext_menu_caller.js r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D105106
2021-02-14 11:50:25 +00:00
Mark Banner
c991d8611e
Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D104683
2021-02-11 22:02:15 +00:00
digitalsimboja
c3f90e331f
Bug 1588616 -Test case added Fix ext-menus.js to call withLastError with caller r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D103442
2021-02-11 13:42:31 +00:00
Alessio Placitelli
5a13124796
Bug 1691144 - Trigger windows.onFocusChanged with no private window permission. r=zombie
...
Credits to Jonathan Mayer for submitting the original patch.
The patch changes the onFocusChanged extension event handler
so that it no longer bails out if focus is moving to a private
window, ensuring that the onFocusChanged event gets generated
with the proper WINDOW_ID_NONE identifier.
Differential Revision: https://phabricator.services.mozilla.com/D104732
2021-02-11 09:26:29 +00:00
Mark Banner
2ce2957e83
Bug 1690750 - Simplify OpenSearchEngine to only allow loading engines from protocols where users can load them from. r=mak
...
The urls where an OpenSearch engine can be loaded from are already limited in LinkHandlerChild. This is cleaning up and simplifying what the OpenSearchEngine allows, and as a result allows the load path handling to be greatly simplified.
The test changes are due to no longer allowing chrome or file protocols. For future, we probably want to move away from OpenSearch for most of these, but the changes will make it easier to find the places to update.
Differential Revision: https://phabricator.services.mozilla.com/D104010
2021-02-10 18:12:08 +00:00
Paul Zuehlcke
b6fbc9a3ff
Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh,remote-protocol-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-02-05 13:40:42 +00:00
Agi Sferro
b116176172
Bug 1625593 - Move activeTab functionality to toolkit. r=robwu,esawin
...
Differential Revision: https://phabricator.services.mozilla.com/D95420
2021-02-04 02:19:18 +00:00
Agi Sferro
9f9f82e79a
Bug 1681360 - Implement AppUiTestDelegate for Desktop. r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D101206
2021-02-04 11:35:20 +00:00
Neil Deakin
508ef239bb
Bug 1690029, move image related context menu commands into a single section and remove view image info command, r=Gijs,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D103774
2021-02-03 17:56:25 +00:00
Luca Greco
ecc3c2550a
Bug 1525179 - Use aboutaddons.html at the root of about:addons. r=robwu
...
- Moved aboutaddons.html at the root of the about:addons page
- renamed aboutaddons.js `initialize` global function to `initializeView` (and renamed `show` and `hide` global functions accordingly)
- Simplify initial load logic a bit more:
- remove gCategories
- moved responsability of the CategoriesBox initialization to the `initializationView` function
- replaced initialization logic based on `gPendingInitializations` and `notifyInitialized` with
a `promiseInitialized` global resolved when `initializeView` method has been called and its return value resolved
- Fix test helpers and test failures
- InlineOptionsBrowser: take into account that browser-custom-element does opt-in the delayedConnectedCallback behavior
and browser.loadURI may throw if called while the document is still loading.
Differential Revision: https://phabricator.services.mozilla.com/D96472
2021-02-03 17:08:14 +00:00
Narcis Beleuzu
926d2f6257
Backed out 2 changesets (bug 1596897) for bc failures on browser_search_discovery.js
...
Backed out changeset 635972f169e7 (bug 1596897)
Backed out changeset a84b667007e2 (bug 1596897)
2021-01-30 04:01:21 +02:00
Dorel Luca
5ddb1327fc
Backed out changeset 100bc29bbb72 (bug 1625593) for Browser-chrome failures in gfx/layers/apz/test/mochitest/browser_test_scrollbar_in_extension_popup_window.js. CLOSED TREE
2021-01-30 01:13:18 +02:00
Dorel Luca
92d9fe8486
Backed out 3 changesets (bug 1681360) for Browser-chrome failures in browser/base/content/test/performance/browser_startup_content_subframe.js. CLOSED TREE
...
Backed out changeset 2e07885dda4c (bug 1681360)
Backed out changeset c80806107851 (bug 1681360)
Backed out changeset 49e0948090b9 (bug 1681360)
2021-01-30 01:12:33 +02:00
Agi Sferro
ac03594a01
Bug 1625593 - Move activeTab functionality to toolkit. r=robwu,esawin
...
Differential Revision: https://phabricator.services.mozilla.com/D95420
2021-01-29 19:07:55 +00:00
Agi Sferro
1549d9b1a6
Bug 1681360 - Implement AppUiTestDelegate for Desktop. r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D101206
2021-01-29 19:01:23 +00:00
Paul Zuehlcke
2c4fecbca6
Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh,remote-protocol-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-01-29 16:11:08 +00:00
Brindusan Cristian
b0f9bc02f2
Backed out 2 changesets (bug 1596897) for mochitest failures at browser_setIgnoreCertificateErrors.js. CLOSED TREE
...
Backed out changeset 00c45a405129 (bug 1596897)
Backed out changeset 61304ccbaada (bug 1596897)
2021-01-28 21:53:46 +02:00
Paul Zuehlcke
31296e2f9e
Bug 1596897 - Updated tests for decoupled permissions panel. r=johannh
...
Differential Revision: https://phabricator.services.mozilla.com/D99893
2021-01-28 12:14:43 +00:00
Magnus Melin
0f56a88072
Bug 1524836 - Move new HTML about:config page from browser to toolkit. r=fluent-reviewers,preferences-reviewers,geckoview-reviewers,Gijs,agi
...
Unbitrot and change strategy for geckoview: now map about:config directly in nsAboutRecirector.cpp
Differential Revision: https://phabricator.services.mozilla.com/D25938
2021-01-26 00:27:56 +00:00
Robbendebiene
c1a024b056
Bug 1679688 - make host permissions grant access to privileged parts of the tabs API and fix Bug 1686443 r=robwu,geckoview-reviewers,agi
...
Differential Revision: https://phabricator.services.mozilla.com/D98471
2021-01-23 14:09:22 +00:00
harry
e4a3bcc261
Bug 1687313 - Add international Amazon search suggestions URLs. r=Standard8,mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D102210
2021-01-21 21:57:41 +00:00
Csoregi Natalia
b561be2a41
Backed out changeset 0b6e13411d3f (bug 1646817) for causing crashes on macOS. a=backout
2021-01-18 18:32:42 +02:00
Tomislav Jovanovic
6e70e958b1
Bug 1646817 - Support DocumentChannel process switching in sidebars and popups r=mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D100396
2021-01-14 20:32:24 +00:00
Micah Tigley
8f370a3e55
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs,marionette-reviewers,whimboo,remote-protocol-reviewers
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-14 21:45:14 +00:00
Butkovits Atila
24473dc461
Backed out 4 changesets (bug 1680637, bug 1682395) for causing Marionette failures. CLOSED TREE
...
Backed out changeset 073e0be7db95 (bug 1680637)
Backed out changeset 552b91b31b0f (bug 1682395)
Backed out changeset c80de6c72779 (bug 1680637)
Backed out changeset d513e228b0ad (bug 1680637)
2021-01-13 02:13:06 +02:00
Micah Tigley
c6396a0136
Bug 1680637 - Update tests using the old dialog UI to only use the old UI. r=jaws,Gijs
...
Depends on D100172
Differential Revision: https://phabricator.services.mozilla.com/D101388
2021-01-12 22:32:24 +00:00
Mihai Alexandru Michis
5c1c52ad92
Backed out changeset 6e6788b1853e (bug 1646817) for causing bc failures in browser_ext_popup_api_injection.js
...
CLOSED TREE
2020-12-25 01:54:50 +02:00
Tomislav Jovanovic
15fec10580
Bug 1646817 - Support DocumentChannel process switching in sidebars and popups r=mixedpuppy
...
Differential Revision: https://phabricator.services.mozilla.com/D100396
2020-12-24 20:16:12 +00:00
Shane Caraveo
3055f359f5
Bug 1253129 warn when using focused property with windows.create r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D76944
2020-12-18 19:06:56 +00:00
Sonia Singla
441cbc1780
Bug 1458764 - Removed the references with extensions.webextensions.tabhide.enabled pref. r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D97092
2020-12-17 19:14:07 +00:00
Csoregi Natalia
1673685a38
Backed out 2 changesets (bug 1253129) for causing failures on browser_ext_windows_create_params.js. CLOSED TREE
...
Backed out changeset ac8d0372dcb1 (bug 1253129)
Backed out changeset 016006d107b6 (bug 1253129)
2020-12-17 00:50:20 +02:00
Shane Caraveo
a5582fcca6
Bug 1253129 warn when using focused property with windows.create r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D76944
2020-12-16 19:55:45 +00:00
Kartik Gautam
cb9c278e67
Bug 1679758 - Remove trailing empty lines r=sylvestre,marionette-reviewers,jgraham
...
Differential Revision: https://phabricator.services.mozilla.com/D99595
2020-12-15 10:34:54 +00:00
Dorel Luca
7f1605c133
Backed out changeset f3aaf04fce3b (bug 1679758) for Devtool failures in browser_styleeditor_syncAddProperty.js. CLOSED TREE
2020-12-13 16:38:21 +02:00
Kartik Gautam
2908b96137
Bug 1679758 - Remove trailing empty lines r=sylvestre
...
Differential Revision: https://phabricator.services.mozilla.com/D99595
2020-12-13 13:28:30 +00:00
Tomislav Jovanovic
8503d10dd3
Bug 1680877 - Enable content scripts in extension popups and sidebars r=rpl
...
See comment in ExtensionPolicyService::CheckDocument for details.
Differential Revision: https://phabricator.services.mozilla.com/D99133
2020-12-12 15:59:18 +00:00
Shane Caraveo
a8eeda52ff
Bug 1678786 fix url_overrides_newtab intermittent r=robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D99132
2020-12-11 17:51:56 +00:00
Sam Foster
69e18b4ee0
Bug 1654684 - Add sheet-indicator and preview navigation to the print preview. r=mstriemer,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D96737
2020-12-09 20:56:28 +00:00
ankushduacodes
8c88fe5bcc
Bug 1671579 - Granting the devtools optional permission should also enabled the extension devtools page from a toolbox perspective r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D98841
2020-12-09 17:35:58 +00:00
Csoregi Natalia
4c609e0f1a
Backed out changeset 9d25024d5811 (bug 1680877) for causing failures on browser_ext_menus_events.js. CLOSED TREE
2020-12-09 18:13:47 +02:00
Tomislav Jovanovic
4787438a52
Bug 1680877 - Enable content scripts in extension popups and sidebars r=rpl
...
See comment in ExtensionPolicyService::CheckDocument for details.
Differential Revision: https://phabricator.services.mozilla.com/D99133
2020-12-09 10:10:56 +00:00
Csoregi Natalia
ab71c86aaf
Backed out 2 changesets (bug 1654684) for browser chrome failures with .printPreviewCurrentPageNumber. CLOSED TREE
...
Backed out changeset 2fdc1b5569e1 (bug 1654684)
Backed out changeset 8ae1d037aa9c (bug 1654684)
2020-12-09 16:11:42 +02:00
Sam Foster
b39650600d
Bug 1654684 - Add sheet-indicator and preview navigation to the print preview. r=mstriemer,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D96737
2020-12-09 02:59:26 +00:00
Agi Sferro
04b98eef65
Bug 1625233 - Move xpcshell browsingData to toolkit. r=robwu
...
Depends on D98368
Differential Revision: https://phabricator.services.mozilla.com/D98369
2020-12-04 21:43:32 +00:00
Agi Sferro
a75b71c074
Bug 1625233 - Convert browsingData browser tests to mochitests. r=rpl
...
Depends on D96153
Differential Revision: https://phabricator.services.mozilla.com/D96154
2020-12-04 21:43:22 +00:00
harry
db399473d2
Bug 1679890 - Change UrlbarProviderExtension.notificationTimeout into a pref. r=adw
...
Differential Revision: https://phabricator.services.mozilla.com/D98253
2020-12-01 05:35:45 +00:00