Commit Graph

169 Commits

Author SHA1 Message Date
Gijs Kruitbosch
4be153abfe Bug 1705793 - fix browser_contextmenu.js for image info appearing in devedition, r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D112439
2021-04-17 21:56:43 +00:00
Michelle Goossens
0877de41a4 Bug 1703245 - Move Take Screenshot label above "Search [search engine] for ..." item in the selection context menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D112066
2021-04-14 19:51:55 +00:00
Stephen A Pohl
5cf3b65f8f Bug 1704856: Stop synthesizing events on context menus in browser_contextmenu_share_macosx.js r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111899
2021-04-14 18:01:50 +00:00
Markus Stange
06152d0f89 Bug 1704569 - Don't synthesize events on menus in browser/base/content/test/contextMenu/browser_contextmenu_save_blocked.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111674
2021-04-13 16:22:16 +00:00
Markus Stange
534e869357 Bug 1704569 - Don't synthesize events on menus in browser/base/content/test/contextMenu/browser_view_image.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111670
2021-04-13 16:22:15 +00:00
Markus Stange
a867f81efc Bug 1704572 - Use BrowserTestUtils.is_visible rather than checking the bounding client rect in browser_contextmenu_linkopen.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111684
2021-04-13 15:54:24 +00:00
Markus Stange
b04c4348a5 Bug 1704572 - Use openMenu(true) instead of openPopup() for opening the 'this frame' submenu in browser/base/content/test/contextMenu/browser_contextmenu_iframe.js. r=Gijs
openMenu(true) works on both native and non-native context menus. openPopup() does not work on native context menus.

Differential Revision: https://phabricator.services.mozilla.com/D111682
2021-04-13 15:54:23 +00:00
Michael Kohler
35980293e4 Bug 1700984 - Remove excessive separators in Page context menu r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D110859
2021-04-06 15:50:07 +00:00
Jared Wein
f2fe5abf3d Bug 1692669 - Replace icon group navigation on macOS page context menu with 'normal' menuitems. r=flod,mconley
Differential Revision: https://phabricator.services.mozilla.com/D108475
2021-03-22 14:43:32 +00:00
Sam Foster
c8b09eff21 Bug 1690567 - Hide some sync context menu items when not signed in. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D104746
2021-03-17 04:22:50 +00:00
Michelle Goossens
cdff878083 Bug 1696574 - Adjust "print selection" to come directly after "select all" before the separator with "search [search engine] for..." r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D108318
2021-03-13 19:30:10 +00:00
Micah Tigley
0390222f4b Bug 1697470 - Update video element context menu. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D107960
2021-03-12 18:07:28 +00:00
Jonathan Kew
3db396ce84 Bug 1692673 - Update tests for new Cut/Copy command-enabling behavior. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D107481
2021-03-12 16:34:42 +00:00
Brindusan Cristian
8aedc787eb Backed out 3 changesets (bug 1692673) for bc failures in browser_contextmenu_input.js. CLOSED TREE
Backed out changeset 6060fa16bc3e (bug 1692673)
Backed out changeset 0f6717c26ae3 (bug 1692673)
Backed out changeset 8148b9e5dfba (bug 1692673)
2021-03-12 16:07:49 +02:00
Jonathan Kew
7f62840064 Bug 1692673 - Update tests for new Cut/Copy command-enabling behavior. r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D107481
2021-03-12 12:04:08 +00:00
Erica Wright
e89e696bfa Bug 1692666 - Move 'Search... for...' to a dedicated section. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D107255
2021-03-11 21:26:15 +00:00
Gijs Kruitbosch
9bb1b0f5b5 Bug 1697783 - don't create a share menu on older Windows versions, r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D107997
2021-03-11 20:11:44 +00:00
Neil Deakin
4697e9c46e Bug 1690030, change view image on context menu to default to open in a new tab, r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D107336
2021-03-11 19:54:41 +00:00
Emma Malysz
d226f603eb Bug 1690585, replace screenshot context menu item r=Gijs,fluent-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D106871
2021-03-10 16:12:02 +00:00
Micah Tigley
1b29468c3d Bug 1694512 - Add automated tests for Share item in tab context menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D106999
2021-03-09 23:53:32 +00:00
prathikshaprasadsuman
02ca6f95d5 Bug 1692329 - Remove (No login suggestions) context menu item and hide the use saved login item where there are no matching saved logins. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D106961
2021-03-09 14:56:59 +00:00
Gijs Kruitbosch
6880b01455 Bug 1695942 - fix context menu tests for beta, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D107534
2021-03-08 23:04:22 +00:00
Michelle Goossens
d577a427d6 Bug 1692628 - Update ordering of developer items in the content context menu r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D106834
2021-03-05 00:15:23 +00:00
Neil Deakin
cded37bb53 Bug 1686931, merge view image and view background image commands on context menu, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D103775
2021-03-04 08:50:30 +00:00
Neil Deakin
9c2b6f8a9a Bug 1691860, move code that hides separators in the content area context menu into a single place that just hides duplicates, r=Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D104615
2021-03-04 00:16:16 +00:00
prathiksha
14c8c67c31 Bug 1692322 - Move view saved logins context menu item to the top level and rename to manage logins. r=sfoster,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D106470
2021-03-03 11:53:51 +00:00
Gijs Kruitbosch
5b97d7ab3a Bug 1686929 - only show the inspect a11y properties menuitem for devtools users, r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D105086
2021-03-01 10:28:01 +00:00
Michelle Goossens
ad74dbf9dd Bug 1692339 - Add a "Redo" option underneath "Undo" in context menu for form fields r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D106565
2021-02-27 01:19:38 +00:00
Butkovits Atila
97b8fba0d3 Backed out changeset a2091ee84e0e (bug 1692339) for causing failures at browser_contextmenu_keyword.js. CLOSED TREE 2021-02-27 01:23:52 +02:00
Michelle Goossens
dbaa1097f9 Bug 1692339 - Add a "Redo" option underneath "Undo" in context menu for form fields r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D106565
2021-02-26 20:04:29 +00:00
Jared Wein
d5e6d39d95 Bug 1692330 - Hide the 'Add a keyword for this search' when inside of a login form. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D106314
2021-02-25 12:15:23 +00:00
Michelle Goossens
2530101ace Bug 1692670 - Remove separator between delete and "select all" in the content context menu r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D105992
2021-02-24 17:54:03 +00:00
Michelle Goossens
a9e57d7d25 Bug 1692553 - Remove "View page info" from page context menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D105987
2021-02-23 16:09:43 +00:00
Mark Banner
c991d8611e Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104683
2021-02-11 22:02:15 +00:00
Neil Deakin
508ef239bb Bug 1690029, move image related context menu commands into a single section and remove view image info command, r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D103774
2021-02-03 17:56:25 +00:00
Oliver Pope
1e1d271b73 Bug 1626600 - removed PiP from browser_contextmenu tests r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D102865
2021-01-24 18:10:31 +00:00
Kartik Gautam
619cd73acb Bug 1684173 - Add newline character at end of files when missing r=sylvestre,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D100484
2021-01-07 08:53:08 +00:00
Cosmin Sabou
5980f4a6e1 Backed out changeset dbed1cdf588f (bug 1684173) for mochitest plain and devtools failures. a=backout DONTBUILD 2020-12-28 00:43:51 +02:00
Kartik Gautam
25fc1e9e28 Bug 1684173 - Add newline character at end of files when missing r=sylvestre
Depends on D100443

Differential Revision: https://phabricator.services.mozilla.com/D100484
2020-12-27 11:43:41 +00:00
Masatoshi Kimura
3f071f68b7 Bug 1681642 - Improve error messages when extensions blocked downloads. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D99592
2020-12-12 21:28:13 +00:00
Kagami Sascha Rosylight
0d97c91683 Bug 1680596 - Part 1: Hide <menuitem> behind a flag r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D98684
2020-12-08 05:36:27 +00:00
Cosmin Sabou
54ab981483 Backed out 2 changesets (bug 1680596) for xpcshell and mochitest plain failures. CLOSED TREE
Backed out changeset a5fce6a4b5b9 (bug 1680596)
Backed out changeset 8ea7d760b4a8 (bug 1680596)
2020-12-07 22:02:46 +02:00
Kagami Sascha Rosylight
07d28d5c5f Bug 1680596 - Hide <menuitem> behind a flag r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D98684
2020-12-07 17:03:27 +00:00
Emilio Cobos Álvarez
6e34e31600 Bug 1679050 - Backed out changeset 73181c2aa309 (bug 1455479) for having too many false positives. r=backout,a=NarcisB
MANUAL PUSH: Backout on a CLOSED TREE
2020-11-25 00:41:59 +01:00
Emilio Cobos Álvarez
d2d7231b56 Bug 1455479 - Show paste context menu item when there are paste event listeners. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D97751
2020-11-21 16:22:42 +00:00
David Parks
b06e5865dd Bug 1675349: Update tests under browser/base/content/test for the removal of plugins. r=jmathies
UPDATED
-------
browser/base/content/test/plugins/browser_CTP_favorfallback.js
Test that plugin fallback behavior is correct.
Updated to reflect that plugins always show "alternate" content, which is either the user fallback of the browser's transparent fallback, regardless of the HTML.

browser/base/content/test/plugins/browser_CTP_outsideScrollArea.js
Test that overlay is visible (in layout sense) only if plugin is partially or completely visible.
Changed to test new fallback behavior where overlay is a hidden element with "blockall" atribute.

browser/base/content/test/plugins/browser_CTP_zoom.js
Test that overlay is present and visible at multiple zoom levels.
Adjusted to work with hidden overlay.

browser/base/content/test/performance/browser_startup_mainthreadio.js
Track IO done at browser startup
Removed `UserPlugins.parent` from list since we no longer scan for plugins.

browser/base/content/test/plugins/browser_bug797677.js
bug 797677
Test that plugin instantiation fails (with PLUGIN_UNSUPPORTED and no console error) when MIME type missing.
Removed the cleanup of (unused) test plugin.

browser/base/content/test/contextMenu/browser_contextmenu.js
Test context menu for many types of elements
Removed plugin element portion.

REMOVED
-------
browser/base/content/test/plugins/browser_CTP_contextmenu.js
Test that the CTP activate action in content menus for plugins works

browser/base/content/test/plugins/browser_CTP_crashreporting.js
Test that plugin crash submissions still work properly after click-to-play activation.

browser/base/content/test/plugins/browser_CTP_drag_drop.js
Test that plugin CTP dialog behaves correctly when dragging tab out of/into a window

browser/base/content/test/plugins/browser_CTP_hide_overlay.js
Test ability to close plugin "overlay" placeholder (the grey lego element)

browser/base/content/test/plugins/browser_CTP_iframe.js
Test that overlay can be interacted with (closed) when in an iframe

browser/base/content/test/plugins/browser_CTP_nonplugins.js
Bug 926605
Says it tests that non-plugin <object> elements don't show CTP but it doesn't.  It tests that removing a CTP plugin from a page does not remove CTP dialog (in case, for example, page shows, then quickly removes plugin).

browser/base/content/test/plugins/browser_CTP_overlay_styles.js
Verify that styling on overlay elements, based on sizing, is correct.

browser/base/content/test/plugins/browser_CTP_resize.js
Test that a resize properly updates the overlay styling, which is only visible when large enough.

browser/base/content/test/plugins/browser_CTP_shouldShowOverlay.js
Test that partially obscured plugins show the overlay, properly styled (when they should).

browser/base/content/test/plugins/browser_blocking.js
bug 1129040
Test CTP behavior -- overlay dialog behavior, vulnerable plugin user approval, plugin's infoURL, etc.

browser/base/content/test/plugins/browser_blocklist_content.js
bug 1129040
Test (plugin) blocklist, including attempt to "hack" it in a content process.

browser/base/content/test/plugins/browser_bug743421.js
Test CTP approval persists for new plugin instances in page.

browser/base/content/test/plugins/browser_bug744745.js
Test that CTP notification correctly appears despite plugin with opacity: 0 !important

browser/base/content/test/plugins/browser_bug787619.js
bug 787619
Make sure CTP works for plugins nested inside <a></a> elements.

browser/base/content/test/plugins/browser_bug812562.js
bug 812562
Navigating away from, then back to a page should restore its CTP status.

browser/base/content/test/plugins/browser_bug818118.js
bug 818118
Test that CTP plugin and "unknown" plugin type work correctly on same page.

browser/base/content/test/plugins/browser_clearplugindata.js
Test clearing plugin data using Sanitizer.jsm

browser/base/content/test/plugins/browser_iterate_hidden_plugins.js
Bug 1318383
Test `plugins.navigator.hidden_ctp_plugin`, which hides CTP plugins from `navigator.plugins`.

browser/base/content/test/plugins/browser_pluginCrashCommentAndURL.js
Test plugin crash detection and reporting

browser/base/content/test/plugins/browser_pluginCrashReportNonDeterminism.js
Bug 1110887
Test both "plugin process crash notification" orders -- content proc before main proc and vice-versa.

browser/base/content/test/plugins/browser_plugin_reloading.js
Bug 1129040
Re-instantiating plugin (using `plugin.src = new_value`) should retain CTP approval.

browser/base/content/test/plugins/browser_plugin_framed_domain.js
Plugin CTP prompts should adopt top-level page's principal for instead of closest frame's principal.

browser/base/content/test/plugins/browser_pluginnotification.js
Tests many CTP interface behavior cases -- doorhangers, overlays, multiple plugin instances, CTP choices (always, allow, never)

browser/base/content/test/plugins/browser_private_clicktoplay.js
Make sure CTP interface works in private windows

browser/base/content/test/plugins/browser_subframe_access_hidden_plugins.js
Allow navigator.plugins to list plugin after CTP approval, even if it listed in `plugins.navigator.hidden_ctp_plugin`

Differential Revision: https://phabricator.services.mozilla.com/D95906
2020-11-18 15:56:56 +00:00
Bogdan Tara
d1cceb4cfb Backed out 19 changesets (bug 1675349) for lint failures on browser_ext_browsingData_pluginData and test_archive CLOSED TREE
Backed out changeset 244e0f2b410c (bug 1675349)
Backed out changeset ba5724069dd4 (bug 1675349)
Backed out changeset 37fca259c7e9 (bug 1675349)
Backed out changeset f2b16caca1fc (bug 1675349)
Backed out changeset 28835d4935be (bug 1675349)
Backed out changeset eb913f58953a (bug 1675349)
Backed out changeset 19e3cb80f469 (bug 1675349)
Backed out changeset d9723f3a3a7e (bug 1675349)
Backed out changeset c888dfcdf70e (bug 1675349)
Backed out changeset 48f153341af6 (bug 1675349)
Backed out changeset 7fc67a9b2932 (bug 1675349)
Backed out changeset 1cee4d97f801 (bug 1675349)
Backed out changeset 59a0cb79c7c1 (bug 1675349)
Backed out changeset 43d349fa37b1 (bug 1675349)
Backed out changeset c84bfb6eae59 (bug 1675349)
Backed out changeset 38e9af69ae57 (bug 1675349)
Backed out changeset 3255c1ab3059 (bug 1675349)
Backed out changeset 2f3eaf9c342c (bug 1675349)
Backed out changeset 769e5c0db4c2 (bug 1675349)
2020-11-18 06:06:36 +02:00
David Parks
5dde62cdb6 Bug 1675349: Update tests under browser/base/content/test for the removal of plugins. r=jmathies
UPDATED
-------
browser/base/content/test/plugins/browser_CTP_favorfallback.js
Test that plugin fallback behavior is correct.
Updated to reflect that plugins always show "alternate" content, which is either the user fallback of the browser's transparent fallback, regardless of the HTML.

browser/base/content/test/plugins/browser_CTP_outsideScrollArea.js
Test that overlay is visible (in layout sense) only if plugin is partially or completely visible.
Changed to test new fallback behavior where overlay is a hidden element with "blockall" atribute.

browser/base/content/test/plugins/browser_CTP_zoom.js
Test that overlay is present and visible at multiple zoom levels.
Adjusted to work with hidden overlay.

browser/base/content/test/performance/browser_startup_mainthreadio.js
Track IO done at browser startup
Removed `UserPlugins.parent` from list since we no longer scan for plugins.

browser/base/content/test/plugins/browser_bug797677.js
bug 797677
Test that plugin instantiation fails (with PLUGIN_UNSUPPORTED and no console error) when MIME type missing.
Removed the cleanup of (unused) test plugin.

browser/base/content/test/contextMenu/browser_contextmenu.js
Test context menu for many types of elements
Removed plugin element portion.

REMOVED
-------
browser/base/content/test/plugins/browser_CTP_contextmenu.js
Test that the CTP activate action in content menus for plugins works

browser/base/content/test/plugins/browser_CTP_crashreporting.js
Test that plugin crash submissions still work properly after click-to-play activation.

browser/base/content/test/plugins/browser_CTP_drag_drop.js
Test that plugin CTP dialog behaves correctly when dragging tab out of/into a window

browser/base/content/test/plugins/browser_CTP_hide_overlay.js
Test ability to close plugin "overlay" placeholder (the grey lego element)

browser/base/content/test/plugins/browser_CTP_iframe.js
Test that overlay can be interacted with (closed) when in an iframe

browser/base/content/test/plugins/browser_CTP_nonplugins.js
Bug 926605
Says it tests that non-plugin <object> elements don't show CTP but it doesn't.  It tests that removing a CTP plugin from a page does not remove CTP dialog (in case, for example, page shows, then quickly removes plugin).

browser/base/content/test/plugins/browser_CTP_overlay_styles.js
Verify that styling on overlay elements, based on sizing, is correct.

browser/base/content/test/plugins/browser_CTP_resize.js
Test that a resize properly updates the overlay styling, which is only visible when large enough.

browser/base/content/test/plugins/browser_CTP_shouldShowOverlay.js
Test that partially obscured plugins show the overlay, properly styled (when they should).

browser/base/content/test/plugins/browser_blocking.js
bug 1129040
Test CTP behavior -- overlay dialog behavior, vulnerable plugin user approval, plugin's infoURL, etc.

browser/base/content/test/plugins/browser_blocklist_content.js
bug 1129040
Test (plugin) blocklist, including attempt to "hack" it in a content process.

browser/base/content/test/plugins/browser_bug743421.js
Test CTP approval persists for new plugin instances in page.

browser/base/content/test/plugins/browser_bug744745.js
Test that CTP notification correctly appears despite plugin with opacity: 0 !important

browser/base/content/test/plugins/browser_bug787619.js
bug 787619
Make sure CTP works for plugins nested inside <a></a> elements.

browser/base/content/test/plugins/browser_bug812562.js
bug 812562
Navigating away from, then back to a page should restore its CTP status.

browser/base/content/test/plugins/browser_bug818118.js
bug 818118
Test that CTP plugin and "unknown" plugin type work correctly on same page.

browser/base/content/test/plugins/browser_clearplugindata.js
Test clearing plugin data using Sanitizer.jsm

browser/base/content/test/plugins/browser_iterate_hidden_plugins.js
Bug 1318383
Test `plugins.navigator.hidden_ctp_plugin`, which hides CTP plugins from `navigator.plugins`.

browser/base/content/test/plugins/browser_pluginCrashCommentAndURL.js
Test plugin crash detection and reporting

browser/base/content/test/plugins/browser_pluginCrashReportNonDeterminism.js
Bug 1110887
Test both "plugin process crash notification" orders -- content proc before main proc and vice-versa.

browser/base/content/test/plugins/browser_plugin_reloading.js
Bug 1129040
Re-instantiating plugin (using `plugin.src = new_value`) should retain CTP approval.

browser/base/content/test/plugins/browser_plugin_framed_domain.js
Plugin CTP prompts should adopt top-level page's principal for instead of closest frame's principal.

browser/base/content/test/plugins/browser_pluginnotification.js
Tests many CTP interface behavior cases -- doorhangers, overlays, multiple plugin instances, CTP choices (always, allow, never)

browser/base/content/test/plugins/browser_private_clicktoplay.js
Make sure CTP interface works in private windows

browser/base/content/test/plugins/browser_subframe_access_hidden_plugins.js
Allow navigator.plugins to list plugin after CTP approval, even if it listed in `plugins.navigator.hidden_ctp_plugin`

Differential Revision: https://phabricator.services.mozilla.com/D95906
2020-11-18 03:17:34 +00:00
Nika Layzell
ed9e85fc9a Bug 1671983 - Part 4: Stop awaiting BrowserTestUtils.loadURI, r=annyG,remote-protocol-reviewers,extension-reviewers,preferences-reviewers,whimboo,zombie
This method only is async in order to allow callers to wait for a process switch
triggered by the call to `loadURI` to be finished before resolving. With
DocumentChannel, we should never trigger a process switch eagerly like this
again, so we don't need any of the async behaviour here anymore.

This part is largely mechanical changes to tests, removing the `await` calls on
`loadURI`, and a follow-up part will remove the actual async logic from
`BrowserTestUtils.loadURI`.

Differential Revision: https://phabricator.services.mozilla.com/D94641
2020-11-12 18:01:03 +00:00
Razvan Maries
beb7584870 Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00