Commit Graph

24604 Commits

Author SHA1 Message Date
Ed Lee
840011ef5a Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya
Detect old windows version to change content reusing an asrouter "Okay" string for now.

Differential Revision: https://phabricator.services.mozilla.com/D113583
2021-04-29 06:30:11 +00:00
Alexandru Michis
ad95115f4d Backed out changeset 48f696159514 (bug 1707141) for causing bc failures in browser_browserGlue_upgradeDialog.js
CLOSED TREE
2021-04-29 07:32:43 +03:00
Gijs Kruitbosch
49c72ce0fd Bug 1705084 - remove icons from builtin items in the sidebar selector dropdown, and stop using checkbox items in it altogether, r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D113652
2021-04-28 21:45:06 +00:00
Harry Twyford
817e98a51c Bug 1708209 - Use native checkboxes in all native windows. r=Gijs,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D113678
2021-04-28 20:21:34 +00:00
Anny Gakhokidze
3013fd614d Bug 1703607 - Exempt about:*pages from new bfcache, with the exception of about:blank, r=peterv
This also fixes test
browser/base/content/test/tabs/browser_navigate_through_urls_origin_attributes.js
which was failing for fission + bfcacheInParent, because about:privatebrowsing
was getting bfcached, and an extra XULFrameLoaderCreated event was firing, when
we were not expecting it.

Differential Revision: https://phabricator.services.mozilla.com/D112441
2021-04-28 20:17:35 +00:00
Harry Twyford
3468883144 Bug 1706901 - Allow the toolbar to shift with position: relative. r=mstange,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D113612
2021-04-28 20:15:38 +00:00
Gijs Kruitbosch
2799396ec0 Bug 1704483 - improve a11y labeling of disconnected/errored account item in the hamburger menu, r=morgan
The full text is split into 2 labels, one describing state and one containing the e-mail address.
To sighted users, both are visible. When this happens, let's use aria-labelledby to ensure both
labels are associated with the button control, so that both are read by screenreaders.

In the signed in and signed out state, the label is already correct (and either doesn't include
an email address, or doesn't include anything *but* the email address).

Note that in non-proton, the only label (both visible and otherwise) is the
state (the e-mail is not shown/used).

Differential Revision: https://phabricator.services.mozilla.com/D113657
2021-04-28 18:27:47 +00:00
Csoregi Natalia
010df0501b Backed out changeset e01ec8694924 (bug 1700957) as requested. CLOSED TREE 2021-04-28 18:09:01 +03:00
Niklas Goegge
25f6c5a920 Bug 1708150 - Add user activation flag to reload, goBack and goForward r=ckerschb,Gijs,smaug
Differential Revision: https://phabricator.services.mozilla.com/D110245
2021-04-28 11:26:49 +00:00
Emma Malysz
91c90b996d Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 03:17:56 +00:00
Butkovits Atila
e3f5ddbc25 Backed out changeset 1c362512f27b (bug 1700957) for causing failures at test_chrome_only_media_queries.html. CLOSED TREE 2021-04-28 05:55:14 +03:00
Emma Malysz
75fb2ad086 Bug 1700957, graduate browser.proton.doorhangers.enabled pref to main proton pref r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D110135
2021-04-28 00:29:45 +00:00
Ed Lee
a8bea67136 Bug 1707141 - [win7] Remove theme screen from upgrade onboarding r=pdahiya
Detect old windows version to change content reusing an asrouter "Okay" string for now.

Differential Revision: https://phabricator.services.mozilla.com/D113583
2021-04-27 23:37:37 +00:00
Markus Stange
3e4d49b883 Bug 1706337 - Avoid spurious accessibility notifications from the Dock menu. r=Gijs
macOS calls `-[MacApplicationDelegate applicationDockMenu:]` shortly after startup.
We fire popupshowing/shown/hiding/hidden events for the Dock menu when this
happens, mostly for consistency with other menus. Accessibility code was
processing these events and turning them into unintended accessibility notifications.

The Dock menu is a "native menu", but it is not covered by the workaround from
bug 1703482 because it's not a native *context* menu. It's its own special thing
and makes use of nsIMacDockSupport and nsIStandaloneNativeMenu and some JS glue
code.

Prior to the "Simplify nsMenuX state management" patch from bug 1699551, we were
*not* firing the popup DOM events for the Dock menu, mostly by accident.
In fact, it looks like we were only ever firing the events if a DOM modification
had occurred in the menu between menu construction and the current menu opening.
That's definitely not what we want and I'm surprised we got away with it for so
long.

Differential Revision: https://phabricator.services.mozilla.com/D113599
2021-04-27 22:33:23 +00:00
Olli Pettay
a007acddc6 Bug 1707865 - Tweak browser/base/content/test/performance/browser_preferences_usage.js to pass with Fission+bfcache, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D113512
2021-04-27 13:41:26 +00:00
imoraru
63bab09dde Backed out changeset 7517d291e2f5 (bug 1702237) for causing Browser-Chrome failures at browser_switchToTab_chiclet.js . CLOSED TREE 2021-04-27 10:12:55 +03:00
Daisuke Akatsuka
2d83a9e59c Bug 1702237: Make chiclet label properly upon tabs mode.r=harry
Differential Revision: https://phabricator.services.mozilla.com/D113274
2021-04-27 06:14:11 +00:00
Cosmin Sabou
aeaaee173a Backed out changeset 7338e5d940a6 (bug 1702237) for bc failures on browser_switchToTab_chiclet.js. 2021-04-27 04:14:10 +03:00
Daisuke Akatsuka
6d796b73d5 Bug 1702237: Make chiclet label properly upon tabs mode.r=harry
Differential Revision: https://phabricator.services.mozilla.com/D113274
2021-04-26 22:51:14 +00:00
Cosmin Sabou
4947d61610 Bug 1707182 - Disable browser_autoSubmitRequest.js on apple silicon for causing crashes. r=jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D113254
2021-04-26 16:52:51 +00:00
Andrei Oprea
80ba0dff4d Bug 1681130 - Remove the Set to Default notification bar r=Mardak,jaws
Differential Revision: https://phabricator.services.mozilla.com/D112350
2021-04-22 19:27:55 +00:00
Emma Malysz
87f1294779 Bug 1702990, add toolbarseparator to bookmark panel r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D112988
2021-04-22 18:53:59 +00:00
Joel Maher
5a5bc0c176 Bug 1706716 green up mda, xpcshell, browser-chrome, reftest for apple silicon. r=necko-reviewers,extension-reviewers,preferences-reviewers,application-update-reviewers,zombie,ahal,bytesized
Differential Revision: https://phabricator.services.mozilla.com/D113001
2021-04-22 18:39:40 +00:00
Mark Striemer
2ea6a4f349 Bug 1701544 - Show Sent! confirmation when sending a tab to a device r=harry,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D113047
2021-04-22 17:59:10 +00:00
Ava Katushka
1e8942dedf Bug 789550 - Avoid using document title while saving data URIs. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111857
2021-04-22 16:14:02 +00:00
Claudia
596c2615f2 Bug 1644719 - Add basic support to display offline support pages when SUMO is unreachable. r=prathiksha,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D111841
2021-04-22 15:11:37 +00:00
Dave Townsend
3c77f470e4 Bug 1700972: Remove profile-per-install onboarding UI. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D112292
2021-04-21 20:06:31 +00:00
Dana Keeler
fbb74a1e99 Bug 1688703 - reuse certviewer utility files in devtools r=johannh,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D106340
2021-04-21 17:48:21 +00:00
Emma Malysz
ed642d15fc Bug 1706460: update fxa disconnected string r=mhowell,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D112838
2021-04-21 16:40:13 +00:00
Ed Lee
a7d3feaf6f Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r=nanj
Reuse existing "show" event object to track which primary button was shown on the first screen. Update Events.yaml with longer description of expected values.

Differential Revision: https://phabricator.services.mozilla.com/D112837
2021-04-21 07:42:13 +00:00
smolnar
1d97e06982 Backed out changeset 3ac594597045 (bug 1706489) for causing bc failures in browser_browserGlue_upgradeDialog. CLOSED TREE 2021-04-21 09:10:07 +03:00
Markus Stange
472630329c Bug 1705257 - Use activateItem in browser/base/content/test/backforward/browser_history_menu.js. r=mac-reviewers,spohl
Differential Revision: https://phabricator.services.mozilla.com/D112126
2021-04-21 02:05:54 +00:00
Ed Lee
6af6ea1386 Bug 1706489 - Allow for calculating upgrade dialog funnel by first screen primary action r=nanj
Reuse existing "show" event object to track which primary button was shown on the first screen. Update Events.yaml with longer description of expected values.

Differential Revision: https://phabricator.services.mozilla.com/D112837
2021-04-21 01:38:46 +00:00
Molly Howell
ae9916ca7d Bug 1702298 - Allow the bookmark create/edit panel to scroll. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D112644
2021-04-21 00:25:22 +00:00
Noemi Erli
9f3821cda5 Backed out changeset 714e6e7b8eef (bug 789550) for causing failures in browser_default_audio_filename.js CLOSED TREE 2021-04-21 01:17:20 +03:00
Sam Foster
5f402dca54 Bug 1704865 - Update the boomark icons and remove the bookmarked transition filmstrip animations. r=desktop-theme-reviewers,dao,harry
Differential Revision: https://phabricator.services.mozilla.com/D112404
2021-04-20 22:05:43 +00:00
David Parks
80cf7b4c5e Bug 1704784: Remove stray uses of defunct nsIObjectLoadingContent values r=Gijs
This cleans up some pieces that were left behind after bug 1682030 removed NPAPI plugin support.

Differential Revision: https://phabricator.services.mozilla.com/D112233
2021-04-20 21:51:49 +00:00
Ava Katushka
1ec90720aa Bug 789550 - Avoid using document title while saving data URIs. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111857
2021-04-20 21:34:41 +00:00
Markus Stange
6b1bad5e51 Bug 1704948 - Update browser.bookmarks.openInTabClosesMenu handling to keep the menu open for middle clicks. r=Gijs
In the past, menus stayed open when an item was middle-clicked. Now that menus
fire command on middle-click, they automatically close when middle-clicked.
So this code now needs to handle middle clicks on menus like left clicks on
menus, and manually keep the menu open (rather than rely on them staying open
by default).
This functionality is covered by browser_stayopenmenu.js.

Differential Revision: https://phabricator.services.mozilla.com/D112683
2021-04-20 17:44:17 +00:00
Markus Stange
a81a414f15 Bug 1704948 - Use EventUtils.synthesizeMouseAtCenter for middle-clicking the back/forward context menu. r=Gijs
Now that there is no more click handler, we need to go one level lower to keepthis test passing.
At this point in the patch series, activateItem does not yet support the button property.
Later on in this series, I will replace this with an activateItem call so that the test works with native context menus as well.

Differential Revision: https://phabricator.services.mozilla.com/D112073
2021-04-20 17:44:17 +00:00
Markus Stange
2444e8909a Bug 1704948 - Remove onclick handlers from menuitems, because menuitems now dispatch command events even on middle click. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D112046
2021-04-20 17:44:17 +00:00
Markus Stange
4b2c5e6c55 Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111955
2021-04-20 17:44:16 +00:00
Butkovits Atila
851ebe0c5d Backed out changeset 43711f4646a7 (bug 1644719) for causing failures on browser_aboutCertError_offlineSupport.js. CLOSED TREE 2021-04-20 16:00:18 +03:00
Claudia
75f1ee7779 Bug 1644719 - Add basic support to display offline support pages when SUMO is unreachable. r=prathiksha,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D111841
2021-04-20 10:54:12 +00:00
Florian Quèze
5f252c4411 Bug 1703583 - fix tests that keep waitForEvent or topicObserved promises pending, r=Gijs,zombie.
Differential Revision: https://phabricator.services.mozilla.com/D111116
2021-04-19 21:56:05 +00:00
Emma Malysz
215f1834c6 Bug 1703012: fix control center and identity panel proton styling r=desktop-theme-reviewers,fluent-reviewers,mconley,flod,pbz,Itiel
Migrates two strings to fluent and uses sentence casing.
Places identity security block into a toolbar button.
Fixes margin spacing.
Removes green color from secure connection.

Differential Revision: https://phabricator.services.mozilla.com/D111368
2021-04-19 18:51:37 +00:00
Neil Deakin
3f1ebf3227 Bug 1667235, fix various issues with the browser_selectpopup.js test, mostly on Windows, r=Gijs
Change the height of a window opened during the test now that menus on windows 10 are larger. Make sure that the zoom level is reset after the test so that running the test again doesn't use the old zoom level. The default value of 'ignorekeys' is 'shortcuts' on Windows so reset this properly otherwise the test fails if run again.

Differential Revision: https://phabricator.services.mozilla.com/D112407
2021-04-19 17:22:08 +00:00
Mark Striemer
50364ef74a Bug 1701691 - print modal -moz-toolbar-prefers-color-scheme support r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D111974
2021-04-18 22:22:51 +00:00
Gijs Kruitbosch
4be153abfe Bug 1705793 - fix browser_contextmenu.js for image info appearing in devedition, r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D112439
2021-04-17 21:56:43 +00:00
Ed Lee
5187bd60c3 Bug 1705091 - Set various roles and aria attributes on the upgrade dialog r=pdahiya
Use labelledby and describedby to have reasonable reading of the dialog and buttons. Set live for dynamic changes. Remove spacers and other items from the accessibility list.

Differential Revision: https://phabricator.services.mozilla.com/D112160
2021-04-17 02:20:42 +00:00