Commit Graph

258 Commits

Author SHA1 Message Date
Katherine Patenio
6d1eaab783 Bug 1728460 - Migrate appmenu-viewcache.inc.xhtml to Fluent. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D124404
2021-09-07 17:46:19 +00:00
Katherine Patenio
bd7e890d96 Bug 1727197 - Remove fluent strings for synced tabs "show all" button. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D124143
2021-09-01 17:57:30 +00:00
Molly Howell
e9ba2664a2 Bug 1727484 - Convert the "Send Tab to Device" string in the tab context menu to title case. r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D124131
2021-09-01 00:18:57 +00:00
Katherine Patenio
b2b6c01fc5 Bug 1625478 - Convert appMenu* strings from browser.dtd to appmenu.ftl. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D123167
2021-08-30 02:36:44 +00:00
Molly Howell
bf500595af Bug 1684950 - Change the remaining Firefox Account panel strings to sentence case. r=Gijs,flod,fluent-reviewers
Only two strings that appear in the accounts panel are still in title case,
but those two need to be forked, because they are also used in other menus
where they need to remain in title case.

This patch adds the two "new" strings and the necessary switch to select
between them and the existing strings, since all of these menus are dynamically
constructed by the same code.

Differential Revision: https://phabricator.services.mozilla.com/D122764
2021-08-17 19:17:24 +00:00
Gijs Kruitbosch
5d35161584 Bug 1724718 - do not set an image attribute for synced tabs items in the synced tabs menupanel unless there is an icon to show, r=markh
Depends on D122162

Differential Revision: https://phabricator.services.mozilla.com/D122163
2021-08-10 06:52:51 +00:00
Sam Foster
10c8de097c Bug 1719463 - Part 2: Remove the Fxa items from the pre-proton appMenu view. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D121802
2021-08-10 05:29:30 +00:00
Neil Deakin
a551374625 Bug 1714079, send confirmation does not appear when sending a tab when the account button is in the overflow menu, r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D120845
2021-07-28 09:13:38 +00:00
Tarik Eshaq
e436613e2b Bug 1587228 - Removes support for old send-tab clients. r=markh
* Removes the fallback to the old sent-tab
* Deletes the api to send URIs using commands
* Modifies tests that depended on that api to now use
   other commands, namely the wipeEngine command

Differential Revision: https://phabricator.services.mozilla.com/D118086
2021-07-14 16:50:26 +00:00
Gijs Kruitbosch
4508e659f8 Bug 1711508 - remove PanelUI.protonAppMenuEnabled property, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D117058
2021-07-07 22:15:50 +00:00
Mike Conley
591e5facd9 Bug 1700198 - Remove most subviewbutton-iconic class usage from FxA panel. r=markh
This also removes code that handled the case where a Send Tab or Send Link to Device
menu needed to be populated when in the STATUS_NOT_CONFIGURED state. Since those menus
should be unavailable when in the STATUS_NOT_CONFIGURED state, we throw instead.

Depends on D118622

Differential Revision: https://phabricator.services.mozilla.com/D118623
2021-06-24 20:27:47 +00:00
Brindusan Cristian
b098967db9 Backed out changeset 0a18936814a7 (bug 1587228) for causing bc failures in browser_contextmenu_sendpage.js.
CLOSED TREE
2021-06-23 00:09:46 +03:00
Tarik Eshaq
0bf2762b2d Bug 1587228 - Removes support for old send-tab clients. r=markh
* Removes the fallback to the old sent-tab
* Deletes the api to send URIs using commands
* Modifies tests that depended on that api to now use
   other commands, namely the wipeEngine command

Differential Revision: https://phabricator.services.mozilla.com/D118086
2021-06-22 20:21:40 +00:00
Gijs Kruitbosch
7ad523084b Bug 1711523 - remove private proton tracking flags in frontend modules, r=mak,emalysz,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D116009
2021-05-28 19:33:38 +00:00
Bernard Igiri
e96485c24a Bug 1705500 - Added word wrap to send tab to another device menu r=mconley
Modified toolbaritem for the send tab to another device menu item to wrap text and align icon at the top of the button.

Differential Revision: https://phabricator.services.mozilla.com/D115657
2021-05-21 16:30:21 +00:00
Mike Conley
67629f2ea8 Bug 1703494 - Use CSS box for FxA CTA item to avoid need for descriptionHeightWorkaround. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D114770
2021-05-10 23:49:55 +00:00
Gijs Kruitbosch
2799396ec0 Bug 1704483 - improve a11y labeling of disconnected/errored account item in the hamburger menu, r=morgan
The full text is split into 2 labels, one describing state and one containing the e-mail address.
To sighted users, both are visible. When this happens, let's use aria-labelledby to ensure both
labels are associated with the button control, so that both are read by screenreaders.

In the signed in and signed out state, the label is already correct (and either doesn't include
an email address, or doesn't include anything *but* the email address).

Note that in non-proton, the only label (both visible and otherwise) is the
state (the e-mail is not shown/used).

Differential Revision: https://phabricator.services.mozilla.com/D113657
2021-04-28 18:27:47 +00:00
Mark Striemer
2ea6a4f349 Bug 1701544 - Show Sent! confirmation when sending a tab to a device r=harry,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D113047
2021-04-22 17:59:10 +00:00
Emma Malysz
ed642d15fc Bug 1706460: update fxa disconnected string r=mhowell,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D112838
2021-04-21 16:40:13 +00:00
Vijay Budhram
15218741b0 Bug 1701529 - Remove unused FxA toolbar menu items r=preferences-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D111303
2021-04-09 19:08:03 +00:00
Harry Twyford
744801a37d Bug 1703838 - Stop triggering a ConfirmationHint when a tab is sent to a device. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D111327
2021-04-09 07:46:31 +00:00
Molly Howell
3bb3d0087e Bug 1703239 - Expose the accounts error messages in the app menu to screen readers. r=emalysz
The Proton app menu version of the accounts button doesn't need the button
label attribute for display purposes, but if the attribute isn't updated when
an error happens, then accessibility tools only ever see the "Sign in" text.

Differential Revision: https://phabricator.services.mozilla.com/D111183
2021-04-08 16:56:20 +00:00
Emma Malysz
75c19ab3db Bug 1702461, set fxa submenu header correctly when opening the panel r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D110633
2021-04-02 15:27:01 +00:00
Emma Malysz
734559fa70 Bug 1698062: set app menu width and ensure text can wrap r=fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D110461
2021-04-01 14:58:05 +00:00
Francesco Lodolo (:flod)
d52c58a671 Bug 1700638 - Remove Sync brand from Sync dialogs and sidebar, App menu and FxA menu, r=mconley,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D110013
2021-03-30 14:30:55 +00:00
Emma Malysz
309c68d599 Bug 1700993, adjust app menu fxa button for different states. r=fluent-reviewers,flod,markh
This patch:
-displays the correct fxa button in the app menu when
unverified or disconnected
-shows the "sign out" button in the fxa panel for the above states
-introduces a new string for a disconnected state
-strengthens our test coverage for the proton fxa panel

Differential Revision: https://phabricator.services.mozilla.com/D109802
2021-03-29 15:05:23 +00:00
Emma Malysz
433221554d Bug 1700431: take syncing state into account when setting datal10nid for sync now buttons r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D109540
2021-03-24 17:02:29 +00:00
Emma Malysz
093e6a8e94 Bug 1697659, remove chevron from fxa sign in button r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D109109
2021-03-22 15:03:43 +00:00
Molly Howell
4eb84b12c2 Bug 1695792 - Update copy for accounts error notifications. r=mconley,fluent-reviewers
Also take the opportunity to convert these two strings to Fluent,
since we're changing the text here anyway.

Differential Revision: https://phabricator.services.mozilla.com/D108530
2021-03-18 21:45:09 +00:00
Sam Foster
c8b09eff21 Bug 1690567 - Hide some sync context menu items when not signed in. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D104746
2021-03-17 04:22:50 +00:00
Emma Malysz
0c8b7ae760 Bug 1698492, dynamically set data-l10n-id attribute for sync now buttons when panel views are showing r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D108506
2021-03-16 20:24:29 +00:00
Emma Malysz
7d11edc7ec Bug 1698024, reintroduce 'Send to All Devices' and 'Manage Devices' buttons in app menu and context menu r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D108231
2021-03-15 17:42:59 +00:00
Cosmin Sabou
b554fc4a57 Backed out changeset 59f02c384ab7 (bug 1698024) for bc failures on browser_page_action_menu.js. CLOSED TREE 2021-03-15 18:29:36 +02:00
Emma Malysz
1d48c55a39 Bug 1698024, reintroduce 'Send to All Devices' and 'Manage Devices' buttons in app menu and context menu r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D108231
2021-03-15 14:58:16 +00:00
Doug Thayer
2d71520ae5 Bug 1693052 - Update fxa signout dialog r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D108225
2021-03-13 03:05:17 +00:00
Emma Malysz
d0dfec879a Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-03-12 21:41:46 +00:00
Neil Deakin
9c2b6f8a9a Bug 1691860, move code that hides separators in the content area context menu into a single place that just hides duplicates, r=Gijs,robwu
Differential Revision: https://phabricator.services.mozilla.com/D104615
2021-03-04 00:16:16 +00:00
Csoregi Natalia
1e06aeb360 Backed out changeset 44ff4cb38ce1 (bug 1694678) for failures on browser_sync.js. CLOSED TREE 2021-03-03 09:56:35 +02:00
Emma Malysz
980daa17c1 Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-03-03 06:52:10 +00:00
Mihai Alexandru Michis
ccc1280186 Backed out changeset 7692908f97e7 (bug 1694678) for causing bc failures in browser_sync.js
CLOSED TREE
2021-03-02 19:56:17 +02:00
Emma Malysz
3099633e0e Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-03-02 16:02:35 +00:00
Emma Malysz
7790027044 Bug 1695697, update show more button label in remote tabs panels r=mconley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D106804
2021-03-01 18:39:22 +00:00
Emma Malysz
780d56ea92 Bug 1695264, display sync settings in fxa panel only when more than 1 device is connected r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D106654
2021-03-01 16:04:17 +00:00
Butkovits Atila
16933857f0 Backed out changeset 962540b712f9 (bug 1694678) for causing failure at browser_sync.js. CLOSED TREE 2021-02-27 05:05:08 +02:00
Emma Malysz
1e1d99a84c Bug 1694678: update fxa and remote tabs sync now buttons r=fluent-reviewers,mconley
This patch:
-Maintains consistency between the fxa and remote tabs' panels "sync now" buttons
-Removes a fluent string no longer in use
-Restores tooltip functionality

Differential Revision: https://phabricator.services.mozilla.com/D106651
2021-02-27 01:16:40 +00:00
Mike Conley
cb7ba99a3f Bug 1693851 - Fix browser_sync.js tests when Proton AppMenu is enabled. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D106380
2021-02-25 23:43:07 +00:00
Micah Tigley
97e4b64d1e Bug 1690569 - Replace sync's isSendableURI checks with BrowserUtils.isShareableURL. r=markh
Depends on D104558

Differential Revision: https://phabricator.services.mozilla.com/D105640
2021-02-25 02:51:04 +00:00
Emma Malysz
5227256307 Bug 1694650, update fxa avatar when proton is enable r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D106320
2021-02-24 21:28:33 +00:00
Mike Conley
9378802413 Bug 1693177 - Apply Proton stylings to Firefox Accounts menu and surroundings. r=emalysz
Differential Revision: https://phabricator.services.mozilla.com/D105697
2021-02-24 03:01:51 +00:00
Dorel Luca
3c18ad591d Backed out 2 changesets (bug 1688960, bug 1693177) for Browser-chrome failures in browser/base/content/test/sync/browser_sync.js. CLOSED TREE
Backed out changeset 13e08408add0 (bug 1693177)
Backed out changeset a34474998cd6 (bug 1688960)
2021-02-24 03:36:21 +02:00