corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
713,696 Commits 1 Branch 0 Tags
6c474b08c8e26be479ed6c57cd9c3672028d8a91
Commit Graph

64 Commits

Author SHA1 Message Date
Gijs Kruitbosch
49c72ce0fd Bug 1705084 - remove icons from builtin items in the sidebar selector dropdown, and stop using checkbox items in it altogether, r=emalysz 
Differential Revision: https://phabricator.services.mozilla.com/D113652
 2021-04-28 21:45:06 +00:00
Mike Conley
be30e09964 Bug 1697617 - Update Synced Tabs menu for Proton. r=emalysz,flod,desktop-theme-reviewers,harry 
Differential Revision: https://phabricator.services.mozilla.com/D109404
 2021-03-24 07:20:46 +00:00
Emma Malysz
c032dac581 Bug 1648530, implement sidebar telemetry probes to track how often it was opened and what type of panel was viewed. r=jaws 
Differential Revision: https://phabricator.services.mozilla.com/D81165
 2020-08-10 04:16:07 +00:00
Neil Deakin
8e276daf54 Bug 1614752, remove obsolete Sidebar:VisibilityChange messages, r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D62471
 2020-02-12 22:47:15 +00:00
Kirk Steuber
3ab1e6cd7e Bug 1603830 - Replace XULElement.ordinal with el.style.MozBoxOrdinalGroup r=bgrins 
Depends on D58670

Differential Revision: https://phabricator.services.mozilla.com/D58671
 2020-01-06 20:02:43 +00:00
Emma Malysz
ce4da4686b Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D55751
 2019-12-11 00:27:19 +00:00
Victor Porof
a3641f184a Bug 1561435 - Format browser/base/, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041
 2019-07-05 09:48:57 +02:00
Ehsan Akhgari
24fd5a68b2 Bug 1557887 - Part 6: Pass a storage principal to the rest of the call sites for createAboutBlankContentViewer(); r=baku 
Differential Revision: https://phabricator.services.mozilla.com/D34460
 2019-06-12 09:07:33 +00:00
Mohd Umar Alam
af86d46266 Bug 1533533-Add a label to hide synced tabs sidebar when it is shown r=sfoster,jaws,flod 
Differential Revision: https://phabricator.services.mozilla.com/D28177
 2019-04-26 06:10:43 +00:00
Luca Greco
d4c9385f21 Bug 1536473 - ext-menu onWindowOpen handler should wait for SidebarUI to be fully initialized. r=mixedpuppy,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D24034
 2019-03-25 20:47:27 +00:00
Neil Deakin
ce9efe8f68 Bug 1519953, replace calls to retrieve boxobject position and size with getBoundingClientRect, r=gijs 2019-03-01 12:26:45 -05:00
Shane Caraveo
d664555fde Bug 1516680 sidebar incognito support, r=rpl,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D15485
 2019-01-18 14:16:33 +00:00
Dão Gottwald
9931da215f Bug 1509651 - Stop flushing style for knowing the UI direction. r=florian 
Differential Revision: https://phabricator.services.mozilla.com/D12827
 2018-11-26 11:59:04 +00:00
Paolo Amadini
9bb8406b1b Bug 1482610 - Part 2 - Move the remaining attributes and remove the sidebar broadcasters. r=jaws,mixedpuppy 
This also fixes unintended behavior for which clicking the selected item in the sidebar selector would hide the sidebar.

Differential Revision: https://phabricator.services.mozilla.com/D3145
 2018-08-19 19:54:02 +01:00
Paolo Amadini
86dc95e48d Bug 1482610 - Part 1 - Move the sidebar title and URL from the broadcasters to a JavaScript object. r=jaws,mixedpuppy 
The immediate goal is only to remove the broadcasters, so we still require the labels to be set manually on the "toolbarbutton" and "menuitem" elements. Generating these elements programmatically from the new SidebarUI.sidebars object, both for built-in sidebars and extensions, can be a future improvement.

The autoCheck attribute is also unnecessary since it is only intended for the menu items, and they are already properly updated after their command is invoked. Since the attribute was written with the wrong capitalization, it already had no effect.

The persistence of the label of the sidebar selector is also unnecessary since it is already set on startup. Removing this does not seem to cause any additional flickering.

Differential Revision: https://phabricator.services.mozilla.com/D3143
 2018-08-14 15:18:03 +01:00
Brian Grinstead
1c86f46ecd Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo 
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw
 2018-08-08 15:22:53 -07:00
Brian Grinstead
7f0bb42e22 Bug 1476030 - Part 3 - Migrate callers from document.persist to xulStore.persist;r=Gijs 
MozReview-Commit-ID: JmlIDK9A8dv
 2018-07-18 09:43:45 -07:00
Brian Grinstead
0ae3afe87d Bug 1476030 - Part 1 - Expose xulStore through Services;r=Gijs 
This lets us use Services.xulStore instead of requiring
Cc["@mozilla.org/xul/xulstore;1"].getService(Ci.nsIXULStore);

MozReview-Commit-ID: 2eXifCPhlGs
 2018-07-18 09:43:38 -07:00
Mark Banner
b24bddc9dc Bug 1452645 - Remove load in sidebar functionality. r=lina,mak 
Based on patch by mixedpuppy.

MozReview-Commit-ID: BZwOtr4VbCH
 2018-06-06 21:00:45 +01:00
Mark Banner
efb967ef3e Bug 1453667 - Remove BrowserUITelemetry from other parts of browser/ r=Gijs 
MozReview-Commit-ID: FG1PiVPBY5U
 2018-06-06 19:42:19 +01:00
Shane Caraveo
a8067884f5 Bug 1403965 fix context menu position in extension sidebar, r=kmag 
MozReview-Commit-ID: 37XgWflt2qG
 2018-04-24 13:01:00 -05:00
Andreea Pavel
bb13111748 Backed out changeset e2573db9d14e (bug 1403965) for failing browser chrome at browser/components/extensions/test/browser/test-oop-extensions/browser_ext_sidebarAction_runtime.js on a CLOSED TREE 2018-04-24 02:13:38 +03:00
Shane Caraveo
0427883ade Bug 1403965 fix context menu position in extension sidebar, r=kmag 
MozReview-Commit-ID: 37XgWflt2qG
 2018-04-23 17:11:18 -05:00
Shane Caraveo
cc9b7fb4c5 Bug 1398713 pass triggeringPrincipal when using browser.loadURI, r=Gijs,kmag 2018-02-28 17:32:01 -06:00
Nihanth Subramanya
c3963ef3d5 Bug 1438511 - Don't update sidebar UI density before SidebarUI is initialized, or if the sidebar is not open. r=florian 
MozReview-Commit-ID: GTfBrSccecX
 2018-02-15 19:31:03 +05:30
Mark Striemer
72a365d7a0 Bug 1421811 - Part 3: Update shortcut in sidebar on update r=Gijs,mixedpuppy 
MozReview-Commit-ID: 4y02mCqwacg
 2018-02-06 12:55:40 -06:00
Vikas
9ea08c54ff Bug 1374791 - Favicon should be used for sidebar icon when loading web content, r=gijs 2017-12-06 14:15:23 +05:30
Brian Grinstead
9c738ef67f Bug 1407737 - Don't persist sidebar state unless if the last window is being closed. r=mikedeboer 
MozReview-Commit-ID: 7wBtCZDG1V3
 2017-10-18 08:32:41 -07:00
Gijs Kruitbosch
9f4f621edb Bug 1391280 - store last sidebar command irrespective of whether sidebar was open, r=bgrins,mixedpuppy 
MozReview-Commit-ID: HBfdW5vEZaD
 2017-08-23 14:06:26 +01:00
Shane Caraveo
d0f7276f00 Bug 1385630 fix extension sidebar restore after app update, r=Gijs 
MozReview-Commit-ID: IR0UDJgrp58
 2017-09-10 13:36:54 -07:00
Brian Grinstead
1cb90a3262 Bug 1394207 - Export a function to show the sidebar without firing focus for session restore;r=Gijs 
MozReview-Commit-ID: uHrShpl2xJ
 2017-09-06 08:58:10 -07:00
Brian Grinstead
e80fe18a55 Bug 1394207 - Only fire the SidebarFocused event for non-startup entry points;r=Gijs 
If the sidebar is being opened during startup (either at delayedLoad or when being
adopted from another window), we don't want sidebar panels to steal focus from the page

MozReview-Commit-ID: 4mBP2dQdyKY
 2017-09-06 08:49:07 -07:00
Adrian Wielgosik
fb0a533b78 Bug 1387356 - Remove deprecated sidebar functions. r=dao 
MozReview-Commit-ID: R7iw6RpDmc
 2017-09-04 19:53:35 +02:00
Gijs Kruitbosch
d755247497 Back out b5f5d47ac123 (bug 1391280) for breaking when session store tries to restore sidebars (latent errors in webextension test browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_lazy.js ) on a CLOSED TREE 
MozReview-Commit-ID: LO2dv6ALkfZ
 2017-08-25 12:17:21 +01:00
Gijs Kruitbosch
510b58d450 Bug 1391549 - persist positionend value to ensure sidebar side is correct on startup when sidebar is closed, r=bgrins 
MozReview-Commit-ID: LOn3Q7Hg3BC
 2017-08-23 14:07:46 +01:00
Gijs Kruitbosch
5a4d2a6cfd Bug 1391280 - store last sidebar command irrespective of whether sidebar was open, r=bgrins 
MozReview-Commit-ID: HBfdW5vEZaD
 2017-08-23 14:06:26 +01:00
Gijs Kruitbosch
7a7dc44dc8 Bug 1372601 - fix title being gone when closing and reopening the sidebar with a webpage loaded, r=bgrins 
MozReview-Commit-ID: JvZ5BbVqdz2
 2017-08-17 12:24:05 +01:00
Mike de Boer
ab742ae535 Bug 1377968 - Add a tools section and subview to the Bookmarks subview inside the Library widget. r=Gijs 
MozReview-Commit-ID: GqbUMbuvYoO
 2017-08-15 13:34:41 +02:00
Blake Winton
055a186c4c Bug 1374048 - Show the sidebar extension icon in the header. r=Gijs, ui-r=shorlander. 
MozReview-Commit-ID: 3FLYauvCs8E
 2017-08-08 14:31:40 -04:00
Nihanth Subramanya
98d9be87e2 Bug 1387022 - Don't attempt to show the sidebar switcher panel if it's closing. r=Gijs 
MozReview-Commit-ID: Cw0VrpC4V8U
 2017-08-03 17:41:41 +05:30
Brian Grinstead
893ef542cf Bug 1366851 - Flip the sidebar icon depending on if the sidebar is positioned at the start or end of the browser;r=Gijs 
MozReview-Commit-ID: Kaobl1Ox2QZ
 2017-06-28 10:15:48 -07:00
Brian Grinstead
a55b1911a1 Bug 1372954 - Do not persist sidebar checked state to document;r=Gijs 
The the state will be properly set in the show() call anyway, and the xulstore
doesn't track attribute removals which led to improper checked state

MozReview-Commit-ID: rGb6Td55eW
 2017-06-19 13:45:03 -07:00
Gijs Kruitbosch
a1e48e4623 Bug 1368317 - fix sidebar overlap styling for when the sidebar is on the end-side of the window (rhs in ltr), r=bgrins 
MozReview-Commit-ID: 3BZily6xSD2
 2017-06-15 14:31:54 +01:00
Brian Grinstead
a8bd252623 Bug 1360282 - Remove the popup that opens from the sidebar toolbar button;r=Gijs 
MozReview-Commit-ID: 4N841nISf3F
 2017-06-13 08:14:58 -07:00
Brian Grinstead
77feb23ee2 Bug 1360282 - Use the existing title setter for SidebarUI instead of changing the value directly;r=Gijs 
MozReview-Commit-ID: FCke6FxUrJj
 2017-06-13 08:14:58 -07:00
Brian Grinstead
c736caa070 Bug 1360282 - Remove _setVisibility helper now that the sidebar is always shown through show();r=Gijs 
MozReview-Commit-ID: FWJshLtYZ3h
 2017-06-13 08:14:57 -07:00
Brian Grinstead
c4465b0338 Bug 1360282 - Use querySelectorAll instead of getElementsByAttribute and a condition;r=Gijs 
MozReview-Commit-ID: Fq6pXxiSZ7b
 2017-06-13 08:14:57 -07:00
Brian Grinstead
73631ec8e2 Bug 1360282 - Always call show to open the sidebar, even when it's called from startDelayedLoad;r=Gijs 
By running through the same path anytime the sidebar is shown it will be easier to
implement the sidebar-button as a toggle, since we can rely on consistent state
to determine which sidebar was opened last.

MozReview-Commit-ID: 14HXtr8uNmb
 2017-06-13 08:14:10 -07:00
Florian Quèze
924bae5dfa Bug 1369751 - avoid constructing the sidebar browser before first paint, r=mikedeboer. 2017-06-09 15:11:07 +02:00
Brian Grinstead
74242a4433 Bug 1355331 - Create an option to move sidebar between the left and right sides of the window;r=mikedeboer 
MozReview-Commit-ID: 79ts9djMC3e
 2017-05-24 09:54:34 -07:00