Commit Graph

85 Commits

Author SHA1 Message Date
james
c8a67215e0 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
Narcis Beleuzu
d5390af0ba Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
1c970f6297 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
Dana Keeler
aa81f21079 Bug 1685552 - move certificate subject alternative name processing for error pages from backend to frontend r=bbeurdouche,johannh,baku
This removes nsIX509Cert.subjectAltNames and reduces potential attack surface
by avoiding parsing subject alternative names in C/C++. It also reduces PSM
reliance on NSS types.

Differential Revision: https://phabricator.services.mozilla.com/D101418
2021-01-14 09:58:03 +00:00
Dana Keeler
ba298e32e2 Bug 1681839 - remove nsISecurityReporter and implementation r=johannh,necko-reviewers,dragana
TLS error report sending was disabled by default in bug 1579906. The server
that ingested these reports has been decommissioned as well, so this patch
removes this dead code.

Differential Revision: https://phabricator.services.mozilla.com/D99405
2021-01-07 17:47:47 +00:00
Johann Hofmann
e0f79a853d Bug 941354 - Use innerMostURI on about:{neterror,certerror}. r=prathiksha,baku
This is to prevent issues with parsing the correct hostname for displaying and adding
exceptions for urls like view-source:.

Differential Revision: https://phabricator.services.mozilla.com/D94421
2020-10-27 10:55:51 +00:00
Butkovits Atila
ab81829e80 Backed out changeset 2edd2bd119ff (bug 941354) for browser-chrome related failures. CLOSED TREE 2020-10-26 23:31:58 +02:00
Johann Hofmann
efc757c654 Bug 941354 - Use innerMostURI on about:{neterror,certerror}. r=prathiksha,baku
This is to prevent issues with parsing the correct hostname for displaying and adding
exceptions for urls like view-source:.

Differential Revision: https://phabricator.services.mozilla.com/D94421
2020-10-26 20:12:14 +00:00
Noemi Erli
9042129fd2 Backed out changeset a96912059b4c (bug 1644719) for causing failures in browser_all_files_referenced.js CLOSED TREE 2020-09-30 19:18:42 +03:00
prathiksha
c89b964b95 Bug 1644719 - Add basic functionality to display offline support pages when SUMO is unreachable from certerror pages. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D91451
2020-09-30 12:45:10 +00:00
Gijs Kruitbosch
a77d13536e Bug 1524323 - fix advanced error messages for certificate error pages regarding certs broken in several ways, r=prathiksha,April
Differential Revision: https://phabricator.services.mozilla.com/D88135
2020-09-02 01:50:06 +00:00
Tim Huang
a75523fa49 Bug 1647825 - Part 2: Report the XFO and CSP: frame-ancestors error through the telemetry event. r=ckerschb,chutten,nhnt11
After user ticks the checkbox of allowing error reporting, we will
report the error through the telemetry event. The event includes the
error type, XFO policy, CSP policy, the frame uri and the top-level uri.

Differential Revision: https://phabricator.services.mozilla.com/D82332
2020-07-22 15:12:38 +00:00
Tim Huang
84aff40d04 Bug 1647825 - Part 1: Add the UI for enable reporting XFO and CSP:frame-ancestors error. r=ckerschb,nhnt11
This patch adds the UI for allowing users to enable reporting XFO error.
The reporting UI will be displayed in the error page if the error is a
XFO error.

Differential Revision: https://phabricator.services.mozilla.com/D82331
2020-07-22 15:12:38 +00:00
Dave Townsend
85cfa4030c Bug 1642398: Add a lint rule to warn about multiple calls to document.l10n.formatValue. r=Standard8,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D77900
2020-07-02 18:51:44 +00:00
Gijs Kruitbosch
23769a50de Bug 1642725 - use sets of known message identifiers to limit possible error titles and messages instead of consulting fluent, r=zbraniecki,prathiksha,fluent-reviewers,Pike
Differential Revision: https://phabricator.services.mozilla.com/D82135
2020-07-06 11:12:08 +00:00
Ingrid Buh twigle_ingrid
1cea232129 Bug 1643595 - Add a learn more link on XFO/CSP error pages r=prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D79280
2020-06-12 12:41:02 +00:00
Ingrid Buh twigle_ingrid
cedf40d9c0 Bug 1461195 - CSP/XFO error pages should offer an option to visit the page directly r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D69703
2020-05-26 10:17:50 +00:00
Johann Hofmann
436da43689 Bug 1629826 - Re-enable event telemetry probes for certificate error pages. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D72514
2020-04-25 18:12:32 +00:00
Arthur Iakab
a92e57002d Backed out changeset 5616dd0ad683 (bug 1592877) for causing browser-chrome failures on browser_aboutCertError_manySANsError.js
CLOSED TREE
2020-04-08 15:26:13 +03:00
Lupita Arroyo
527bfcff21 Bug 1592877 - Truncate SANs to 50 in aboutNetError.js and add a test for it. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D68730
2020-04-08 11:22:10 +00:00
aarushivij
73c93e8bec Bug 1624820 - aboutNetError's setNetErrorMessageFromCode likes to pass empty strings to document.l10n.formatValues which produces errors r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D69230
2020-04-08 09:46:34 +00:00
sourab
ecac6797d5 Bug 1622269 - Use fluent to display cert error titles. r=flod,prathiksha,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D66968
2020-03-26 14:35:50 +00:00
jayati
24f529fe56 Bug 1500464 - Do not display local system clock message if update ping date matches the current date. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D67524
2020-03-26 13:36:19 +00:00
Michael Kaply
d25860fe16 Bug 1617275 - Don't allow TLS downgrade if TLS min pref is locked. r=mt
Differential Revision: https://phabricator.services.mozilla.com/D63731
2020-02-24 19:47:58 +00:00
prathiksha
8a9684d240 Bug 1613477 - Add relevant info to the advanced section of the captive portal page and make the buttons work. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D62204
2020-02-20 12:59:05 +00:00
Thomas Wisniewski
a3468be3b7 Bug 1553265 - add a document.addCertException function to about:certerror pages and use it there; also treat GeckoView error pages as CallerIsTrusted(Net|Cert)Error; r=snorp,johannh,baku
Add a document.addCertException function to about:certerror pages, and use it on the desktop certerror page.

Also, as the CallerIsTrusted* functions expect URLs like about:certerror, but GeckoView error pages are data URLs, and so need to be handled differently for these special error-page methods to be exposed on their documents.

Example usage of document.addCertException:
  document.addCertException(
    true|false /* true == temporary, false == permanent */
  ).then(
    () => {
      location.reload();
    },
    err => {
      console.error(err);
    }
  );

Differential Revision: https://phabricator.services.mozilla.com/D56974
2019-12-18 21:55:32 +00:00
Cosmin Sabou
a3ca483125 Backed out changeset b1e1671fd704 (bug 1553265) for gv-unit failures. 2019-12-18 03:18:14 +02:00
Thomas Wisniewski
1b8a36fc99 Bug 1553265 - add a document.addCertException function to about:certerror pages and use it there; also treat GeckoView error pages as CallerIsTrusted(Net|Cert)Error; r=snorp,johannh,baku
Add a document.addCertException function to about:certerror pages, and use it on the desktop certerror page.

Also, as the CallerIsTrusted* functions expect URLs like about:certerror, but GeckoView error pages are data URLs, and so need to be handled differently for these special error-page methods to be exposed on their documents.

Example usage of document.addCertException:
  document.addCertException(
    true|false /* true == temporary, false == permanent */
  ).then(
    () => {
      location.reload();
    },
    err => {
      console.error(err);
    }
  );

Differential Revision: https://phabricator.services.mozilla.com/D56974
2019-12-17 21:54:32 +00:00
Johann Hofmann
9a60403082 Bug 1586846 - Put the TLS 1.0 and TLS 1.1 enabling UI behind a pref. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D56528
2019-12-12 10:22:25 +00:00
kyle
0afb463c69 Bug 1570502 - Fixed typo erroCodeString to errorCodeString r=keeler
Fix for Bug: 1570502
fixed typo `erroCodeString` to `errorCodeStrng`

Differential Revision: https://phabricator.services.mozilla.com/D52492
2019-11-27 13:46:10 +00:00
Martin Thomson
80b0a04a74 Bug 1590935 - Offer to re-enable TLS 1.0 on SSL_ERROR_PROTOCOL_VERSION_ALERT, r=nhnt11
As it turns out, there are some sites that generate this error.  It's a small
number, but enough to justify the change.

No new tests because we can't generate this condition in our test setup.

Differential Revision: https://phabricator.services.mozilla.com/D50396
2019-11-13 09:34:48 +00:00
Kashav Madan
cc05815a3c Bug 1588193 - Don't dispatch AboutNetErrorLoad until we're completely setup, r=johannh
BrowserTestUtils.waitForErrorPage may resolve slightly earlier than it did
before, so we may arrive at an about:neterror page that hasn't been completely
initialized. We should only dispatch the AboutNetErrorLoad event when we're done
making changes to the page.

Differential Revision: https://phabricator.services.mozilla.com/D51439
2019-11-06 19:34:18 +00:00
Dorel Luca
e1b89415f1 Backed out 4 changesets (bug 1588193) for Broswer-chrome failures on browser/base/content/test/favicons/browser_favicon_change_not_in_document.js. CLOSED TREE
Backed out changeset df4c4004abc5 (bug 1588193)
Backed out changeset 1beab20978b2 (bug 1588193)
Backed out changeset 1ada54e7ba7c (bug 1588193)
Backed out changeset a0d9537d24c6 (bug 1588193)
2019-11-06 21:30:29 +02:00
Kashav Madan
586bea6aca Bug 1588193 - Don't dispatch AboutNetErrorLoad until we're completely setup, r=johannh
BrowserTestUtils.waitForErrorPage may resolve slightly earlier than it did
before, so we may arrive at an about:neterror page that hasn't been completely
initialized. We should only dispatch the AboutNetErrorLoad event when we're done
making changes to the page.

Differential Revision: https://phabricator.services.mozilla.com/D51439
2019-11-06 15:35:18 +00:00
Brindusan Cristian
b64f009576 Backed out 4 changesets (bug 1588193) for bc failures at browser_mixedcontent_aboutblocked.js. CLOSED TREE
Backed out changeset 0bbb1f92bb47 (bug 1588193)
Backed out changeset 074bb8a6fd68 (bug 1588193)
Backed out changeset b10ec4058ec3 (bug 1588193)
Backed out changeset c90bab12f4cb (bug 1588193)
2019-11-06 02:39:32 +02:00
Kashav Madan
f43db60e2a Bug 1588193 - Don't dispatch AboutNetErrorLoad until we're completely setup, r=johannh
BrowserTestUtils.waitForErrorPage may resolve slightly earlier than it did
before, so we may arrive at an about:neterror page that hasn't been completely
initialized. We should only dispatch the AboutNetErrorLoad event when we're done
making changes to the page.

Differential Revision: https://phabricator.services.mozilla.com/D51439
2019-11-05 21:52:14 +00:00
Christoph Kerschbaumer
9545b113fa Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D50588
2019-10-31 08:28:35 +00:00
Razvan Maries
29f5ebb20d Backed out changeset 5f185a11889b (bug 1584998) for perma fails on browser_bug593387.js. CLOSED TREE 2019-10-30 23:26:01 +02:00
Christoph Kerschbaumer
e153436cc8 Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh
Differential Revision: https://phabricator.services.mozilla.com/D50588
2019-10-30 17:54:36 +00:00
Daniel Varga
5ad67b3c4d Backed out changeset ac8f6632f7e0 (bug 1584998) on request by dev. On a CLOSED TREE 2019-10-30 19:33:29 +02:00
Christoph Kerschbaumer
bf3d7aada0 Bug 1584998: Make x-frame-options work with fission enabled. r=jkt,farre,johannh
Differential Revision: https://phabricator.services.mozilla.com/D50588
2019-10-30 14:47:19 +00:00
prathiksha
96b6011597 Bug 1563355 - Handle exceptionDialogButton click on certerror pages in AboutNetErrorhandler.jsm. r=johannh
Depends on D46438

Differential Revision: https://phabricator.services.mozilla.com/D46583
2019-10-28 20:39:16 +00:00
prathiksha
3a7ca9e9ac Bug 1563355 - Remove AboutNetErrorResetPreferences and use RPM in aboutNetError.js to communicate with AboutNetErrorHandler. r=johannh
Depends on D46154

Differential Revision: https://phabricator.services.mozilla.com/D46438
2019-10-28 20:39:01 +00:00
prathiksha
a7f0271b06 Bug 1563355 - Remove AboutNetErrorSetAutomatic and use RPM in aboutNetError.js to communicate with AboutNetErrorHandler.jsm. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D46154
2019-10-28 20:38:45 +00:00
Csoregi Natalia
d86e48d443 Backed out changeset 54ca07441fde (bug 1590935) for browser-chrome failures on browser_aboutNetError.js. CLOSED TREE 2019-10-25 05:27:32 +03:00
Martin Thomson
9511fdc6ad Bug 1590935 - Offer to re-enable TLS 1.0 on SSL_ERROR_PROTOCOL_VERSION_ALERT, r=johannh
As it turns out, there are some sites that generate this error.  It's a small
number, but enough to justify the change.

No new tests because we can't generate this condition in our test setup.

Differential Revision: https://phabricator.services.mozilla.com/D50396
2019-10-25 00:25:34 +00:00
Johann Hofmann
2c9c5a6278 Bug 1584685 - Don't use try..catch to check for non-existent error strings in aboutNetError.js. r=nhnt11
document.l10n.formatValues seems to have changed and now not throw an error but instead
return `undefined` when no string was found. This broke the implementation which relied
on try..catch to detect non-existent error strings.

Differential Revision: https://phabricator.services.mozilla.com/D49873
2019-10-22 11:48:36 +00:00
longsonr
2860cd862e Bug 1584685 - correct parameter to ssl-connection-error. r=johannh?
Differential Revision: https://phabricator.services.mozilla.com/D47524
2019-10-14 19:25:12 +00:00
Brindusan Cristian
86c996c000 Bug 1579285 - Fix prettier Eslint. r=me CLOSED TREE 2019-09-27 07:30:19 +03:00
Martin Thomson
ff059987d6 Bug 1579285 - Offer to enable TLS 1.0 on neterror page r=johannh
As we roll out the TLS 1.0 and 1.1 deprecation, sites that don't support TLS 1.2
will show the neterror page.  This adds a box to that page that shows in this
specific case.  That box explains what is going on and gives an option to
re-enable TLS 1.0.

As mentioned, this will show alongside an option to reset TLS-related
preferences if any overrides are active.

Hitting the button will set the new pref to 'true' and reload the page.

Once the override is engaged, the option won't show, but that option to reset
preferences will show (as this is a TLS-related preference).

The intent is to remove this affordance in March 2020 as we formally move to
having TLS 1.2 the minimum version.  All going to plan, this will only affect
prerelease channels, though anyone who has tweaked security.tls.version.* could
also see this.

Differential Revision: https://phabricator.services.mozilla.com/D45799
2019-09-27 01:26:06 +00:00