* Remove some of the overloading of SidebarState.updateVisibility
* Remove the no-longer-used #previousLauncherExpanded property
* SidebarController.hide() just hides the panel (same as legacy/original API)
* Skip the browser_toolbarKeyNav.js test when sidebar.revamp=true, this should have been failing all along.
Differential Revision: https://phabricator.services.mozilla.com/D242240
* Remove some of the overloading of SidebarState.updateVisibility
* Remove the no-longer-used #previousLauncherExpanded property
* SidebarController.hide() just hides the panel (same as legacy/original API)
Differential Revision: https://phabricator.services.mozilla.com/D242240
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done
Differential Revision: https://phabricator.services.mozilla.com/D234773
- Remove flushTaskQueue() from head.js and its usages. Reduce arbitrary waits as much as possible.
- Replace _waitForOngoingAnimations() with a generic function to await all UI updates, which can be used in tests as well.
- Create a helper method to reliably wait for a repaint for cases where it's truly necessary.
Differential Revision: https://phabricator.services.mozilla.com/D238042
- Remove flushTaskQueue() from head.js and its usages. Reduce arbitrary waits as much as possible.
- Replace _waitForOngoingAnimations() with a generic function to await all UI updates, which can be used in tests as well.
- Create a helper method to reliably wait for a repaint for cases where it's truly necessary.
Differential Revision: https://phabricator.services.mozilla.com/D238042
On right clicking the sidebar main element when vertical tabs are disabled,
show options for hiding the sidebar, customizing the sidebar and turning on
vertical tabs.
Differential Revision: https://phabricator.services.mozilla.com/D237264
On right clicking the sidebar main element when vertical tabs are disabled,
show options for hiding the sidebar, customizing the sidebar and turning on
vertical tabs.
Differential Revision: https://phabricator.services.mozilla.com/D237264
* Make sure we don't overwrite a user's choice to hide-sidebars in vertical tabs at startup
* Roll in a fix to bug 1947257 and ensure the launcher is initially expanded when enabling vertical tabs
Differential Revision: https://phabricator.services.mozilla.com/D237849
Disabling revamp means that we also set expanded to false. However, since revamp is disabled, these changes are not reflected back to sidebar-main, resulting in a weird mismatch between SidebarState and what the launcher sees.
This was partially fixed by the lines in initializeState(), which updates the tab container, but not the launcher. This generalizes the solution to ensure that *all* components are kept up to date.
Differential Revision: https://phabricator.services.mozilla.com/D236240
Disabling revamp means that we also set expanded to false. However, since revamp is disabled, these changes are not reflected back to sidebar-main, resulting in a weird mismatch between SidebarState and what the launcher sees.
This was partially fixed by the lines in initializeState(), which updates the tab container, but not the launcher. This generalizes the solution to ensure that *all* components are kept up to date.
Differential Revision: https://phabricator.services.mozilla.com/D236240
Disabling revamp means that we also set expanded to false. However, since revamp is disabled, these changes are not reflected back to sidebar-main, resulting in a weird mismatch between SidebarState and what the launcher sees.
This was partially fixed by the lines in initializeState(), which updates the tab container, but not the launcher. This generalizes the solution to ensure that *all* components are kept up to date.
Differential Revision: https://phabricator.services.mozilla.com/D236240
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel
Differential Revision: https://phabricator.services.mozilla.com/D234592
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel
Differential Revision: https://phabricator.services.mozilla.com/D234592
