Commit Graph

38816 Commits

Author SHA1 Message Date
Natalia Csoregi
66cb0e397f Backed out 2 changesets (bug 1864896) for causing node failures. CLOSED TREE
Backed out changeset adba0b352699 (bug 1864896)
Backed out changeset 153146ce081c (bug 1864896)
2024-03-01 18:25:05 +02:00
Dave Townsend
b6eba7ca5c Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 15:20:18 +00:00
Dave Townsend
20b5d8c60f Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 15:20:17 +00:00
Sam Foster
27c17caceb Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu,chutten
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-03-01 15:02:51 +00:00
Iulian Moraru
26d2d56621 Backed out changeset bfb6942faf35 (bug 1876165) for causing multiple bc failures. CLOSED TREE 2024-03-01 16:20:18 +02:00
Jonathan Sudiaman
f4ce3f9847 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201759
2024-03-01 13:34:08 +00:00
Christoph Kerschbaumer
b001dbde19 Bug 1877195: Expand mixed-content download protection to all http downloads, r=freddyb,Gijs,anti-tracking-reviewers,pbz
Differential Revision: https://phabricator.services.mozilla.com/D200267
2024-03-01 13:04:39 +00:00
Marco Bonardo
adbeacbb4a Bug 1880069 - Switch-to-tab result sometimes appears twice with wrong container. r=jteow
The InputHistory (adaptive) provider is not properly reporting the open tab
userContextId, thus the Muxer is unable to dedupe results properly.
This cleans up the query a little bit avoiding numeric indices and fields that
are unused later.

Differential Revision: https://phabricator.services.mozilla.com/D203012
2024-03-01 12:23:49 +00:00
Iulian Moraru
d067b329de Backed out 5 changesets (bug 1864896) for causing newtab failures related to bundles. CLOSED TREE
Backed out changeset 2cd1cc279f99 (bug 1864896)
Backed out changeset e48d6928bdcb (bug 1864896)
Backed out changeset 1abbcaf91693 (bug 1864896)
Backed out changeset 06a05e5257d5 (bug 1864896)
Backed out changeset b1955ae3e9e2 (bug 1864896)
2024-03-01 12:58:03 +02:00
Dave Townsend
2a38962b3a Bug 1864896: Autofix unused function arguments (browser/components/preferences). r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202952
2024-03-01 10:10:09 +00:00
Dave Townsend
d5beece355 Bug 1864896: Autofix unused function arguments (browser/components/newtab). r=omc-reviewers,aminomancer,thecount
Differential Revision: https://phabricator.services.mozilla.com/D202950
2024-03-01 10:10:08 +00:00
Daisuke Akatsuka
25ace7ed62 Bug 1882677: Change 'Learn more' menu to 'Manage' for weather suggestion r=adw,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D203075
2024-03-01 04:18:35 +00:00
Mike Conley
b130c3c3a1 Bug 1882874 - Fix JSDoc warnings for browser/components/backup. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D203189
2024-02-29 22:06:02 +00:00
Cristian Tuns
7a00471ac3 Backed out changeset 4099afcff2be (bug 1881925) for causing gecko decision task failures in browser.toml CLOSED TREE 2024-02-29 16:49:46 -05:00
Joel Maher
e325923409 Bug 1881925 - standardize on more manifest conditions. r=aryx,credential-management-reviewers,devtools-reviewers,dom-storage-reviewers,omc-reviewers,nchevobbe,janv,issammani
Differential Revision: https://phabricator.services.mozilla.com/D202663
2024-02-29 21:25:17 +00:00
Noemi Erli
6b84db45b8 Backed out changeset 9b4da905ce36 (bug 1789727) for causing failures in browser_asrouter_toolbarbadge.js CLOSED TREE 2024-02-29 22:43:51 +02:00
Michael Hughes
a9151787eb Bug 1880368 - change firefox and firefox-private protocols to firefox-bridge and firefox-private-bridge protocols r=nshukla,mossop
Differential Revision: https://phabricator.services.mozilla.com/D201879
2024-02-29 19:03:17 +00:00
Sam Foster
998fa1d9fe Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu,chutten
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-02-29 18:27:46 +00:00
Marco Bonardo
35f7ec0073 Bug 1880078 - A previously opened tab is shown in Address Bar after restarting the browser and closing the tab. r=jteow
Some consumer is passing in integer as expected, most pass a numeric string
that is the result of a getAttribute. This causes a mismatch as that id is used
as key in a Map.
While it would be possible to fix all the consumers, the mistake seems so
common and trivial, that is worth just adapting the API to accept both.

Differential Revision: https://phabricator.services.mozilla.com/D203019
2024-02-29 14:52:56 +00:00
Bojidar Marinov
4f5ad30178 Bug 1839845 - Add a few tests for about:settings behavior. r=Gijs,robwu,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203052
2024-02-29 10:09:59 +00:00
Bojidar Marinov
b0118a001e Bug 1839845 - Try switching to about:settings tab when opening about:preferences. r=Gijs,extension-reviewers,migration-reviewers,mconley,robwu
Differential Revision: https://phabricator.services.mozilla.com/D202735
2024-02-29 10:09:59 +00:00
Bojidar Marinov
a02f6a1df5 Bug 1839845 - Add about:settings as alias of about:preferences. r=Gijs,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D202594
2024-02-29 10:09:58 +00:00
Nikki Sharpley
8dceebb0c7 Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=fxview-reviewers,desktop-theme-reviewers,emilio
- added pin icons to the tab row for tabs pinned in New Tab

Differential Revision: https://phabricator.services.mozilla.com/D201770
2024-02-29 02:26:27 +00:00
Daisuke Akatsuka
a66db50e7d Bug 1882220: Support simple UI weather suggestion r=adw
Differential Revision: https://phabricator.services.mozilla.com/D202786
2024-02-28 22:36:29 +00:00
Gregory Pappas
9bd4fc9c87 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 21:29:39 +00:00
Gregory Pappas
c1ec40f95a Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 21:29:37 +00:00
Anna Yeddi
f26477c3f9 Bug 1882430 - Temporarily fail-if browser_acknowledgeFeedbackAndDismissal.js that is failing a11y-checks. r=intermittent-reviewers,jmaher?
Failing this test until the main patch in the D202897 is under the review. That patch would include removing the `fail-if` notation added to the test manifest here.

Differential Revision: https://phabricator.services.mozilla.com/D203036
2024-02-28 20:20:46 +00:00
Stanca Serban
c5104d8b31 Bug 1857298 - Fix lint failure in browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js. a=lint-fix CLOSED TREE 2024-02-28 22:20:51 +02:00
Nikki Sharpley
487579b587 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Depends on D201652

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 19:37:22 +00:00
Stanca Serban
c67b0bdbfc Backed out 2 changesets (bug 1857298) for causing mochitests failures in browser_parsable_css.js. CLOSED TREE
Backed out changeset 32ca524f7abf (bug 1857298)
Backed out changeset c4ed2e3e1ff2 (bug 1857298)
2024-02-28 20:47:18 +02:00
Sandor Molnar
38ed31cc11 Bug 1857298 - Fix lint failure @ browser/components/firefoxview/tests/browser/browser_opentabs_pinned_tabs.js a=lint-fix CLOSED TREE 2024-02-28 19:52:12 +02:00
Nikki Sharpley
0fc9567678 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
2024-02-28 17:31:17 +00:00
Sandor Molnar
0941fe84f2 Backed out changeset c8f7d19d58bb (bug 1789727) for causing telemetry/marionette/tests/client/test_subsession_management.py CLOSED TREE 2024-02-28 18:42:48 +02:00
Sandor Molnar
c853f2f3e9 Backed out 8 changesets (bug 1878401, bug 1879041) for causing build bustages on widget/nsBaseFilePicker.cpp CLOSED TREE
Backed out changeset 2e2b8df3bdd6 (bug 1879041)
Backed out changeset 6d6952f9df2c (bug 1878401)
Backed out changeset 30b5bb590d3e (bug 1878401)
Backed out changeset 9a4b830334b9 (bug 1878401)
Backed out changeset 3c3d67f1fcb7 (bug 1878401)
Backed out changeset c83ba4026822 (bug 1878401)
Backed out changeset 6bcb670ce475 (bug 1878401)
Backed out changeset f263b196df96 (bug 1878401)
2024-02-28 17:56:48 +02:00
Sam Foster
0b69b3a243 Bug 1789727 - Default to the component implementation of Screenshots for nightly builds. r=extension-reviewers,sfoster,robwu
* Flip the component pref to true by default for nightly builds only
* Move the pref check and initialization to a startup idle task
* And be a bit smarter about when we get and disable the addon
* Fix a bug where we try to communicate with the overlay after the window actor is destroyed when
  the component pref gets flipped off during use

Differential Revision: https://phabricator.services.mozilla.com/D196888
2024-02-28 15:40:08 +00:00
Gregory Pappas
55e30a8b92 Bug 1878401 - part 7 - Pass BrowsingContext to nsIFilePicker::Init in tests r=extension-reviewers,settings-reviewers,credential-management-reviewers,anti-tracking-reviewers,devtools-reviewers,sgalich,pbz,nchevobbe,zombie,migration-reviewers,mconley
Depends on D200551

Differential Revision: https://phabricator.services.mozilla.com/D200552
2024-02-28 15:07:46 +00:00
Gregory Pappas
0428704119 Bug 1878401 - part 2 - Update nsIFilePicker users in browser/ to pass BrowsingContext to init r=extension-reviewers,settings-reviewers,credential-management-reviewers,Gijs,sgalich,migration-reviewers,mconley,robwu
Depends on D200546

Differential Revision: https://phabricator.services.mozilla.com/D200547
2024-02-28 15:07:44 +00:00
Mike Conley
b85dcce676 Bug 1882171 - Stub out the beginnings of the BackupService. r=mossop,kpatenio,fchasen
This creates a new BackupService component that lives under browser/components/backup.
It doesn't do much yet, except allow itself to be instantiated (which currently occurs
using the idle scheduler in BrowserGlue) - but it does set us up to have docs, SphinxJS
exporting for JSDoc, linting, etc.

Differential Revision: https://phabricator.services.mozilla.com/D202753
2024-02-28 14:23:56 +00:00
Daisuke Akatsuka
3e741cd5fb Bug 1880862: Avoid duplicate location-sign written in title r=adw
Differential Revision: https://phabricator.services.mozilla.com/D202284
2024-02-28 04:09:40 +00:00
Bojidar Marinov
eabb83dbfd Bug 1677823 - Use OTHER_LOCAL instead of HISTORY for about: pages. r=adw
Otherwise, they get removed when browser.urlbar.suggest.history is off.

Differential Revision: https://phabricator.services.mozilla.com/D202601
2024-02-28 03:02:58 +00:00
Daisuke Akatsuka
0b831d2ee3 Bug 1882174: Vendor application-services into mozilla-central r=adw,lina
Differential Revision: https://phabricator.services.mozilla.com/D202894
2024-02-28 02:59:00 +00:00
Dana Keeler
f738a6874e Bug 1881335 - collect error page telemetry for TLS errors and non-overridable certificate errors r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D202350
2024-02-28 00:57:56 +00:00
Kelly Cochrane
32b2d59715 Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao
Differential Revision: https://phabricator.services.mozilla.com/D201652
2024-02-27 23:33:19 +00:00
Dale Harvey
b65689bfd9 Bug 1882043 - Ensure recent searches are shown above topsites. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D202765
2024-02-27 23:30:09 +00:00
Natalia Csoregi
20f1a3f6d6 Backed out 3 changesets (bug 1877678, bug 1849175) for causing failures on browser_opentabs_recency.js CLOSED TREE
Backed out changeset 67fd66802500 (bug 1849175)
Backed out changeset da9aa1960b63 (bug 1877678)
Backed out changeset 8d9e1646bd6e (bug 1877678)
2024-02-28 00:22:14 +02:00
Kelly Cochrane
4cd48be87c Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao
Differential Revision: https://phabricator.services.mozilla.com/D201652
2024-02-27 20:30:59 +00:00
Anna Yeddi
22d8caa498 Bug 1878395 - Move label exception checks closer to their failing blocks of AccessibilityUtils. r=Jamie
This would make these exceptions more specific. After moving the `isUnlabeledUrlBarOption()` and `isUnlabeledMenuitem()` checks in the try-catch block, it won't be enough for the accessible to exist but have no name; the accessible must actually disappear after having no name. Most of the time, this will make no practical difference because clicking a URL bar option or menu item pretty much always makes it disappear. But the AccessibilityUtils would be more explicit about its exceptions.

We also explicitly including in the checks `<richlistitem>` and `<menuitem>` from the Url Bar and Search Bar autocomplete dialogs to be excluded from the label check via the `isUnlabeledMenuitem`

Differential Revision: https://phabricator.services.mozilla.com/D200744
2024-02-27 19:50:05 +00:00
Shane Hughes
37f30cffbd Bug 1881106 - Move ModalOverlay.test.jsx to newtab directory. r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D202255
2024-02-27 18:52:20 +00:00
Sam Foster
ae1907b174 Bug 1877678 - Improve window switching in the opentabs cards tests. r=fxview-reviewers,sclements
* Adds a new switchToWindow helper and calls it in openFirefoxViewTab to ensure we wait until the window is active
* Fix some fallout from this change in the browser_opentabs_recency.js test

Differential Revision: https://phabricator.services.mozilla.com/D201861
2024-02-27 18:26:18 +00:00
Sam Foster
a00823f347 Bug 1877678 - Split out the open tabs 'more' tests into their own file. r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D202486
2024-02-27 18:26:18 +00:00