Commit Graph

139 Commits

Author SHA1 Message Date
Mats Palmgren
661649e16a Bug 1362886 part 2 - Devirtualize the IsLeaf() method by doing an array lookup instead. r=jfkthame
MozReview-Commit-ID: 1zm9rFhRVZ3
2017-05-26 12:11:12 +02:00
Mats Palmgren
6a8fbc8c30 Bug 1364805 part 4 - Remove the now unused LayoutFrameType values from the ctors. r=jfkthame
MozReview-Commit-ID: 1RSDoc3pQXf
2017-05-26 12:11:11 +02:00
Mats Palmgren
450c7ae245 Bug 1364805 part 2 - Add a nsIFrame::mClass field and propagate the concrete class' value up the ctor chain. r=jfkthame
nsIFrame::mClass is of type enum class nsQueryFrame::ClassID which is
a strict subset of the nsQueryFrame::FrameIID values.  For a concrete
frame class, its FrameIID is the same numeric value as its ClassID.

MozReview-Commit-ID: 1N0AkCGo1ol
2017-05-26 12:11:11 +02:00
Mats Palmgren
bd90393cc1 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz
MozReview-Commit-ID: IbwWM0FL6HF
2017-05-21 17:15:00 +08:00
Carsten "Tomcat" Book
1aa86b3e0e Backed out changeset bbb688fe1ba3 (bug 1365614) 2017-05-22 15:45:31 +02:00
Mats Palmgren
473a358067 Bug 1365614 part 3 - Backout bug 1333482 part 1-9. Removes support for [-webkit-]appearance for now b/c web compat issues. r=bz 2017-05-21 17:15:00 +08:00
Kris Maglione
3f4ff7cee9 Bug 1365660: Part 3 - Disable transparency (where necessary) for popups which contain remote content. r=mstange,bas
Transparency is not handled correctly for composited popups on any platform,
but works with varying degrees of success on some platforms, for some popups.
Oddly, out of the three main desktop platforms, Linux seems to handle it the
best, so long as we render the popup as opaque, and let the platform
compositor handle the transparency.

MozReview-Commit-ID: E8NQlToUQq3
2017-05-16 14:29:35 -07:00
Kris Maglione
c6d57c7637 Bug 1365660: Part 2 - Add a HasRemoteContent flag to popup widgets that contain remote browsers. r=kats,bas
There are several behaviors that we only need to apply to popups which are
known to contain remote content. And since those behaviors can cause issues
elsewhere, we need to be able to identify popups which should contain remote
content, and treat them specially, where appropriate.

MozReview-Commit-ID: EMFrSP8lZiD
2017-05-17 10:16:25 -07:00
Neil Deakin
77c6e243b5 Bug 1358713, when a popup's anchor does not have a frame originally, don't have the popup update its position to follow it, r=tn 2017-05-05 11:13:56 -04:00
Emilio Cobos Álvarez
8114a16f25 Bug 1361749: Initialize nsMenuPopupFrame::{mXPos, mYPos}. r=mats
MozReview-Commit-ID: 3T7ZzFPz0Wa
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-05-03 22:06:26 +02:00
Emilio Cobos Álvarez
643f3f8618 Bug 1361051: rename mozilla::FrameType to mozilla::LayoutFrameType. r=xidorn
This avoids conflicts with mozilla::dom::FrameType.

MozReview-Commit-ID: 7aEMbHRaTFk
2017-05-01 19:32:52 +02:00
Emilio Cobos Álvarez
3731858edf Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
MozReview-Commit-ID: 5Nzhyta5Hle
2017-04-30 17:30:08 +02:00
KuoE0
8b543a5a1c Bug 1342874 - (Part 1) DocGroup labeling for runnables dispatched by NS_DispatchTo(Main|Current)Thread in XUL frames. r=dholbert
MozReview-Commit-ID: JR28J1weiL4
2017-03-16 18:09:13 +08:00
Daniel Holbert
dd93243ee2 Bug 1351217: Add missing includes to fix latent unified bustage in layout/xul. r=mats
MozReview-Commit-ID: WJoMxmGYnt
2017-03-28 00:46:22 -07:00
Mats Palmgren
4729a520a5 Bug 1333482 part 2 - [css-ui] Change all consumers of StyleDisplay::mAppearance to use the accessor UsedAppearance() instead, and make mAppearance/mMozAppearance private. r=dholbert
MozReview-Commit-ID: 8JwLsY1CLDJ
2017-03-23 22:11:18 -07:00
Mats Palmgren
259eff1c5f Bug 1348665 part 4 - Remove some params to SyncFrameViewProperties and make it a member function instead. Make the aView param optional, use the frame's view if none provided. r=tnikkel
MozReview-Commit-ID: KTUaiqr0cmT
2017-03-21 01:22:13 +01:00
Mats Palmgren
442d95de91 Bug 1348665 part 3 - Remove the aFlags param to SyncFrameViewProperties because all callers pass zero. r=tnikkel
MozReview-Commit-ID: 7zohl3bOsO1
2017-03-21 01:22:13 +01:00
Mats Palmgren
683f0d5571 Bug 1348665 part 2 - Remove the ViewProperty and store the nsView* in a field on the relevant frame classes instead. r=tnikkel
The relevant frame classes are:
SubDocumentFrame
ListControlFrame (only when used for (non-e10s?) comboboxes)
PluginFrame
ViewportFrame
MenuPopupFrame

The view is now created in the frame's Init() method, except for
ViewportFrame which has its view assigned by the frame constructor
via a SetView() call.

MozReview-Commit-ID: 4O7Hm1yqwIp
2017-03-21 01:22:13 +01:00
Mats Palmgren
fcf1999622 Bug 1348665 part 1 - Move a few nsView related methods from nsContainerFrame to nsIFrame/nsFrame (idempotent patch). r=dholbert
Views are used for PluginFrame which inherits nsFrame, not nsContainerFrame,
so it's more appropriate that these methods should live in nsIFrame/nsFrame.

MozReview-Commit-ID: 87EgCnkF5YT
2017-03-21 01:22:13 +01:00
Neil Deakin
4ced4dcb03 Bug 1342398, incorporate the popup's scroll position into the computation of where the current menuitem is, preventing misplaced popups on Mac, r=mstange 2017-03-13 09:44:02 -04:00
Mats Palmgren
7c43dcf986 Bug 1340771 part 1 - Rename nsWeakFrame to AutoWeakFrame (automated change). r=tn
MozReview-Commit-ID: 8pl4nyeGEkr
2017-03-01 18:03:14 +01:00
Neil Deakin
bbadbd2016 Bug 1109868, panels should watch their anchors for position and visibility changes and update accordingly, r=tn 2017-02-16 08:53:59 -05:00
Ting-Yu Lin
88ba0449c7 Bug 1333366 Part 2 - Update legacy NS_SIDE usage and document. r=mats
Delete the "or 0 for no movement in that direction" from the CanAdjustEdges
document in nsMenuPopupFrame.h because the only caller in nsResizerFrame.cpp
never passes 0 to it.

MozReview-Commit-ID: 3A5A8O4MDn1
2017-01-24 18:41:56 +08:00
Tyler Maklebust
562973cc78 Bug 1309935 - Add ability to find within select dropdown when over 40 elements. r=jaws
Original patch by Tyler Maklebust <tmaklebust@gmail.com> and Jared Beach <beachjar@msu.edu>

MozReview-Commit-ID: 7FW6PHIrXF4
2017-01-17 15:40:15 -05:00
Marco Bonardo
e00ec4e5e7 Bug 1321556 - Remove unused bindings from urlbarbindings.xml. r=dao
MozReview-Commit-ID: FfIsoh76ajn
2016-12-09 14:17:12 -10:00
Ting-Yu Lin
7e10b6ab51 Bug 1317588 Part 3 - Remove #define NS_SIDE_TOP/RIGHT/BOTTOM/LEFT. r=mats
This patch was written with the help of the following script. Also, manually
add mozilla qualifier to the enum values in nsStyleCoord.h, gfxRect.h, and
Types.h to make it build.

function rename() {
find .\
     -type f\
     ! -path "./obj*"\
     ! -path "./.git"\
     ! -path "./.hg"\
     \( -name "*.cpp" -or\
        -name "*.h" \)\
        -exec sed -i -e "s/$1/$2/g" "{}" \;
}

rename "NS_SIDE_TOP" "eSideTop"
rename "NS_SIDE_RIGHT" "eSideRight"
rename "NS_SIDE_BOTTOM" "eSideBottom"
rename "NS_SIDE_LEFT" "eSideLeft"

MozReview-Commit-ID: 9T0ORsqM6nP
2016-11-18 18:12:25 +08:00
Neil Deakin
86d770c8a3 Bug 1313131, don't wrap when using cursor navigation in menus onr dropdowns on Mac, or dropdowns on Windows, r=ksteuber 2016-11-17 09:56:43 -05:00
Carsten "Tomcat" Book
f184be4ebd Backed out changeset 4ed7a34ea7ab (bug 1313131) 2016-11-17 15:42:45 +01:00
Neil Deakin
9da3647006 Bug 1313131, don't wrap when using cursor navigation in menus onr dropdowns on Mac, or dropdowns on Windows, r=ksteuber 2016-11-17 09:28:27 -05:00
Mike Conley
50492d1889 Bug 1313195 - Clear active EventStateManager if a XUL popup is opened. r=enndeakin+6102
MozReview-Commit-ID: 2f6ui1X6cxj
2016-10-26 16:51:30 -04:00
Andrea Marchesini
481c5c7d53 Bug 1309818 - Fixing some warning when compiling dom/*, r=smaug 2016-10-13 14:33:07 +02:00
Neil Deakin
a95143ba64 Bug 1307793, pressing space when menulist is ofocused should perform incremental find select rather than open the menu, r=ksteuber 2016-10-12 09:18:08 -04:00
Neil Deakin
3cf3744fa4 Bug 1304243, scroll the current item into view when opening a menulist after it gets positioned so that it scrolls properly if the popup gets cropped, r=ksteuber 2016-10-12 09:18:05 -04:00
Neil Deakin
311fe3bbe7 Bug 1210328, compute correct flip state for popups, r=ksteuber 2016-10-11 14:13:36 -04:00
Neil Deakin
77cfc5173d Bug 1308233, fix assertion opening menulists in rtl, r=mstange 2016-10-11 14:13:36 -04:00
Kirk Steuber
2c1ac87580 Bug 1206133 - Add popuppositioning state and popuppositioned event to improve arrow panel position handling. r=enndeakin
MozReview-Commit-ID: Dh1npORCQ6J
2016-08-16 15:33:05 -07:00
Kartikaya Gupta
6fbfa692d4 Bug 1300421 - Back out 4 csets from bug 1288760 for regressing event coordinate reporting. r=jfkthame
MozReview-Commit-ID: AJ2PkSfYCpv
2016-09-29 10:20:52 -04:00
Sebastian Hengst
68b358f6c4 Backed out changeset c5cb27604f9f (bug 1206133) for timing out in notification tests of passwordmanager on Linux. r=backout 2016-08-18 19:58:44 +02:00
Jonathan Kew
7d5d412732 Bug 1288760 patch 2.2 - Make InitializePopupAtScreen handle position specified in global CSS-pixel values. r=emk 2016-07-28 23:04:33 +01:00
Kirk Steuber
a06fa73747 Bug 1206133 - Add popuppositioning state and popuppositioned event to improve arrow panel position handling. r=enn, r=adw
MozReview-Commit-ID: 6YPRbRB5RBX
2016-08-16 15:33:05 -07:00
Neil Deakin
24f1b04c80 Bug 52106, open menulist popup with selection over cursor, r=mstange 2016-08-11 10:37:25 -04:00
Neil Deakin
e8399e4841 Bug 1246089, don't rollup a menulist popup when alt is pressed, r=tn 2016-08-11 10:36:20 -04:00
Neil Deakin
b9edbbd8e1 Bug 1159301, clear the mouse capture whenever a menu is opened, r=tn 2016-08-03 07:45:45 -04:00
Neil Deakin
ea37b37afb Bug 1253975, don't reset the scroll position of a menulist when it opens as it should scroll to its selection instead, r=mconley 2016-07-25 09:08:36 -04:00
Neil Deakin
4633a9395f Bug 1276976, ensure that popups are visible in the right area, r=tn, r=mrbkap 2016-06-09 11:34:12 -04:00
Carsten "Tomcat" Book
d4c54cdcf7 Backed out changeset e7a3ba795e1a (bug 1276976) for timeouts in browser_tableWidget_mouse_interaction.js on a CLOSED TREE 2016-06-09 15:28:22 +02:00
Neil Deakin
24322506d0 Bug 1276976, ensure that popups are visible in the right area, r=tn, r=mrbkap 2016-06-09 07:59:31 -04:00
Neil Deakin
80f74ae14e Bug 1251634, release mouse capture when a context menu is opened, r=tn 2016-05-04 10:08:01 -04:00
Matt Woodrow
61200a9c5c Bug 1243610 - Refactor UpdateOverflow to separate out local overflow from that contributed by descendants. r=dbaron 2016-05-04 12:27:43 +12:00
Kyle Huey
a9cf047227 Bug 1265927: Move nsRunnable to mozilla::Runnable, CancelableRunnable to mozilla::CancelableRunnable. r=froydnj 2016-04-25 17:23:21 -07:00