Commit Graph

90 Commits

Author SHA1 Message Date
Alex Kontos
6614ff9a2f feat(sidebar): part 2 - tree vertical tabs v1.1 2025-11-06 14:13:52 +00:00
mark
dc89961c6d Bug 1949259 - Enforce valid HTML in HTML for Lit templates r=frontend-codestyle-reviewers,mtigley,credential-management-reviewers,fxview-reviewers,sidebar-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D245591
2025-05-19 16:00:42 +00:00
Fred Chasen
32bb998a69 Bug 1961955 - Clean up Review Checker sidebar panel. r=shopping-reviewers,fluent-reviewers,sidebar-reviewers,kpatenio,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D246993
2025-05-06 02:24:28 +00:00
Iulian Moraru
6951b54b38 Backed out changeset 646fc6fe1859 (bug 1961955) for causing bc failures on browser_all_files_referenced.js. CLOSED TREE 2025-04-30 04:33:43 +03:00
Fred Chasen
b099c87ad0 Bug 1961955 - Clean up Review Checker sidebar panel. r=shopping-reviewers,fluent-reviewers,sidebar-reviewers,kpatenio,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D246993
2025-04-29 23:59:01 +00:00
Micah Tigley
44634783bd Bug 1956952 - Add a probe for when CPM is enabled in sidebar customization panel. r=rsafaeian,sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D243389
2025-04-15 14:30:04 +00:00
Goloman Adrian
f22b24fa25 Backed out changeset 27451e8e8c20 (bug 1956952) bc failures @browser_glean_sidebar.js. CLOSED TREE 2025-04-01 04:13:29 +03:00
Micah Tigley
4284bf2ce2 Bug 1956952 - Add a probe for when CPM is enabled in sidebar customization panel. r=rsafaeian,sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D243389
2025-04-01 00:05:18 +00:00
Kelly Cochrane
11a04a64b6 Bug 1953155 - Enable expand on hover option and remove expand on hover coming soon message r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D241293
2025-03-18 22:03:50 +00:00
Kelly Cochrane
a9d254af97 Bug 1945959 - Add tests for sidebar expand on hover feature r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D237646
2025-03-18 20:35:37 +00:00
Alexandru Marc
1392ec0c92 Backed out changeset ce0f25a25732 (bug 1945959) for causing linting failure CLOSED TREE 2025-03-18 21:46:10 +02:00
Kelly Cochrane
852e54ea33 Bug 1945959 - Add tests for sidebar expand on hover feature r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D237646
2025-03-18 19:12:25 +00:00
Alexandru Marc
bf85365277 Backed out changeset 0d6b951540ba (bug 1945959) for causing sidebar related bc failures CLOSED TREE 2025-03-14 23:40:11 +02:00
Kelly Cochrane
04272e8fe4 Bug 1945959 - Add tests for sidebar expand on hover feature r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D237646
2025-03-14 20:20:44 +00:00
Nikki Sharpley
fdb515f9f2 Bug 1949238: Part 2 - Update strings for expand on hover message bar in sidebar customize r=sidebar-reviewers,fluent-reviewers,bolsson,mstriemer
Depends on D239026

Differential Revision: https://phabricator.services.mozilla.com/D239369
2025-02-25 16:18:50 +00:00
Mark Striemer
6aa3b1349e Bug 1949238: Part 1 - Expand on hover message bar in sidebar customize r=sidebar-reviewers,desktop-theme-reviewers,reusable-components-reviewers,nsharpley
This is an initial patch with the message bar styled as we would like,
but it is using temporary strings directly in the markup. These will
need to be extracted to fluent strings in a follow up change.

Differential Revision: https://phabricator.services.mozilla.com/D239026
2025-02-25 16:18:49 +00:00
Micah Tigley
a99127f0ca Bug 1941077 - Render CPM in the sidebar. r=rsafaeian,fluent-reviewers,sidebar-reviewers,credential-management-reviewers,bolsson,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D233948
2025-02-14 13:11:04 +00:00
Kelly Cochrane
cae199c0f2 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao
Differential Revision: https://phabricator.services.mozilla.com/D233098
2025-02-05 18:04:20 +00:00
Stanca Serban
0efa589b90 Backed out changeset 1be8354cedcd (bug 1930201) for causing mochitests failures. CLOSED TREE 2025-02-05 19:11:28 +02:00
Kelly Cochrane
03c6b75a99 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao
Differential Revision: https://phabricator.services.mozilla.com/D233098
2025-02-05 14:05:08 +00:00
Jonathan Sudiaman
6bb4358a74 Bug 1935432 - Fix customize panel not being in sync with prefs. r=sidebar-reviewers,kcochrane
This fixes the "actual" issue as we're leaning towards placing the refactoring bits on hold. It should be straightforward to rework SidebarCustomize in the future, should we decide that prefs ought to be read from a different module.

Differential Revision: https://phabricator.services.mozilla.com/D234509
2025-02-04 14:18:08 +00:00
Nikki Sharpley
3a0cdaac95 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-31 17:20:04 +00:00
Goloman Adrian
076b72e294 Backed out changeset bcb4fe8937d9 (bug 1939917) for causing bc failures @browser_toolbar_sidebar_button.js. 2025-01-30 23:12:08 +02:00
Nikki Sharpley
90377aaee3 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-30 19:51:57 +00:00
Goloman Adrian
a2f88b27ce Backed out changeset fd1a85f26bc5 (bug 1939917) for causing bc failures @browser_all_files_referenced.js. 2025-01-30 21:14:06 +02:00
Nikki Sharpley
a205e140f0 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-30 16:52:11 +00:00
Sandor Molnar
cc838f6396 Backed out changeset 97ac16a67945 (bug 1939917) for causing bc failures @ browser_customize_sidebar.js CLOSED TREE 2025-01-30 01:58:33 +02:00
Nikki Sharpley
c3ae33f79c Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-29 23:02:52 +00:00
Sandor Molnar
289ab282d7 Backed out changeset 1ddeda5cc40a (bug 1939917) for causing sidebar related failures CLOSED TREE 2025-01-30 00:23:19 +02:00
Nikki Sharpley
89a42ee5df Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-29 20:59:31 +00:00
Nikki Sharpley
551f8d2aaa Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane,sessionstore-reviewers
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
2025-01-28 00:51:28 +00:00
Butkovits Atila
a375e8316f Backed out changeset ead9919b0da6 (bug 1938249) for causing failures at test_restore_sidebar.py. CLOSED TREE 2025-01-27 23:43:36 +02:00
Nikki Sharpley
5d44461250 Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
2025-01-27 18:19:26 +00:00
Goloman Adrian
7dc18d7e06 Backed out changeset 2e8e6c3c9ad8 (bug 1938249) for causing bc failures @browser_glean_sidebar.js. CLOSED TREE 2025-01-27 18:50:28 +02:00
Nikki Sharpley
e80180f302 Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
2025-01-27 15:52:05 +00:00
Sandor Molnar
0e23de4f07 Backed out changeset 125d12cc3cdb (bug 1938249) for causing bc failures @ browser_sidebar_keys.js CLOSED TREE 2025-01-25 01:11:14 +02:00
Nikki Sharpley
463d047cea Bug 1938249 - Disable expanded sidebar behaviour for horizontal tabs mode r=sidebar-reviewers,desktop-theme-reviewers,dao,jsudiaman,kcochrane
- disable expand behaviour for horizontal tabs mode
- remove expand/collapse option from customize panel when horizontal mode (follow up bug to land immediately after - bug 1939917)
- default horizontal mode to show/hide with the launcher visible initially
- default vertical mode to expand/collapse
- remove auto collapsing behviour when expanded and opening a panel

Differential Revision: https://phabricator.services.mozilla.com/D234592
2025-01-24 21:34:33 +00:00
kpatenio
49e79df143 Bug 1938428 - Add new probe for RC sidebar tool being enabled or disabled in sidebar settings. r=sidebar-reviewers,shopping-reviewers,rking
Differential Revision: https://phabricator.services.mozilla.com/D235053
2025-01-24 18:16:41 +00:00
Sandor Molnar
991d828365 Backed out changeset 63792baa34ad (bug 1935432) for causing bc perma failures @ browser_customize_sidebar.js CLOSED TREE 2025-01-24 20:26:33 +02:00
Jonathan Sudiaman
5fbb160ed8 Bug 1935432 - Fix customize panel not being in sync with prefs. r=sidebar-reviewers,kcochrane
This fixes the "actual" issue as we're leaning towards placing the refactoring bits on hold. It should be straightforward to rework SidebarCustomize in the future, should we decide that prefs ought to be read from a different module.

Differential Revision: https://phabricator.services.mozilla.com/D234509
2025-01-24 17:14:01 +00:00
Goloman Adrian
0acf0b8472 Backed out changeset 71732d1ca82f (bug 1935432) for causing bc failures @browser_customize_sidebar.js. CLOSED TREE 2025-01-23 16:14:02 +02:00
Jonathan Sudiaman
38276f5013 Bug 1935432 - Fix customize panel not being in sync with prefs. r=sidebar-reviewers,kcochrane
This fixes the "actual" issue as we're leaning towards placing the refactoring bits on hold. It should be straightforward to rework SidebarCustomize in the future, should we decide that prefs ought to be read from a different module.

Differential Revision: https://phabricator.services.mozilla.com/D234509
2025-01-23 13:15:15 +00:00
Sarah Clements
999958fa5a Bug 1933818 - Sidebar panel keyboard shortcuts should hide the sidebar r=sidebar-reviewers,nsharpley,jsudiaman
*Update SidebarState logic so that opening and closing panels reverts to the correct launcher visibility for the show and hide setting
*Add a test

Differential Revision: https://phabricator.services.mozilla.com/D231838
2024-12-13 13:24:28 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Ed Lee
acaddfd634 Bug 1923900 - Record sidebar-customize for toggling chatbot and bookmarks r=jsudiaman,sidebar-reviewers
Add events for chatbot and bookmarks. Update tests to support default unchecked bookmarks.

Differential Revision: https://phabricator.services.mozilla.com/D225304
2024-10-11 15:37:32 +00:00
Jonathan Sudiaman
3f3415399b Bug 1922037 - Record Glean metrics upon sidebar initialization r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D224797
2024-10-09 20:09:55 +00:00
Nikki Sharpley
b9c3ba706c Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,dao,sfoster,jsudiaman
- different sidebar button icons for expanded, collapsed sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning
- add hover animation to button

Differential Revision: https://phabricator.services.mozilla.com/D223406
2024-10-03 14:20:55 +00:00
Sandor Molnar
fbc2bb1bd2 Backed out changeset 6ad99c7c787d (bug 1914452) for causing bc sider bar related failures. CLOSED TREE 2024-10-02 21:25:44 +03:00
Nikki Sharpley
20a153c56b Bug 1914452 - Update revamp sidebar button to reflect sidebar states r=sidebar-reviewers,desktop-theme-reviewers,dao,sfoster,jsudiaman
- different sidebar button icons for expanded, collapsed and hidden sidebar states
- move sidebar-button to beginning of navbar strip, to the left of back button
- update tests to reflect new sidebar button positioning

Differential Revision: https://phabricator.services.mozilla.com/D223406
2024-10-02 16:52:46 +00:00
Iulian Moraru
7f4f522517 Backed out changeset 5808b8ac42ad (bug 1914452) for causing multiple bc failures. CLOSED TREE 2024-09-28 02:36:30 +03:00