Commit Graph

246 Commits

Author SHA1 Message Date
agoloman
63c83deb26 Revert "Bug 1606785 - Enable Prettier for CSS files r=desktop-theme-reviewers,Standard8,frontend-codestyle-reviewers,emilio" for causing multiple failures.
This reverts commit ec5fa1d4c0.

Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"

This reverts commit baa5d72bbd.

Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"

This reverts commit 9604b0a8ae.

Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"

This reverts commit 686c1cf85f.

Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"

This reverts commit a7a4f31251.

Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"

This reverts commit 41bc4d5237.

Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"

This reverts commit 7bb7f82374.

Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"

This reverts commit c22e910235.

Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"

This reverts commit c08e43fc3d.

Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"

This reverts commit 4f2a32d1a4.

Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"

This reverts commit c05f675ddf.

Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"

This reverts commit b10c7de8d0.

Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"

This reverts commit d32c555e37.

Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"

This reverts commit 965887a708.

Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"

This reverts commit 8338860f74.

Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"

This reverts commit d66681f553.

Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"

This reverts commit 530b815cad.

Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"

This reverts commit 813c864381.
2025-05-21 04:49:28 +00:00
hannajones
baa5d72bbd Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D249182
2025-05-21 03:55:13 +00:00
Alexandru Marc
43acd12a3b Revert "Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests, r=valentin,webdriver-reviewers,extension-reviewers,settings-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,migration-reviewers,backup-reviewers,sthompson,robwu,ochameau" for causing multiple failures
This reverts commit 585626d8fc.

Revert "Bug 1955685 - Improve cookie validation - part 6 - CookieValidation for web-ext, r=robwu,cookie-reviewers,valentin"

This reverts commit b38d308433.

Revert "Bug 1955685 - Improve cookie validation - part 5 - 0x20 as invalid chars for cookie names and values r=valentin,cookie-reviewers"

This reverts commit 3578880f65.

Revert "Bug 1955685 - Improve cookie validation - part 4 - expiry validation, r=edgul,cookie-reviewers,valentin"

This reverts commit 26e16d402f.

Revert "Bug 1955685 - Improve cookie validation - part 3 - nsICookieValidation in cookieManager.add, r=edgul,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,backup-reviewers,nchevobbe,mconley,Standard8,webdriver-reviewers,whimboo,valentin,sfoster,robwu"

This reverts commit 433a4d736d.

Revert "Bug 1955685 - Improve cookie validation - part 2 - nsICookieValidation in cookieManager.addNative, r=edgul,cookie-reviewers,geckoview-reviewers,nalexander,glandium"

This reverts commit 818c2c1769.

Revert "Bug 1955685 - Improve cookie validation - part 1 - nsICookieValidation, r=edgul,cookie-reviewers"

This reverts commit 55ad680779.
2025-05-20 09:31:40 +00:00
Andrea Marchesini
585626d8fc Bug 1955685 - Improve cookie validation - part 7 - Fix existing tests, r=valentin,webdriver-reviewers,extension-reviewers,settings-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,migration-reviewers,backup-reviewers,sthompson,robwu,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D248600
2025-05-20 08:02:18 +00:00
Andrea Marchesini
433a4d736d Bug 1955685 - Improve cookie validation - part 3 - nsICookieValidation in cookieManager.add, r=edgul,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,cookie-reviewers,sessionstore-reviewers,backup-reviewers,nchevobbe,mconley,Standard8,webdriver-reviewers,whimboo,valentin,sfoster,robwu
Differential Revision: https://phabricator.services.mozilla.com/D244897
2025-05-20 08:02:03 +00:00
Mark Banner
8a3c99b9cb Bug 1966662 - Migrate most of toolkit/components/search to moz-src uris. r=search-reviewers,scunnane
Differential Revision: https://phabricator.services.mozilla.com/D249563
2025-05-17 17:38:49 +00:00
Joel Maher
986c1b9cc2 Bug 1959265 - clean and sanitize browser/**/xpcshell.toml files. r=aryx,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,migration-reviewers,backup-reviewers,home-newtab-reviewers,urlbar-reviewers,firefox-ai-ml-reviewers,profiles-reviewers,willdurand,tarek,dimi,jteow,sthompson,mconley,pdahiya,mossop
Differential Revision: https://phabricator.services.mozilla.com/D244829
2025-04-17 18:30:44 +00:00
Joel Maher
34dc8fc793 Bug 1957450 - cleanup chrome.toml files to remove old conditions and standardize remaining conditions. r=aryx,devtools-reviewers,fxview-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,backup-reviewers,julienw,nchevobbe,mconley,pdahiya,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D243709
2025-04-01 21:16:45 +00:00
mark
c2958a4a93 Bug 1936120 - Enforce no quotes around Lit expressions r=reusable-components-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,backup-reviewers,sidebar-reviewers,frontend-codestyle-reviewers,profiles-reviewers,mtigley,mconley,hjones,jsudiaman,niklas,Standard8,pdahiya
* Enables lit/quoted-expressions rule to enforce that no surrounding
  quotes when expressions are bound to attributes and properties in Lit templates.
  See f71ea1741e/docs/rules/quoted-expressions.md

* Updates all violations to adhere to lit/quoted-expressions rule

Differential Revision: https://phabricator.services.mozilla.com/D237657
2025-02-19 16:19:42 +00:00
Punam Dahiya
4f67dc494e Bug 1937170 - Transfer ownership of ActivityStreamStorage to ASRouter r=backup-reviewers,home-newtab-reviewers,omc-reviewers,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D234113
2025-01-22 05:59:40 +00:00
hjones
476bb0c534 Bug 1837658 - enable Stylelint length-zero-no-unit r=frontend-codestyle-reviewers,desktop-theme-reviewers,mtigley,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,translations-reviewers,android-reviewers,backup-reviewers,nchevobbe,dao,mconley,tthibaud
This use of units for zero length occasionally gets flagged during theme reviews so it makes sense to establish our preference and automate checks via Stylelint.

Differential Revision: https://phabricator.services.mozilla.com/D230287
2024-12-10 00:28:49 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Spencer Poor
9e4c37fcd1 Bug 1920145 - [moz-message] Modified moz-message property definitions, fluent set to true. r=hjones,settings-reviewers,credential-management-reviewers,reusable-components-reviewers,translations-reviewers,backup-reviewers,mtigley,fxview-reviewers,sidebar-reviewers,mossop,mconley
Bug 1920145 - [moz-message] Further cleanup of moz-message attribute declarations, edited docs. r=hjones

Bug 1920145 - [moz-message] Edited additional README that mentions relevant header declarations. r=hjones

Bug 1920145 - [moz-message] Fixed linter errors stemming from changes. r=hjones

Bug 1920145 - [moz-message] Reverted accidental removals of necessary data-l10n-attrs references. r=hjones

Bug 1920145 - [moz-message] Further reverted other removals of data-l10n-attrs references in components that aren't moz-message. r=hjones

Bug 1920145 - [moz-message] Cleaned up a couple more references to datal10nAttrs in NotificationMessageBar.mjs. r=hjones

Differential Revision: https://phabricator.services.mozilla.com/D226891
2024-11-15 19:21:06 +00:00
Henrik Skupin
640cf7afac Bug 1930116 - [marionette] Improvements for browser/components/backup/tests/marionette/test_backup.py. r=backup-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D228428
2024-11-09 06:38:29 +00:00
Mike Conley
3bb69687fc Bug 1924095 - Don't regenerate backups when cookies are removed by the site. r=backup-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D227865
2024-11-06 21:18:18 +00:00
Mike Conley
091ca7e7af Bug 1908732 - Add event probes for the backup component. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221660
2024-11-06 15:26:54 +00:00
Mike Conley
5504e6700c Bug 1908727 - Add probes for the initial state and configuration for BackupService. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221531
2024-11-05 18:49:00 +00:00
Stanca Serban
708727fac6 Backed out changeset 334773fe02f0 (bug 1908727) for causing codecs failures. 2024-11-04 23:49:46 +02:00
Mike Conley
69ffa598ec Bug 1908727 - Add probes for the initial state and configuration for BackupService. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221531
2024-11-04 20:22:54 +00:00
Dave Townsend
6cd8d87df6 Bug 1915216: Add a method to asynchronously write the important data about the current profile to the INI file on disk. r=glandium,jhirsch,pehrsons,backup-reviewers,mconley
This adds an asynchronous method to lock the startup files using the same
lock that we use during normal startup.

The profile service then uses this lock to gate access to the profiles.ini
files adding a method to async flush the entire database or in the case
that the on-disk database has changed a way to mergwe in some properties
about the current profile into the on-disk version.

Differential Revision: https://phabricator.services.mozilla.com/D222662
2024-10-18 07:53:02 +00:00
Sandor Molnar
8e1180f323 Backed out changeset 1d68ad927ddb (bug 1908727) for causing bc failures @ browser_startup_mainthreadio.js CLOSED TREE 2024-10-17 21:16:17 +03:00
Mike Conley
a28d8661d3 Bug 1908727 - Add probes for the initial state and configuration for BackupService. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221531
2024-10-17 16:29:47 +00:00
Butkovits Atila
20cd2bfd08 Backed out changeset fe441360b591 (bug 1915216) for causing leaks at ThreadSafeWeakReference. CLOSED TREE 2024-10-17 19:11:29 +03:00
Dave Townsend
4d68ba5791 Bug 1915216: Add a method to asynchronously write the important data about the current profile to the INI file on disk. r=glandium,jhirsch,pehrsons,backup-reviewers,mconley
This adds an asynchronous method to lock the startup files using the same
lock that we use during normal startup.

The profile service then uses this lock to gate access to the profiles.ini
files adding a method to async flush the entire database or in the case
that the on-disk database has changed a way to mergwe in some properties
about the current profile into the on-disk version.

Differential Revision: https://phabricator.services.mozilla.com/D222662
2024-10-17 15:09:41 +00:00
Norisz Fay
e8694852ee Backed out changeset 46f4c195d34a (bug 1915216) for causing async related xpcshell failures CLOSED TREE 2024-10-16 18:07:26 +03:00
Dave Townsend
75cb8ade57 Bug 1915216: Add a method to asynchronously write the important data about the current profile to the INI file on disk. r=glandium,jhirsch,pehrsons,backup-reviewers,mconley
This adds an asynchronous method to lock the startup files using the same
lock that we use during normal startup.

The profile service then uses this lock to gate access to the profiles.ini
files adding a method to async flush the entire database or in the case
that the on-disk database has changed a way to mergwe in some properties
about the current profile into the on-disk version.

Differential Revision: https://phabricator.services.mozilla.com/D222662
2024-10-16 08:32:25 +00:00
Mike Conley
afb930d214 Bug 1923125 - Don't regenerate backups on batched cookie deletion due to expiry / size limits. r=kpatenio,backup-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D224832
2024-10-09 14:06:20 +00:00
Mike Conley
69fe481887 Bug 1890427 - Part 11: Avoid regenerating when scheduled backups disabled, and deleting non-existant backup destination folder. r=backup-reviewers,kpatenio
We don't want to regenerate a backup if scheduled backups are disabled, so
we now do a check inside of the DeferredTask for the scheduling pref before
attempting a regeneration.

The prior patches in this stack cause us to attempt to delete any known
backups when doing certain clearing operations. If a backup destination
folder was not configured or is pointing at a non-existant directory,
this can cause us to throw. This is non-fatal but annoying.

This patch is some belt-and-suspenders which changes the behaviour so that:

1. Deletion is not attempted if scheduled backups are not enabled.
2. The backup destination pref is checked for non-empty values before
   attempting to check its existence.
3. The existence check is wrapped in a try/catch in the event that
   the destination pref is set to an invalid path for the OS.

Differential Revision: https://phabricator.services.mozilla.com/D221478
2024-09-18 13:32:12 +00:00
Mike Conley
b7bcb4dc52 Bug 1890427 - Part 10: Use an observer to regenerate backups on newtab links being blocked. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218880
2024-09-18 13:32:11 +00:00
Mike Conley
5d294d5f3d Bug 1890427 - Part 9: Use an observer to regenerate backups on cookie removal. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218879
2024-09-18 13:32:11 +00:00
Mike Conley
c38ff72c4c Bug 1890427 - Part 8: Use an observer to regenerate backups on permission removal. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218878
2024-09-18 13:32:10 +00:00
Mike Conley
1e876ebf64 Bug 1890427 - Part 7: Use an observer to regenerate backups on data sanitization. r=backup-reviewers,kpatenio
This also reorganizes things a bit in BackupService so that uninitBackupScheduler
also disarms the debouncer and any queued debounced jobs end up being inert.

Differential Revision: https://phabricator.services.mozilla.com/D218877
2024-09-18 13:32:10 +00:00
Mike Conley
d811f82945 Bug 1890427 - Part 6: Use an observer to regenerate backups when an address is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218876
2024-09-18 13:32:10 +00:00
Mike Conley
051850805e Bug 1890427 - Part 5: Use an observer to regenerate backups when a payment method is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218875
2024-09-18 13:32:09 +00:00
Mike Conley
89ce1cb51b Bug 1890427 - Part 4: Use an AddonListener to regenerate backups when an addon is uninstalled. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218874
2024-09-18 13:32:09 +00:00
Mike Conley
5e0572f68f Bug 1890427 - Part 3: Use a PlacesObserver to regenerate backups when a bookmark is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218886
2024-09-18 13:32:08 +00:00
Mike Conley
67293d208f Bug 1890427 - Part 2: Use an observer to regenerate backups when a password is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218873
2024-09-18 13:32:08 +00:00
Mike Conley
9570092c28 Bug 1890427 - Part 1: Use a PlacesObserver to regenerate backups when pages are removed or history is cleared. r=backup-reviewers,kpatenio
This debounces backup regenerations using a DeferredTask.

Differential Revision: https://phabricator.services.mozilla.com/D218872
2024-09-18 13:32:07 +00:00
Mike Conley
154be6716d Bug 1914940 - Do not back up permissions or content prefs databases if the browser is not configured to remember history, or to clear history on shutdown. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221552
2024-09-17 13:54:28 +00:00
Mike Conley
b4e120a34f Bug 1914936 - Do not back up cookies if the browser is not configured to remember history, or to clear history on shutdown. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221551
2024-09-17 13:54:27 +00:00
Mike Conley
c052d17afd Bug 1914926 - Do not back up form history if the browser is not configured to remember history, or to clear history on shutdown. r=backup-reviewers,places-reviewers,mak,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D221550
2024-09-17 13:54:27 +00:00
Eemeli Aro
b3031aa097 Bug 1889417 - Fix minor Fluent bugs in various tests. r=fluent-reviewers,credential-management-reviewers,fxview-reviewers,places-reviewers,omc-reviewers,backup-reviewers,urlbar-reviewers,dimi,Standard8,nsharpley,mconley,flod,emcminn
Issues revealed by adding a `MOZ_ASSERT(false)` in Fluent error reporting and trawling through the resulting logs.

Differential Revision: https://phabricator.services.mozilla.com/D221421
2024-09-10 19:03:18 +00:00
Butkovits Atila
9095b72df7 Backed out 10 changesets (bug 1890427) for causing failures at LateWriteChecks.cpp. CLOSED TREE
Backed out changeset b3ea334a7968 (bug 1890427)
Backed out changeset 8534805fac67 (bug 1890427)
Backed out changeset 2b31d978a116 (bug 1890427)
Backed out changeset f1db7acebebe (bug 1890427)
Backed out changeset 57b90c2b57be (bug 1890427)
Backed out changeset c72168ca8f99 (bug 1890427)
Backed out changeset 6ccf8483a0c1 (bug 1890427)
Backed out changeset 76ac3e81db91 (bug 1890427)
Backed out changeset 6599f4c9d1cb (bug 1890427)
Backed out changeset 054da7263696 (bug 1890427)
2024-09-05 01:05:36 +03:00
Mike Conley
7e5dab7371 Bug 1910968 - Make sure unverified search engines stay unverified during backup recovery. r=Standard8,backup-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D218656
2024-09-04 18:04:49 +00:00
Mike Conley
51225be16e Bug 1890427 - Part 10: Use an observer to regenerate backups on newtab links being blocked. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218880
2024-09-04 17:56:59 +00:00
Mike Conley
4887d56637 Bug 1890427 - Part 9: Use an observer to regenerate backups on cookie removal. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218879
2024-09-04 17:56:59 +00:00
Mike Conley
b9636f86f1 Bug 1890427 - Part 8: Use an observer to regenerate backups on permission removal. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218878
2024-09-04 17:56:58 +00:00
Mike Conley
7ca5c1c77a Bug 1890427 - Part 7: Use an observer to regenerate backups on data sanitization. r=backup-reviewers,kpatenio
This also reorganizes things a bit in BackupService so that uninitBackupScheduler
also disarms the debouncer and any queued debounced jobs end up being inert.

Differential Revision: https://phabricator.services.mozilla.com/D218877
2024-09-04 17:56:58 +00:00
Mike Conley
2d3cbfc487 Bug 1890427 - Part 6: Use an observer to regenerate backups when an address is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218876
2024-09-04 17:56:57 +00:00
Mike Conley
01d75928e9 Bug 1890427 - Part 5: Use an observer to regenerate backups when a payment method is deleted. r=backup-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D218875
2024-09-04 17:56:57 +00:00