Commit Graph

962 Commits

Author SHA1 Message Date
Mark Banner
ec9074e132 Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6
2017-03-20 12:36:37 +01:00
Thomas Nguyen
77b3b0ad21 Bug 1345569 - Get blocked info from content when clicking report false deceiptive site from xul browser. r=francois
MozReview-Commit-ID: GXkbjfOrnHX
2017-03-20 14:43:08 +08:00
Henry Chang
7f0e427cd5 Bug 1348626 - Retry when isPinged() failed to avoid false alarm. r=francois
MozReview-Commit-ID: BOdJZReICxZ
2017-03-19 15:52:25 +08:00
dimi
2039871388 Bug 1346196 - URLCLASSIFIER_UPDATE_REMOTE_STATUS2 records values using empty keys. r=francois
mTelemetryProvider might be empty if |CancelUpdate| is called during update.
In that scenario, the call flow will look like:
CancelUpdate -> UpdateError -> DownloadDone -> set mTelemetryProvider to empty ->
OnStartRequest -> record telemetry with empty key.

So in this patch, move mTelemetryProvider.Truncate() to OnStopRequest.

MozReview-Commit-ID: JDgNUqR4SKa
2017-03-16 14:42:46 +08:00
Henry Chang
c3c42fecfb Bug 1347657 - Use array entry as value instead of reference to avoid being invalidated by realloc. r=francois
nsTArray::AppendElement may cause memory reallocation if out of capacity.
In nsUrlClassifierStreamUpdater::FetchNextRequest(), we take the reference of
the first element of mPendingRequests and pass its member as reference to
DownloadUpdate(), where mPendingRequests.AppendElement will be called.
If the AppendElement in DownloadUpdate() causes realloc, the reference
becomes dangling.

The most efficient fix is to "move" the reference's (i.e. request)
member variables to DownloadUpdate() but I think in this case we can just
take the value from the array and pass it around with no given that the
array element contains simply a couple of strings and pointers.

MozReview-Commit-ID: KEZ5d3l3HoI
2017-03-16 15:19:45 +08:00
Henry Chang
6d4717a54c Bug 1345922 - Avoid concurrent update and take the failed beginUpdate into account. r=francois
MozReview-Commit-ID: IfRIazBvAyl
2017-03-10 00:47:26 +08:00
Kirk Steuber
82f36355d4 Bug 1345611 - Change behavior of subdocument Flash blocking to be Third-Party Flash blocking r=bsmedberg,qdot
The previous implementation regarding to the Flash Blocking Subdocument list blocked all subdocuments that matched the list. This patch changes that so that subdocuments are only blocked if they are on the Subdocument Block List and also are loaded in a Third-Party context.

The changes to cert8.db and key3.db add the https certificate for subdocument.example.com so that testing can verify that a scheme mismatch between the document and its parent results in a third-party classification.

MozReview-Commit-ID: IXnA4iPzB4y
2017-03-10 10:50:21 -08:00
Henry Chang
b1b06f3fe9 Bug 1346757 - Change the downloadError callback timing. r=francois
MozReview-Commit-ID: JleLPltEBOw
2017-03-13 21:16:07 +08:00
Thomas Nguyen
23421961ee Bug 1343416 - Use LCG when generating noise entries for Safe Browsing completions r=gcp
MozReview-Commit-ID: FxQH2haAcrf
2017-03-09 10:59:52 +08:00
Carsten "Tomcat" Book
41c5179adf Merge mozilla-central to autoland 2017-03-08 17:04:17 +01:00
Benjamin Smedberg
4c9ad8511e Bug 1344908 - Build flash-block-lists.rst into the generated documentation, r=bytesized
MozReview-Commit-ID: AdHUGjNXQjL
2017-03-06 17:11:44 -05:00
Thomas Nguyen
72ec8b5761 Bug 1339006 - Specify event target if we run nsIURIClassifier.clasify() from content process.r=ehsan, r=gcp
MozReview-Commit-ID: BztjVMlQngi
2017-03-08 11:06:36 +08:00
Wes Kocher
b589990f5f Merge inbound to central, a=merge
MozReview-Commit-ID: 96co4Bbby7W
2017-03-07 16:40:44 -08:00
Florian Quèze
0b17fc5d60 Bug 1344711 - hand cleanup of cases that were ignored by the script to remove try blocks around get*Pref calls, r=jaws. 2017-03-07 15:29:48 +01:00
Henry Chang
75d7890222 Bug 1339760 - Split update process to background/foreground and run background on update thread **synchronously**. r=francois,gcp
MozReview-Commit-ID: J0phPC1nWsf
2017-02-22 17:25:26 +08:00
David Major
b1e362f6f7 Bug 1344615: Remove nsXPCOMStrings.{h,cpp} r=bsmedberg
These are now dead code.

MozReview-Commit-ID: AClU0Qx3kmN
2017-03-06 17:52:54 +13:00
Carsten "Tomcat" Book
dc21916166 merge mozilla-inbound to mozilla-central a=merge 2017-03-02 14:02:48 +01:00
Thomas Nguyen
c68b0c13e5 Bug 1341514 - Using the valid update url provider in test. r=gcp
MozReview-Commit-ID: 50NcRd2e9hB
2017-03-02 00:07:53 +08:00
Wes Kocher
93580c6796 Merge m-c to autoland, a=merge
MozReview-Commit-ID: 8dvpEkAL5Vh
2017-02-27 13:39:07 -08:00
Wes Kocher
8ba52721c8 Merge inbound to central, a=merge
MozReview-Commit-ID: F0XvCKnh8H7
2017-02-27 13:34:55 -08:00
Thomas Nguyen
a1f79aa942 Bug 1331139 - Sync safebrowsing.proto from Chromium. r=francois
MozReview-Commit-ID: KWi8wWhqCcr
2017-02-27 12:18:50 +08:00
Thomas Nguyen
d107e3566b Bug 1331139 - Enable download protection for V4 lists. r=francois
MozReview-Commit-ID: 8IHKGvXQjPt
2017-02-27 12:18:33 +08:00
Henry Chang
73fc8b0a2d Bug 1342397 - Properly reset stuff when failing to create LookupCache for update. r=gcp
MozReview-Commit-ID: 1ecI2lFIj2U
2017-02-25 00:22:39 +08:00
Thomas Nguyen
6eea6d2df4 Bug 1341514 - Disable test_reporturl.html due to intermittent failure. a=testonly
MozReview-Commit-ID: Ff7koH8xIwJ
* * *
[mq]: TEST-INFO

MozReview-Commit-ID: 9TUQqlj7h3M
2017-02-27 16:57:05 +08:00
Dimi Lee
7545e85763 Bug 1335974 - Add more error codes to URLCLASSIFIER_UPDATE_ERROR. r=francois
MozReview-Commit-ID: AAd6Yu0AuUO
2017-02-22 16:25:04 +08:00
Dimi Lee
9792f44648 Bug 1332780 - Add telemetry to record network error while SafeBrowsing update. r=francois
MozReview-Commit-ID: 7Yqxs0XHmNP
2017-02-24 09:54:49 +08:00
Thomas Nguyen
2b6e2edd11 Bug 1297962 - Add noise data when sending v4 gethash request r=francois
MozReview-Commit-ID: GbyvX7wcg8c
* * *
[mq]: 1297962_review

MozReview-Commit-ID: 1U2T0wq778R
2017-02-24 10:22:12 +08:00
Dimi Lee
5375a9f0e5 Bug 1311931 - Add telemetry to measure full match rate for v2 and v4. r=francois
MozReview-Commit-ID: H9jAR82rgDh
2017-02-23 23:07:13 +08:00
Henry Chang
7330f247a6 Bug 1341506 - Part 2: Add telemetry for AsyncClassifyLocalWithTables. r=francois
MozReview-Commit-ID: 14QG0AdxbE5
2017-02-24 00:14:11 +08:00
Henry Chang
40c00b3543 Bug 1341506 - Part 1: Implement and use nsIURIClassifier.asyncClassifyLocalWithTables. r=Ehsan,francois
MozReview-Commit-ID: 8dvYM4o2Xxw
2017-03-01 11:27:51 +08:00
Kirk Steuber
b36b9ba335 Bug 1340448 - Fix intermittent timeout of browser_flash_block_lists.js r=Felipe
MozReview-Commit-ID: InSc42mWEJN
2017-02-17 09:34:34 -08:00
Thomas Nguyen
f1bf9d77e5 Bug 1288633 - Add SafeBrowsing report false positive URL test.r=francois
MozReview-Commit-ID: JEMLug9M85Q
2017-02-21 11:25:04 +08:00
Thomas Nguyen
6ca9c778d6 Bug 1288633 - Add more information when an URL matches Safe Browsing list. r=dragana,francois
MozReview-Commit-ID: 6u0dUOB838F
2017-02-21 09:46:36 +08:00
Henry Chang
c16ea9af44 Bug 1338970 - Introduce 2-step DB update scheme. (background update then swap in) r=francois,gcp
MozReview-Commit-ID: 4C9N0tuSso0
2017-02-21 14:18:29 +08:00
dimi
9052d78921 Bug 1338082 - Add telemetry probes to track the positive and negative cache durations in V4. r=francois
MozReview-Commit-ID: 43Nf5bS2Uo
2017-02-20 10:25:18 +08:00
Henry Chang
48936c9334 Bug 1313711 - Fix track element CORS bug. r=dveditz
MozReview-Commit-ID: SRWbiIuUdt
2017-02-14 11:47:14 +08:00
Tom Tromey
e90d95a3f9 Bug 1060419 - make AppendPrintf and nsPrintfCString use Printf.h, r=froydnj
MozReview-Commit-ID: 2E8FoiNxU8L
2016-12-14 09:32:21 -07:00
Tom Tromey
e014854967 Bug 1060419 - convert one nsPrintfCString to MOZ_LOG, r=froydnj
MozReview-Commit-ID: IFwMAtAgfRq
2016-12-19 13:15:14 -07:00
Tom Tromey
a4b717ab39 Bug 1060419 - make log_print use Printf.h, r=froydnj
MozReview-Commit-ID: BIZ1GQEZ1vs
2016-12-15 20:16:31 -07:00
Tom Tromey
48da5b7de4 Bug 1060419 - remove unneeded includes of prprf.h, r=froydnj
MozReview-Commit-ID: JifhpA3oOeH
2016-12-09 10:00:01 -10:00
Wes Kocher
b91739bde1 Merge inbound to m-c a=merge
MozReview-Commit-ID: IKI0zVtF1n9
2017-02-15 16:18:13 -08:00
Nathan Froyd
a7d8bdb5d3 Bug 1339556 - remove nsUrlClassifierUtils::Charmap; r=gcp
The current code doesn't use Charmap.
2017-02-15 09:29:42 -05:00
Kirk Steuber
bdcea14c4d Bug 1338287 - Make nsIDocument::DocumentFlashClassification accessible from privileged JS r=bz
MozReview-Commit-ID: 1II2puZMub5
2017-02-13 13:39:40 -08:00
Sylvestre Ledru
887ae57066 Bug 1338086 - Remove useless else blocks in order to reduce complexity in toolkit/components/url-classifier/ r=francois
MozReview-Commit-ID: GTb9ME8pfVq
2017-02-09 10:57:22 +01:00
Thomas Nguyen
96756deadd Bug 1329558 - Implement Minimum wait duration for V4 gethash r=francois
MozReview-Commit-ID: 7i9Wz7pq0yJ
2017-02-09 16:56:44 +08:00
Tim Huang
b3fb2c8458 Bug 1336802 - Part 2: Updating the whole code base to make sure nsILoadInfo get null check. r=smaug 2017-02-07 11:49:34 +08:00
Kirk Steuber
ff5a51d776 Bug 1335549 - Enable table updates when flashblock pref is flipped r=francois
MozReview-Commit-ID: 4L5xP1lkL8d
2017-02-07 11:12:11 -08:00
dimi
5750b4baba Bug 1336909 - Restrict URLCLASSIFIER_PREFIX_MATCH to profiles that have working V4. r=francois
MozReview-Commit-ID: L3lKgiohalH
2017-02-08 15:18:35 +08:00
dimi
591977dd60 Bug 1336865 - Add telemetry to measure time spent on constructing variable-length prefix set. r=francois
MozReview-Commit-ID: CNhfYdH1ryA
2017-02-07 16:14:58 +08:00
Francois Marier
93a6db0a84 Bug 1334616 - Add telemetry probe to monitor ClassifyLocalWithTables() perf. r=gcp
MozReview-Commit-ID: LfKovwAX9Ov
2017-02-03 20:56:05 +08:00