Abhishek Tiwari
cec6f4b2e7
Bug 1820878 - Convert toolkit/mozapps/downloads to ESmodules . r=Standard8,extension-reviewers,application-update-reviewers,bytesized,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D172245
2023-04-12 17:32:30 +00:00
Gregory Pappas
0e505f184a
Bug 1804264 - Refactor PermissionUI to use JS class r=pbz
...
Also, esmify.
Differential Revision: https://phabricator.services.mozilla.com/D167074
2023-01-23 21:53:19 +00:00
Noemi Erli
9299cc61f9
Backed out changeset c37b70009a8b (bug 1804264) for causing failures in Geolocation.cpp CLOSED TREE
2023-01-23 19:11:47 +02:00
Gregory Pappas
8972ac3379
Bug 1804264 - Refactor PermissionUI to use JS class r=pbz
...
Also, esmify.
Differential Revision: https://phabricator.services.mozilla.com/D167074
2023-01-23 16:30:32 +00:00
Mark Banner
34d6fb8d94
Bug 1806503 - Automatically replace Cu.reportError with console.error (browser/actors, browser/base). r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D165068
2022-12-27 10:08:58 +00:00
Neil Deakin
65756040a9
Bug 1801168, initialize the field that gets the fullscr-toggler element properly, as showNavToolbox can be called without it being set yet, this caused the browser_tabswitch_select.js test to fail in verify mode, r=dao
...
Depends on D162857
Differential Revision: https://phabricator.services.mozilla.com/D163059
2022-11-25 10:36:00 +00:00
Michael Kohler
59a0472aa2
Bug 1749989 - Rename FullScreen.getAutohide to FullScreen.updateAutohideMenuitem r=jaws
...
Differential Revision: https://phabricator.services.mozilla.com/D148353
2022-07-11 16:24:07 +00:00
Edgar Chen
225e30e4b3
Bug 1756388; r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D144193
2022-05-03 19:11:30 +00:00
Mark Banner
d22663f0f9
Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu
...
Differential Revision: https://phabricator.services.mozilla.com/D140518
2022-03-17 22:13:08 +00:00
Cristian Tuns
a180c6cba3
Backed out changeset 528295e7cb0c (bug 1758476) for causing tabswitch failures CLOSED TREE
2022-03-14 12:27:48 -04:00
Mark Banner
beed912c8e
Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu
...
Differential Revision: https://phabricator.services.mozilla.com/D140518
2022-03-14 10:19:40 +00:00
Mark Banner
7ea3c792f2
Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-11 16:41:29 +00:00
smolnar
19781d16c7
Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE
2022-03-10 11:58:45 +02:00
Mark Banner
de1754318e
Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky
...
Differential Revision: https://phabricator.services.mozilla.com/D140517
2022-03-10 09:25:28 +00:00
aminomancer
7aebd7f3db
Bug 1591040 - show both fullscreen and normal toolbar/tabstrip context menus in full screen, r=jaws,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D131493
2022-01-21 22:52:24 +00:00
Norisz Fay
d35104b746
Backed out changeset e23259733a51 (bug 1591040) for causing bc failures on browser_fullscreen_context_menu.js CLOSED TREE
2022-01-19 13:32:54 +02:00
aminomancer
3394fc2082
Bug 1591040 - show both fullscreen and normal toolbar/tabstrip context menus in full screen, r=jaws,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D131493
2022-01-19 10:14:34 +00:00
Edgar Chen
55e49c6194
Bug 1739220 - Handle fullscreen state in a more reliable way; r=smaug,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D131185
2021-12-17 09:15:10 +00:00
Csoregi Natalia
f20254ab82
Backed out 2 changesets (bug 1739220) for causing multiple failures e.g.browser_media_control_non_eligible_media.js. CLOSED TREE
...
Backed out changeset 20bce7cd571c (bug 1739220)
Backed out changeset f69aa1b07b51 (bug 1739220)
2021-12-14 20:32:26 +02:00
Edgar Chen
8add597890
Bug 1739220 - Handle fullscreen state in a more reliable way; r=smaug,Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D131185
2021-12-14 15:23:54 +00:00
Paul Zuehlcke
0ca511ff0f
Bug 1739091, r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D131268
2021-11-22 16:11:45 +00:00
Harry Twyford
45025048ce
Bug 1701929 - Define positioning required for Mac fullscreen slide in CSS to avoid frame reconstruction. r=mstange,Gijs
...
Baseline profile: https://share.firefox.dev/3p5PgDn (jank)
Profile with just setting pinned tab position to absolute: https://share.firefox.dev/30jKR5p (jank)
Profile with just moving relative positioning to CSS: https://share.firefox.dev/3p6c5a7 (jank)
Profile with this patch: https://share.firefox.dev/3FRLmnK (no jank)
Markus said setting abspos pinned tabs would be safe as long as there were no relative-positioned ancestors in the tab overflow scrollbox. The only notable ancestor of a pinned tab is the tab arrowscrollbox itself, so there aren't any surprise ancestors here. Manual testing indicates things work fine.
I also confirmed that this patch fixes bug 1725151.
Differential Revision: https://phabricator.services.mozilla.com/D121403
2021-10-20 13:59:23 +00:00
Emilio Cobos Alvarez
2edef0e001
Bug 1735318 - Unify "native" vs. "fullscreen" window controls. r=desktop-theme-reviewers,dao
...
I've tested this (both with and without titlebar) in Linux, Win10,
Win11, Win7 and macOS.
* On macOS behavior doesn't change at all (since on fullscreen we didn't
show the buttons to begin with).
* Linux now shows "native" buttons on fullscreen (which is also an
improvement).
* On Windows 10/11 the sizing of the buttons is now the same when
fullscreen vs. not (which is an improvement).
* On Windows 7 we now use regular native-looking buttons (like on
windows 10) instead of the custom windowControls.png. That could be
considered a slight regression I guess, but is consistent with win10.
Differential Revision: https://phabricator.services.mozilla.com/D128196
2021-10-12 13:20:13 +00:00
Harry Twyford
3468883144
Bug 1706901 - Allow the toolbar to shift with position: relative. r=mstange,desktop-theme-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D113612
2021-04-28 20:15:38 +00:00
Harry Twyford
787f35839a
Bug 740148 - Allow toolbar autohide in fullscreen on macOS, but disable it by default. r=mac-reviewers,mstange,bradwerth
...
Differential Revision: https://phabricator.services.mozilla.com/D110573
2021-04-01 18:16:25 +00:00
Harry Twyford
2be160a28f
Bug 1695921 - Rename OSXLionFullscreen to macOSNativeFullscreen. r=mac-reviewers,mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D109931
2021-03-26 16:34:54 +00:00
Harry Twyford
bd1a4f8ca2
Bug 1699506 - Part 2 - Add CSS rules to shift the toolbar over the content when the macOS menubar is shown. r=mstange
...
Differential Revision: https://phabricator.services.mozilla.com/D106847
2021-03-18 20:20:40 +00:00
james
c8a67215e0
Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 23:33:51 +00:00
Narcis Beleuzu
d5390af0ba
Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE
2021-02-13 21:46:51 +02:00
james
1c970f6297
Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D104552
2021-02-13 18:11:18 +00:00
Emma Malysz
779c8f15b9
Bug 1678211, remove unused fullscreen.used telemetry probe r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D98124
2020-12-01 16:59:30 +00:00
Xidorn Quan
ddbb4074f5
Bug 729011 - Make fullscr-toggler not affect viewport size. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D97736
2020-11-20 11:21:03 +00:00
Steven MacLeod
c75aa0c6fc
Bug 1656741, r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D91760
2020-10-05 22:38:03 +00:00
Gijs Kruitbosch
38116bcd2a
Bug 1663879 - do not show 'pdf.js' as the origin of the full screen request, r=jaws
...
Depends on D89675
Differential Revision: https://phabricator.services.mozilla.com/D89676
2020-09-11 15:05:50 +00:00
Gijs Kruitbosch
ff8194eb68
Bug 1663879 - migrate fullscreen and pointer lock warnings to fluent, r=jaws,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D89675
2020-09-12 20:09:26 +00:00
Alphan Chen
edb5050b7e
Bug 1644484 - Handle the TypeError and InvalidStateError when calling FullScreen.cleanupDomFullscreen() from DOMFullscreenParent.didDestroy() r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D81716
2020-07-03 03:00:53 +00:00
Jan Horak
fa84722e46
Bug 1594738 Remove top black line from kiosk mode; r=mkaply
...
There is a fullscr-toggler still shown in kiosk mode. This patch
disables it showing when in kiosk mode.
Differential Revision: https://phabricator.services.mozilla.com/D81828
2020-07-01 13:31:14 +00:00
Emma Malysz
f713450311
Bug 1645460, switch from the expired FX_BROWSER_FULLSCREEN_USED to a scalar that we actually collect until Fx86 r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D79519
2020-06-17 18:07:40 +00:00
Xidorn Quan
6caaa147cd
Bug 1276537 part 3 - Remove OS X detection code from full screen handling. r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D74556
2020-05-13 12:43:09 +00:00
Gijs Kruitbosch
ac92dd370a
Bug 1631229 - make popup hiding exiting fullscreen work correctly for tooltips, r=dao
...
Differential Revision: https://phabricator.services.mozilla.com/D72461
2020-04-27 09:30:40 +00:00
Dão Gottwald
724f548867
Bug 1632166 - Obey prefers-reduced-motion when animating toolbars for fullscreen mode. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D71959
2020-04-23 22:15:53 +00:00
Drew Willcoxon
ba131af622
Bug 1610200 - In full screen, properly hide the toolbars after the user picks a result in the urlbar. r=dao
...
Two fixes:
* The urlbar view isn't a popup anymore, so `FullScreen` should listen for `onViewOpen` and `onViewClose` on the urlbar controller instead of popup events.
* Change the keypress listeners to keydown to listen for enter events in the urlbar and hide the toolbars.
Differential Revision: https://phabricator.services.mozilla.com/D62123
2020-02-13 21:39:08 +00:00
Abdoulaye Oumar Ly
ae0f59c088
Bug 1590138 - Handle the case where the actor is already destroyed during fullscreen exit so that chrome UI is fully restored. r=smaug,NeilDeakin
...
Differential Revision: https://phabricator.services.mozilla.com/D51339
2019-11-05 23:29:26 +00:00
Dão Gottwald
05613d9736
Bug 1589018 - Remove global-scope pollution from browser-fullScreenAndPointerLock.js. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D49393
2019-10-16 12:34:22 +00:00
Dão Gottwald
97086934c1
Bug 1588813 - Remove redundant imports and service getters from browser-fullScreenAndPointerLock.js and nsContextMenu.js. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D49298
2019-10-15 15:06:22 +00:00
Abdoulaye Oumar Ly
a56875675a
Bug 1505916 - [Fission] Part 2: Make the fullscreen code work with oop iframes. r=NeilDeakin,smaug
...
e10s scenario:
1. An DOM element request fulscreen mode.
2. The request is redirected to the parent.
3. Parent enters fullscreen.
4. Parent notifies child that it has finished entering fullscreen.
5. Child goes fullscreen.
6. Then, child notifies parent that it has finished transitioning to fullscreen.
4. Finally, parent notify observers that fullscreen paint has finished.
Let's go into the details of how step 5 works in the above scenario.
5.a The element that made the request is set to fullscreen.
5.b Then, the document where that element lives is set to fullscreen as well as all of its ancestors until we reach the top level document. (see Document::ApplyFulscreen method)
Now in Fission world, we may have a request comming from an oop iframe. And it that case since we won't have to ancestor documents living in different content process(es), we will first notiy those content processes (one after another from bottom to top) to go fullscreen. Once they all do, the content process where the request originated will be told to enter fullscreen.
Differential Revision: https://phabricator.services.mozilla.com/D45972
2019-10-11 14:30:28 +00:00
Abdoulaye Oumar Ly
404b13dc0f
Bug 1505916 - [Fission] Part 1: Make the fullscreen code work with JSWindowActors. r=NeilDeakin,dao,smaug
...
At this point, fullscreen is not regressed but it doesn't work with oop iframes yet.
Differential Revision: https://phabricator.services.mozilla.com/D35026
2019-10-11 14:30:28 +00:00
Paul Zuehlcke
b83b198c79
Bug 1583665 - Fixed AddonManager.jsm fullscreen check to only cancel installation for DOM fullscreen. r=johannh
...
Differential Revision: https://phabricator.services.mozilla.com/D47933
2019-10-09 09:28:19 +00:00
Michael Kaply
e45d30657d
Bug 158968 - Implement kiosk mode. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D41848
2019-10-04 19:47:56 +00:00
monikamaheshwari
edb30ffaec
Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
...
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00