Commit Graph

4715 Commits

Author SHA1 Message Date
Joel Maher
397e8ec3f4 Bug 1961608 - Green up macosx 15.30. r=aryx,necko-reviewers,extension-reviewers,media-playback-reviewers,credential-management-reviewers,sync-reviewers,anti-tracking-reviewers,sessionstore-reviewers,places-reviewers,omc-reviewers,profiles-reviewers,pdahiya,alwu,jhirsch,mtigley,skhamis,timhuang,valentin,robwu,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D246100
2025-04-22 18:12:28 +00:00
Timothy Nikkel
b8004617a2 Bug 1960856. Grayscale PNGs with cicp chunk need to convert to RGB before qcms color manages it. r=gfx-reviewers,lsalzman
qcms expects rgb data for profiles created from cicp info. This mirrors what we do for icc profiles below.

Differential Revision: https://phabricator.services.mozilla.com/D245887
2025-04-17 11:19:00 +00:00
Lucas Chollet
8bbb6fe514 Bug 1862235 Remove non-compliant behavior with tRNS chunks. r=tnikkel
In previous editions of the spec, out-of-range values were not
considered. As this is now specified, we should let libpng do the right
thing and not inject non-compliant behavior.

Differential Revision: https://phabricator.services.mozilla.com/D211677
2025-04-15 15:08:40 +00:00
Rob Wu
62248a8bcc Bug 1953004 - Run test-manifest-toml --fix on all toml files in the trees r=credential-management-reviewers,places-reviewers,desktop-theme-reviewers,Standard8,devtools-reviewers,hjones,jmaher,jdescottes,dimi,necko-reviewers,sidebar-reviewers,jsudiaman,kershaw
This diff was generated as follows:

List all toml files in the tree:

`find * -name '*.toml' > /tmp/toml`

Manually edited /tmp/toml to drop non-relevant entries (objdir).

Ran the toml linter for all files:

`cat /tmp/toml | xargs ./mach lint -l test-manifest-toml --fix`

Differential Revision: https://phabricator.services.mozilla.com/D240948
2025-04-14 08:30:13 +00:00
Florian Quèze
9885783942 Bug 1956726 - remove leftover Telemetry.h includes in .cpp files, r=chutten,geckoview-reviewers,cookie-reviewers,win-reviewers,dom-storage-reviewers,gstoll,valentin,m_kato,janv.
Differential Revision: https://phabricator.services.mozilla.com/D244351
2025-04-08 13:03:02 +00:00
Florian Quèze
f861f3fa68 Bug 1956726 - remove leftover Telemetry.h includes in header files, r=chutten,places-reviewers.
Differential Revision: https://phabricator.services.mozilla.com/D244350
2025-04-08 13:03:01 +00:00
Lee Salzman
e1fbc38338 Bug 1958191 - Update Skia to m136. r=aosmond
This looks like a fairly mild update with some of our local patches
being upstreamed and otherwise reasonably small amounts of code churn.

Differential Revision: https://phabricator.services.mozilla.com/D244290
2025-04-04 03:46:00 +00:00
Timothy Nikkel
5d3111722f Bug 1944122. Make sure the first (vector) part of a multipart images gets load complete. r=emilio
In bug 1862059 we ensured that every (vector) part of a multipart image got load complete before it was made the current part. This missed the first part because it was never the next part, it just become the current part immediately. This was good enough to fix all cases except where the multipart image reached a finite end point (which would then send the final part load complete and hit the same duplicate final part load complete bug).

Differential Revision: https://phabricator.services.mozilla.com/D241816
2025-04-03 02:03:41 +00:00
Joel Maher
34dc8fc793 Bug 1957450 - cleanup chrome.toml files to remove old conditions and standardize remaining conditions. r=aryx,devtools-reviewers,fxview-reviewers,profiler-reviewers,omc-reviewers,migration-reviewers,backup-reviewers,julienw,nchevobbe,mconley,pdahiya,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D243709
2025-04-01 21:16:45 +00:00
Emilio Cobos Álvarez
0120f86928 Bug 1957490 - Use ShouldClearEntry in imgLoader too. r=arai
No behavior change intended.

Differential Revision: https://phabricator.services.mozilla.com/D243714
2025-04-01 08:27:02 +00:00
kernp25
4d18975ff5 Bug 1945924 - Replace SchemeIsFoo functions with the inlined SchemeIs() call. r=valentin,emilio,necko-reviewers,geckoview-reviewers,anti-tracking-reviewers,core-sessionstore-reviewers,ohall,farre
No behavior change intended.

Differential Revision: https://phabricator.services.mozilla.com/D236756
2025-03-31 14:25:54 +00:00
Emilio Cobos Álvarez
757741e34c Bug 1955624 - Remove now unused OriginAttributes argument to ImageCacheKey constructor. r=arai
Just drive-by cleanup, the regressing bug made these unused.

Differential Revision: https://phabricator.services.mozilla.com/D242639
2025-03-23 17:11:47 +00:00
Emilio Cobos Álvarez
dc708bbcee Bug 1955624 - Don't include partitioned principal hash on image cache key hash. r=arai
As the hash can change during the principal's lifetime, see bug 1955775.

Differential Revision: https://phabricator.services.mozilla.com/D242638
2025-03-23 17:11:46 +00:00
Mike Hommey
61f8be5d7a Bug 1949947 - Adjust images tests for the new libz-rs release. r=gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D241124
2025-03-19 20:11:18 +00:00
Tooru Fujisawa
8fa3cc1097 Bug 1947158 - Add url option to ChromeUtils.clearResourceCache. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D238357
2025-03-18 09:57:57 +00:00
Tooru Fujisawa
893c87646e Bug 1948875 - Part 1: Add static imgLoader::ClearCache and refactor IPC. r=tnikkel
In order to clear cache from ChromeUtils.clearResourceCache with variuos
filtering, imgLoader needs a method that are adaptive to the current process,
where in the parent process, clear all processes' cache,
and in the content process, clear the cache in the process.

Refactored the cache methods based on single static method and single IPC
method, this is also necessary to extend the ChromeUtils.clearResourceCache in
bug 1947158.

Differential Revision: https://phabricator.services.mozilla.com/D239138
2025-03-18 02:03:31 +00:00
Emilio Cobos Álvarez
2cc4039e44 Bug 1954134 - Simplify ImageCacheKey partitioning. r=necko-reviewers,valentin,arai
Use the same scheme as the JS and CSS caches:

https://searchfox.org/mozilla-central/rev/5c2888b35d56928d252acf84e8816fa89a8a6a61/layout/style/Loader.cpp#2341
https://searchfox.org/mozilla-central/rev/5c2888b35d56928d252acf84e8816fa89a8a6a61/dom/script/ScriptLoader.cpp#329

(And fonts, and plenty of others)

Differential Revision: https://phabricator.services.mozilla.com/D241664
2025-03-15 15:36:25 +00:00
Timothy Nikkel
73295ba039 Bug 1951423. Use the sRGB transfer characteristics for BT.709, BT.601, and BT.2020. r=gfx-reviewers,aosmond
That is what other apps are doing.

Differential Revision: https://phabricator.services.mozilla.com/D240850
2025-03-14 10:06:18 +00:00
Goloman Adrian
6fa58a5cca Backed out changeset 00823f809729 (bug 1951423) for causing build bustages @Decoder.cpp. 2025-03-14 08:13:09 +02:00
Timothy Nikkel
d1ff842387 Bug 1951423. Use the sRGB transfer characteristics for BT.709, BT.601, and BT.2020. r=gfx-reviewers,aosmond
That is what other apps are doing.

Differential Revision: https://phabricator.services.mozilla.com/D240850
2025-03-13 21:13:46 +00:00
Alex Franchuk
da658fa4b2 Bug 1942129 pt4 - Convert old shmem call sites to use the new shmem classes r=ipc-reviewers,media-playback-reviewers,padenot,lsalzman,aosmond,nika
While much of this is simply converting code (and removing extraneous
`size` parameters), toolkit/xre/GeckoArgs.{h,cpp} has some significant
changes to support sending read-only handles (which is all we need!).

Differential Revision: https://phabricator.services.mozilla.com/D236750
2025-03-04 22:11:12 +00:00
Butkovits Atila
2406ce261c Backed out 8 changesets (bug 1942129) for causing bustages at SharedMemoryMapping.h. CLOSED TREE
Backed out changeset 8d9053f1c203 (bug 1942129)
Backed out changeset 393e3c507c27 (bug 1942129)
Backed out changeset 8240d353d224 (bug 1942129)
Backed out changeset 8c4cd026b720 (bug 1942129)
Backed out changeset 742634b0d6e9 (bug 1942129)
Backed out changeset d16857f9812f (bug 1942129)
Backed out changeset 7ff7af041ee7 (bug 1942129)
Backed out changeset ef41d9e4c7de (bug 1942129)
2025-03-04 00:43:23 +02:00
Alex Franchuk
f7ee08eef3 Bug 1942129 pt4 - Convert old shmem call sites to use the new shmem classes r=ipc-reviewers,media-playback-reviewers,padenot,lsalzman,aosmond,nika
While much of this is simply converting code (and removing extraneous
`size` parameters), toolkit/xre/GeckoArgs.{h,cpp} has some significant
changes to support sending read-only handles (which is all we need!).

Differential Revision: https://phabricator.services.mozilla.com/D236750
2025-03-03 19:53:20 +00:00
Mike Hommey
f26e135cfb Bug 1949096 - Adjust images tests for when using libz-rs. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D239088
2025-02-21 22:38:37 +00:00
Florian Quèze
b9a56a1402 Bug 1949492 - migrate to glean the AVIF_MAJOR_BRAND and AVIF_SEQUENCE histograms, r=tnikkel.
Differential Revision: https://phabricator.services.mozilla.com/D239108
2025-02-21 13:35:56 +00:00
Florian Quèze
8790af7a25 Bug 1949492 - remove AVIF_* legacy telemetry histograms that already have an equivalent in Glean, r=tnikkel.
Differential Revision: https://phabricator.services.mozilla.com/D239107
2025-02-21 13:35:56 +00:00
Sandor Molnar
f4ac4c4611 Bug 1948808 - Fix build bustage 2025-02-20 13:43:28 +02:00
Tooru Fujisawa
6917577339 Bug 1948814 - Part 2: Also clear resource:// uris in imgLoader::ClearImageCache with chromeOnly option. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D238579
2025-02-20 10:16:46 +00:00
Tooru Fujisawa
5be020f499 Bug 1948814 - Part 1: Fix content-only mode of imgICache.clearCache, and add explicit clear-both mode. r=tnikkel,anti-tracking-reviewers,emz
Differential Revision: https://phabricator.services.mozilla.com/D238578
2025-02-20 10:16:45 +00:00
Sandor Molnar
61d8ddba5a Backed out 5 changesets (bug 1948814, bug 1948808) for causing build bustages @ gfxWindowsPlatform.cpp & imgLoader.cpp CLOSED TREE
Backed out changeset 9dad8866deac (bug 1948808)
Backed out changeset 7d15850e1871 (bug 1948808)
Backed out changeset 94a8ed4703ac (bug 1948808)
Backed out changeset 1249b7246565 (bug 1948814)
Backed out changeset 67a316ead440 (bug 1948814)
2025-02-20 10:19:27 +02:00
Tooru Fujisawa
334030680f Bug 1948814 - Part 2: Also clear resource:// uris in imgLoader::ClearImageCache with chromeOnly option. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D238579
2025-02-20 07:04:54 +00:00
Tooru Fujisawa
b7ffedd05c Bug 1948814 - Part 1: Fix content-only mode of imgICache.clearCache, and add explicit clear-both mode. r=tnikkel,anti-tracking-reviewers,emz
Differential Revision: https://phabricator.services.mozilla.com/D238578
2025-02-20 07:04:53 +00:00
Timothy Nikkel
cf13e42fbd Bug 1948991. Update internal error string for libpng change. r=gfx-reviewers,aosmond
The error message for this error got changed.

Differential Revision: https://phabricator.services.mozilla.com/D238885
2025-02-20 02:19:27 +00:00
Timothy Nikkel
243aefeeb3 Bug 1945469. Add test for bug 1943715. r=gfx-reviewers,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D236523
2025-02-04 05:53:06 +00:00
Joel Maher
d67a5fd95a Bug 1945276 - Migration Win11 reftest from 22H2 -> 24H2. r=aryx
Differential Revision: https://phabricator.services.mozilla.com/D236436
2025-02-01 15:27:10 +00:00
Florian Quèze
d568f60b00 Bug 1935420 - Migrate histograms to use Glean APIs for IMAGE_DECODE_*, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D234112
2025-01-29 15:58:50 +00:00
mitch-ament
f7061f828c Bug 1942327 Removed image.exif-density-correction-enabled pref as it has been enabled by default for years with no issue and is the standard for Safari and Chromium. r=gregp,emilio
Differential Revision: https://phabricator.services.mozilla.com/D235684
2025-01-28 17:08:07 +00:00
Timothy Nikkel
320981307d Bug 1862245. Support cICP colorspace chunk in png files. r=gfx-reviewers,lsalzman
Most recent libpng update included native support for this so we don't need to fiddle with unknown chunks.

Differential Revision: https://phabricator.services.mozilla.com/D235079
2025-01-22 04:32:38 +00:00
Florian Quèze
9609e47f62 Bug 1879329 - script generated replacement of the GleanMetrics.h includes, r=chutten,valentin,media-playback-reviewers,cookie-reviewers,anti-tracking-reviewers,profiler-reviewers,win-reviewers,rkraesig,emz,aabh,padenot.
Differential Revision: https://phabricator.services.mozilla.com/D234744
2025-01-21 11:21:45 +00:00
Joel Maher
bcc50efbeb Bug 1940980 - Green up win11-64 opt/debug/asan/ccov. r=aryx,media-playback-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,tabbrowser-reviewers,urlbar-reviewers,aosmond,mconley,ochameau,dimi,jteow,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D233862
2025-01-16 23:02:48 +00:00
Benjamin VanderSloot
986aa04113 Bug 1937102 - Fix protections UI tests that rely on unpartitioning storage - r=anti-tracking-reviewers,cookie-reviewers,webcompat-reviewers,timhuang,twisniewski
This is where I found and addressed a bug with surplus console messages when we enabled APS

Differential Revision: https://phabricator.services.mozilla.com/D233915
2025-01-16 15:39:24 +00:00
Landry Breuil
5b7226bb03 Bug 1559213 Allow to use system av1 libs instead of bundled r=glandium,media-playback-reviewers,aosmond,stransky,alwu
Differential Revision: https://phabricator.services.mozilla.com/D34921
2025-01-13 11:34:33 +00:00
Daniel Holbert
8b4107e59f Bug 1929147: Make VectorImage::GetWidth/GetHeight gracefully fail (rather than crashing) if internal doc's root element is nullptr. r=tnikkel
Based on intermittent crashes in automation, it seems like during shutdown, two
things may happen independently:
(A) we gather a memory report that asks our SVG images for their width/height.
(B) we tear down the internal SVG document for our SVG images.

If they happen in that order (A before B), then everything's fine; but if B
happens *before* A, then the width/height queries in A will find an SVG
document with a null pointer for the root element. So we need to handle that
case gracefully.

Differential Revision: https://phabricator.services.mozilla.com/D231825
2024-12-12 08:38:32 +00:00
Timothy Nikkel
79ea57a98d Bug 1935828. Enable test_animSVGImage.html and test_animSVGImage2.html everywhere. r=longsonr
With the fixes in bug 1935099 these seems to pass everywhere. I ran every job in the default set of tasks for try that includes these and even did test-verify jobs with no-op changes to the tests so they get picked up as modified and then retriggered every job multiple times and got zero failures.

Differential Revision: https://phabricator.services.mozilla.com/D231473
2024-12-07 22:18:55 +00:00
Timothy Nikkel
40093290b7 Bug 1935099. Wait until image loads before checking in image/test/mochitest/test_animSVGImage.html. r=layout-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D231378
2024-12-07 04:23:07 +00:00
Timothy Nikkel
42babc4a1a Bug 1935099. Fix image/test/mochitest/test_animSVGImage.html. r=dshin
Differential Revision: https://phabricator.services.mozilla.com/D231074
2024-12-07 04:23:07 +00:00
Sebastian Hengst
6450439c72 Bug 1922355 - adjust expectations for reftests on macOS 14.70 with x86-64. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D231164
2024-12-06 15:05:06 +00:00
Alexandru Marc
92d825c1de Backed out changeset d3603c9cc465 (bug 1922355) for causing multiple reftest failures CLOSED TREE 2024-12-05 02:39:42 +02:00
Sebastian Hengst
c686a8cf7c Bug 1922355 - adjust expectations for reftests on macOS 14.70 with x86-64. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D231164
2024-12-04 22:33:24 +00:00
Andrew Osmond
e1368b4e31 Bug 1874523. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D227304
2024-11-25 17:55:49 +00:00