Commit Graph

52 Commits

Author SHA1 Message Date
agoloman
63c83deb26 Revert "Bug 1606785 - Enable Prettier for CSS files r=desktop-theme-reviewers,Standard8,frontend-codestyle-reviewers,emilio" for causing multiple failures.
This reverts commit ec5fa1d4c0.

Revert "Bug 1606785 - Format Firefox CSS files with Prettier r=desktop-theme-reviewers,perftest-reviewers,places-reviewers,translations-reviewers,omc-reviewers,backup-reviewers,browser-installer-reviewers,sparky,dao,pdahiya,nrishel,kpatenio"

This reverts commit baa5d72bbd.

Revert "Bug 1606785 - Format browser/themes and toolkit/themes CSS files with Prettier r=desktop-theme-reviewers,pip-reviewers,tabbrowser-reviewers,places-reviewers,dao,mconley"

This reverts commit 9604b0a8ae.

Revert "Bug 1606785 - Format browser/themes/preferences CSS files with Prettier r=settings-reviewers,desktop-theme-reviewers,dao,mconley"

This reverts commit 686c1cf85f.

Revert "Bug 1606785 - Format urlbar CSS files with Prettier r=urlbar-reviewers,desktop-theme-reviewers,dao"

This reverts commit a7a4f31251.

Revert "Bug 1606785 - Format webcompat CSS files with Prettier r=webcompat-reviewers,denschub"

This reverts commit 41bc4d5237.

Revert "Bug 1606785 - Format search CSS files with Prettier r=search-reviewers,jteow"

This reverts commit 7bb7f82374.

Revert "Bug 1606785 - Format dom CSS files with Prettier r=emilio"

This reverts commit c22e910235.

Revert "Bug 1606785 - Format android CSS files with Prettier r=geckoview-reviewers,hiro"

This reverts commit c08e43fc3d.

Revert "Bug 1606785 - Format layout CSS files with Prettier r=layout-reviewers,dholbert"

This reverts commit 4f2a32d1a4.

Revert "Bug 1606785 - Format devtools CSS files with Prettier r=devtools-reviewers,nchevobbe,frontend-codestyle-reviewers"

This reverts commit c05f675ddf.

Revert "Bug 1606785 - Format recomp CSS files with Prettier r=reusable-components-reviewers,desktop-theme-reviewers,dao,mkennedy"

This reverts commit b10c7de8d0.

Revert "Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley"

This reverts commit d32c555e37.

Revert "Bug 1606785 - Format shopping CSS files with Prettier r=shopping-reviewers,desktop-theme-reviewers,dao,rking"

This reverts commit 965887a708.

Revert "Bug 1606785 - Format profiles CSS files with Prettier r=profiles-reviewers,desktop-theme-reviewers,dao,mossop"

This reverts commit 8338860f74.

Revert "Bug 1606785 - Format genai and ml CSS files with Prettier r=firefox-ai-ml-reviewers,Mardak"

This reverts commit d66681f553.

Revert "Bug 1606785 - Format firefoxview CSS files with Prettier r=fxview-reviewers,desktop-theme-reviewers,dao,jsudiaman"

This reverts commit 530b815cad.

Revert "Bug 1606785 - Format aboutlogins, megalist, and form autofill CSS files with Prettier r=credential-management-reviewers,mtigley,desktop-theme-reviewers,dao"

This reverts commit 813c864381.
2025-05-21 04:49:28 +00:00
hannajones
d32c555e37 Bug 1606785 - Format sidebar CSS files with Prettier r=sidebar-reviewers,desktop-theme-reviewers,dao,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D249172
2025-05-21 03:54:32 +00:00
Tim Giles
134dc6c03a Bug 1936648 - Replace searchfield-cancel with close-12 icon. r=desktop-theme-reviewers,fxview-reviewers,tabbrowser-reviewers,reusable-components-reviewers,omc-reviewers,emilio,aminomancer,hjones
Replaces the searchfield-cancel icon with the close-12 icon so that we
can style the background-color of the icon as needed.

Since we need close-12.svg to be content accessible, I needed to move
the icon to layout/style/res and add it as a content accessible file.
This resulted in replacing the existing uses of
chrome://global/skin/icons/close-12.svg with the new resource URL,
resource://content-accessible/close-12.svg.

Differential Revision: https://phabricator.services.mozilla.com/D243564
2025-05-01 15:24:34 +00:00
Kelly Cochrane
11a04a64b6 Bug 1953155 - Enable expand on hover option and remove expand on hover coming soon message r=sidebar-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D241293
2025-03-18 22:03:50 +00:00
Mark Striemer
6aa3b1349e Bug 1949238: Part 1 - Expand on hover message bar in sidebar customize r=sidebar-reviewers,desktop-theme-reviewers,reusable-components-reviewers,nsharpley
This is an initial patch with the message bar styled as we would like,
but it is using temporary strings directly in the markup. These will
need to be extracted to fluent strings in a follow up change.

Differential Revision: https://phabricator.services.mozilla.com/D239026
2025-02-25 16:18:49 +00:00
Kelly Cochrane
cae199c0f2 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao
Differential Revision: https://phabricator.services.mozilla.com/D233098
2025-02-05 18:04:20 +00:00
Stanca Serban
0efa589b90 Backed out changeset 1be8354cedcd (bug 1930201) for causing mochitests failures. CLOSED TREE 2025-02-05 19:11:28 +02:00
Kelly Cochrane
03c6b75a99 Bug 1930201 - Add option to expand sidebar on hover r=desktop-theme-reviewers,sidebar-reviewers,emilio,tabbrowser-reviewers,flod,sclements,dao
Differential Revision: https://phabricator.services.mozilla.com/D233098
2025-02-05 14:05:08 +00:00
Nikki Sharpley
3a0cdaac95 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-31 17:20:04 +00:00
Goloman Adrian
076b72e294 Backed out changeset bcb4fe8937d9 (bug 1939917) for causing bc failures @browser_toolbar_sidebar_button.js. 2025-01-30 23:12:08 +02:00
Nikki Sharpley
90377aaee3 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-30 19:51:57 +00:00
Goloman Adrian
a2f88b27ce Backed out changeset fd1a85f26bc5 (bug 1939917) for causing bc failures @browser_all_files_referenced.js. 2025-01-30 21:14:06 +02:00
Nikki Sharpley
a205e140f0 Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-30 16:52:11 +00:00
Sandor Molnar
cc838f6396 Backed out changeset 97ac16a67945 (bug 1939917) for causing bc failures @ browser_customize_sidebar.js CLOSED TREE 2025-01-30 01:58:33 +02:00
Nikki Sharpley
c3ae33f79c Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-29 23:02:52 +00:00
Sandor Molnar
289ab282d7 Backed out changeset 1ddeda5cc40a (bug 1939917) for causing sidebar related failures CLOSED TREE 2025-01-30 00:23:19 +02:00
Nikki Sharpley
89a42ee5df Bug 1939917 - Update Sidebar visibility settings and settings order r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements,hjones
- change order of settings as per spec
- only show visibilty settings if vertical tabs enabled

Depends on D234592

Differential Revision: https://phabricator.services.mozilla.com/D235178
2025-01-29 20:59:31 +00:00
Nikki Sharpley
935eac6d0a Bug 1932354 - Fix sidebar visual styling nits r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,dao,hjones,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D232286
2024-12-20 15:13:04 +00:00
Butkovits Atila
5ce18cb959 Backed out changeset d5d8966d01d0 (bug 1932354) for causing failures at browser_sidebar_panel_header.js. CLOSED TREE 2024-12-20 01:08:04 +02:00
Nikki Sharpley
e118a4fc86 Bug 1932354 - Fix sidebar visual styling nits r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,dao,hjones,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D232286
2024-12-19 21:35:47 +00:00
Tim Giles
99606ce3ee Bug 1918490 - Move support link element outside of label element. r=reusable-components-reviewers,accessibility-frontend-reviewers,desktop-theme-reviewers,hjones,nlapre,sidebar-reviewers,nsharpley
The motivation for this change is to improve the screen reader user
experience when navigating through moz-checkbox and moz-radio elements.
When a screen reader encounters and focuses a moz-checkbox or
moz-radio element, only the label is announced. Previously the label
and the support-link element would be announced which is confusing since
it is not clear what will happen when activating one of these moz
elements.

Additionally, we remove the display flex and width rules from
sidebar-customize.css to prevent sidebar test breakage and create a
larger click surface for moz-radio and moz-checkbox when used in the
sidebar.

The moz-input-common.css change makes moz-label behave more like XUL
labels where the click area for the label and control span the entire
width unless there is a support link in the moz-label. In this case,
clicking on the other side of the support link will not activate the
respective control.

We needed to add "label: 'A label'" to the verifySupportPage function
otherwise debug assertions would be thrown and cause test_moz_radio.html
to fail. I'm still not entirely sure why there are debug assertions
failing here, someone with a greater depth of knowledge around layout
reflows would need to investigate.

Differential Revision: https://phabricator.services.mozilla.com/D226181
2024-11-21 16:18:16 +00:00
Stanca Serban
faf468d4f2 Backed out changeset 25a8e51c3fe2 (bug 1918490) for causing mochitests failures in test_moz_radio.html. CLOSED TREE 2024-11-19 23:28:07 +02:00
Tim Giles
b6d2c26a8c Bug 1918490 - Move support link element outside of label element. r=reusable-components-reviewers,accessibility-frontend-reviewers,desktop-theme-reviewers,hjones,nlapre,sidebar-reviewers,nsharpley
The motivation for this change is to improve the screen reader user
experience when navigating through moz-checkbox and moz-radio elements.
When a screen reader encounters and focuses a moz-checkbox or
moz-radio element, only the label is announced. Previously the label
and the support-link element would be announced which is confusing since
it is not clear what will happen when activating one of these moz
elements.

Additionally, we remove the display flex and width rules from
sidebar-customize.css to prevent sidebar test breakage and create a
larger click surface for moz-radio and moz-checkbox when used in the
sidebar.

The moz-input-common.css change makes moz-label behave more like XUL
labels where the click area for the label and control span the entire
width unless there is a support link in the moz-label. In this case,
clicking on the other side of the support link will not activate the
respective control.

Differential Revision: https://phabricator.services.mozilla.com/D226181
2024-11-19 20:30:46 +00:00
Emilio Cobos Álvarez
112244f5f4 Bug 1930992 - Don't use toolbar colors for sidebar cards. r=sidebar-reviewers,desktop-theme-reviewers,sclements,dao
Also use consistent borders.

Differential Revision: https://phabricator.services.mozilla.com/D228879
2024-11-19 09:06:38 +00:00
Butkovits Atila
09cd25afd7 Backed out 2 changesets (bug 1930992) for causing failures at browser_html_detail_view.js. CLOSED TREE
Backed out changeset b5d37bddf198 (bug 1930992)
Backed out changeset c182493e091d (bug 1930992)
2024-11-18 23:31:05 +02:00
Emilio Cobos Álvarez
7fbd133c36 Bug 1930992 - Don't use toolbar colors for sidebar cards. r=sidebar-reviewers,desktop-theme-reviewers,sclements,dao
Also use consistent borders.

Differential Revision: https://phabricator.services.mozilla.com/D228879
2024-11-18 19:55:03 +00:00
Stuart Colville
0bfc30cdeb Bug 1912493 - Update sidebar settings groups spacing and extensions heading weight. r=sidebar-reviewers,desktop-theme-reviewers,jsudiaman,dao,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D218969
2024-08-16 11:37:29 +00:00
Nikki Sharpley
a441acbbaa Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
2024-08-02 19:10:14 +00:00
Butkovits Atila
dd41b6e962 Backed out changeset 397b2df59338 (bug 1886847) for causing failures at browser-custom-colors.css. CLOSED TREE 2024-08-02 19:18:43 +03:00
Nikki Sharpley
54d0b76fd9 Bug 1886847 - Styling and UI polish for sidebar r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,dao,settings-reviewers,tgiles,mconley,jsudiaman,kcochrane
- styled synced tabs and history
- styled sidebar search
- styled customize settings
- added sidebar right icon to customize input

Differential Revision: https://phabricator.services.mozilla.com/D216748
2024-08-02 15:26:00 +00:00
Jonathan Sudiaman
52e63f2908 Bug 1892941 - Add a "Always Show" sidebar visibility setting r=sidebar-reviewers,fluent-reviewers,sessionstore-reviewers,bolsson,sclements,reusable-components-reviewers,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D212285
2024-06-27 19:34:08 +00:00
Mark Striemer
cabc85f076 Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213330
2024-06-19 18:37:37 +00:00
Mark Striemer
fb377d8a08 Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213328
2024-06-19 18:37:37 +00:00
Kelly Cochrane
e2fe9bf11e Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D213278
2024-06-18 18:24:08 +00:00
pstanciu
e91ba02454 Backed out changeset ab055e5ace5e (bug 1899576) for causing bc failures on browser_all_files_referenced.js CLOSED TREE 2024-06-18 20:49:29 +03:00
Kelly Cochrane
c8bfc52deb Bug 1899576 - Create a reusable sidebar header component with a close button r=desktop-theme-reviewers,fxview-reviewers,sidebar-reviewers,fluent-reviewers,nsharpley,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D213278
2024-06-18 16:03:11 +00:00
Sandor Molnar
34e807bc63 Backed out 5 changesets (bug 1897529, bug 1901336, bug 1900126) for causing bc failures @ browser_a11y_sidebar.js CLOSED TREE
Backed out changeset 334b820a4c19 (bug 1897529)
Backed out changeset 70350abadcba (bug 1900126)
Backed out changeset 3d631de2ce01 (bug 1897529)
Backed out changeset 1d654154d5ea (bug 1897529)
Backed out changeset a8f7b541a548 (bug 1901336)
2024-06-14 22:41:48 +03:00
Mark Striemer
d06b2bcf0e Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213330
2024-06-14 18:18:19 +00:00
Mark Striemer
caac4b33d7 Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213328
2024-06-14 18:18:19 +00:00
Tamas Szentpeteri
7b9a55f977 Backed out 4 changesets (bug 1900126, bug 1897529, bug 1901336) for causing mochitest failures on test_moz_message_bar.html. CLOSED TREE
Backed out changeset 212bac58cc17 (bug 1900126)
Backed out changeset efaba56826e3 (bug 1897529)
Backed out changeset 9c52e2ac9df2 (bug 1897529)
Backed out changeset fc94dfe91c29 (bug 1901336)
2024-06-14 06:09:39 +03:00
Mark Striemer
7b96f60e6a Bug 1900126 - Update sidebar settings fonts/spacing r=reusable-components-reviewers,sidebar-reviewers,nsharpley,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213330
2024-06-13 21:52:53 +00:00
Mark Striemer
75fb7b5b6c Bug 1897529 - Part 2: Use moz-fieldset/moz-checkbox in Customize sidebar r=sidebar-reviewers,fluent-reviewers,reusable-components-reviewers,flod,nsharpley,hjones
Differential Revision: https://phabricator.services.mozilla.com/D213328
2024-06-13 21:52:53 +00:00
Nikki Sharpley
79b74fdc93 Bug 1894222 - Add Manage Firefox Settings link to customize sidebar panel r=sidebar-reviewers,fluent-reviewers,bolsson,sclements
As traditional `a` tag links open in the sidebar panel when clicked, I've instead used `window.openPreferences()` as Gijs suggested.

Differential Revision: https://phabricator.services.mozilla.com/D211401
2024-06-10 13:42:10 +00:00
Norisz Fay
f69ee9dbb8 Backed out changeset e650be9ceb1f (bug 1894222) for causing bc failures on browser_customize_sidebar.js CLOSED TREE 2024-06-06 06:27:05 +03:00
Nikki Sharpley
5e7bc1e164 Bug 1894222 - Add Manage Firefox Settings link to customize sidebar panel r=sidebar-reviewers,fluent-reviewers,bolsson,sclements
As traditional `a` tag links open in the sidebar panel when clicked, I've instead used `window.openPreferences()` as Gijs suggested.

Differential Revision: https://phabricator.services.mozilla.com/D211401
2024-06-05 17:13:07 +00:00
Jonathan Sudiaman
6ccee8c69b Bug 1892429 - Create an expanded sidebar state r=sidebar-reviewers,fluent-reviewers,kcochrane,sclements,extension-reviewers,robwu
Adds an `expanded` property, which, if enabled, shows labels along with their respective icons within the sidebar menu. Currently, this property is not controllable from the UI. As I understand it, the follow-up bugs are responsible for addressing that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f269729808eed19051bea5fe4eb41550ff94ce03

Differential Revision: https://phabricator.services.mozilla.com/D210187
2024-05-28 15:55:49 +00:00
Kelly Cochrane
8f3ea55cfc Bug 1894221 - Add Sidebar Extensions section to Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,bolsson,sclements,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D210381
2024-05-21 14:00:03 +00:00
Kelly Cochrane
6fddd3893a Bug 1891775 - Create a 'Customize Sidebar' menu with default options r=desktop-theme-reviewers,sidebar-reviewers,fluent-reviewers,jsudiaman,bolsson,sclements,flod,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D208003
2024-05-09 02:12:39 +00:00
Stanca Serban
cf6b65c339 Backed out changeset dbbb4693be30 (bug 1891775) for causing build bustages. 2024-05-09 04:45:45 +03:00
Kelly Cochrane
d64f7640d8 Bug 1891775 - Create a 'Customize Sidebar' menu with default options r=desktop-theme-reviewers,sidebar-reviewers,fluent-reviewers,jsudiaman,bolsson,sclements,flod,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D208003
2024-05-09 01:09:03 +00:00