corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
909,731 Commits 1 Branch 0 Tags
63c83deb265ae17a24f36b668c4f4460acdf48ce
Commit Graph

99 Commits

Author SHA1 Message Date
Florian Quèze
a2877463a4 Bug 1950710 - Migrate histograms to use Glean APIs for FIREFOX_VIEW_CUMULATIVE_SEARCHES, r=chutten,fxview-reviewers,jsudiaman. 
Differential Revision: https://phabricator.services.mozilla.com/D242792
 2025-03-27 06:36:58 +00:00
Gijs Kruitbosch
19f781c655 Bug 1953575 - remove duplicated clipboard code from firefox view, r=fxview-reviewers,sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D241488
 2025-03-20 15:54:32 +00:00
mark
c2958a4a93 Bug 1936120 - Enforce no quotes around Lit expressions r=reusable-components-reviewers,credential-management-reviewers,fxview-reviewers,omc-reviewers,backup-reviewers,sidebar-reviewers,frontend-codestyle-reviewers,profiles-reviewers,mtigley,mconley,hjones,jsudiaman,niklas,Standard8,pdahiya 
* Enables lit/quoted-expressions rule to enforce that no surrounding
  quotes when expressions are bound to attributes and properties in Lit templates.
  See f71ea1741e/docs/rules/quoted-expressions.md

* Updates all violations to adhere to lit/quoted-expressions rule

Differential Revision: https://phabricator.services.mozilla.com/D237657
 2025-02-19 16:19:42 +00:00
Florian Quèze
1ee252004d Bug 1935420 - rewrite JS code storing histograms in local variables to make automatic glean migration easier, r=chutten,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,places-reviewers,markh,nsharpley. 
Differential Revision: https://phabricator.services.mozilla.com/D234008
 2025-01-24 16:18:32 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
 2024-11-29 15:18:25 +00:00
Florian Quèze
03b00e2a53 Bug 1918702 - Migrate telemetry events to use Glean APIs for firefoxview, r=chutten,fxview-reviewers,jsudiaman. 
Differential Revision: https://phabricator.services.mozilla.com/D222416
 2024-09-20 13:58:15 +00:00
Sukhmeet
3ad327de7f Bug 1893013 - Remove browser.firefox-view.search.enabled preference r=kcochrane,fxview-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D211353
 2024-06-03 15:12:53 +00:00
Jonathan Sudiaman
a1780ebc7d Bug 1867614 - fxview-tab-list story is broken, shows a "ChromeUtils is not defined" error r=fxview-reviewers,reusable-components-reviewers,hjones,nsharpley 
Remove transitive dependency on `ChromeUtils` that is causing this error.

Differential Revision: https://phabricator.services.mozilla.com/D208380
 2024-04-23 21:26:09 +00:00
Nikki Sharpley
318c5b9a6d Bug 1881107 - Remove delay opening context menu due to awaiting fetched devices r=fxview-reviewers,jsudiaman,sfoster 
I've moved the call to fetch devices to occur in connectedCallback rather than holding up the context menu toggle function.
https://profiler.firefox.com/from-browser/calltree/?globalTrackOrder=80w7&hiddenGlobalTracks=1w6&hiddenLocalTracksByPid=56852-134~56853-0~56859-0~56860-0~56858-0~56861-0~56857-0~56856-0&thread=c&v=10

Differential Revision: https://phabricator.services.mozilla.com/D205390
 2024-04-09 20:41:21 +00:00
Sandor Molnar
8da6a0d86c Backed out changeset f108b931f2d5 (bug 1881107) for causing bc failures @ browser_opentabs_pinned_tabs.js 2024-04-06 01:57:55 +03:00
Nikki Sharpley
d601acf989 Bug 1881107 - Remove delay opening context menu due to awaiting fetched devices r=fxview-reviewers,jsudiaman,sfoster 
I've moved the call to fetch devices to occur in connectedCallback rather than holding up the context menu toggle function.
https://profiler.firefox.com/from-browser/calltree/?globalTrackOrder=80w7&hiddenGlobalTracks=1w6&hiddenLocalTracksByPid=56852-134~56853-0~56859-0~56860-0~56858-0~56861-0~56857-0~56856-0&thread=c&v=10

Differential Revision: https://phabricator.services.mozilla.com/D205390
 2024-04-05 19:53:53 +00:00
Cristian Tuns
e67e7c25d4 Backed out changeset 03cfb27bc3a2 (bug 1881107) for causing bc failures in browser_opentabs_pinned_tabs.js CLOSED TREE 2024-04-04 17:38:48 -04:00
Nikki Sharpley
6a41ab03be Bug 1881107 - Remove delay opening context menu due to awaiting fetched devices r=fxview-reviewers,jsudiaman,sfoster 
I've moved the call to fetch devices to occur in connectedCallback rather than holding up the context menu toggle function.
https://profiler.firefox.com/from-browser/calltree/?globalTrackOrder=80w7&hiddenGlobalTracks=1w6&hiddenLocalTracksByPid=56852-134~56853-0~56859-0~56860-0~56858-0~56861-0~56857-0~56856-0&thread=c&v=10

Differential Revision: https://phabricator.services.mozilla.com/D205390
 2024-04-04 19:08:19 +00:00
Sam Foster
5cd812c843 Bug 1873025 - Fix the displayed relative time for open tabs listing to match the recency sorting.r=jsudiaman,fxview-reviewers,tabbrowser-reviewers,dao 
* Carry over lastAccessed times from tabs that haven't been seen/active this session.
* Use the lastSeenActive rather than lastAccessed timestamp for labeling open tabs in firefox view.

Differential Revision: https://phabricator.services.mozilla.com/D198892
 2024-04-04 16:27:32 +00:00
Kelly Cochrane
c64a9447f3 Bug 1880542 - Refactor fxview-tab-list and fxview-tab-row r=sfoster,fxview-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D205499
 2024-03-26 18:01:02 +00:00
Kelly Cochrane
d65e0d0ea0 Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-22 17:02:53 +00:00
Stanca Serban
766c9f922a Backed out changeset 319a405e8b57 (bug 1883876) for causing mochitests failures in browser_blanking.js. 2024-03-22 18:22:25 +02:00
Kelly Cochrane
7cc1085907 Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-22 14:02:18 +00:00
Sandor Molnar
ae3c7d9083 Backed out changeset 153aa2b4247f (bug 1883876) for causing multiple bc failures @ browser/components/firefoxview/<...> & browser/components/aboutwelcome/<...> 2024-03-21 21:46:22 +02:00
Kelly Cochrane
8b550e92b2 Bug 1883876 - Update window list in Open Tabs in Fx View when moving a tab between windows r=fxview-reviewers,sclements,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203971
 2024-03-21 18:44:36 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D203005
 2024-03-19 09:36:35 +00:00
Jonathan Sudiaman
a85f5fcf62 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201759
 2024-03-04 13:02:16 +00:00
Iulian Moraru
26d2d56621 Backed out changeset bfb6942faf35 (bug 1876165) for causing multiple bc failures. CLOSED TREE 2024-03-01 16:20:18 +02:00
Jonathan Sudiaman
f4ce3f9847 Bug 1876165 - Create BookmarkList class that internally stays up-to-date to indicate bookmarked open tabs in Fx View r=mak,fxview-reviewers,places-reviewers,fluent-reviewers,bolsson,sfoster,desktop-theme-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D201759
 2024-03-01 13:34:08 +00:00
Nikki Sharpley
8dceebb0c7 Bug 1879609 - Add pinned indicator for urls pinned in New Tab r=fxview-reviewers,desktop-theme-reviewers,emilio 
- added pin icons to the tab row for tabs pinned in New Tab

Differential Revision: https://phabricator.services.mozilla.com/D201770
 2024-02-29 02:26:27 +00:00
Nikki Sharpley
487579b587 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements 
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Depends on D201652

Differential Revision: https://phabricator.services.mozilla.com/D200689
 2024-02-28 19:37:22 +00:00
Stanca Serban
c67b0bdbfc Backed out 2 changesets (bug 1857298) for causing mochitests failures in browser_parsable_css.js. CLOSED TREE 
Backed out changeset 32ca524f7abf (bug 1857298)
Backed out changeset c4ed2e3e1ff2 (bug 1857298)
 2024-02-28 20:47:18 +02:00
Nikki Sharpley
0fc9567678 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements 
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
 2024-02-28 17:31:17 +00:00
Kelly Cochrane
32b2d59715 Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201652
 2024-02-27 23:33:19 +00:00
Natalia Csoregi
20f1a3f6d6 Backed out 3 changesets (bug 1877678, bug 1849175) for causing failures on browser_opentabs_recency.js CLOSED TREE 
Backed out changeset 67fd66802500 (bug 1849175)
Backed out changeset da9aa1960b63 (bug 1877678)
Backed out changeset 8d9e1646bd6e (bug 1877678)
 2024-02-28 00:22:14 +02:00
Kelly Cochrane
4cd48be87c Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201652
 2024-02-27 20:30:59 +00:00
Cristian Tuns
26a80e06db Backed out changeset f9c17890d242 (bug 1849175) for causing bc failures in browser_opentabs_firefoxview.js CLOSED TREE 2024-02-27 11:56:55 -05:00
Kelly Cochrane
11fb04203e Bug 1849175 - Add pinned tabs to Open Tabs in Firefox View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,flod,sclements,nsharpley,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201652
 2024-02-27 16:27:20 +00:00
Iulian Moraru
3725609047 Backed out changeset 37ef0aa2d2b5 (bug 1857298) for causing bc failures on browser_recentlyclosed_firefoxview.js. 2024-02-20 18:06:25 +02:00
Nikki Sharpley
c6710ccaf5 Bug 1857298 - Add close button to open tabs in view r=fxview-reviewers,fluent-reviewers,desktop-theme-reviewers,bolsson,sclements 
- created tertiary button option for tab rows, styled by a class prop
- added close button to open tabs rows
- removed close tab from open tab context menu
- updated tests to reflect removed panel item in open tab context menu
- added test for the new open tabs close button
- added telemetry for close open tab (requires data review)
- added test suite for keyboard navigation across tab row buttons

Differential Revision: https://phabricator.services.mozilla.com/D200689
 2024-02-20 14:50:25 +00:00
Jules Simplicio
dbf6341376 Bug 1877793 - Standardize headings 1-3 r=kcochrane,desktop-theme-reviewers,settings-reviewers,fxview-reviewers,dao,hjones,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D200203
 2024-02-09 15:15:11 +00:00
Stanca Serban
296d0a814f Backed out changeset 2443d0b3d17d (bug 1873025) for causing mochitests failures in browser_opentabs_recency.js. CLOSED TREE 2024-02-09 05:11:12 +02:00
Sam Foster
ee66131750 Bug 1873025 - Fix the displayed relative time for open tabs listing to match the recency sorting.r=jsudiaman,fxview-reviewers,tabbrowser-reviewers,dao 
* Carry over lastAccessed times from tabs that haven't been seen/active this session.
* Use the lastSeenActive rather than lastAccessed timestamp for labeling open tabs in firefox view.

Differential Revision: https://phabricator.services.mozilla.com/D198892
 2024-02-09 00:10:20 +00:00
Jonathan Sudiaman
fb35250f69 Bug 1855817 - Add the ability to sort tabs by recency in the (view all) Open tabs section of Firefox View r=fluent-reviewers,fxview-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D200464
 2024-02-07 11:16:40 +00:00
Sandor Molnar
d0185266b4 Backed out changeset 25aa38248ad9 (bug 1873025) for causing bc failures at browser/base/content/test/tabs/browser_lastSeenActive.js CLOSED TREE 2024-02-06 00:25:46 +02:00
Sam Foster
d07b593bed Bug 1873025 - Fix the displayed relative time for open tabs listing to match the recency sorting.r=jsudiaman,fxview-reviewers,tabbrowser-reviewers,dao 
* Carry over lastAccessed times from tabs that haven't been seen/active this session.
* Use the lastSeenActive rather than lastAccessed timestamp for labeling open tabs in firefox view.

Differential Revision: https://phabricator.services.mozilla.com/D198892
 2024-02-05 21:21:44 +00:00
Irene Ni
b933099065 Bug 1854593 - Reduced vertical space between window cards in Open tabs to 16 px. r=cmkm,desktop-theme-reviewers,fxview-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D198439
 2024-02-05 16:10:23 +00:00
Sam Foster
ad882469b1 Bug 1866667 - Ensure open tabs have a fallback url value. r=jsudiaman,fxview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D200092
 2024-01-31 21:36:10 +00:00
Kelly Cochrane
b3dfa7a67a Bug 1857005 - Add indicators to open tabs in Fx View r=desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,sfoster,bolsson 
Differential Revision: https://phabricator.services.mozilla.com/D199119
 2024-01-30 19:52:31 +00:00
Sam Foster
e2508dd237 Bug 1855704 - Implement a shared module for getting lists of tabs and notification of changes to those lists. r=Gijs,fxview-reviewers,sclements CLOSED TREE 
* Add the shared module. It uses EveryWindow to listen for tab-related events and collapses them
  into a single dispatched event.
* The class extends EventTarget, and only monitors window and tab events when a listener is added.
* Update the firefox-view consumers and their tests to use the module. Note that triggering a
  tab-state change and seeing the tab change/recency events is async now.
* Add a new browser mochitest for the module and both TabChange and TabRecencyChange events.
* The module provides a potential home for optimizations like smarter caching and sorting of the tab
  lists, but implementing these will belong to other bugs.

Differential Revision: https://phabricator.services.mozilla.com/D191502
 2024-01-27 00:30:22 +00:00
Sandor Molnar
943300c574 Backed out changeset 99babcb9f349 (bug 1855704) for causing mochitest failures at dom/animation/test/chrome/test_animation_observers_async.html CLOSED TREE 2024-01-27 03:18:38 +02:00
Sam Foster
26b81676a6 Bug 1855704 - Implement a shared module for getting lists of tabs and notification of changes to those lists. r=Gijs,fxview-reviewers,sclements 
* Add the shared module. It uses EveryWindow to listen for tab-related events and collapses them
  into a single dispatched event.
* The class extends EventTarget, and only monitors window and tab events when a listener is added.
* Update the firefox-view consumers and their tests to use the module. Note that triggering a
  tab-state change and seeing the tab change/recency events is async now.
* Add a new browser mochitest for the module and both TabChange and TabRecencyChange events.
* The module provides a potential home for optimizations like smarter caching and sorting of the tab
  lists, but implementing these will belong to other bugs.

Differential Revision: https://phabricator.services.mozilla.com/D191502
 2024-01-27 00:30:22 +00:00
Nikki Sharpley
7e42a6aec5 Bug 1869765 - Add telemetry to Firefox View search. r=fxview-reviewers,kcochrane 
- record frequency and page of search
- record how often show all search results is clicked on recent browsing and from which section
- record how often sort by date or site is clicked on history
- record how many searches are made before clicking on a search result

Differential Revision: https://phabricator.services.mozilla.com/D199285
 2024-01-26 19:52:59 +00:00
Nikki Sharpley
17c37d523d Bug 1869836 - Rename files with Firefox View Next to Firefox View. r=fxview-reviewers,sfoster 
- rename files to exclude "next" suffix
- move tests out of firefoxview-next folder into parent folder
- updat AboutRedirector to point at firefoxview.html
- this patch also resolves Bug 1872919 by adding a scroll into view during the `search_synced_tabs_recent_browsing` test

Differential Revision: https://phabricator.services.mozilla.com/D196347
 2024-01-18 14:32:33 +00:00
Cristian Tuns
7368009cd2 Backed out changeset 7ec1dad4bca4 (bug 1869836) for causing bc failures in browser_syncedtabs_firefoxview.js CLOSED TREE 2024-01-16 17:36:03 -05:00