corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
909,731 Commits 1 Branch 0 Tags
63c83deb265ae17a24f36b668c4f4460acdf48ce
Commit Graph

132 Commits

Author SHA1 Message Date
Rob Wu
38b9ddf35c Bug 1963616 - Don't try adding action context menus without permission r=willdurand 
When an extension does not have the contextMenus or menus permission,
it is not possible to have extension-defined context menus on an
extension's action button. The actionContextMenu() call would never
add menu items in this case.

As the bug report shows, trying to call actionContextMenu() can throw
an error when the ext-menus.js module has not been loaded. To avoid
this error, verify that the extension has the permission to add menus.

Because ext-menus.js is declared with `"events": ["startup"]`, the
module is guaranteed to be loaded if an extension has the permissions.

Differential Revision: https://phabricator.services.mozilla.com/D248154
 2025-05-07 23:27:01 +00:00
Mike Conley
b6aa0cf47f Bug 1917913 - Make PanelMultiView.sys.mjs pass the valid-jsdoc ESLint rule and add missing source documentation. r=sfoster 
This also makes some members and methods private that were using the
underscore pseudoprivate technique.

Differential Revision: https://phabricator.services.mozilla.com/D225820
 2025-01-16 21:14:22 +00:00
Luca Greco
38a13671ae Bug 1925291 - Add Extensions Button panel a new per-item messagebar. r=willdurand,fluent-reviewers,desktop-theme-reviewers,dao,flod,devtools-reviewers,ochameau 
Depends on D229902

Differential Revision: https://phabricator.services.mozilla.com/D229904
 2024-12-04 18:42:21 +00:00
Goloman Adrian
90701c4927 Backed out 3 changesets (bug 1925291) for causing dt failures @browser_aboutdebugging_addons_debug_console.js. CLOSED TREE 
Backed out changeset 540773496872 (bug 1925291)
Backed out changeset 46bd418a9e54 (bug 1925291)
Backed out changeset ac2a87182d6a (bug 1925291)
 2024-12-04 14:37:29 +02:00
Luca Greco
762933f39d Bug 1925291 - Add Extensions Button panel a new per-item messagebar. r=willdurand,fluent-reviewers,desktop-theme-reviewers,dao,flod 
Depends on D229902

Differential Revision: https://phabricator.services.mozilla.com/D229904
 2024-12-04 10:43:19 +00:00
Dave Townsend
8ca92a1c30 Bug 1864896: Autofix unused function arguments (webextensions). r=extension-reviewers,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D202999
 2024-03-05 14:21:14 +00:00
Emilio Cobos Álvarez
82807a55ad Bug 1853515 - Simplify webextension toolbar icons. r=desktop-theme-reviewers,dao,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D188407
 2023-10-02 17:53:18 +00:00
Iulian Moraru
47ba569ad5 Backed out changeset 0ad87df402c6 (bug 1853515) for causing bc failures on browser_ext_browserAction_pageAction_icon.js. CLOSED TREE 2023-09-18 15:15:55 +03:00
Emilio Cobos Álvarez
0f4720ac07 Bug 1853515 - Simplify webextension toolbar icons. r=desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D188407
 2023-09-18 09:45:43 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D184623
 2023-08-01 23:01:02 +00:00
Gregory Pappas
96ae23fb76 Bug 1814905 - Implement action.getUserSettings r=robwu,geckoview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D169102
 2023-06-22 15:22:19 +00:00
Katherine Patenio
ce9d8a5dad Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 18:44:48 +00:00
Cristian Tuns
f826f1b621 Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE 
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
 2023-06-19 13:22:35 -04:00
Katherine Patenio
333197cd22 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D179169
 2023-06-19 16:46:18 +00:00
Itiel
213e2bd9a9 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-14 17:16:39 +00:00
Iulian Moraru
ff572127aa Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
548aeccf66 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-06-12 17:16:35 +00:00
William Durand
fbd55117bc Bug 1836448 - Part 1: show attention "dot" when an extension is quarantined from a domain. r=rpl,zombie,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D179780
 2023-06-09 14:58:02 +00:00
Narcis Beleuzu
8f2b59f94b Backed out 2 changesets (bug 1836448) for bc failure on browser_preferences_usage.js 
Backed out changeset 1c53eee1c466 (bug 1836448)
Backed out changeset a86d5a3f177d (bug 1836448)
 2023-06-08 21:22:20 +03:00
William Durand
86def29cf9 Bug 1836448 - Part 1: show attention "dot" when an extension is quarantined from a domain. r=rpl,zombie,fluent-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D179780
 2023-06-08 10:50:31 +00:00
Rob Wu
f0c7c874d6 Bug 1830814 - Migrate remaining extension jsm files to ESM r=geckoview-reviewers,Standard8,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D179890
 2023-06-05 10:23:40 +00:00
Saira Abdulla
d8dc989e1b Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE 
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
 2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato 
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
 2023-05-31 10:21:37 +00:00
Shane Hughes
9ecaef8cdb Bug 1810509 - Add a clickable invisible space around the UEI menu button. r=willdurand,extension-reviewers,desktop-theme-reviewers,dao 
A unified extension item has two buttons: an action button and a menu
button. They are visually separated by 8px. The description string in
the action button depends on which of the buttons is hovered - the
action button, the menu button, or neither. If the mouse moves from the
action button to the menu button, it has to cross the 8px gap where
neither is hovered, causing the description to flash quickly between 3
strings. This patch circumvents that issue by making the 8px gap an
invisible padding of the menu button. This also removes the inert area
where you can move the mouse within the item and see a tooltip with the
name of the extension, but clicking would have no effect since a button
is not hovered.

Differential Revision: https://phabricator.services.mozilla.com/D177979
 2023-05-30 02:14:49 +00:00
Katherine Patenio
99d830d71b Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe 
Differential Revision: https://phabricator.services.mozilla.com/D177423
 2023-05-24 15:52:34 +00:00
Mark Banner
0666077666 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu 
Differential Revision: https://phabricator.services.mozilla.com/D177027
 2023-05-20 12:26:53 +00:00
Iulian Moraru
9a36d620f9 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
801dad3de3 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D176791
 2023-05-18 17:19:45 +00:00
Itiel
332aa98bae Bug 1818622 - More clean up to the unified extensions panel r=willdurand,mconley 
Also, update also the menu button's class depending on its location. Update tests accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D170828
 2023-05-01 19:57:49 +00:00
William Durand
9a9c666058 Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl 
Depends on D169810

Differential Revision: https://phabricator.services.mozilla.com/D162712
 2023-02-16 12:03:07 +00:00
Cristian Tuns
011493bc1c Backed out changeset e391918bb558 (bug 1800417) for causing mochitest failures in /browser_unified_extensions_overflowable_toolbar.js CLOSED TREE 2023-02-14 17:21:09 -05:00
William Durand
5993be7f69 Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl 
Depends on D169810

Differential Revision: https://phabricator.services.mozilla.com/D162712
 2023-02-14 20:51:53 +00:00
Marian-Vasile Laza
f298aadd15 Backed out changeset d26e7747cf69 (bug 1800417) for bc failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 2023-02-13 22:14:44 +02:00
William Durand
e23737e755 Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D162712
 2023-02-13 16:52:18 +00:00
Sandor Molnar
d82f8e0057 Backed out changeset 549ce0549c2e (bug 1800417) for causing bc failures in browser/components/extensions/test/browser/browser_unified_extensions_overflowable_toolbar.js CLOSED TREE 2023-02-08 14:23:39 +02:00
William Durand
6f77c2b373 Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl 
Depends on D169088

Differential Revision: https://phabricator.services.mozilla.com/D162712
 2023-02-08 10:25:02 +00:00
Sandor Molnar
a0241439d5 Backed out changeset 6dbcf3dd30c4 (bug 1800417) for causing bc failures in browser/components/extensions/test/browser/browser_unified_extensions_overflowable_toolbar.js CLOSED TREE 2023-02-08 13:54:33 +02:00
William Durand
4cf5bc48b2 Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl 
Depends on D169088

Differential Revision: https://phabricator.services.mozilla.com/D162712
 2023-02-08 10:25:02 +00:00
Butkovits Atila
af64ca6493 Backed out changeset ab00cf793f29 (bug 1800417) for causing failures at browser_unified_extensions_overflowable_toolbar.js. 2023-01-30 17:34:14 +02:00
William Durand
fd0ded3d7b Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl 
Differential Revision: https://phabricator.services.mozilla.com/D162712
 2023-01-30 13:36:07 +00:00
William Durand
d42c7aaa29 Bug 1811128 - Use 16/32px extension icons in toolbars. r=rpl,dao 
Differential Revision: https://phabricator.services.mozilla.com/D167573
 2023-01-30 10:46:12 +00:00
Tomislav Jovanovic
d378ab25a4 Bug 1805523 - Implement temporary access state and attention, r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D165490
 2023-01-24 00:47:13 +00:00
William Durand
8b62e8dde9 Bug 1801540 - Clean-up unified extensions CSS after it ships by default. r=Itiel,desktop-theme-reviewers 
Depends on D166934

Differential Revision: https://phabricator.services.mozilla.com/D167378
 2023-01-23 21:31:18 +00:00
William Durand
7761eccedb Bug 1799009 - Remove unified extensions pref and non-unified extensions variants from test suite. r=rpl,mconley,fluent-reviewers,desktop-theme-reviewers,Itiel 
This patch removes the use of the "unified extensions" pref and adjust
the existing tests. More clean-ups will be done in follow-ups, e.g. the
removal of `gUnifiedExtensions.isEnabled` and some test-only changes to
no longer create a new window in each test file.

Differential Revision: https://phabricator.services.mozilla.com/D166908
 2023-01-19 10:59:25 +00:00
Marian-Vasile Laza
3f9e8980c7 Backed out changeset 1c135e14142e (bug 1805523) for causing bc failures on browser_ext_windows_create_tabId.js. 2023-01-02 16:34:38 +02:00
Tomislav Jovanovic
6716f18a49 Bug 1805523 - Implement temporary access state and attention, r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D165490
 2023-01-01 21:46:00 +00:00
William Durand
0640c4da83 Bug 1803650 - Remove setAttribute() since the label is updated with Fluent. r=zombie 
Differential Revision: https://phabricator.services.mozilla.com/D163629
 2022-12-02 20:31:49 +00:00
William Durand
80f9f71d60 Bug 1799694 - Avoid flickering when messages have different lengths. r=rpl,mconley,desktop-theme-reviewers,Itiel 
This is a completely redesign based on mconley's idea to use `deck`.
That removes a lot of code and makes things a lot better.

Depends on D163077

Differential Revision: https://phabricator.services.mozilla.com/D162390
 2022-11-27 17:07:44 +00:00
William Durand
ef7a4e1a24 Bug 1799694 - Rename action/menu button class names in unified extensions. r=Itiel,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D163077
 2022-11-27 17:07:44 +00:00