corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
909,731 Commits 1 Branch 0 Tags
63c83deb265ae17a24f36b668c4f4460acdf48ce
Commit Graph

251 Commits

Author SHA1 Message Date
Meg Viar
48389d49cb Bug 1967342 - Add preview update string for existing user TOU infobar r=fluent-reviewers,omc-reviewers,bolsson,pdahiya 
Add preview string for use in TOU infobar

Differential Revision: https://phabricator.services.mozilla.com/D250273
 2025-05-20 20:21:27 +00:00
Emily McMinn
c75f64e314 Bug 1963213 - Allow messaging on only one profile in a multiprofile selectable group r=pdahiya,jhirsch,omc-reviewers,profiles-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D247459
 2025-05-20 18:49:49 +00:00
Shane Hughes
a1fcf2855e Bug 1892417 - Make feature callout autofocus configurable and disabled by default. r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D247391
 2025-05-19 18:41:25 +00:00
Meg Viar
ac61100a31 Bug 1964816 - Support Localization in Universal Infobars r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D248136
 2025-05-13 14:15:51 +00:00
Beth Rennie
25f1aa8bdb Bug 1963183 - Add buildId to ASRouterTargeting and Nimbus targeting context r=omc-reviewers,nimbus-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D246994
 2025-05-06 22:08:17 +00:00
Meg Viar
d42d78e05a Bug 1964116 - Update infobar schema to reflect that 'text' can be an array r=jprickett,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D247646
 2025-05-05 09:43:25 +00:00
Emily McMinn
b41709a7cc Bug 1961862 - Land animated onboarding callouts for tab groups in tree r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D246480
 2025-05-02 14:39:40 +00:00
Meg Viar
0114e29cfd Bug 1963951 - Change ToS spotlight modal's button string from 'Confirm and continue' to just 'Continue' r=fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D247570
 2025-05-02 12:56:55 +00:00
Meg Viar
9d474d2001 Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux) r=hanna_a,omc-reviewers 
- Show ToS modal by default for all new users on official builds
  - Remove code related to the on-train rollout for Mac/Linus/MSIX

Differential Revision: https://phabricator.services.mozilla.com/D247111
 2025-05-01 03:50:23 +00:00
Reem H
29b06e65ba Bug 1949001 - Add OMC for inferred p13n card. r=home-newtab-reviewers,omc-reviewers,nbarrett,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D246376
 2025-04-30 04:31:20 +00:00
smolnar
a2d552f453 Backed out changeset af872f8e8213 (bug 1949001) for causing xpc failures @ test_PanelTestProvider.js CLOSED TREE 2025-04-30 04:54:45 +03:00
Reem H
9421ec89d3 Bug 1949001 - Add OMC for inferred p13n card. r=home-newtab-reviewers,omc-reviewers,nbarrett,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D246376
 2025-04-30 00:48:33 +00:00
smolnar
bd51edbf53 Backed out changeset c62c5b5629ff (bug 1959542) for causing bc failures @ browser_browserGlue_showModal_trigger.js CLOSED TREE 2025-04-30 03:03:43 +03:00
Meg Viar
7888974e9f Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux) r=hanna_a,omc-reviewers 
- Show ToS modal by default for all new users on official builds
  - Remove code related to the on-train rollout for Mac/Linus/MSIX

Differential Revision: https://phabricator.services.mozilla.com/D247111
 2025-04-29 18:57:33 +00:00
negin
af4c9168f2 Bug 1935255 - FC Updates split dismiss button HCM styling and buttons using tokens-shared variables r=omc-reviewers,accessibility-frontend-reviewers,emcminn,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D245474
 2025-04-29 17:51:38 +00:00
Beth Rennie
85992a9d15 Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D246149
 2025-04-29 13:07:23 +00:00
Butkovits Atila
d5769ff5cb Backed out changeset 5591b71c7d59 (bug 1961629) for causing failures at browser_asrouter_toast_notification.js. 2025-04-29 15:45:16 +03:00
Beth Rennie
c8b5015aca Bug 1961629 - Use ExperimentFeature.getEnrollmentMetadata() in browser/components/asrouter r=omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D246149
 2025-04-29 11:28:57 +00:00
Cristina Horotan
01a3787bf5 Backed out changeset b19f01c4a432 (bug 1959542) for causing bc failures at browser_browserGlue_showModal_trigger.js CLOSED TREE 2025-04-24 17:36:56 +03:00
Meg Viar
37e9896cea Bug 1959542 - Enable ToS by default in Firefox 138.x mid-cycle dot release (Windows, Mac, Linux) r=omc-reviewers,hanna_a 
-     Show ToS modal by default for all new users on official builds
  -     Remove code related to the on-train rollout for Mac/Linus/MSIX

Differential Revision: https://phabricator.services.mozilla.com/D245100
 2025-04-24 11:04:43 +00:00
Meg Viar
81929eb72f Bug 1960078 - Add universal type to InfoBar to show notification across all current and new windows r=omc-reviewers,mimi 
Differential Revision: https://phabricator.services.mozilla.com/D245309
 2025-04-23 20:58:27 +00:00
negin
05fbc8e569 Bug 1930250 - Adds AppMenu configuration and styling for 'row' layout r=omc-reviewers,mconley,emcminn 
Adds configuration for row layout design that we'd like to eventually rollout. See [figma](https://www.figma.com/design/qe9yX8x51jjbt6DJYgayg2/Device-Migration--Account-and-Multi-Device-Adoption-?node-id=8208-4895&m=dev)

{F19072665}

{F19072664}

{F19072663}

Differential Revision: https://phabricator.services.mozilla.com/D246145
 2025-04-23 19:50:32 +00:00
Niklas Baumgardner
7276800327 Bug 1953884 - Eagerly create the profiles shared database. r=profiles-reviewers,mossop,jhirsch,firefox-desktop-core-reviewers ,omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D244621
 2025-04-23 15:20:14 +00:00
Meg Viar
3651f417fc Bug 1961230 - Allow for plain text after infobar links with optional spacing before and after r=omc-reviewers,jprickett 
We want to be able to create the appears of links being embedded in the content text of an infobar.

Differential Revision: https://phabricator.services.mozilla.com/D245969
 2025-04-22 14:05:36 +00:00
pstanciu
c17bdcd640 Backed out changeset 118838e56e20 (bug 1961230) for causing failures on browser_asrouter_infobar.js CLOSED TREE 2025-04-22 16:43:03 +03:00
Meg Viar
685be9e86c Bug 1961230 - Allow for plain text after infobar links with optional spacing before and after r=omc-reviewers,jprickett 
We want to be able to create the appears of links being embedded in the content text of an infobar.

Differential Revision: https://phabricator.services.mozilla.com/D245969
 2025-04-22 12:34:24 +00:00
Maxx Crawford
1624c4bd3a Bug 1959189 - Create Download Firefox for Mobile promo modal r=home-newtab-reviewers,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D245483
 2025-04-16 20:15:30 +00:00
Emily McMinn
4d51735a98 Bug 1958271 - Update string IDs for shopping callout dropdown r=omc-reviewers,fluent-reviewers,bolsson,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D244998
 2025-04-16 16:23:24 +00:00
Jason Prickett
8b6faaef37 Bug 1953834 - Add profile group id to asrouter targeting r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D244229
 2025-04-14 18:01:54 +00:00
Emily McMinn
20e1dc6911 Bug 1958294 - Add aria-label && aria-labelledby options to submenu buttons r=omc-reviewers,fluent-reviewers,bolsson,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D244992
 2025-04-11 16:52:22 +00:00
Meg Viar
0c85630592 Bug 1958972 - Add dismissable property configurable for infobars r=reusable-components-reviewers,omc-reviewers,emcminn,hanna_a,hjones 
Differential Revision: https://phabricator.services.mozilla.com/D244668
 2025-04-09 14:22:08 +00:00
Shane Hughes
68848bd409 Bug 1931454 - Allow feature callouts to have multiple screens without requiring a tour pref. r=omc-reviewers,mviar 
This adds a new `advance_screens` pseudo-action to the `feature_callout`
messaging system template, which can be added to any action in the same
way `navigate` is used currently. This should generally be used instead
of `navigate`, which only advances the inner content but not the outer
wrapper, the anchor, the page event listeners, and other state relevant
for panel callouts.

Some callouts want to show even if the `cfr.features` pref is disabled,
such as surveys and important onboarding messages, and hard-coding that
check in FeatureCallout is heavy-handed as we already have better ways
to do it. Most callouts belong to the `cfr` group, which locks them
behind the features pref. Any that can't use groups, like the PDF
annotations callouts, can check the pref directly in their targeting.

Aside from blocking messages that don't want to be blocked by that pref,
it also results in a weird behavior where, if the pref changes while the
callout is still open (pretty unlikely), the callout will hide when you
click "next" instead of advancing to the next screen. If you clicked the
Next button, it should show you the next screen, even if you somehow
blocked the message by pref before clicking.

So it's cleaner to just let ASRouter handle that in the targeting phase.
If the pref changes while a message is showing, then we'll just leave it
open, and it won't apply until targeting is checked.

It's appropriate to make the change here, because this patch adds a new
screen advancement scheme, separate from the tour pref system. Since
we're reproducing the advancement logic, we're forced to decide whether
to reproduce the feature pref check in this new scheme. I realized 99%
of the time it's doing nothing, and in the rare cases where it does have
an effect that differs from the regular pref targeting, it's a negative
effect. And at that point, we might as well rip the bandaid off all at
once, to keep everything consistent.

Additionally, while adding documentation for this new feature, I also
corrected some existing errors in the documentation.

Differential Revision: https://phabricator.services.mozilla.com/D229084
 2025-04-04 08:27:57 +00:00
Shane Hughes
fe799a22d0 Bug 1931562 - Remove RC churn microsurvey. r=emcminn,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D244064
 2025-04-01 21:24:03 +00:00
Emily McMinn
31c83f3c1e Bug 1950468 - Add "tabGroupCollapsed" trigger to messaging system and update schema entries r=omc-reviewers,aminomancer,tabbrowser-reviewers,sthompson 
Differential Revision: https://phabricator.services.mozilla.com/D241304
 2025-04-01 15:44:11 +00:00
Rebecca King
8a1bcf5764 Bug 1955055 - Review Checker Callout 4B not triggered if the sidebar is closed with X button - r=shopping-reviewers,omc-reviewers,sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D242963
 2025-03-28 01:20:11 +00:00
Rebecca King
63cdb2330f Bug 1917983 - Move migration-specific strings to locales version of shopping.ftl and finalize any illustrations - r=shopping-reviewers,fluent-reviewers,omc-reviewers,kpatenio,bolsson,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D242814
 2025-03-27 01:27:56 +00:00
Rebecca King
ec6800e10e Bug 1953742 - Adjust Review Checker callouts to show anchor attachment with vertical tabs, all sidebar tools added, and maximized screen - r=shopping-reviewers,omc-reviewers,emcminn,kpatenio 
Differential Revision: https://phabricator.services.mozilla.com/D242610
 2025-03-26 15:45:29 +00:00
Florian Quèze
2ea57560fd Bug 1950710 - Migrate histograms to use Glean APIs for MS_MESSAGE_REQUEST_TIME_MS, r=chutten,omc-reviewers,mviar. 
Differential Revision: https://phabricator.services.mozilla.com/D242518
 2025-03-26 14:41:10 +00:00
Jason Prickett
9e27050c4b Bug 1955715 - update addonsInfo asrouter targeting to include if user has installed addons r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D242819
 2025-03-25 18:21:07 +00:00
Nathan Barrett
3df69e20a2 Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer,maxx 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-25 14:34:05 +00:00
Rebecca King
f47fc87b92 Bug 1953838 - Correct string ids for dropdown options in Review Checker callout 3 - r=omc-reviewers,shopping-reviewers,aminomancer,fchasen 
Differential Revision: https://phabricator.services.mozilla.com/D242822
 2025-03-24 21:35:44 +00:00
Stanca Serban
92c3bbb32a Backed out 4 changesets (bug 1954848, bug 1951426, bug 1951782, bug 1953632) for causing xpcshell failures in test_NewTabMessaging.js. CLOSED TREE 
Backed out changeset b2ee50813323 (bug 1954848)
Backed out changeset 211563f87799 (bug 1953632)
Backed out changeset 5003a2a06685 (bug 1951782)
Backed out changeset 4a882623c86d (bug 1951426)
 2025-03-24 20:46:17 +02:00
Nathan Barrett
84c498dc3b Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer,maxx 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-24 17:42:04 +00:00
Emily McMinn
3b5c94bb3f Bug 1949271 - Add tab groups callouts for SessionRestore && add userPrefs.cfrFeatures to all tab groups callouts r=omc-reviewers,aminomancer,beth 
Differential Revision: https://phabricator.services.mozilla.com/D239808
 2025-03-21 16:10:57 +00:00
Goloman Adrian
ac2cd44a24 Backed out 4 changesets (bug 1953632, bug 1951782, bug 1951426, bug 1954848) for causing build bustages. CLOSED TREE 
Backed out changeset 6825e2911771 (bug 1954848)
Backed out changeset 56f68e9e9ab5 (bug 1953632)
Backed out changeset bda4413155d7 (bug 1951782)
Backed out changeset 04623acb0ff2 (bug 1951426)
 2025-03-21 20:38:15 +02:00
Nathan Barrett
3957775da8 Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-21 15:26:34 +00:00
Stanca Serban
4380403c09 Backed out 4 changesets (bug 1951426, bug 1954848, bug 1953632, bug 1951782) for causing Node tests failures. CLOSED TREE 
Backed out changeset 2a8c811ce373 (bug 1954848)
Backed out changeset 04b8c4b9620a (bug 1953632)
Backed out changeset b51759b5f846 (bug 1951782)
Backed out changeset fc971f683077 (bug 1951426)
 2025-03-20 23:36:40 +02:00
Nathan Barrett
9e01a2ba3e Bug 1951426 - Request messages from OMC in newtab r=home-newtab-reviewers,omc-reviewers,mconley,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D240175
 2025-03-20 14:12:21 +00:00
Rebecca King
7a5cd481d5 Bug 1947884 - Add background property to dismiss button on Review Checker callouts - r=shopping-reviewers,omc-reviewers,kpatenio,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D240229
 2025-03-17 19:22:39 +00:00
Shane Hughes
e7f24e223a Bug 1948423 - Skip targeting and trigger listener creation for messages with skip_in_tests. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D238374
 2025-03-07 04:36:57 +00:00