Commit Graph

334 Commits

Author SHA1 Message Date
Aron Cseh
08943f7f60 Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE 2024-04-23 18:16:55 +03:00
Hanna Jones
cf0399a238 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 13:52:27 +00:00
Yi Xiong Wong
03a2372d77 Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount
Differential Revision: https://phabricator.services.mozilla.com/D207110
2024-04-15 10:22:46 +00:00
Gijs Kruitbosch
e6dd680afd Bug 1887717 - remove prompts.windowPromptSubDialog pref, r=mtigley,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206685
2024-04-09 18:28:44 +00:00
Dão Gottwald
324741e710 Bug 1360028 - Use getBoundsWithoutFlushing instead of getBoundingClientRect on addon-progress-notification to set the min-height of the addon-install-confirmation notifaction. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D205455
2024-03-28 14:21:58 +00:00
Dave Townsend
ab57b0fdc1 Bug 1864896: Autofix unused function arguments (browser/base/content). r=Gijs,application-update-reviewers,tabbrowser-reviewers,places-reviewers,bytesized,dao
Differential Revision: https://phabricator.services.mozilla.com/D202949
2024-03-19 14:59:20 +00:00
Gregory Pappas
ec549b100a Bug 1877883 - More consistently refer to 'your organization' in enterprise policy notices instead of 'your administrator' or 'system administrator' r=mkaply,fluent-reviewers,settings-reviewers,fxview-reviewers,bolsson,sclements,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200328
2024-02-06 08:27:10 +00:00
Sandor Molnar
1e9196f7fa Backed out changeset 1ce5079e7de7 (bug 1877883) for causing bc failures at toolkit/mozapps/extensions/test/browser/browser_webapi_install.js CLOSED TREE 2024-02-05 21:39:56 +02:00
Gregory Pappas
5d5148317a Bug 1877883 - More consistently refer to 'your organization' in enterprise policy notices instead of 'your administrator' or 'system administrator' r=mkaply,fluent-reviewers,settings-reviewers,fxview-reviewers,bolsson,sclements
Differential Revision: https://phabricator.services.mozilla.com/D200328
2024-02-05 18:41:41 +00:00
Luca Greco
5f924c7ac5 Bug 1866565 - Do not open an about:addons tab when opening an abuse report form in a tab from a toolbar button context menu. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D194648
2023-11-27 22:03:16 +00:00
Tomislav Jovanovic
3e72673c66 Bug 1820153 - Port addonsManager.* telemetry events to Glean, r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D192907
2023-11-10 16:53:06 +00:00
Gijs Kruitbosch
e48e7b5dbd Bug 1860046 - remove/simplify code iterating docshell tree items, r=extension-reviewers,rpl
AFAICT the browser-addons.js code is unused.

The AM code is untested, at best, but probably unused after the demise of the disco pane.
Either way, using browsingContexts to determine the toplevel browser seems better and is
easier to read.

Differential Revision: https://phabricator.services.mozilla.com/D191425
2023-10-23 12:07:34 +00:00
ganna
9246abd406 Bug 1844850 - Use moz-message-bar in the unified extensions panel. r=tgiles,hjones,fluent-reviewers,extension-reviewers,willdurand,bolsson,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D186718
2023-10-03 15:35:42 +00:00
William Durand
4d0a5dc988 Bug 1845749 - Introduce a specific install.error for incompatible add-ons. r=rpl,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184801
2023-08-04 08:11:14 +00:00
Gregory Pappas
a57c4f9405 Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
William Durand
a70d941683 Bug 1845745 - Introduce a specific install.error for blocklisted add-ons. r=rpl,geckoview-reviewers,robwu,zmckenney
Differential Revision: https://phabricator.services.mozilla.com/D184741
2023-08-01 10:40:37 +00:00
Luca Greco
e06f04f583 Bug 1837670 - Update extension button's quarantined domains warning messagebar to mention user controls for exempting specific extensions. r=willdurand,flod,fluent-reviewers
Depends on D181079

Differential Revision: https://phabricator.services.mozilla.com/D182483
2023-06-30 10:19:50 +00:00
William Durand
a7a1d41243 Bug 1838465 - Show an appmenu notification when the user has imported add-ons to install. r=rpl,flod
Depends on D181398

Differential Revision: https://phabricator.services.mozilla.com/D181465
2023-06-22 15:34:14 +00:00
William Durand
7d98f15a74 Bug 1836448 - Part 2: show attention "dot" on the extensions button for quarantined domains. r=zombie,fluent-reviewers,flod
Depends on D179780

Differential Revision: https://phabricator.services.mozilla.com/D180091
2023-06-09 14:58:03 +00:00
William Durand
fbd55117bc Bug 1836448 - Part 1: show attention "dot" when an extension is quarantined from a domain. r=rpl,zombie,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D179780
2023-06-09 14:58:02 +00:00
William Durand
2799d3e5ca Bug 1836771 - Add aria attributes to the message-bar notification used in the extensions panel. r=ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D179957
2023-06-08 20:39:51 +00:00
Narcis Beleuzu
8f2b59f94b Backed out 2 changesets (bug 1836448) for bc failure on browser_preferences_usage.js
Backed out changeset 1c53eee1c466 (bug 1836448)
Backed out changeset a86d5a3f177d (bug 1836448)
2023-06-08 21:22:20 +03:00
William Durand
8308622bca Bug 1836448 - Part 2: show attention "dot" on the extensions button for quarantined domains. r=zombie,fluent-reviewers,flod
Depends on D179780

Differential Revision: https://phabricator.services.mozilla.com/D180091
2023-06-08 15:37:19 +00:00
William Durand
86def29cf9 Bug 1836448 - Part 1: show attention "dot" when an extension is quarantined from a domain. r=rpl,zombie,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D179780
2023-06-08 10:50:31 +00:00
William Durand
fd07ed0190 Bug 1836224 - A click on the "learn more" link in the panel should close it. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D179649
2023-06-01 11:27:43 +00:00
William Durand
846ce75f99 Bug 1833438 - Implement user notification for quarantined domains. r=zombie,rpl,fluent-reviewers,flod
Depends on D179388

Differential Revision: https://phabricator.services.mozilla.com/D179386
2023-05-31 20:42:37 +00:00
Saira Abdulla
d8dc989e1b Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236 Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
William Durand
ffdc71c1cd Bug 1833438 - Add support for notifications in the extensions panel. r=Itiel,rpl,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D179345
2023-05-30 20:07:39 +00:00
Eemeli Aro
05300da5a3 Bug 1793557 - Migrate add-on notification strings to Fluent. r=extension-reviewers,flod,robwu
The l10n migration shows a diff for `addon-downloading-and-verifying`,
`addon-confirm-install-message`, and `addon-confirm-install-unsigned-message`
due to the en-US source having `1` rather than `one` variants.
For `addon-confirm-install-some-unsigned-message`,
the en-US source has a single-variant plural selector for localization to new languages.

In addition to moving strings from `browser.properties` to the new `addonNotifications.ftl`,
there's some shuffling of strings to & from `browser.ftl` as well.
The intent is to collect the more rarely used strings out of files loaded during startup,
especially as many of the notification strings need to be formatted in a sync context.

For the most part, string keys are left roughly the same as they were in .properties.
With some guidance, some rationalisation might make sense as a part of this for the
rather wide selection of prefixes in this set:
- `addon-`
- `site-permission-install-`
- `webext-`
- `xpinstall-`

The `addon-install-started` and `addon-install-failed` notifications appear to need sync l10n formatting,
as using async format calls before their `PopupNotifications.show()` leads to test failures in
`toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js`.

Differential Revision: https://phabricator.services.mozilla.com/D178235
2023-05-23 12:00:01 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
William Durand
df4f375b85 Bug 1805924 - Allow to re-order the list of extensions in the unified extensions panel. r=rpl,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D175348
2023-05-04 06:11:44 +00:00
Itiel
332aa98bae Bug 1818622 - More clean up to the unified extensions panel r=willdurand,mconley
Also, update also the menu button's class depending on its location. Update tests accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D170828
2023-05-01 19:57:49 +00:00
William Durand
2ecb3826ff Bug 1828966 - Ensure Pin to Toolbar context menu item shows the correct state when opening the context menu. r=mconley
I could only reproduce on macOS but it is indeed a valid bug. I noticed
that moving the `await` code at the bottom of the function fixed it but
that didn't sound too great.

I decided to propose this patch instead, and I made sure that we
wouldn't hit a similar problem with the "disabled" state of the remove
button. Apparently, that still works as expected (on macOS).

I am not quite sure how to cover that with a test, though, because we
have test coverage for the attributes and the HTML markup is correctly
updated. For example, I could see the correct `checked` attribute in the
HTML (in the devtools) with the wrong context menu item state rendered,
sigh. This likely means the race is at a lower level (cocoa?).

Differential Revision: https://phabricator.services.mozilla.com/D176416
2023-04-25 15:48:14 +00:00
William Durand
ee885114f8 Bug 1801266 - Handle the case where an extension widget is not visible and not in the extensions panel. r=mconley,rpl
Differential Revision: https://phabricator.services.mozilla.com/D168532
2023-04-19 07:42:16 +00:00
Bobby Holley
c934412517 Bug 1808431 — Reword first WebMIDI prompt. r=rpl,flod
Differential Revision: https://phabricator.services.mozilla.com/D174813
2023-04-06 17:07:14 +00:00
Tim Giles
fb12c56560 Bug 1813077 - Make addon-install-blocked learn more link use Fluent. r=mstriemer,fluent-reviewers,extension-reviewers,Gijs,flod
The previous way of setting textContent via string from the
browser.properties file does not work with the moz-support-link widget
since it has a Fluent ID by default. Instead we migrate the existing
string from the browser.properties file to the browser.ftl file.

Differential Revision: https://phabricator.services.mozilla.com/D170255
2023-03-23 14:07:42 +00:00
Tim Giles
3bc1de1d4d Bug 1813077 - Add import of moz-support-link for use in popup-notification via ensureCustomElements. r=mstriemer,extension-reviewers
Since we can't synchronously load ESModules yet, we use a new
abstraction of ensureCustomElements to ensure we have access to the
moz-support-link widget in popup-notifications.inc. The previous pattern
of loading the widget via module script does not work in this case due
to browser.xhtml, as we do not want to block on this path.

Differential Revision: https://phabricator.services.mozilla.com/D170254
2023-03-23 14:07:41 +00:00
William Durand
a4e3ec09cc Bug 1820743 - Allow to move unified extensions button on the navbar. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D171845
2023-03-21 16:55:11 +00:00
Cristina Horotan
3afab63217 Backed out changeset 56de7c6ac457 (bug 1820743) for causing bc failures at browser_toolbarKeyNav.js CLOSED TREE 2023-03-21 16:16:47 +02:00
William Durand
7b68de7353 Bug 1820743 - Allow to move unified extensions button on the navbar. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D171845
2023-03-21 13:10:08 +00:00
William Durand
53fa5ffd91 Bug 1820124 - Remove addonManager.action/link/view Telemetry events. r=rpl,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D171541
2023-03-20 20:11:15 +00:00
William Durand
3efdf5595f Bug 1821288 - Remove "addon-install-complete" event. r=rpl
This is not used anymore.

Differential Revision: https://phabricator.services.mozilla.com/D172102
2023-03-15 17:37:42 +00:00
William Durand
9a9c666058 Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
Depends on D169810

Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-02-16 12:03:07 +00:00
Cristian Tuns
011493bc1c Backed out changeset e391918bb558 (bug 1800417) for causing mochitest failures in /browser_unified_extensions_overflowable_toolbar.js CLOSED TREE 2023-02-14 17:21:09 -05:00
William Durand
5993be7f69 Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
Depends on D169810

Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-02-14 20:51:53 +00:00
Malte Jürgens
51c2bf31f4 Bug 1808459 - Take extensions.getAddons.showPane into consideration when clicking on empty unified extensions button r=extension-reviewers,robwu
In case the user does not have any active extensions listed, if `extensions.getAddons.showPane` is set to true (default), clicking on the unified extensions button will lead to the recommendations section in about:addons. If it is set to false, clicking the button will now lead to the extension list instead of the, disabled by the user, recommendations section.

Differential Revision: https://phabricator.services.mozilla.com/D169570
2023-02-14 13:07:22 +00:00
Marian-Vasile Laza
f298aadd15 Backed out changeset d26e7747cf69 (bug 1800417) for bc failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE 2023-02-13 22:14:44 +02:00
William Durand
e23737e755 Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-02-13 16:52:18 +00:00