Commit Graph

17 Commits

Author SHA1 Message Date
Xidorn Quan
ca2c06410b Bug 1135361 - Fix position of ruby annotation in vertical-rl mode when justification is applied to the base. r=jfkthame 2015-02-24 14:46:29 +11:00
Xidorn Quan
7db92724c8 Bug 1132008 part 1 - Calculate bsize of rtc according to its children. r=dbaron 2015-02-17 14:25:18 +13:00
Xidorn Quan
18a293b76d Bug 1115262 - Fix position of ruby annotation when writing mode is vertical-rl. r=jfkthame 2015-01-13 20:04:41 +11:00
Xidorn Quan
0549a155fe Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron 2015-01-13 20:04:41 +11:00
Nigel Babu
2492f633d1 Backed out 4 changesets (bug 1055658) for M5 bustage on a CLOSED TREE
Backed out changeset 3cbd9323c896 (bug 1055658)
Backed out changeset 99e071295c42 (bug 1055658)
Backed out changeset 55119d19e4c5 (bug 1055658)
Backed out changeset e82f640cb53f (bug 1055658)
2015-01-12 10:43:11 +05:30
Xidorn Quan
cdb8162daf Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron 2015-01-12 14:31:55 +11:00
Xidorn Quan
2dffaa6260 Bug 1116037 part 12 - Move mLineSize to RubyReflowState. r=dbaron 2014-12-30 11:20:10 +11:00
Xidorn Quan
6e53ba9ae1 Bug 1116037 part 11 - Add RubyReflowState for sharing states between ruby level boxes. r=dbaron 2014-12-30 11:16:30 +11:00
Xidorn Quan
d1ef25d527 Bug 1116037 part 2 - Use frame state bit to mark rtc of span. r=dbaron 2014-12-29 13:34:07 +11:00
Xidorn Quan
10dbd31052 Bug 1055665 part 3 - Position ruby annotations and set the line size of them correctly. r=dholbert 2014-12-09 17:47:26 +11:00
Xidorn Quan
71052dfdb0 Bug 1052924 - Implement basic line breaking for ruby. r=dbaron
Known problem:
It would cause infinite loop if there is any line break happens inside
ruby base or annotation, or the width of container is not enough for
the widest pair/span. This might be fixed in bug 1098272.
2014-11-26 15:52:50 +11:00
Xidorn Quan
4cfdc5a174 Bug 1052924 - Resolve some warnings. r=dbaron
Important changes:
  * Change base class of nsRuby{Base,Text}Frame to nsInlineFrame
  * Make ComputeSize of nsRubyFrame and nsRubyBaseContainerFrame behavior like inline frames
2014-11-26 15:52:49 +11:00
Xidorn Quan
d0c08c2081 Bug 1052924 - Rewrite reflow code. r=dbaron
Important changes:
  * Avoid using GetPrefISize on the ruby texts in
    nsRubyBaseContainerFrame::Reflow, since the size it produces might
    not match the size produced by Reflow.  The old code calls that on
    all the ruby texts to determine how big they are, then reflows all
    the ruby bases, and then reflows all the ruby texts.  The new code
    instead processes one pair at a time, and for each pair reflows the
    ruby texts and then the ruby base.
  * Change the base class of nsRubyTextContainerFrame from nsBlockFrame
    to nsContainerFrame, and stop constructing an nsBlockReflowState for
    its reflow.
  * Move the code for reflowing ruby texts from nsRubyTextContainerFrame
    and to nsRubyBaseContainerFrame.
  * Fix the regression that ruby text containers contain span are not
    reflowed properly. It is the regression introduced in patch 0.

Known regression:
  * This patch drops centering ruby base and annotation in pairs. This
    should be fixed in bug 1055676 (ruby-align).
2014-11-26 15:52:49 +11:00
Carsten "Tomcat" Book
cf285d5764 Backed out changeset 357b7bb14462 (bug 1083004) for frequent b2g m-9 test failures 2014-11-12 11:26:12 +01:00
Xidorn Quan
3696b71328 Bug 1083004 - Fix crashes for tests. r=dbaron 2014-11-12 17:31:31 +11:00
Susanna Bowen
3c4a808a0e Bug 1030993 - Basic reflow implementation for ruby frame classes. r=dbaron
To account for spacing between bases or text boxes during reflow, the line
layout which manages the bases updates its inline direction coordinate based on
the preferred inline size for the corresponding text boxes. Next, the base is
reflowed at the correct inline coordinate. Each paired text box is then also
reflowed at the proper inline position determined by (1) the current position of
its corresponding base and (2) its own preferred width.

In computing intrinsic widths, accounting for spacing is less complicated. The
minimum intrinsic width is the width of the widest ruby column, and the
preferred intrinsic width is the sum of all the ruby column widths. Each ruby
column width is the maximum width of its base box and text boxes. These
individual widths are determined using GetPrefISize on the base and text boxes.

Ruby base container frames store a list of pointers to the ruby text container
frames in the segment they denote. This list of pointers is created in the ruby
frame reflow method before calling the reflow method for the ruby base
container. The list exists and is used only during reflow of the main ruby frame
and is cleared before returning from reflow.
2014-08-15 10:34:20 -07:00
Susanna Bowen
2f81b02ca1 Bug 1021952 - Add ruby display values and ruby frames. r=dholbert,bz 2014-07-22 19:08:01 -07:00