Commit Graph

1555 Commits

Author SHA1 Message Date
Sebastian Hengst
3443590645 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 4cZJ3qFjvPY
2017-08-12 23:49:21 +02:00
Gijs Kruitbosch
e49aca3ee2 Bug 1389285 - check that clicking history items actually works, r=mikedeboer
MozReview-Commit-ID: 2WKqYaO8Iht
2017-08-11 14:05:48 +01:00
Gijs Kruitbosch
c4743c2245 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz
2017-08-10 23:04:54 +01:00
Gijs Kruitbosch
eea295f174 Bug 1388990 - avoid breaking the broadcast/listener relationships of the back/fwd buttons when customizing, r=dao
MozReview-Commit-ID: EsH3lv8QXfJ
2017-08-12 11:56:22 +01:00
Andrew Halberstadt
1ecb0adc26 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw
2017-08-10 14:48:21 -04:00
Phil Ringnalda
5e91797776 Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
MozReview-Commit-ID: 3HDE2C3wSU0
2017-08-10 20:21:19 -07:00
Wes Kocher
d292002f8c Merge m-c to autoland, a=merge
MozReview-Commit-ID: 2YvHbITn9w3
2017-08-10 18:25:34 -07:00
Wes Kocher
b6c157e8cd Merge inbound to m-c a=merge
MozReview-Commit-ID: KRQeIGmhAPA
2017-08-10 18:14:34 -07:00
Sebastian Hengst
d476fe4639 Backed out changeset bf603affd1e0 (bug 1388753) for failing browser-chrome's browser_947914_button_history.js. r=backout a=merge
MozReview-Commit-ID: AHOsaTvCWms
2017-08-10 20:02:44 +02:00
Gijs Kruitbosch
046814d043 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz
2017-08-09 18:02:36 +01:00
Gijs Kruitbosch
53cf8f5743 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz
2017-08-10 23:04:54 +01:00
Mike Taylor
4692c73d4d Bug 1373650. Unteach CustomizableUI about the Report Site Issue button. r=Gijs
MozReview-Commit-ID: BCXVJChZ0mt
2017-08-04 15:35:18 -05:00
Gijs Kruitbosch
279127e720 Bug 1388753 - unbreak bookmarks/history item clicks and tidy up code in browserPlacesViews.js, r=mikedeboer
MozReview-Commit-ID: 1vjP6IeIiPz
2017-08-10 23:04:54 +01:00
Dão Gottwald
8e9d7061d2 Bug 956731 - Remove legacy add-on bar and statusbar shims. r=Gijs
MozReview-Commit-ID: 2deeujcHYUM
2017-08-10 09:17:48 +02:00
Kris Maglione
0fb6b2e73c Bug 1388215: Part 3 - Use JIT-friendly defineLazy*Getters methods when defining many lazy imports. r=florian
MozReview-Commit-ID: APoFwUhDFdj
2017-08-09 13:03:36 -07:00
Andrew Halberstadt
6c60ffa524 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw
2017-08-10 14:48:21 -04:00
Sebastian Hengst
33ad9881bc Backed out changeset bf603affd1e0 (bug 1388753) for failing browser-chrome's browser_947914_button_history.js. r=backout 2017-08-10 20:02:44 +02:00
Gijs Kruitbosch
01f7270ba2 Bug 1381556 - adjust panel widths to accommodate longer/wider content, r=mikedeboer
MozReview-Commit-ID: 6bOoRIfttEy
2017-08-09 14:04:21 +01:00
Gijs Kruitbosch
eb2cc9876d Bug 1383009 - add flexible spacers and library button to the navbar by default, r=jaws
Because we generate IDs for special nodes, we should update the inDefaultState getter to actually consider
these nodes to match even when the ids differ. This wasn't an issue before because specials weren't in the
default set for any nodes.

MozReview-Commit-ID: AI85yt2LuJD
2017-08-07 19:10:40 +01:00
Michael Kohler
f15ab23e9f Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code. r=dao
MozReview-Commit-ID: 8w1vfF2yRui
2017-08-08 12:09:14 +02:00
Carsten "Tomcat" Book
b83067d218 merge mozilla-inbound to mozilla-central a=merge 2017-08-08 13:18:14 +02:00
Kris Maglione
fa416b7835 Bug 1387902: Don't attempt to localize browserAction widget properties. r=Gijs
We spend a lot of time at startup generating exception objects while trying to
retrieve nonexistent localized properties from string bundles. Since extension
widget values will never be localized this way, we should skip the string
bundle lookup entirely.

MozReview-Commit-ID: L9r59bf2Dgf
2017-08-06 16:34:31 -07:00
Sebastian Hengst
31742f9ca2 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
a220eeb86a Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao
MozReview-Commit-ID: CoHv9mKpAe
2017-08-05 20:37:40 +02:00
Dão Gottwald
421fc16fa5 Bug 1387602 - Update customize mode favicon. r=Gijs
MozReview-Commit-ID: 7gin0zuJTN0
2017-08-04 23:00:00 +02:00
Sam Foster
05040037c0 Bug 1352075 - Implement new animation for opening/closing the arrow panels. r=dao,mossop
* Use new panel animation when opening arrow-panels (including bookmarks menu) to fade in and drop into position
* Linux/GTK is (still) excluded
* New animation is non-directional (i.e. LTR vs. RTL)

This was landed then backed out due to test failures. New since last review:

* Make opacity & transform transition durations equal - ensuring popup is not still moving when popupshown is fired
* Fix missing comma in transition-duration values
* Add animating attribute to the arrowpanel binding to disable pointer-events during the opening transition (via :jaws)
* Wait for popupshown rather than transitionend in bookmark reparenting test
* Fix specificity of CSS rules for panels/bookmarks-menu on edges other than the top (via :jaws)

MozReview-Commit-ID: DTnvyMryf5Y
2017-07-27 11:07:23 -07:00
Gijs Kruitbosch
4639ca807b Bug 1354117 - stop relying on gPhotonStructure in bookmarks/history code, r=adw
MozReview-Commit-ID: FqUFNrSufvQ
2017-08-01 19:55:41 +01:00
Gijs Kruitbosch
3a2a3f1870 Bug 1354117 - remove old panel code from panelUI and CSS, r=jaws
MozReview-Commit-ID: G6a9ybDxqki
2017-08-01 19:59:38 +01:00
Gijs Kruitbosch
4f5a9c34e6 Bug 1354117 - remove old panel code from customize mode and update related CSS, r=jaws
MozReview-Commit-ID: IwKUWMTagCK
2017-08-02 11:51:58 +01:00
Gijs Kruitbosch
a659b10191 Bug 1354117 - remove old panel code from CustomizableUI, add migration, r=jaws
MozReview-Commit-ID: 8kTETHR1P7X
2017-08-01 12:56:48 +01:00
Gijs Kruitbosch
1dde1ca8d5 Bug 1354117 - fix telemetry and a number of tests that flip photon prefs, r=johannh
MozReview-Commit-ID: 7ynaIQm22eS
2017-08-01 20:15:48 +01:00
Gijs Kruitbosch
5a6c52f6a7 Bug 1354117 - only dispatch view events once, and fix synced tabs button test, r=jaws
Prior to this patch, both CustomizableUI itself and the PanelMultiView module
tried to ensure that onViewShowing/Shown/Hiding/Hidden listeners were invoked
when the relevant DOM events fired.

PanelMultiView was doing this manually because CUI was only adding listeners
once the corresponding widget was created. Now that the relevant views can be
accessed without the corresponding widgets (via the fixed appMenu), there was
no guarantee that the listeners would be attached, and this caused empty
subviews.

Unfortunately, if the widget *was* present, it caused events to fire more than
once, which understandably broke consumers like the sync remote tabs widget,
which broke the test we're fixing up here. For other views, even if they were
not completely broken it at least did busy-work.

This patch removes the manual event invocation, and delegates the event
listener work to CUI from the PanelMultiView side. This ensures events fire,
and fire only once.

MozReview-Commit-ID: 94GhcrdcBuB
2017-08-01 12:45:55 +01:00
Gijs Kruitbosch
083671c400 Bug 1354117 - Update various other customizableui tests for photon, r=adw
There are no more help/quit buttons in the panel that shows up in customize mode,
and there are no more hyphenation quirks in items in the panel, so those tests
have been removed. The remaining tests are updated to test the correct panels.

MozReview-Commit-ID: LiUWejjZC7c
2017-08-01 15:46:58 +01:00
Gijs Kruitbosch
865d6f5756 Bug 1354117 - fix or remove tests that drag items to the panel, r=adw
The new panel doesn't have placeholders, or a distinction between wide and
narrow widgets, so those tests can just be removed.

MozReview-Commit-ID: D61AjwMbabG
2017-07-31 18:26:38 +01:00
Gijs Kruitbosch
80565d2e85 Bug 1354117 - update panel button tests for photon, r=adw
MozReview-Commit-ID: 94mIvlOenCg
2017-08-01 11:33:26 +01:00
Gijs Kruitbosch
fcc4f4817a Bug 1354117 - update customize mode button state test, r=johannh
Again, this test is mostly useless now, so I would also be fine with just removing it.

MozReview-Commit-ID: BwOGQ5pwSQd
2017-07-31 21:10:14 +01:00
Gijs Kruitbosch
d485cb5fac Bug 1354117 - remove wrap handling for the bookmarks toolbar button and tests verifying it, r=johannh
MozReview-Commit-ID: CeSGIQrDPpw
2017-07-31 21:52:06 +01:00
Gijs Kruitbosch
1bc740f04e Bug 1354117 - remove panel-specific styling and associated code, include closemenu in styling in overflow panel, r=johannh
MozReview-Commit-ID: 4EgZP0Huo80
2017-07-27 16:27:05 +01:00
Jared Wein
d016c13ec8 Bug 1385913 - Remove MOZ_PHOTON_ANIMATIONS ifdef. r=Gijs
MozReview-Commit-ID: 40TP43EKPCU
2017-08-07 12:37:34 -04:00
Gijs Kruitbosch
2d0c23d1fb Bug 1387182 - fix border (empty space) compensation when dragging items in customize mode in RTL, r=jaws
MozReview-Commit-ID: AblsJGmu5zm
2017-08-07 12:14:19 +01:00
Gijs Kruitbosch
a626facc1f Bug 1385083 - history panel should actually list history, r=mikedeboer
MozReview-Commit-ID: G98QMcmASv0
2017-08-07 15:24:49 +01:00
Julian Descottes
e4c5c61d18 Bug 1387023 - initialize devtools before asserting menu items in browser_989751_subviewbutton_class.js;r=Gijs
MozReview-Commit-ID: 9piucVkS0Y9
2017-08-03 14:04:54 +02:00
UK992
890c6e6ae5 Bug 1363485 - Update tests r=dao
MozReview-Commit-ID: 4epuVQVCJPH
2017-07-30 20:39:55 +02:00
UK992
4725c98c0b Bug 1363485 - Add migration to new navbar layout r=Gijs
MozReview-Commit-ID: HIPq5rKgtlA
2017-06-29 19:09:43 +02:00
UK992
d474ac2448 Bug 1363485 - Move the Back, Forward, Reload and Stop buttons outside of the location bar container to the start of the toolbar along with the Home button r=Gijs
MozReview-Commit-ID: 2GxcXMxdbjW
2017-06-29 01:09:05 +02:00
Erica Wright
056e3d8dba Bug 1378016 - Fix keyboard navigation and selection on 'recent bookmarks'. r=Gijs
MozReview-Commit-ID: GJ7vRPz8zuo
2017-07-31 09:47:19 -04:00
Sebastian Hengst
6415681153 Backed out changeset 1e6aea26ec16 (bug 1363485) for failing browser_urlbar_search_reflows.js on OSX debug with e10s and Windows. r=backout 2017-08-02 16:26:03 +02:00
Sebastian Hengst
4f8c56e473 Backed out changeset 69063acda8eb (bug 1363485) 2017-08-02 16:25:05 +02:00
Sebastian Hengst
6b72dd3d4c Backed out changeset f3e224764ca8 (bug 1363485) 2017-08-02 16:24:54 +02:00
Rajesh Kathiriya
fefc455410 Bug 1374620 - Enabled the ESLint dot-notation rule across mozilla-central r=standard8
MozReview-Commit-ID: FadrI2li43G
2017-07-25 23:45:41 +05:30