Commit Graph

32 Commits

Author SHA1 Message Date
Timothy Guan-tin Chien
6071bf1543 Bug 1399367 - Remove MasterPassword.{encrypt|decrypt}Sync() methods r=MattN
This also makes various AutofillRecords methods async, with the exception of
remove() and removeAll().

Noted that I didn't implement any kind of "lock" for FormAutofillStorage --
please do not call these methods concurrently -- if you must please |await|
for the last call to resolve. This most likely would happen in tests, and
shouldn't happen in the real world, given that all user actions happen on
macrotasks, and probably not at the next tick, unless Quicksilver is a
Firefox user.

FormAutofillStorage can be improved if there are complex use cases for it.

Differential Revision: https://phabricator.services.mozilla.com/D4420
2018-09-05 00:32:57 +00:00
Mark Banner
76e8f30587 Bug 1478305 - Remove unnecessary imports and fix ESLint warnings about unused variables for browser/. r=jaws
MozReview-Commit-ID: 1vHR6ixePkN
2018-07-30 10:27:36 +01:00
Matthew Noorenberghe
5df3a9f472 Bug 1476204 - Check Luhn algorithm in the basic-card-form and in storage and disable save button when invalid. r=jaws
* Provide an cc-exp-year option to match cc-exp-month
* Make cc-number and cc-name required in the basic-card-form
* Disable the basic-card-page save button when the form is invalid.

MozReview-Commit-ID: LjzsnAKJp6R
2018-07-26 13:40:22 -07:00
Cosmin Sabou
4d1b71eee6 Backed out 5 changesets (bug 1476204) for browser chrome failures on browser_editCreditCardDialog. CLOSED TREE
Backed out changeset 10f3d1014592 (bug 1476204)
Backed out changeset a88879ea32e8 (bug 1476204)
Backed out changeset 001f13f2dd21 (bug 1476204)
Backed out changeset f0f464e3c27c (bug 1476204)
Backed out changeset ed92000eca20 (bug 1476204)
2018-07-26 04:12:56 +03:00
Matthew Noorenberghe
1ba778c9a8 Bug 1476204 - Check Luhn algorithm in the basic-card-form and in storage and disable save button when invalid. r=jaws
* Provide an cc-exp-year option to match cc-exp-month
* Make cc-number and cc-name required in the basic-card-form
* Disable the basic-card-page save button when the form is invalid.

MozReview-Commit-ID: LjzsnAKJp6R
2018-07-25 16:38:25 -07:00
Kris Maglione
76e74e6ca5 Bug 1474140: Don't load FormAutofillUtils.jsm at content process startup. r=MattN
MozReview-Commit-ID: 2bOyTPU9QbX
2018-07-07 17:49:34 -07:00
Matthew Noorenberghe
578163b125 Bug 1427954 - Pass FormAutofillUtils.isCCNumber to EditCreditCard. r=sfoster
The point of this is to remove dependencies on privileged code from autofillEditForms.js so it can
be used in the unprivileged PaymentRequest dialog. The PaymentRequest dialog will be able to inject
the privileged APIs in a different way.

MozReview-Commit-ID: 34PvRxzWcSr
2018-03-14 18:11:03 -07:00
Matthew Noorenberghe
c4094215a1 Bug 1427954 - Pass supported and default countries to EditAutofillForm and move loadInitialValues. r=sfoster
The point of this is to remove dependencies on privileged code from autofillEditForms.js so it can
be used in the unprivileged PaymentRequest dialog. The PaymentRequest dialog will be able to inject
the privileged APIs in a different way.

MozReview-Commit-ID: 4KITOMz7Uxh
2018-03-14 18:11:36 -07:00
Matthew Noorenberghe
1597ac3676 Bug 1427954 - Move autofill edit dialog l10n to mutation observers. r=sfoster
MozReview-Commit-ID: 5jSj0xPBTQj
2018-03-14 18:12:00 -07:00
Matthew Noorenberghe
28196f5a82 Bug 1427954 - Remove string bundle references from autofillEditForms.js. r=sfoster
This is a step on the path to making it unpriveleged.

MozReview-Commit-ID: 3DSYvM2Pje9
2018-03-14 18:12:15 -07:00
Matthew Noorenberghe
79e4b011ea Bug 1427954 - Remove unused uninit code from editDialog.js and autofillEditForms.js. r=sfoster
MozReview-Commit-ID: 9GP1gsycgJo
2018-03-14 17:31:56 -07:00
Matthew Noorenberghe
447c316378 Bug 1427954 - Split autofill dialog logic from field logic. r=sfoster
We want to re-use the field/form logic but not the dialog-specific logic so this separates them out.

Custom Elements aren't enabled by default yet so we can't use them yet.

MozReview-Commit-ID: 60hMpgSOmpp
2018-03-14 18:12:38 -07:00
Matthew Noorenberghe
85cea5f35d Bug 1427954 - Don't pass child elements into the constructor. r=sfoster
MozReview-Commit-ID: 2iqHks0yD0v
2018-03-14 18:12:58 -07:00
Matthew Noorenberghe
6983623bf5 Bug 1427954 - Remove unused Services and XPCOMUtils imports in editDialog.js. r=sfoster
MozReview-Commit-ID: F4ryqNOYMn6
2018-03-14 17:06:42 -07:00
Daniel Marshall
7724f2e32c Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I
2018-02-10 21:23:19 +00:00
Narcis Beleuzu
439cc34017 Backed out changeset a8130e46c530 (bug 1434483) for ESlint failures on browser_change_shipping.js. CLOSED TREE 2018-03-05 23:50:02 +02:00
Daniel Marshall
49ad18cee3 Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I
2018-02-10 21:23:19 +00:00
Ian Moody
a54a2601c7 Bug 1432070 - Block context menu in Autofill preference dialogs, except on text fields. r=MattN,scottwu
The context menu shown is the standard web page one, and so inappropriate for
inside preferences.  Keep it on text fields so text editing commands are still
available, though unfortunately so are "This Frame", "Inspect Element", and
"Add a Keyword for this Search".

MozReview-Commit-ID: 7L012CZ4BhR
2018-01-21 22:50:07 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
George Dan, Ryan Neilsen, Dylan Turner
61369dbaa9 Bug 1387632: Rename ProfileStorage module to FormAutofillStorage. r=MattN 2018-01-30 14:44:59 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Scott Wu
1e0139fa29 Bug 1421538 - Set country field to default country when creating new addresses. r=lchang
MozReview-Commit-ID: 5Bd6TdZOej
2018-01-03 17:50:44 +08:00
Scott Wu
7c6b72fff4 Bug 1383687 - Order edit dialog fields based on country selected. r=lchang,steveck
MozReview-Commit-ID: 1qPxvHhNGtK
2017-11-03 16:24:30 +08:00
Scott Wu
d0daefcea9 Bug 1417843 - Add supportedCountries pref to configure which countries are supported. r=lchang,steveck
MozReview-Commit-ID: 13m1ezHcR8n
2017-11-17 17:15:56 +08:00
Luke Chang
66b98e77e9 Bug 1395122 - [Form Autofill] Treat "cc-number-encrypted" as a computed field and compute it within the storage. r=kitcambridge,MattN,steveck
MozReview-Commit-ID: K58A7Qdj4va
2017-09-08 12:31:02 +08:00
Scott Wu
b8584a5e80 Bug 1370764 - (Part 3) Add browser chrome test for adding and editing credit card. r=lchang
MozReview-Commit-ID: Di1GtjknK5E
2017-08-23 17:10:36 +08:00
Scott Wu
c808f8d5d0 Bug 1370764 - (Part 2) Create a dialog to add/edit/view a credit card entry. r=lchang
MozReview-Commit-ID: 7d6cfcShrwc
2017-08-11 15:31:57 +08:00
Scott Wu
6d3db9462d Bug 1370764 - (Part 1) Rename editAddress files to editDialog. r=lchang
MozReview-Commit-ID: LxETrvltB2G
2017-08-22 14:28:31 +08:00