corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
874,028 Commits 1 Branch 0 Tags
5ebd63c57804898aa7feb1e7e5c36ac850e1d791
Commit Graph

83 Commits

Author SHA1 Message Date
Sam Foster
5ebd63c578 Bug 1899346 - Move CUI widgets out of the horizontal tabstrip when in vertical tabs mode. r=sidebar-reviewers,mconley,sclements,webdriver-reviewers,whimboo 
* Ensure tabstrip widgets are temporarily removeable at browser init so the CUI placements are correctly applied
* Shuffle placements during initialization to build the correct toolbars for the verticalTabs pref value
* Notify on the 'tabstrip-orientation-change' topic when the verticalTabs pref changes and CUI placements have been updated
* Add tests for switching tabstrip orientation, and for initializing in verticalTabs mode

Differential Revision: https://phabricator.services.mozilla.com/D217161
 2024-09-04 00:12:07 +00:00
Ed Lee
d1d69b2d3a Bug 1895932 - Add sidebar prefs to nimbus r=sidebar-reviewers,Gijs,sclements 
Add new SidebarManager singleton with init on import that allows setting user branch prefs specified in the nimbus variable for sidebar.

Differential Revision: https://phabricator.services.mozilla.com/D219903
 2024-09-02 22:43:28 +00:00
Emilio Cobos Álvarez
f7551929f8 Bug 1916098 - Remove appcontent box. r=dao,desktop-theme-reviewers,devtools-reviewers,tabbrowser-reviewers,nchevobbe 
gNotificationBox doesn't go there anymore (it goes inside the toolbox),
so we have really no use for that.

Simplify how the devtools theme is set on the browser, so that it is set
on the root.

Differential Revision: https://phabricator.services.mozilla.com/D220769
 2024-09-02 13:47:45 +00:00
Kelly Cochrane
86f229c8a5 Bug 1915821 - Remove all screenshots after sidebar expand/collapse animation r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D220736
 2024-08-31 13:16:48 +00:00
Kelly Cochrane
fceef0f8b6 Bug 1915232 - Fix for sidebar toolbar button inverted state r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D220735
 2024-08-30 19:45:30 +00:00
Stanca Serban
37b5e2bd39 Backed out changeset f20f138ea4ac (bug 1915232) for causing mochitests failures in browser_history_sidebar.js. CLOSED TREE 2024-08-31 03:31:19 +03:00
Stanca Serban
1466a02554 Backed out changeset 8b97e9376724 (bug 1915821) for causing OS X mochitests failures in browser_toolbarButtonKeyPress.js. CLOSED TREE 2024-08-31 02:32:35 +03:00
Kelly Cochrane
0372b26dea Bug 1915232 - Fix for sidebar toolbar button inverted state r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D220735
 2024-08-30 19:45:30 +00:00
Kelly Cochrane
1e5899abe1 Bug 1915821 - Remove all screenshots after sidebar expand/collapse animation r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D220736
 2024-08-30 19:45:09 +00:00
Ed Lee
857840a797 Bug 1915335 - Display sidebar tool pref changes in existing windows r=sidebar-reviewers,jsudiaman 
Detect pref change to refresh disabled state to update if any changed.

Differential Revision: https://phabricator.services.mozilla.com/D220370
 2024-08-29 00:52:13 +00:00
Kelly Cochrane
04a3166151 Bug 1913157 - Ensure new sidebar pref is enabled when enabling vertical tabs in Firefox Labs r=sidebar-reviewers,nsharpley,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D219887
 2024-08-27 17:02:04 +00:00
Norisz Fay
a1d50a6697 Backed out changeset c540259f992c (bug 1913157) for causing bc failure on browser_sidebar_prefs.js CLOSED TREE 2024-08-27 17:31:26 +03:00
Kelly Cochrane
448c1dcaf6 Bug 1913157 - Ensure new sidebar pref is enabled when enabling vertical tabs in Firefox Labs r=sidebar-reviewers,nsharpley,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D219887
 2024-08-27 13:08:12 +00:00
Kelly Cochrane
9600083d6c Bug 1898251 - Add animations for sidebar 'launcher' in 'Always show' mode r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,dao,hjones,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D215520
 2024-08-26 19:16:07 +00:00
Tamas Szentpeteri
db26c1b7f0 Backed out changeset 4270bbbfb92d (bug 1898251) for causing frequent marionette failures on test_restore_sidebar.py. CLOSED TREE 2024-08-24 00:24:39 +03:00
Kelly Cochrane
9c271bfe95 Bug 1898251 - Add animations for sidebar 'launcher' in 'Always show' mode r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,dao,hjones,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D215520
 2024-08-23 15:56:40 +00:00
Iulian Moraru
6a5418ae50 Backed out changeset 0df1c4dc3e1e (bug 1898251) for causing marionette failures related to always_show. CLOSED TREE 2024-08-22 23:59:31 +03:00
Kelly Cochrane
19636d4e59 Bug 1898251 - Add animations for sidebar 'launcher' in 'Always show' mode r=desktop-theme-reviewers,reusable-components-reviewers,sidebar-reviewers,dao,hjones,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D215520
 2024-08-22 17:26:03 +00:00
Jonathan Sudiaman
0091e139e7 Bug 1909704 - Add three-dot menu to history and right-click menu for history and synced tabs r=sidebar-reviewers,fluent-reviewers,fxview-reviewers,nsharpley,sclements 
- Custom right-click menu for History and Synced Tabs.
- Three dot menu for changing sort option and clearing history.
- Tests for Synced Tabs and right-click menu in History.

Differential Revision: https://phabricator.services.mozilla.com/D218741
 2024-08-22 15:19:02 +00:00
Nikki Sharpley
096c2ae629 Bug 1912229 - Move setPosition to sidebar init r=sidebar-reviewers,sclements 
Previously we were only calling `setPosition` in `show()`. This meant
the "launcher" was not updated during session restore to be on the
correct side if "show on right" was set, because `SessionStore` only
calls `show()` if the sidebar panel is open.

To fix, `setPosition` has been moved to `init` instead.

Differential Revision: https://phabricator.services.mozilla.com/D219553
 2024-08-20 15:44:10 +00:00
Sam Foster
40253cf104 Bug 1912017 - Avoid responding to pref changes in the sidebar when the window is closing. r=sidebar-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D219077
 2024-08-15 06:03:05 +00:00
Sam Foster
f64b68c78d Bug 1899580 - Exclude collapsed vertical tabs from indicator-replaces-favicon behavior. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements 
- Ensure everything that sets .expanded on sidebar-main uses the toggleExpanded method

Differential Revision: https://phabricator.services.mozilla.com/D217507
 2024-08-07 18:51:26 +00:00
Kelly Cochrane
f07a9b2932 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs. r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-08-06 14:21:04 +00:00
Noemi Erli
add41c1a33 Backed out changeset 81c607ae7fa3 (bug 1906140) for causing mochitest failures CLOSED TREE 2024-08-03 04:30:26 +03:00
Kelly Cochrane
95e61eaaba Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-08-03 00:04:27 +00:00
Noemi Erli
ea6ddac0d7 Backed out changeset f14b6d618dee (bug 1906140) for causing mochitest failures 2024-08-03 00:48:34 +03:00
Kelly Cochrane
0e25ff4d26 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-08-02 21:07:57 +00:00
Noemi Erli
9526f13a15 Backed out changeset a5aa68704532 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-03 00:03:13 +03:00
Kelly Cochrane
12ead799a2 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-08-02 19:27:10 +00:00
Noemi Erli
aa53f7828b Backed out changeset b825b6411765 (bug 1906140) for causing failures in browser_view_sidebar_menu.js CLOSED TREE 2024-08-02 22:17:11 +03:00
Kelly Cochrane
3f0ff02121 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman,sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-08-02 18:32:38 +00:00
Sandor Molnar
62ae38bb63 Backed out changeset 3b4a3a45aa1a (bug 1906140) @ browser_sidebar_prefs.js CLOSED TREE 2024-08-01 04:21:31 +03:00
Kelly Cochrane
6f31e3a9a9 Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-08-01 00:34:29 +00:00
Sandor Molnar
daa46360f2 Backed out changeset 086cdcffa062 (bug 1906140) for causing bc failures @ browser_sidebar_prefs.js CLOSED TREE 2024-08-01 00:37:35 +03:00
Kelly Cochrane
466cbf628a Bug 1906140 - Update the labs UI toml file for sidebar and vertical tabs r=settings-reviewers,fluent-reviewers,sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D217504
 2024-07-31 21:02:05 +00:00
Jonathan Sudiaman
93a0b7bce5 Bug 1900979 - Fix empty strings assigned in Sidebar.ftl r=sidebar-reviewers,fluent-reviewers,kcochrane 
The empty strings were used as a workaround to clear out labels when switching from expanded to collapsed state. This really should have been the component's responsibility.

Differential Revision: https://phabricator.services.mozilla.com/D218087
 2024-07-31 15:18:42 +00:00
Sarah Clements
7ea40f53e4 Bug 1899336 - Position pinned tabs and new tab button for vertical tabs mode r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane 
* Create a new container to house pinned tabs, new tab button and non-pinned tabs
* Create new pinned tabs container to apply grid layout and overflow scrolling
* Update test coverage for pinned tabs for both horizontal and vertical tabs

Differential Revision: https://phabricator.services.mozilla.com/D215482
 2024-07-29 11:30:37 +00:00
Jonathan Sudiaman
4976e075f8 Bug 1886408 - History in sidebar: Remove row limit, fix empty state, add hover button. r=sidebar-reviewers,desktop-theme-reviewers,fxview-reviewers,fluent-reviewers,kcochrane,nsharpley 
- max-history-rows pref set to 0 for Nightly only.
- Add the X button to close a tab on hover.
- Introduce an extension to `fxview-tab-list` which handles the differences between here and FxView.
- Reuse the empty state for when history is cleared (same as firefox view).
- Update the logic of `fxview-empty-state` to allow for opening prefs link in the parent window (instead of the sidebar browser).

Differential Revision: https://phabricator.services.mozilla.com/D217111
 2024-07-25 16:03:17 +00:00
Matthew_Cash
a8fbb156bd Bug 1900282 - Apply browser.tabs.allow_transparent_browser pref to sidebar browsers. r=dao,sidebar-reviewers,sclements,sfoster 
This change allows users to remove the opaque background from the
sidebar, enabling sidebar backgrounds to be fully transparent when used
alongside a userChrome.css that provides transparency.
This is purely an aesthetic option for use with custom themes and a
continuation of Bug 28354.

Differential Revision: https://phabricator.services.mozilla.com/D212385
 2024-07-15 15:06:56 +00:00
Kelly Cochrane
b40657ff11 Bug 1897976 - Update existing tests involving sidebar-button in the nav bar for when sidebar.revamp pref is flipped on r=places-reviewers,sidebar-reviewers,urlbar-reviewers,mak,sfoster,Gijs,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D215253
 2024-07-12 15:58:29 +00:00
Luca Greco
3ae0a96b30 Bug 1905771 - switcherTarget element label set by SidebarController.registerExtension is still set when switching to a non extension sidebar. r=willdurand,sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D215945
 2024-07-10 17:52:30 +00:00
Ed Lee
e7565e634f Bug 1906122 - Selecting AI Chatbot or extensions with old sidebar panel switcher when already on that panel closes the sidebar r=sidebar-reviewers,nsharpley 
Detect menu usage as checkbox or not to toggle or show.

Differential Revision: https://phabricator.services.mozilla.com/D215797
 2024-07-04 21:06:53 +00:00
Ed Lee
1bac981cb5 Bug 1900915 - Include chat as tool for new sidebar r=sidebar-reviewers,sclements 
Update default tool ordering. Conditionally render tool if not hidden for both main and customize.

Differential Revision: https://phabricator.services.mozilla.com/D215721
 2024-07-04 14:44:11 +00:00
Gijs Kruitbosch
40e851d728 Bug 1905692 - use JS to handle activation/click of sidebar close button in non-revamped sidebar, r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D215379
 2024-07-01 19:40:55 +00:00
Jonathan Sudiaman
fec725412b Bug 1892430 - Add a "Hide" sidebar visibility setting r=sidebar-reviewers,sessionstore-reviewers,sclements 
The toggle was there to begin with, but this commit actually gets it working to spec.

Differential Revision: https://phabricator.services.mozilla.com/D214181
 2024-06-27 19:34:08 +00:00
Jonathan Sudiaman
52e63f2908 Bug 1892941 - Add a "Always Show" sidebar visibility setting r=sidebar-reviewers,fluent-reviewers,sessionstore-reviewers,bolsson,sclements,reusable-components-reviewers,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D212285
 2024-06-27 19:34:08 +00:00
Nikki Sharpley
60f464ed8e Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213591
 2024-06-21 18:15:25 +00:00
Cristian Tuns
ecab83f214 Backed out changeset bd06757d8344 (bug 1892957) for causing mochitest failures in browser_sidebar_move.js CLOSED TREE 2024-06-21 11:40:07 -04:00
Nikki Sharpley
72b2fd0ee7 Bug 1892957 - Add sidebar position settings to the Customize Sidebar menu r=sidebar-reviewers,fluent-reviewers,desktop-theme-reviewers,sessionstore-reviewers,kcochrane,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D213591
 2024-06-21 14:00:00 +00:00
Sarah Clements
92d796abdd Bug 1893655 - Set up the tabstrip to work vertically r=dao,sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,Gijs 
* Add ability to move tabstrip into the sidebar based on a pref

Differential Revision: https://phabricator.services.mozilla.com/D212287
 2024-06-15 10:43:19 +00:00