Commit Graph

4122 Commits

Author SHA1 Message Date
Sandor Molnar
5e9ca11c9d Backed out 5 changesets (bug 1867017, bug 1867019, bug 1867018, bug 1867020) for causing bc failures at browser/components/preferences/tests/browser_search_subdialogs_within_preferences_5.js CLOSED TREE
Backed out changeset 0c4bc9a698ba (bug 1867017)
Backed out changeset ea95d41995f0 (bug 1867017)
Backed out changeset 56289937eb65 (bug 1867020)
Backed out changeset 022c1f63a6fe (bug 1867019)
Backed out changeset fa5b89f2d1b6 (bug 1867018)
2023-12-12 05:54:37 +02:00
Nipun Shukla
dd8b73c28c Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191763
2023-12-12 00:22:08 +00:00
Cristian Tuns
2f6520726f Backed out changeset 7351cc3d5b11 (bug 1853747) for causing failures in createcredential-abort.https.html CLOSED TREE 2023-12-11 18:17:22 -05:00
jneuberger
a3d542118c Bug 1867017 - P1. Update about:preferences strings of passwords section r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D195280
2023-12-11 21:54:34 +00:00
jneuberger
777f61f0ec Bug 1867020 - Update about:preferences strings for exceptions modal r=credential-management-reviewers,fluent-reviewers,settings-reviewers,joschmidt,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D195279
2023-12-11 21:54:34 +00:00
Sandor Molnar
2313150db4 Backed out changeset 677c3005fd69 (bug 1860271) for causing node newtab failures at browser/components/newtab CLOSED TREE 2023-12-11 23:31:08 +02:00
Nipun Shukla
c334dcfcd7 Bug 1860271 - Resolved launch on login checkbox and infobar bugs when user created Startup shortcut exists r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191763
2023-12-11 20:59:45 +00:00
John Schanck
3300c3d653 Bug 1853747 - add a link to Windows settings for passkey management. r=keeler,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,bolsson,flod
Differential Revision: https://phabricator.services.mozilla.com/D195613
2023-12-11 20:51:52 +00:00
Sandor Molnar
717f90695a Backed out 2 changesets (bug 1856415) for causing bc failures at browser/base/content/test/static/browser_all_files_referenced.js CLOSED TREE
Backed out changeset f5e458c049b9 (bug 1856415)
Backed out changeset ffd79f9e0881 (bug 1856415)
2023-12-11 20:20:33 +02:00
Harshit Sohaney
2bbd228a56 Bug 1856415 - (Part 1) Updating clear data dialog UI. r=pbz,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,Gijs,dao,flod
Differential Revision: https://phabricator.services.mozilla.com/D189947
2023-12-11 16:50:57 +00:00
Karandeep
d41e533454 Bug 1852045 - Hide the "Show search suggestions in address bar results" checkbox when the search bar isn't in the toolbar. r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D192571
2023-12-05 11:04:39 +00:00
Johannes J. Schmidt
0b4bf0b0eb Bug 1867015 - Update Strings for about:preferences - Sync page - r=credential-management-reviewers,fluent-reviewers,settings-reviewers,flod,issammani
Differential Revision: https://phabricator.services.mozilla.com/D195118
2023-12-04 13:55:36 +00:00
Eemeli Aro
07145792f8 Bug 1814969: Migrate ContextualIdentityService strings to Fluent r=geckoview-reviewers,fluent-reviewers,mconley,owlish,flod
This includes a containers.json version increment and the necessary migration,
as the StringBundle identifiers are replaced with a Fluent reference.

As it's not possible to filter the attributes that are applied with DOM localization,
the code in utilityOverlay.js is a little clumsy. The non-acceskey versions are needed
due to bug 1297738, i.e. the long-press menu available from the tab bar down arrow.

Previously, the "Manage containers" menu item and its accesskey were defined in two places.
These are here combined into one.

Differential Revision: https://phabricator.services.mozilla.com/D194510
2023-12-04 13:09:15 +00:00
Michael Hughes
5ea9a03802 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
2023-12-01 20:07:08 +00:00
Cosmin Sabou
e276c6b6b9 Backed out 2 changesets (bug 1801954, bug 1863980) for bc failures on browser_setDefaultBrowser.js. CLOSED TREE
Backed out changeset b96506a6d950 (bug 1801954)
Backed out changeset 306a649fcc00 (bug 1863980)
2023-12-01 02:34:26 +02:00
Michael Hughes
9cc9c079f5 Bug 1863980 - [msix] Make ShellService.setDefaultBrowser async. r=nalexander,mconley,dmose,omc-reviewers
This commit includes the changes to call into the new asynchronous code to set the browser as default, using powershell.

While here, we add more logging to this interaction to allow easier
debugging with QA.

Differential Revision: https://phabricator.services.mozilla.com/D194949
2023-11-30 22:22:16 +00:00
Valentin Gosu
efe722971f Bug 1859505 - Make text referring to DoH more consistent across the UI r=necko-reviewers,fluent-reviewers,settings-reviewers,bolsson,Gijs,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D194894
2023-11-29 17:19:38 +00:00
Cristian Tuns
ffdaa2ecdb Backed out changeset 25b74ab09261 (bug 1852045) for causing bc failures in browser_searchShowSuggestionsFirst.js CLOSED TREE 2023-11-29 12:15:07 -05:00
Karandeep
a7df4578f7 Bug 1852045 - Hide the "Show search suggestions in address bar results" checkbox when the search bar isn't in the toolbar r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D192571
2023-11-29 15:53:48 +00:00
Emilio Cobos Álvarez
21e7e9d5e9 Bug 1865346 - Fix updater deck downloading state alignment. r=Gijs,settings-reviewers,desktop-theme-reviewers,dao
This is the only element in the deck which has plain inlines inside.
Make them a block, which is more similar to what the about dialog does
too, anyways.

Differential Revision: https://phabricator.services.mozilla.com/D194604
2023-11-27 14:39:50 +00:00
Tarik Eshaq
698216944d Bug 1855513: Move in-browser verification to open web content. r=markh,fluent-reviewers,settings-reviewers,Gijs,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D193678
2023-11-22 17:58:18 +00:00
Karandeep
ce4416a490 Bug 1852044 - Remove the Search Bar section. r=dao,fluent-reviewers,desktop-theme-reviewers,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192722
2023-11-21 05:09:08 +00:00
Karandeep
499e1c4a7e Bug 1852046 - Convert "Suggestions from the web" and "Suggestions from sponsors" toggles to checkboxes on privacy prefs page r=dao,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D191641
2023-11-16 07:19:42 +00:00
Natalia Csoregi
ab3b33ee93 Backed out changeset 555c786396f8 (bug 1852046) as requested. CLOSED TREE 2023-11-09 20:53:42 +02:00
Dale Harvey
3abcf233ac Bug 1794752 - Increase status column width. r=Gijs,settings-reviewers,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D192598
2023-11-04 11:25:19 +00:00
Emilio Cobos Álvarez
0983cb4e16 Bug 1664278 - Expose an "always underline links" checkbox in settings. r=morgan,settings-reviewers,fluent-reviewers,Gijs
Might want to run it through UX or so...

Differential Revision: https://phabricator.services.mozilla.com/D190672
2023-11-02 09:43:41 +00:00
Karandeep
e2ba36560e Bug 1852042 - Move checkbox from search bar section to the default search engine section in search pref page. r=dao,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D191978
2023-11-01 11:21:14 +00:00
ChaseKnowlden
3f6be9bda6 Bug 1859348 - Rename mac to macosx in preferences. r=settings-reviewers,mossop
Differential Revision: https://phabricator.services.mozilla.com/D192165
2023-10-30 07:28:21 +00:00
Karandeep
9ec67c7d3d Bug 1852046 - Convert all toggles to checkboxes on privacy prefs page r=dao,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D191641
2023-10-25 15:30:14 +00:00
Emilio Cobos Álvarez
8024655b1a Bug 1860346 - Fix browser_permissions_dialog.js.
MANUAL PUSH: Trivial orange fix CLOSED TREE
2023-10-25 14:13:14 +02:00
Emilio Cobos Álvarez
f8e535d8d7 Bug 1860346 - Simplify site permissions markup and styling. r=settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D191564
2023-10-25 11:08:08 +00:00
Emilio Cobos Álvarez
ed873d6616 Bug 1644612 - Add a height and cleanup languages listbox styling. r=desktop-theme-reviewers,dao
The "righter" way to do this is adding a bunch of min-height: 0 to the
grid, the dialog, the content box, etc. But this is more similar to what
other dialogs do.

Differential Revision: https://phabricator.services.mozilla.com/D180890
2023-10-24 11:11:18 +00:00
Karandeep
d612dc4043 Bug 1852041 - Deemphasized secondary preferences descriptions in search and privacy prefs. r=dao,settings-reviewers,desktop-theme-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D191098
2023-10-19 09:46:15 +00:00
Dave Townsend
108be2cdee Bug 1857999: Manually fix some spacing and comments. r=Gijs,settings-reviewers,places-reviewers,Standard8
Manually re-apply comments and spacing that existed prior to the automated
changes.

Differential Revision: https://phabricator.services.mozilla.com/D190682
2023-10-18 07:04:42 +00:00
Dave Townsend
f2f7777e96 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-18 07:04:41 +00:00
Nipun Shukla
59a0285adf Bug 1858223 - Disable Firefox launch on login when no starting profile is set r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190613
2023-10-18 01:37:26 +00:00
Cristian Tuns
4db9c28d5a Backed out changeset 71746bb87230 (bug 1858223) for causing marionette in test_no_errors_clean_profile.py CLOSED TREE 2023-10-17 13:42:36 -04:00
Nipun Shukla
5a10da6487 Bug 1858223 - Disable Firefox launch on login when no starting profile is set r=nalexander,settings-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190613
2023-10-17 14:21:58 +00:00
Dale Harvey
7d537fc643 Bug 1858961 - Update recent search label in preferences. r=flod,fluent-reviewers,settings-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D191129
2023-10-17 13:17:48 +00:00
Olivia Hall
632f1b3db0 Bug 1857002 - Move getLanguageList from browser to toolkit r=gregtatum,settings-reviewers,mconley
This function is helpful for GeckoView and Translations on Android.
Moving it to toolkit for shared use.

Differential Revision: https://phabricator.services.mozilla.com/D190118
2023-10-16 18:32:51 +00:00
Mike Conley
3c473874e4 Bug 1855280 - Remove the ability to switch to the old migration wizard. r=kpatenio,omc-reviewers,settings-reviewers,credential-management-reviewers,negin,aminomancer,mtigley
This removes the pref to re-enable the legacy wizard, and all of the things that used
to read from it.

It also disables the ability to use the legacy wizard from about:welcome with the
aboutWelcomeBehavior feature.

It also removes the closeMigrationWizard utility from BrowserTestUtils, since that
effectively became a thin-wrapper around BrowserTestUtils.removeTab.

Finally, this patch also removes some documentation about the legacy migration wizard,
and tests that specifically check the legacy dialog behaviour.

Differential Revision: https://phabricator.services.mozilla.com/D190716
2023-10-16 18:24:42 +00:00
Sandor Molnar
099f0fd4c3 Backed out 4 changesets (bug 1857999) for causing dt failures on browser_theme_switching.js & Mn failures at test_element_state_chrome.py CLOSED TREE
Backed out changeset 75f5e6e3d917 (bug 1857999)
Backed out changeset 0d0c1d1e80e7 (bug 1857999)
Backed out changeset b8a03d31ecea (bug 1857999)
Backed out changeset dd5a10f9cfff (bug 1857999)
2023-10-16 14:12:22 +03:00
Dave Townsend
23fed3a46c Bug 1857999: Manually fix some spacing and comments. r=Gijs,settings-reviewers,places-reviewers,Standard8
Manually re-apply comments and spacing that existed prior to the automated
changes.

Differential Revision: https://phabricator.services.mozilla.com/D190682
2023-10-16 09:43:27 +00:00
Dave Townsend
92c3ea0f78 Bug 1857999: Move XML stylesheet processing instructions to link elements. r=Gijs,webdriver-reviewers,settings-reviewers,application-update-reviewers,devtools-reviewers,places-reviewers,Standard8,whimboo,bytesized,ochameau
The result of running the automated script available at https://github.com/Mossop/depi

Differential Revision: https://phabricator.services.mozilla.com/D190681
2023-10-16 09:43:26 +00:00
DJ
d9ef55d8a5 Bug 1857968 - adjust cookiebanner prefs for PBM-only behavior. r=pbz,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190493
2023-10-14 17:14:32 +00:00
Noemi Erli
b9d80ca968 Backed out changeset 0bffbf41279d (bug 1857968) for causing failures in browser_search_subdialogs_within_preferences_site_data.js 2023-10-13 00:22:48 +03:00
Benjamin VanderSloot
964b6f3c68 Bug 1850717 - Add a section header for GPC/DNT - r=pbz,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D189552
2023-10-12 19:40:53 +00:00
DJ
6358e1abb9 Bug 1857968 - adjust cookiebanner prefs for PBM-only behavior. r=pbz,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190493
2023-10-12 18:20:33 +00:00
Dave Townsend
153dc47e7f Bug 1857999: SubDialog should insert stylesheets as link elements. r=Gijs,settings-reviewers
Attempt to find other link elements in the document and insert the injected
stylesheets after those. Strictly speaking we could probably just insert them
at the end of the document but this at least keeps them together with other
link elements to aid in inspecting. Falls back to using the XML processing
instruction in hte unlikely case that no other link elements are present.

Differential Revision: https://phabricator.services.mozilla.com/D190679
2023-10-12 09:44:11 +00:00
Drew Willcoxon
234916db20 Bug 1857391 - Remove Firefox Suggest "best match" as its own separate feature. r=daisuke,settings-reviewers
This removes "best match" as its own separate Firefox Suggest feature. In the
future, whether or not a suggestion is a best match (a.k.a. top pick) will be
determined by relevant product requirements. I've confirmed this with Nive.

Here's a summary of changes:

* Removes prefs and Nimbus variables related to best match
* Removes the "Top pick" checkbox in about:preferences
* Removes support for the `best_match` quick suggest config property. This
  property was removed from the config in remote settings a while ago.
* Removes legacy telemetry scalars related to best match. These scalars were
  added years ago for the original best match experiment and before we started
  using Glean. In the case of non-sponsored suggestions, the scalars have not
  been recorded at all for some time. In the case of sponsored suggestions, they
  can now be recorded again due to the recent addition of sponsored priority
  suggestions, but they are superseded by Glean.

Differential Revision: https://phabricator.services.mozilla.com/D190516
2023-10-11 17:17:06 +00:00