This cannot be done during "showing" because the richlistbox does not have a
frame at that point.
As well as enabling arrow keys, focus also clearly identifies the speaker
being considered for a permission grant. Without focus, the selected item is
identified by subtle background color changes, and so the selected item would
not be clear in a list of two items.
Depends on D182318
Differential Revision: https://phabricator.services.mozilla.com/D182319
This patch replaces both toggles in the different sub views of the ETP panel with `moz-toggle`. Previously there was a small discrepancy where we were setting an `aria-label` on one toggle but not the other. I added a method to handle updating both toggles at once to ensure they stay in sync/always receive the same updates.
Differential Revision: https://phabricator.services.mozilla.com/D176700
Test by Gijs. Note that I removed the .isActive assertion, because this doesn't
affect activeness.
We could make that change too, but that's a bigger change, and I think we want
to do this regardless.
The CAN_RUN_SCRIPT annotations are obsolete (they come from bug 1582042
which directly fired docshell activity events, but that's not true
anymore, bug 1635914 changed the setup a bit later).
Differential Revision: https://phabricator.services.mozilla.com/D185643
The `PanelMultiView.showSubView()` method needed to be made a bit more robust
for titles set by DOM localization rather than directly.
The following messages are dropped during the migration, as they are unused:
- contentBlocking.trackersView.blocked.label
- contentBlocking.cookiesView.firstParty.empty.label
- contentBlocking.cookiesView.trackers.empty.label
- contentBlocking.cookiesView.thirdParty.empty.label
- contentBlocking.fingerprintersView.blocked.label
- contentBlocking.cryptominersView.blocked.label
Differential Revision: https://phabricator.services.mozilla.com/D178829
In order to use the same implementation between regular script and module script,
convert PromiseWorker.js into a template, which is processed by GeneratePromiseWorkerScript.py.
Differential Revision: https://phabricator.services.mozilla.com/D184282
- Update the HTTPS-Only dropdown in the site identity pane to always set exceptions for the http version of the current origin.
- Add new parameter `forcedHTTP` to `gPermissionManager`, in order to only allow origins with a http scheme to be added in the HTTPS-Only section of the settings. This means when a https URL is added as an exeption, it will automatically be converted into a http one.
- Add a migration to convert all existing HTTPS-Only exceptions with a https scheme to a http scheme.
- Update `browser_https_only_exceptions.js` and `browser_identityPopup_HttpsOnlyMode.js` to account for this new behaviour.
Differential Revision: https://phabricator.services.mozilla.com/D182761
Some basic clean-up. I want to do this before doing bigger changes in
bug 1843044.
There's tons more code that can get cleaned-up on the widget side, but
let's start with this.
Differential Revision: https://phabricator.services.mozilla.com/D183622
Setting the selectedItem of a richlistbox to null is a no-op and leaves
previous state remaining, so the selectedIndex is explicitly set instead of
depending on connectedCallback() to do so.
Differential Revision: https://phabricator.services.mozilla.com/D182318
The issue here is that authorStyleDisabledDefault persists on the BrowsingContext.
This means it stays set/unset if the BC navigates same-origin (including
reloads). But the actor was keeping its own copy, on the actor, and the actor
gets destroyed in those circumstances, leading to the frontend and the internal
state no longer being in sync.
This patch addresses this by no longer keeping our own state and just reading
the browsingcontext's field directly.
This is a tiny bit hackish because technically, whether this is the 'default'
is not the same as whether the author style is actually disabled, but in
practice the child actor always sets the two at the same time, and it is
the simpler fix (vs. trying to mirror state to the parent some more).
Differential Revision: https://phabricator.services.mozilla.com/D183188
Subtle things:
* We now have shadow trees in NAC, inception! Only a couple lines of
code in the style system had to be changed to match :host rules and
so properly.
* Had to make highlighters.css contentaccessible, because otherwise we
can't load it from the shadow tree. I don't think it's a big deal.
* I removed some of the code from highlighters.css that claimed that
stuff inherited from the html element. That's just no longer true.
* Had to switch from `setAttribute("style", ...)` to `.style = ...;`.
This is needed because CSSOM from chrome code bypasses CSP (as
AnonymousContent did), but setAttribute() doesn't, see bug 1424474.
Differential Revision: https://phabricator.services.mozilla.com/D173998
* Add a default-true pref to provide an escape hatch allowing us to revert to previous behavior
* in which recently-closed tabs are per-window,
* and undoing closed tabs restores them to the window they were closed from.
* Ensure we set the pref for tests which depend on its value
* Add some spot-checks in tests with the pref off
Differential Revision: https://phabricator.services.mozilla.com/D179574
