We just need to make sure all the throbber animations share a start
time, and we can use an arbitrary time (i.e., zero) rather than going
through all the tabs.
Differential Revision: https://phabricator.services.mozilla.com/D235300
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group
Differential Revision: https://phabricator.services.mozilla.com/D233129
Saved groups, open groups in other windows, and open groups in the current window all have `command` handlers defined in the tab overflow menu (TOM) to perform an action when clicked. However, the tab groups spec shows additional actions that should be available when right-clicking on those tab groups in the TOM. This patch adds those context menus and wires up their functionality:
- opening in current window
- opening in, or moving to, a new window
- deleting an open group
- forgetting a saved group
Differential Revision: https://phabricator.services.mozilla.com/D233129
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.
Differential Revision: https://phabricator.services.mozilla.com/D233016
1. should be available in the context menu even if there are collapsed tab groups to the left/right
2. should close collapsed tab groups when they are to the left/right
3. tab groups should be saved when they are going to be closed when using "close tabs to the left/right"
Differential Revision: https://phabricator.services.mozilla.com/D232432
Since bug 1823984, this focus() call has been a no-op on remote frames.
The previous patch also fixes the non-remote frame focus switch.
Differential Revision: https://phabricator.services.mozilla.com/D230098
There are a number of oddities that cropped up from pinned tabs moving into tab groups, e.g. when the first item in the tab strip is a tab group or when pinning a tab that's already in a tab group. This patch repairs those cases to ensure that pinned tabs stick to the beginning of the tab strip.
Differential Revision: https://phabricator.services.mozilla.com/D230344
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.
Differential Revision: https://phabricator.services.mozilla.com/D229767
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.
Differential Revision: https://phabricator.services.mozilla.com/D229767
Since bug 1823984, this focus() call has been a no-op on remote frames.
The previous patch also fixes the non-remote frame focus switch.
Differential Revision: https://phabricator.services.mozilla.com/D230098
Add a 1 pixel stroke to the tab group icon SVG so that it can be styled as a border using CSS. Using border style properties for CSS does not work in all contexts; specifically, macOS native menus do not seem to allow border rules but do allow SVG rendering.
Differential Revision: https://phabricator.services.mozilla.com/D230070
