This use of units for zero length occasionally gets flagged during theme reviews so it makes sense to establish our preference and automate checks via Stylelint.
Differential Revision: https://phabricator.services.mozilla.com/D230287
Was showing:
WARNING: Calling get_html_theme_path is deprecated. If you are calling it to define html_theme_path, you are safe to remove that code.
Differential Revision: https://phabricator.services.mozilla.com/D230078
The rust-dev toolchain is not updated because 1.82 changed things for
build-std that requires reworking the local patches entirely.
Differential Revision: https://phabricator.services.mozilla.com/D225714
The rust-dev toolchain is not updated because 1.82 changed things for
build-std that requires reworking the local patches entirely.
Differential Revision: https://phabricator.services.mozilla.com/D225714
Using the current example on latest `mozilla-unified` yields this error
when used in a `mach build`:
```
TypeError: startswith first arg must be str or a tuple of str, not list
```
Implement the diagnostic's advice: swap the list for a tuple.
Differential Revision: https://phabricator.services.mozilla.com/D230271
Added JS topic guides and also updated the existing Swift/JS ones a bit.
I didn't add a guide for remote settings, since I don't think we want to
encourage users to use this one over the official client.
Split up the notes at the begining into prerequites and notes on async.
My hope is that the async notes can go away once we start making our
components async.
Differential Revision: https://phabricator.services.mozilla.com/D228481
I'm testing out a docs-first approach to this, based on the excellent
work that Bastian has done with topic guides. Here's how I'm thinking
the new API should generally work, what do others think?
Differential Revision: https://phabricator.services.mozilla.com/D225266
I'm testing out a docs-first approach to this, based on the excellent
work that Bastian has done with topic guides. Here's how I'm thinking
the new API should generally work, what do others think?
Differential Revision: https://phabricator.services.mozilla.com/D225266
This patch both:
1. Provides a static checker to detect global variables which may not be
initialized at compile-time
2. Verify that variables flagged as MOZ_RUNINIT are indeed
initialized at runtime
3. In case of variables whose initialisation status varies based on
macro definition or template parameters, just flag them as
MOZ_GLOBINIT.
Differential Revision: https://phabricator.services.mozilla.com/D223342
MOZ_RUNINIT => initialized at runtime
MOZ_CONSTINIT => initialized at compile time
MOZ_GLOBINIT => initialized either at runtime or compile time, depending on template parameter, macro parameter etc
This annotation is only understood by our clang-tidy plugin. It has no
effect on regular compilation.
Differential Revision: https://phabricator.services.mozilla.com/D223341
This removes the separate handling of different types of warnings/failures, and switches to an allow list of warnings that are the existing ones. They'll still be output as TEST-KNOWN-FAIL. Any new warnings will be output as TEST-UNEXPECTED-FAIL and cause the document generation/upload to fail.
Differential Revision: https://phabricator.services.mozilla.com/D225973
The rust-dev toolchain is not updated because 1.82 changed things for
build-std that requires reworking the local patches entirely.
Differential Revision: https://phabricator.services.mozilla.com/D225714
This adds logging to Pacer<T>, which is currently only used by
VideoFrameConverter. It also updates VideoFrameConverter's own logging through a
dedicated macro, and puts both classes' on the MediaPipeline log module.
Differential Revision: https://phabricator.services.mozilla.com/D224701
Bug 1924903 introduced a new warning that we don't currently care about (document isn't included in any toctree), as the document
is linked to from other pages.
Differential Revision: https://phabricator.services.mozilla.com/D225959
This will clarify when to use the `--vcs=git` argument during the setup
process to prevent people from accidentally setting up their repository
for Mercurial.
Differential Revision: https://phabricator.services.mozilla.com/D224259
This patch lays the foundation for a Mozilla-specific Stylelint plugin that we can continue to expand on with new rules as needed. For the first rule I've implemented a simple check to ensure our color tokens are being used as intended.
Differential Revision: https://phabricator.services.mozilla.com/D223204
